Nick Alexander
97967b0ece
Bug 1918249 - Fix mach lint
linting prefs JS files on Windows by forcing UTF-8. r=ahal
...
Prefs files in general are allowed to not be UTF-8, but all the prefs
files in tree are UTF-8, so we can lint them with that assumption.
Differential Revision: https://phabricator.services.mozilla.com/D221878
2024-09-13 17:00:04 +00:00
Cristian Tuns
5f82b0e5a2
Backed out changeset 78d0a0c70d7c (bug 1918411
) for causing bc failures in browser_quicksuggest_fakespot.js CLOSED TREE
2024-09-13 10:43:48 -04:00
Francesco Lodolo (:flod)
cd4219cfed
Bug 1918411
- Use explicit NUMBER() in Fluent plurals, update docs, r=bolsson,credential-management-reviewers,devtools-reviewers,places-reviewers,omc-reviewers,urlbar-reviewers,nchevobbe,daisuke,dimi,mviar
...
Differential Revision: https://phabricator.services.mozilla.com/D221992
2024-09-13 13:34:52 +00:00
Mark Banner
2387ca3533
Bug 1917532 - Remove overrides sections from *-test configurations in eslint-plugin-mozilla. r=frontend-codestyle-reviewers,mossop
...
ESLint v9 doesn't support overrides/file specification in the configurations, so we don't want these
now.
The top-level configuration already strips out the overrides for these and handles them separately, so
there's nothing to add - simply remove the 'removeOverrides' function.
Differential Revision: https://phabricator.services.mozilla.com/D221447
2024-09-12 21:08:45 +00:00
Mark Banner
533bbce8a6
Bug 1575506 - Enable ESLint rule no-redeclare with builtinGlobals on all module and worker files. r=frontend-codestyle-reviewers,devtools-reviewers,nchevobbe,mossop
...
Differential Revision: https://phabricator.services.mozilla.com/D221446
2024-09-12 21:08:45 +00:00
Mark Banner
0075a7ce1f
Bug 1917530 - Enable ESLint rule no-shadow by default across the tree, disabling where it currently fails. r=frontend-codestyle-reviewers,mossop
...
Differential Revision: https://phabricator.services.mozilla.com/D221445
2024-09-12 21:08:44 +00:00
Mark Banner
f63765b6ef
Bug 1917530 - Enable ESLint rule no-shadow on system modules where no-shadow is enabled already, and warn for remaining failures. r=frontend-codestyle-reviewers,mossop
...
This moves the ESLint rule to apply to jsx, system modules and workers. It is excluded from most system
modules by the roll out, which we can work on later. However, it will be enabled where no-shadow is
already enabled - previously these were hidden due to the order in which ESLint was applying the rules.
Differential Revision: https://phabricator.services.mozilla.com/D221444
2024-09-12 21:08:44 +00:00
Sandor Molnar
6a28b1e440
Backed out 8 changesets (bug 1917532, bug 1575506, bug 1917530) for causing node newtab failures CLOSED TREE
...
Backed out changeset 8d6f7bc74d08 (bug 1917532)
Backed out changeset 7c963e72cf06 (bug 1575506)
Backed out changeset d5e110187781 (bug 1917530)
Backed out changeset 1d2325ffded6 (bug 1917530)
Backed out changeset 8a361e37e32c (bug 1917530)
Backed out changeset c4011d92c7f7 (bug 1917530)
Backed out changeset 1a45047dfb3c (bug 1917530)
Backed out changeset ed6b35444c45 (bug 1917530)
2024-09-12 20:45:28 +03:00
Mark Banner
6b786d4a84
Bug 1917532 - Remove overrides sections from *-test configurations in eslint-plugin-mozilla. r=frontend-codestyle-reviewers,mossop
...
ESLint v9 doesn't support overrides/file specification in the configurations, so we don't want these
now.
The top-level configuration already strips out the overrides for these and handles them separately, so
there's nothing to add - simply remove the 'removeOverrides' function.
Differential Revision: https://phabricator.services.mozilla.com/D221447
2024-09-12 16:42:00 +00:00
Mark Banner
c7331a02cd
Bug 1575506 - Enable ESLint rule no-redeclare with builtinGlobals on all module and worker files. r=frontend-codestyle-reviewers,devtools-reviewers,nchevobbe,mossop
...
Differential Revision: https://phabricator.services.mozilla.com/D221446
2024-09-12 16:41:59 +00:00
Mark Banner
1a8d60d410
Bug 1917530 - Enable ESLint rule no-shadow by default across the tree, disabling where it currently fails. r=frontend-codestyle-reviewers,mossop
...
Differential Revision: https://phabricator.services.mozilla.com/D221445
2024-09-12 16:41:59 +00:00
Mark Banner
5302b1261d
Bug 1917530 - Enable ESLint rule no-shadow on system modules where no-shadow is enabled already, and warn for remaining failures. r=frontend-codestyle-reviewers,mossop
...
This moves the ESLint rule to apply to jsx, system modules and workers. It is excluded from most system
modules by the roll out, which we can work on later. However, it will be enabled where no-shadow is
already enabled - previously these were hidden due to the order in which ESLint was applying the rules.
Differential Revision: https://phabricator.services.mozilla.com/D221444
2024-09-12 16:41:58 +00:00
Florian Quèze
e99179e480
Bug 1918045 - add a macro to reduce code duplication in Perfetto.h, r=denispal.
...
Differential Revision: https://phabricator.services.mozilla.com/D221839
2024-09-11 21:36:40 +00:00
Florian Quèze
f4f0a167d6
Bug 1918045 - Accept the NS_ConvertUTF16toUTF8 type as the payload for profiler text markers in Perfetto.h, r=denispal.
...
Differential Revision: https://phabricator.services.mozilla.com/D221776
2024-09-11 21:36:40 +00:00
Greg Mierzwinski
54f8702e9d
Bug 1917828 - Update browsertime to v22.10.1. r=perftest-reviewers,kshampur
...
This patch updates browsertime to capture some power testing improvements.
Differential Revision: https://phabricator.services.mozilla.com/D221644
2024-09-11 12:00:06 +00:00
Mike Hommey
d46c6229a7
Bug 1917739 - Move Lz4 and mfbt/Compression* to mozglue/static. r=nika,frontend-codestyle-reviewers
...
As per mozglue/static/README:
> mozglue/static contains parts of the mozglue library that can/should be
> statically linked to e.g. js/Gecko.
The compression part of MFBT is a good candidate for this.
Differential Revision: https://phabricator.services.mozilla.com/D221565
2024-09-10 20:35:56 +00:00
Andrew McCreight
04a47c0850
Bug 1275612 - Don't allow any origins to send objects over WebChannel. r=Gijs
...
The last actual Firefox user of this less-safe feature was removed in 2022.
Thunderbird's sync server still needs it, but apparently that is a prototype
that isn't really working, so they said it was okay to remove this.
Differential Revision: https://phabricator.services.mozilla.com/D220646
2024-09-08 15:28:50 +00:00
Francesco Lodolo (:flod)
d0059173bd
Bug 1917163 - Update rstcheck to 6.2.4, fix resulting errors in documents, r=Standard8
...
Differential Revision: https://phabricator.services.mozilla.com/D221287
2024-09-06 15:04:10 +00:00
Cristina Horotan
c6ba4c0134
Backed out changeset 4e2df2c48e4b (bug 1917163) for causing mozlint failure. CLOSED TREE
2024-09-06 16:57:11 +03:00
Francesco Lodolo (:flod)
fd657600c1
Bug 1917163 - Update rstcheck to 6.2.4, fix resulting errors in documents, r=Standard8
...
Differential Revision: https://phabricator.services.mozilla.com/D221287
2024-09-06 12:17:06 +00:00
Francesco Lodolo (:flod)
722e67d046
Bug 1916932 - Move RST linter configuration to file, fix or ignore local errors with code blocks r=sylvestre
...
Differential Revision: https://phabricator.services.mozilla.com/D221113
2024-09-05 11:55:00 +00:00
Nick Alexander
954de9f336
Bug 1610656 - Kill the geckoViewBinaries
product flavor. r=geckoview-reviewers,android-reviewers,nalexander,ohall
...
Differential Revision: https://phabricator.services.mozilla.com/D221066
2024-09-05 01:43:29 +00:00
Emilio Cobos Álvarez
d9aeea9279
Bug 1879744 - Skip this test in tsan. r=aabh,profiler-reviewers
...
Bug 1915433 made this perma because it caused gfxPlatform initialization
(thus a bit more work), where before it used to be skipped by a pref.
But this happened intermittently before my patch, so likely this just
pushed the test over the limit...
Given the amount of tests skipped here on tsan, maybe we should have a
higher xpcshell timeout there?
Differential Revision: https://phabricator.services.mozilla.com/D221052
2024-09-04 16:30:42 +00:00
Greg Mierzwinski
09496e95aa
Bug 1914202 - [mach-try-perf] Use Treeherder link for finding remote base/new revision. r=perftest-reviewers,fbilt
...
This patch changes the link to search for in mach-try-perf base/new revisions to the treeherder one instead of the hgmo link. This resolves an issue where the hg links would come in different styles depending on the number of commits made locally. This patch keeps the original hg matcher though as a fallback-method in case a treeherder link is unavailable. By default, we'll always use the treeherder revision even if an hg revision is found.
Differential Revision: https://phabricator.services.mozilla.com/D219770
2024-09-04 11:39:22 +00:00
Mark Banner
a94fcf9719
Bug 1916093 - Make 'fatal' warnings during documentation raise errors by default. r=sylvestre
...
Differential Revision: https://phabricator.services.mozilla.com/D220765
2024-09-03 18:48:45 +00:00
Mark Banner
1930a2a863
Bug 1916093 - When generating docs, treat critical errors the same as errors. r=sylvestre,perftest-reviewers,sparky
...
Differential Revision: https://phabricator.services.mozilla.com/D220764
2024-09-03 18:48:45 +00:00
Mark Banner
d8cd7314ef
Bug 1875389 - Properly exclude python test files from doc generation. r=sylvestre
...
Differential Revision: https://phabricator.services.mozilla.com/D220629
2024-09-02 14:38:08 +00:00
Mark Banner
fee9dd7be0
Bug 1915550 - Make ERRORS raised during 'mach doc generate' be failures. r=sylvestre
...
Differential Revision: https://phabricator.services.mozilla.com/D220535
2024-09-02 14:38:08 +00:00
Mark Banner
928688c0c5
Bug 1915550 - Fix unknown target name issues in rst documents. r=sylvestre,profiler-reviewers,canaltinova
...
Differential Revision: https://phabricator.services.mozilla.com/D220534
2024-09-02 14:38:08 +00:00
Julien Cristau
5601eda303
Bug 1915635 - update path to nightly cron index for mach try scriptworker. r=releng-reviewers,ahal
...
Since bug 1882083 the `nightly-desktop` cron job no longer runs
regularly, having been replaced with `nightly-all`.
Differential Revision: https://phabricator.services.mozilla.com/D220573
2024-09-02 06:00:55 +00:00
Kagami Sascha Rosylight
d415539adf
Bug 1915242 - Upgrade setuptools to 74.0.0 r=mach-reviewers,ahal
...
Differential Revision: https://phabricator.services.mozilla.com/D220347
2024-08-30 20:11:39 +00:00
Greg Mierzwinski
6925889c60
Bug 1913273 - [mach-try-perf] Add framework auto-detection, and refactor push info passing. r=perftest-reviewers,afinder DONTBUILD
...
This patch adds the ability to auto-detect the framework that is used by the majority of the tasks selected and adds this information to the perfcompare URLs. It also does a refactor on how the perf try push info is passed around to simplify the process.
Differential Revision: https://phabricator.services.mozilla.com/D219219
2024-08-28 16:18:21 +00:00
Mark Banner
ec6c584669
Bug 1870226 - Upgrade eslint-plugin-jsdoc to version 50.2.2. r=zombie,frontend-codestyle-reviewers,translations-reviewers,backup-reviewers,kpatenio
...
Also fixes a few issues found with the newer versions of eslint-plugin-jsdoc.
Differential Revision: https://phabricator.services.mozilla.com/D219513
2024-08-23 16:43:57 +00:00
Mark Banner
a99d89a12c
Bug 1870226 - Upgrade eslint-plugin-jsdoc to version 43.2.0. r=frontend-codestyle-reviewers,credential-management-reviewers,issammani
...
This switches from the deprecated/removed jsdoc/newline-after-description rule to using the replacement jsdoc/tag-lines rule.
Differential Revision: https://phabricator.services.mozilla.com/D219512
2024-08-23 16:43:57 +00:00
Julien Wajsberg
d7ce2585b0
Bug 1914574 - Add the new perfcompare URL to mach try perf r=sparky,perftest-reviewers
...
This also displays it first, with the old compare view URL coming
second.
Differential Revision: https://phabricator.services.mozilla.com/D219953
2024-08-23 14:19:21 +00:00
Masatoshi Kimura
7a6cd72300
Bug 1914286 - Remove NS_RelaxStrictFileOriginPolicy. r=smaug,necko-reviewers,kershaw
...
Differential Revision: https://phabricator.services.mozilla.com/D219921
2024-08-23 10:13:35 +00:00
Butkovits Atila
2837d313b2
Backed out 7 changesets (bug 1870226) for causing build bustages. CLOSED TREE
...
Backed out changeset 619244623dba (bug 1870226)
Backed out changeset e85a5647cae4 (bug 1870226)
Backed out changeset 21ea9baf83ea (bug 1870226)
Backed out changeset a506c0f0ce28 (bug 1870226)
Backed out changeset 77c78201a206 (bug 1870226)
Backed out changeset 7a98dfef087f (bug 1870226)
Backed out changeset f64ad89c2406 (bug 1870226)
2024-08-23 12:22:02 +03:00
Mark Banner
920ffbffdd
Bug 1870226 - Upgrade eslint-plugin-jsdoc to version 50.2.2. r=zombie,frontend-codestyle-reviewers,translations-reviewers,backup-reviewers,kpatenio
...
Also fixes a few issues found with the newer versions of eslint-plugin-jsdoc.
Differential Revision: https://phabricator.services.mozilla.com/D219513
2024-08-23 08:55:49 +00:00
Mark Banner
09fa5144e1
Bug 1870226 - Upgrade eslint-plugin-jsdoc to version 43.2.0. r=frontend-codestyle-reviewers,credential-management-reviewers,issammani
...
This switches from the deprecated/removed jsdoc/newline-after-description rule to using the replacement jsdoc/tag-lines rule.
Differential Revision: https://phabricator.services.mozilla.com/D219512
2024-08-23 08:55:49 +00:00
Issam Mani
f0a84cf2e4
Bug 1913967 - Move shared modules to a shared folder. r=sylvestre,frontend-codestyle-reviewers,dimi
...
Differential Revision: https://phabricator.services.mozilla.com/D219659
2024-08-21 14:12:52 +00:00
Peter Van der Beken
0063c225d9
Bug 1900930 - Make nsProfiler use TypedArrayCreator. r=dom-core,profiler-reviewers,farre,canaltinova
...
Using TypedArrayCreator avoids use of ErrorResult completely (and the need to
call MightThrowJSException/WouldReportJSException).
Differential Revision: https://phabricator.services.mozilla.com/D214793
2024-08-21 08:43:09 +00:00
Florian Quèze
52cde5627b
Bug 1913624 - Remove expired telemetry histograms VIDEO_INFERRED_DECODE_SUSPEND_PERCENTAGE, VIDEO_INTER_KEYFRAME_AVERAGE_MS and VIDEO_INTER_KEYFRAME_MAX_MS, r=chutten,webidl,emilio.
...
Depends on D219447
Differential Revision: https://phabricator.services.mozilla.com/D219448
2024-08-20 10:26:54 +00:00
Tomislav Jovanovic
02a98999ce
Bug 1908925 - Enforce storage.session quota in Nightly builds r=robwu,mccr8
...
Differential Revision: https://phabricator.services.mozilla.com/D218602
2024-08-19 18:25:35 +00:00
Aaditya Dhingra
8abdfca977
Bug 1907129 - Modify linters to run ./gradlew ktlint detekt on Fenix and AC. r=android-reviewers,nalexander,gl,pollymce
...
Differential Revision: https://phabricator.services.mozilla.com/D216999
2024-08-19 15:22:48 +00:00
Andrea Marchesini
45b08a7ee9
Bug 1910886 - Reduce duplicated code between CookieService and CookieServiceChild - part 2 - Unify nsICookieService.setCookieStringFromDocument implementations, r=edgul,cookie-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D218313
2024-08-15 21:35:42 +00:00
Andrea Marchesini
8cf7d4e9d4
Bug 1910886 - Reduce duplicated code between CookieService and CookieServiceChild - part 1 - Unify nsICookieService.getCookieStringFromDocument implementations, r=edgul,cookie-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D218312
2024-08-15 21:35:41 +00:00
Adam Brouwers-Harries
95b0970844
Bug 1883903 - Try to get a profile when we encounter a hang r=florian,profiler-reviewers,ahal
...
Differential Revision: https://phabricator.services.mozilla.com/D214842
2024-08-14 12:11:43 +00:00
tannal
092a80c246
Bug 1911935 - Remove network.IDN_show_punycode pref r=gregp,necko-reviewers,valentin
...
Differential Revision: https://phabricator.services.mozilla.com/D219026
2024-08-13 19:28:23 +00:00
Narcis Beleuzu
b157967a8f
Backed out 3 changesets (bug 1910886) for causing mochitest failures on browser_storageAccessPrivilegeAPI.js . CLOSED TREE
...
Backed out changeset 8fe13ea22554 (bug 1910886)
Backed out changeset a851b9fcca9c (bug 1910886)
Backed out changeset e5791012019f (bug 1910886)
2024-08-09 14:50:41 +03:00
Andrea Marchesini
64d766f610
Bug 1910886 - Reduce duplicated code between CookieService and CookieServiceChild - part 2 - Unify nsICookieService.setCookieStringFromDocument implementations, r=edgul,cookie-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D218313
2024-08-09 08:37:13 +00:00