Before these changes, there were a number of cases where it would be
possible for the pipe to be closed or otherwise encounter an error, and
for there to be a very large or potentially indefinite delay before that
error is reported to the ReadableStream.
This patch avoids changing too much of the structure of the existing
FetchStreamReader's design, while avoiding the potential pitfalls, and
ensuring that the stream is being consistently watched.
A more polished patch in the future may be able to perform a more
efficient and direct adaptation from a `ReadableStream` or
`WritableStream` to the `nsIAsyncInputStream` and `nsIAsyncOutputStream`
types, but that was not tackled here.
Differential Revision: https://phabricator.services.mozilla.com/D168481
The Firefox Profiler expects the channelId to not change. There is no
reason to change the channelId. It was a measure to associate the early
hint preload in devtools and profiler, but neither is the case right
now: Devtools currently don't show preloads at all and changing the
channelId messes up the profiler.
Differential Revision: https://phabricator.services.mozilla.com/D174116
This is a race condition of full screen event and activated event of media
controller.
Media controller will dispatch activated event when full screen button is
clicked on controller. But since this depends on full screen event, if
GeckoView's media session receives this event before controller fires activated
event, `MediaSession.Delegate.onFullscreen` won't be called because
MediaSession.isActive() is false at this time.
So I would like to retry `GeckoView:MediaSession:Fullscreen` call when
entering full screen and controller isn't active yet.
Differential Revision: https://phabricator.services.mozilla.com/D173831
To avoid unnecessary cloning of nsIInputStream, add a hasPostData
boolean attribute to tell whether a nsISHEntry has populated postData.
Differential Revision: https://phabricator.services.mozilla.com/D173237
Add activeSessionHistoryEntry attribute to CanonicalBrowsingContext to
expose the existing implementation of
CanonicalBrowsingContext::GetActiveSessionHistoryEntry.
Differential Revision: https://phabricator.services.mozilla.com/D173235
The intention is to allow PrintedSheetFrame::Reflow to access the page style
prior to reflowing its child so that it can decide whether to apply page style
to the sheet (in the case of one page-per-sheet). This will happen in a
subsequent bug.
Differential Revision: https://phabricator.services.mozilla.com/D173773
This patch uses StateWatching to dispatch a task to process a frame as soon as
it comes in from the VideoCaptureAdapter frame event. This is done async so that
if multiple frames come in while one is being processed, we drop all but the
latest.
Differential Revision: https://phabricator.services.mozilla.com/D171963
Hypothetically if the frame callback is doing something leading to crashes, this
patch should at least affect those symptoms, giving us more clues to where the
problem lies.
This patch changes away from calling the CamerasParent callback directly on the
frame queue, to notifying a MediaEvent owned by the VideoCaptureAdapter. The
frames are then handled on the video capture thread.
Differential Revision: https://phabricator.services.mozilla.com/D171962
This patch mainly changes VideoCaptureAdapter to use an instance method to set
the capturer member under a mutex. It also moves the setting of this capturer
to start rather than init (and unsets it on stop). With this we shouldn't need
the prior fixes to RTCCameraVideoCapturer.m.
Some other cleanup happens as well:
- Constification of members
- Moving the RTCVideoFrame to webrtc::VideoFrame conversion to OnFrame()
- Optimizing away StartFrameRecording()
- Only calculating image type once
Differential Revision: https://phabricator.services.mozilla.com/D171960
* Original author was jaws, prathikshaprasadsuman got it reviewed and landed
* Update to non-hovered .tab-close-button width to avoid regressing bug 1818233 again.
Differential Revision: https://phabricator.services.mozilla.com/D115006
If a `<script>` is on the first line of the HTML file, we were miscalculating
its position in the HTML file because there is not previous line breaks.
A test case is added to fix this.
Differential Revision: https://phabricator.services.mozilla.com/D173929
While the root issue should be fixed on the server,
this patch will help reduce a frequent intermittent
and prevent showing erroneous result to users.
Differential Revision: https://phabricator.services.mozilla.com/D173660
