Commit Graph

520 Commits

Author SHA1 Message Date
Gabriel Luong
da1777509d Bug 1192561 - Eslint cleanup, formating and removal of aArgs in styleinspector r=bgrins
--HG--
rename : browser/devtools/styleinspector/test/browser_ruleview_computed_01.js => browser/devtools/styleinspector/test/browser_ruleview_computed-lists_01.js
rename : browser/devtools/styleinspector/test/browser_ruleview_computed_02.js => browser/devtools/styleinspector/test/browser_ruleview_computed-lists_02.js
2015-08-10 15:17:04 -07:00
Simon Lindholm
54bac9556f Bug 1187777 - Lazily create computed styles list. r=bgrins
---
 browser/devtools/styleinspector/rule-view.js       | 38 +++++++-----
 browser/devtools/styleinspector/test/browser.ini   |  2 +
 .../test/browser_ruleview_computed_01.js           | 47 +++++++++++++++
 .../test/browser_ruleview_computed_02.js           | 68 ++++++++++++++++++++++
 .../browser_ruleview_edit-property-computed.js     |  8 +++
 5 files changed, 149 insertions(+), 14 deletions(-)
 create mode 100644 browser/devtools/styleinspector/test/browser_ruleview_computed_01.js
 create mode 100644 browser/devtools/styleinspector/test/browser_ruleview_computed_02.js
2015-08-07 18:16:32 -07:00
Gabriel Luong
28f98733ae Bug 1187914 - Part 2: Fix the display of the "Add New Rule" and "Copy" menu item in the rule and computed view r=bgrins 2015-08-07 18:14:35 -07:00
Gabriel Luong
9d7a5b9428 Bug 1187914 - Part 1: Convert to unix line endings in style-inspector-menu.js r=bgrins 2015-08-07 18:14:32 -07:00
Julian Descottes
a0fb71dd97 Bug 1191093 - Hide ruleview autocomplete popup on page navigation;r=bgrins
In ruleview #selectElement, if the autocomplete popup is opened, hide it.
Added one mochitest to verify the popup is properly hidden after navigation.

--HG--
extra : commitid : CLLMFnKe34Q
2015-08-07 20:31:13 +02:00
Gabriel Luong
826506cb30 Bug 1191302 - Use array.some instead of array.includes in selector pseudo class check. r=bgrins 2015-08-06 02:16:00 -04:00
Alexandre Poirot
b9fc38483f Bug 1188401 - Expose require out of Loader.jsm and use it. r=jryans 2015-08-06 05:38:10 -07:00
Gabriel Luong
29ee101b21 Bug 1188897 - [Rule View] Ensure the correct editable property is focused when editing and removing properties in the rule view r=bgrins 2015-08-06 01:49:51 -07:00
Julian Descottes
2d848fa979 Bug 1191093 - Add panelId for markup-view autocomplete popup, r=bgrins
When creating the AutocompletePopup for the markup view, use a custom panelId.
This forces the AutocompletePopup to use separate XUL elements.

Otherwise, the markupview popup and the ruleview popup were sharing the same
XUL elements. When the markup-view was destroyed (ie on each page navigation),
the autocomplete popup in the rule view was no longer working.

- added panelId option in markup-view.js
- modified autocompletion tests in styleinspector/test
  to verify the autocomplete popup is still working
  after page navigation
2015-08-05 23:36:05 +02:00
Carsten "Tomcat" Book
46778b4671 Backed out changeset de6f45e30226 (bug 1152721) for XPCshell Bustage 2015-08-05 10:38:18 +02:00
Julian Descottes
80419e3cdf Bug 1152721 - Extract styleinspector common methods to utils.js, r=mratcliffe
--HG--
extra : commitid : 81Rx7sutIMo
2015-08-04 23:26:29 -07:00
Gabriel Luong
f902cde8e7 Bug 1190047 - [Rule View] Ensure changes to swatches are reverted to the original value on escape r=bgrins 2015-08-04 15:03:02 -07:00
Gabriel Luong
0b0eb8d7b0 Bug 1189472 - [Rule View] Pseudo-class panel and checkboxes should only be tab focusable when the panel is opened r=bgrins 2015-07-30 19:02:22 -07:00
Gabriel Luong
1993ec9307 Bug 1188125 - [Rule View] Properties marked overridden does not take into account disabled properties r=bgrins 2015-07-28 20:52:34 -07:00
Gabriel Luong
f3efe1d641 Bug 1187443 - [Rule View] Remove preview value on start editing of a property r=bgrins 2015-07-28 14:26:18 -07:00
Simon Lindholm
0eebe6337a Bug 1187584 - Don't use the hidden window for creating value nodes in the rule view. r=mratcliffe 2015-07-28 09:36:00 -04:00
Gabriel Luong
be89e3704c Bug 1184628 - [Rule View] Editing a disabled property should enable it r=bgrins 2015-07-27 21:40:34 -07:00
Gabriel Luong
a9af0f3967 Bug 1186138 - Part 3: Add unit test for checking that the preview remains disabled after escaping editing a disabled property r=bgrins 2015-07-27 21:40:26 -07:00
Gabriel Luong
2a04a4d224 Bug 1186138 - Part 2: Ensure the property remains disabled after ESC editing a disabled property r=bgrins 2015-07-27 21:40:20 -07:00
Gabriel Luong
f190ebdb18 Bug 1186138 - Part 1: Refactor this.prop.rule to this.rule in rule-view.js r=bgrins 2015-07-27 21:40:05 -07:00
Gabriel Luong
4335253456 Bug 1187681 - [Rule View] Ensure the property value copied also includes the priority r=mikeratcliffe 2015-07-26 19:37:49 -07:00
Gabriel Luong
85a86a8c8c Bug 1187674 - Part 2: Copy URL context menu should only be displayed when clicked node is an image URL r=mikeratcliffe 2015-07-26 19:37:44 -07:00
Julian Descottes
d5b670185e Bug 1184746 - Fixed eslint errors in rule-view.js/computed-view.js, r=mikeratcliffe
Changes in computed-view.js
- Fixed curly braces formatting
- Added missing globals
- Removed named functions
- Removed unused code in openStyleEditor()
- Ensured consistent return in refreshMatchedSelectors()
- Ensured consistent return in refreshPanel()

Changes in rule-view.js
- Ensured consistent return in functions
- Refactored createExpandableContainer() to avoid shadowing
2015-07-24 00:11:07 +02:00
Alexandre Poirot
f8675f433b Bug 1184192 - Fix pending request issue while running browser_ruleview_edit-selector_03.js r=bgrins 2015-07-23 13:36:34 -07:00
Tom Tromey
38f293ac40 Bug 1142206 - Let GetSubpropertiesForCSSProperty handle custom property. r=heycam, r=pbrosset 2015-07-20 16:25:00 -04:00
Gabriel Luong
2e79af2c43 Bug 1167669 - Part 4: Add unit tests for highlighting new filter style matches when rule properties are added and modified r=bgrins 2015-07-20 21:08:46 -07:00
Gabriel Luong
4e20ac62f9 Bug 1167669 - Part 3: Refactor this.ruleEditor.ruleView to this.ruleView in TextPropertyEditor r=bgrins 2015-07-20 21:03:47 -07:00
Gabriel Luong
c4c4da5389 Bug 1167669 - Part 2: Highlight new filter style matches when rules and properties are added or modified r=bgrins 2015-07-20 21:03:22 -07:00
Gabriel Luong
776e857cf5 Bug 1167669 - Part 1: Refactor the logic for highlighting rule selector, property and stylesheet source r=bgrins 2015-07-20 21:03:17 -07:00
Julian Descottes
7d32af6831 Bug 1164343: Part 2 - Refactor style inspector tests to point to the new context-menu and refactor doc.defaultView to styleWindow r=mikeratcliffe 2015-07-13 00:44:22 +02:00
Julian Descottes
4b276c4d29 Bug 1164343: Part 1 - Extract context-menu logic from rule-view and computed-view to style-inspector-menu r=mikeratcliffe 2015-07-13 00:52:16 +02:00
Gabriel Luong
851c3f252f Bug 1183792 - [Rule View] Newly added rule should keep a reference to the RuleEditor r=mratcliffe 2015-07-16 00:37:49 -07:00
Masatoshi Kimura
52428897a6 Backed out changeset acb7eb7f5ad4 (bug 1176496) for web compat problems 2015-07-15 23:37:22 +09:00
Gabriel Luong
4baf551671 Bug 1178535 - Part 2: Highlight pseudoclass and attribute texts in the selector text of the rule view r=bgrins 2015-07-14 10:49:28 -07:00
Gabriel Luong
d48047e7c9 Bug 1178535 - Part 1: Parse the pseudoclasses and attributes from the selector text r=tromney 2015-07-14 10:43:51 -07:00
Gabriel Luong
cf6ca84b82 Bug 1174543 - Part 2: Clear the matched selector container before rebuilding the matched selectors r=mratcliffe 2015-07-10 14:21:23 -07:00
Gabriel Luong
af23e39330 Bug 1174543 - Part 1: Remove Templater code in computed-view.js r=mratcliffe 2015-07-10 14:21:21 -07:00
Alexandre Poirot
a99984f3a1 Bug 1166774 - Wait for rule-view modifications before proceeding to next tests. r=pbrosset,bgrins 2015-07-10 00:22:53 -07:00
Ryan VanderMeulen
dc954fae3a Merge m-c to inbound. a=merge
CLOSED TREE
2015-07-09 13:52:22 -04:00
Gabriel Luong
13fabb5c8f Bug 1181243 - Ctrl + F should focus the filter style search bar if the focus is in the rule and computed view r=mikeratcliffe 2015-07-08 10:40:45 -07:00
Tim Nguyen
0fba7516c4 Bug 1130330 - Add copy url context menu item in styleinspector. r=pbrosset
--HG--
rename : browser/devtools/styleinspector/test/browser_styleinspector_context-menu-copy-data-uri.js => browser/devtools/styleinspector/test/browser_styleinspector_context-menu-copy-urls.js
extra : rebase_source : fe3eb154f5b59ba942972bb50d53fbdfdbf8c5b0
2015-07-03 06:04:00 +02:00
Masatoshi Kimura
6c8654865c Bug 1176496 - Drop support for -moz-prefixed gradients. r=dbaron 2015-07-10 00:57:50 +09:00
J. Ryan Stinnett
ac312da864 Bug 1178851 - Move testing flag to DevToolsUtils. r=ochameau 2015-07-02 04:56:57 -05:00
Michael Layzell
0f9ea8b283 Bug 1170531 - Disable clipboard menu commands correctly in non-(X)HTML documents; r=ehsan 2015-06-30 08:18:04 -04:00
Gabriel Luong
d3ea311566 Bug 1176054 - Fixed vertical of the pseudo class checkbox labels on Linux and Windows r=bgrins 2015-06-26 13:39:18 -07:00
Tim Nguyen
a098ea005e Bug 1165122 - Show Add New Rule button by default. r=bgrins 2015-06-25 16:00:29 -07:00
Gabriel Luong
44c8b16ca6 Backed out changeset aa1f2a978a64 2015-06-25 16:04:40 -07:00
Tim Nguyen
cf3d165b3d Bug 1165122 - Show Add New Rule button by default. r=bgrins 2015-06-25 16:00:29 -07:00
Gabriel Luong
25fdca5e38 Bug 1166959 - Allow the selector editor to advance the focus with tab, shift-tab and enter r=pbrosset 2015-06-25 15:51:52 -07:00
Gabriel Luong
410a2bf7c6 Bug 1175661 - Adding a new rule should use classList instead of splitting the className r=pbrosset 2015-06-18 09:06:56 -07:00