Commit Graph

7272 Commits

Author SHA1 Message Date
Benjamin VanderSloot
066e83f229 Bug 1793647, part 1 - Create new Sec-Fetch-Dest value for WebIdentity (FedCM), r=freddyb,webdriver-reviewers,whimboo
This is to keep up with WHATWG Fetch https://github.com/whatwg/fetch/pull/1495 .
Also revised to not include the new destination type in the RequestDestination enum, per https://github.com/whatwg/fetch/pull/1500 .

I added an element to nsIContentPolicy::nsContentPolicyType as my starting point and
proceeded from there, following the instructions at the end of the internal enum.

Differential Revision: https://phabricator.services.mozilla.com/D158657
2022-10-17 16:07:50 +00:00
Alexandre Lissy
441cf62eed Bug 1794409 - Tests for Telemetry on Utility r=chutten
Differential Revision: https://phabricator.services.mozilla.com/D159042
2022-10-13 13:16:18 +00:00
Alexandre Lissy
435a90663a Bug 1794409 - Add UtilityProcess support for Telemetry r=chutten
Differential Revision: https://phabricator.services.mozilla.com/D158960
2022-10-13 13:16:18 +00:00
Iulian Moraru
69ad012e92 Backed out 2 changesets (bug 1794409) for causing xpcshell failures on test_UtilityScalars.js. CLOSED TREE
Backed out changeset 8f59c21f474c (bug 1794409)
Backed out changeset dfb200d5ae75 (bug 1794409)
2022-10-13 10:07:15 +03:00
Alexandre Lissy
41d4db4ed9 Bug 1794409 - Tests for Telemetry on Utility r=chutten
Differential Revision: https://phabricator.services.mozilla.com/D159042
2022-10-13 06:08:29 +00:00
Alexandre Lissy
3b6b8e904e Bug 1794409 - Add UtilityProcess support for Telemetry r=chutten
Differential Revision: https://phabricator.services.mozilla.com/D158960
2022-10-13 06:08:28 +00:00
Alexandre Lissy
a71bf65582 Bug 1794461 - Skip audioDecoderCrash test on Ccov builds r=gsvelto
Differential Revision: https://phabricator.services.mozilla.com/D158976
2022-10-11 06:54:36 +00:00
Henri Sivonen
cce698d0cd Bug 1794401 - Use UTF-8 instead of Latin1 for XPCShell output. r=jstutte
Differential Revision: https://phabricator.services.mozilla.com/D158958
2022-10-11 06:10:27 +00:00
alwu
b30bf6accf Bug 1791892 - part7 : shutdown gfxconfig and device manager, and use mKind to avoid leaking. r=jolin,gerard-majax
We didn't close gfxconfig and the device manager properly before, which
causes a leak.

Also, using `mKind` to store the kind in the beginning helps us not need
to call `UtilityProcessChild::GetSingleton()` again to check the type,
which would also cause leaking and that would be addressed in bug 1792952.

Depends on D158072

Differential Revision: https://phabricator.services.mozilla.com/D158386
2022-10-10 20:13:31 +00:00
Greg Stoll
7950aa0894 Bug 1783304 - Simplify DLL blocklist init r=handyman
Now that SetGeckoProcessType() is called earlier, we can use that to determine if we are a utility process instead of parsing command-line arguments

Differential Revision: https://phabricator.services.mozilla.com/D158811
2022-10-07 19:22:45 +00:00
Nika Layzell
f5d6df8915 Bug 1792474 - Part 4: Avoid the IO thread hop when sending IPC messages, r=ipc-reviewers,jld
This involves some changes to IPC::Channel::ChannelImpl on all platforms in
order to ensure that they are threadsafe.

1. The ChannelImpl is now internally refcounted, making the correctness
   of parts of its lifecycle more clear.
2. Members of the channel are all annotated with `MOZ_GUARDED_BY` for either
   the `io_thread_` or `mutex_` depending on if they are required in order to
   send a message. This gives us some static checks that we won't deadlock.
3. The `closed_` field is removed, as thanks to the mutex, `pipe_` can now be
   checked directly from any thread instead. This reduces the risk of
   forgetting to update `closed_`.
4. `NodeChannel` now calls `Send()` without dispatching, which also required
   updating some other members to also be accessible from any thread, including
   changes to allow asynchronously reporting a channel error when `Send()`
   fails.
5. The Windows handling for `Connect()` was made more thread-safe to queue
   calls to `Send()` performed before `Connect()` returns. The posix
   `Connect()` handler already did this.

Differential Revision: https://phabricator.services.mozilla.com/D158162
2022-10-07 01:51:29 +00:00
Nika Layzell
f51f359297 Bug 1792474 - Part 3: Stop using IPC::Channel to create the pipe for ForkServer, r=ipc-reviewers,jld
Previously the channel used by the ForkServer would be created using
IPC::Channel, and then stolen after the launch was successful. Unfortunately,
this required invoking IPC::Channel methods (such as `Close()`) from the wrong
thread, and so would be racy and hit assertions with the new checks being
added. This patch instead skips creating the IPC::Channel for the fork server,
and allows it to create and configure its own pipe as needed.

This may be used in the future to change out the IPC strategy for the fork
server to something more appropriate, which supports features like async
replies as forked processes die.

Differential Revision: https://phabricator.services.mozilla.com/D158161
2022-10-07 01:51:29 +00:00
Nika Layzell
4b0d8ed93e Bug 1792474 - Part 2: Remove a couple of unused IPC::Channel members, r=ipc-reviewers,mccr8
Differential Revision: https://phabricator.services.mozilla.com/D158160
2022-10-07 01:51:28 +00:00
Alexandre Lissy
86c49e5acd Bug 1788596 - Force audio element load to avoid edge case on media error handling r=alwu
Differential Revision: https://phabricator.services.mozilla.com/D158076
2022-10-06 15:52:00 +00:00
Alexandre Lissy
6d1c22012d Bug 1788596 - Assert CleanShutown() of audioDecoder_* actor shuts down fine r=nika
Differential Revision: https://phabricator.services.mozilla.com/D157480
2022-10-06 15:52:00 +00:00
Alexandre Lissy
9b9e327700 Bug 1788596 - Release UtilityProcessChild later to allow mShutdownBlockers to act r=nika
Differential Revision: https://phabricator.services.mozilla.com/D157938
2022-10-06 15:51:59 +00:00
Alexandre Lissy
2173169002 Bug 1788596 - Kill audioDecoder_Generic if hanging r=nika
Differential Revision: https://phabricator.services.mozilla.com/D157479
2022-10-06 15:51:59 +00:00
Alexandre Lissy
06ac7c2582 Bug 1788596 - Release UtilityProcessManager at the right moment r=nika
Differential Revision: https://phabricator.services.mozilla.com/D156847
2022-10-06 15:51:59 +00:00
Alexandre Lissy
a9dce934a6 Bug 1788596 - Remove Utility AudioDecoder process naming to keep generic name r=alwu
Differential Revision: https://phabricator.services.mozilla.com/D156486
2022-10-06 15:51:58 +00:00
Alexandre Lissy
de9750a92a Bug 1788596 - Use CanSend() instead of boolean r=nika
Differential Revision: https://phabricator.services.mozilla.com/D156485
2022-10-06 15:51:58 +00:00
Alexandre Lissy
2a13301602 Bug 1788596 - Release UtilityAudioDecoderChild on process shutdown r=alwu
Differential Revision: https://phabricator.services.mozilla.com/D156484
2022-10-06 15:51:57 +00:00
Alexandre Lissy
56318b162d Bug 1788596 - Remove RecvNewContentRemoteDecoderManager on wrong class r=alwu
Differential Revision: https://phabricator.services.mozilla.com/D156483
2022-10-06 15:51:57 +00:00
Alexandre Lissy
cb4424182c Bug 1788596 - Remove extra lock() on UtilityProcessChild r=nika
Differential Revision: https://phabricator.services.mozilla.com/D156482
2022-10-06 15:51:57 +00:00
Alexandre Lissy
6a92f8d147 Bug 1788596 - Use Utility process actor names for crash annotations r=gsvelto
Differential Revision: https://phabricator.services.mozilla.com/D156286
2022-10-06 15:51:56 +00:00
Alexandre Lissy
bb317b2bae Bug 1788596 - Remove UTILITY_AUDIO_DECODING_GENERIC r=nika,media-playback-reviewers,alwu
Differential Revision: https://phabricator.services.mozilla.com/D156285
2022-10-06 15:51:56 +00:00
Sandor Molnar
9e30e89e90 Backed out 13 changesets (bug 1788596) for causing build bustage in toolkit/components/processtools/ProcInfo_common.cpp CLOSED TREE
Backed out changeset 620c85305800 (bug 1788596)
Backed out changeset 1f64776a859a (bug 1788596)
Backed out changeset 707e4c9c8801 (bug 1788596)
Backed out changeset 2221a97ebe97 (bug 1788596)
Backed out changeset d50fd0551159 (bug 1788596)
Backed out changeset 7e2ad8c47afb (bug 1788596)
Backed out changeset f87c5fb2c36f (bug 1788596)
Backed out changeset 61dd9a9eb714 (bug 1788596)
Backed out changeset a67c4ea1c8b3 (bug 1788596)
Backed out changeset 1be7af1214cf (bug 1788596)
Backed out changeset e99c7089bf93 (bug 1788596)
Backed out changeset 9a87f108548b (bug 1788596)
Backed out changeset 3dd59224f38b (bug 1788596)
2022-10-06 16:28:46 +03:00
Alexandre Lissy
cdedf4f10a Bug 1788596 - Force audio element load to avoid edge case on media error handling r=alwu
Differential Revision: https://phabricator.services.mozilla.com/D158076
2022-10-06 10:56:45 +00:00
Alexandre Lissy
b5e2b4f2a2 Bug 1788596 - Assert CleanShutown() of audioDecoder_* actor shuts down fine r=nika
Differential Revision: https://phabricator.services.mozilla.com/D157480
2022-10-06 10:56:45 +00:00
Alexandre Lissy
20a3bd77ae Bug 1788596 - Release UtilityProcessChild later to allow mShutdownBlockers to act r=nika
Differential Revision: https://phabricator.services.mozilla.com/D157938
2022-10-06 10:56:45 +00:00
Alexandre Lissy
b99846e45f Bug 1788596 - Kill audioDecoder_Generic if hanging r=nika
Differential Revision: https://phabricator.services.mozilla.com/D157479
2022-10-06 10:56:44 +00:00
Alexandre Lissy
3fa6e7cc2c Bug 1788596 - Release UtilityProcessManager at the right moment r=nika
Differential Revision: https://phabricator.services.mozilla.com/D156847
2022-10-06 10:56:44 +00:00
Alexandre Lissy
d6a62cd0eb Bug 1788596 - Remove Utility AudioDecoder process naming to keep generic name r=alwu
Differential Revision: https://phabricator.services.mozilla.com/D156486
2022-10-06 10:56:43 +00:00
Alexandre Lissy
81229f5ee4 Bug 1788596 - Use CanSend() instead of boolean r=nika
Differential Revision: https://phabricator.services.mozilla.com/D156485
2022-10-06 10:56:43 +00:00
Alexandre Lissy
263ae78245 Bug 1788596 - Release UtilityAudioDecoderChild on process shutdown r=alwu
Differential Revision: https://phabricator.services.mozilla.com/D156484
2022-10-06 10:56:43 +00:00
Alexandre Lissy
ab9121d425 Bug 1788596 - Remove RecvNewContentRemoteDecoderManager on wrong class r=alwu
Differential Revision: https://phabricator.services.mozilla.com/D156483
2022-10-06 10:56:42 +00:00
Alexandre Lissy
c89a2edc37 Bug 1788596 - Remove extra lock() on UtilityProcessChild r=nika
Differential Revision: https://phabricator.services.mozilla.com/D156482
2022-10-06 10:56:42 +00:00
Alexandre Lissy
16c9919af1 Bug 1788596 - Use Utility process actor names for crash annotations r=gsvelto
Differential Revision: https://phabricator.services.mozilla.com/D156286
2022-10-06 10:56:41 +00:00
Alexandre Lissy
1d211b0ec1 Bug 1788596 - Remove UTILITY_AUDIO_DECODING_GENERIC r=nika,media-playback-reviewers,alwu
Differential Revision: https://phabricator.services.mozilla.com/D156285
2022-10-06 10:56:41 +00:00
Sandor Molnar
2fb4e10f0d Backed out 13 changesets (bug 1788596) for causing browser-chrome failures in security/sandbox/test/browser_sandbox_test.js CLOSED TREE
Backed out changeset 338c18d01cfd (bug 1788596)
Backed out changeset 9d4a5c557191 (bug 1788596)
Backed out changeset 1d1d15dbe44c (bug 1788596)
Backed out changeset e9d29218beba (bug 1788596)
Backed out changeset 397e6c6587f3 (bug 1788596)
Backed out changeset 077fd3a987ca (bug 1788596)
Backed out changeset 2fc674146915 (bug 1788596)
Backed out changeset 4ebb8837ee1a (bug 1788596)
Backed out changeset 9040533dabe1 (bug 1788596)
Backed out changeset 8b27ee4d4168 (bug 1788596)
Backed out changeset 93f50c2f0b9e (bug 1788596)
Backed out changeset 3e7125be66fa (bug 1788596)
Backed out changeset 63ee00ea9be6 (bug 1788596)
2022-10-06 10:28:00 +03:00
Alexandre Lissy
efbdf623dc Bug 1788596 - Force audio element load to avoid edge case on media error handling r=alwu
Differential Revision: https://phabricator.services.mozilla.com/D158076
2022-10-06 06:14:10 +00:00
Alexandre Lissy
ce09ecf9e1 Bug 1788596 - Assert CleanShutown() of audioDecoder_* actor shuts down fine r=nika
Differential Revision: https://phabricator.services.mozilla.com/D157480
2022-10-06 06:14:10 +00:00
Alexandre Lissy
d7c350fcd3 Bug 1788596 - Release UtilityProcessChild later to allow mShutdownBlockers to act r=nika
Differential Revision: https://phabricator.services.mozilla.com/D157938
2022-10-06 06:14:09 +00:00
Alexandre Lissy
7ae16664ea Bug 1788596 - Kill audioDecoder_Generic if hanging r=nika
Differential Revision: https://phabricator.services.mozilla.com/D157479
2022-10-06 06:14:09 +00:00
Alexandre Lissy
981b8ee4ca Bug 1788596 - Release UtilityProcessManager at the right moment r=nika
Differential Revision: https://phabricator.services.mozilla.com/D156847
2022-10-06 06:14:09 +00:00
Alexandre Lissy
58223f22b5 Bug 1788596 - Remove Utility AudioDecoder process naming to keep generic name r=alwu
Differential Revision: https://phabricator.services.mozilla.com/D156486
2022-10-06 06:14:08 +00:00
Alexandre Lissy
76e7488bc0 Bug 1788596 - Use CanSend() instead of boolean r=nika
Differential Revision: https://phabricator.services.mozilla.com/D156485
2022-10-06 06:14:08 +00:00
Alexandre Lissy
19b9401e36 Bug 1788596 - Release UtilityAudioDecoderChild on process shutdown r=alwu
Differential Revision: https://phabricator.services.mozilla.com/D156484
2022-10-06 06:14:07 +00:00
Alexandre Lissy
e8a03a304a Bug 1788596 - Remove RecvNewContentRemoteDecoderManager on wrong class r=alwu
Differential Revision: https://phabricator.services.mozilla.com/D156483
2022-10-06 06:14:07 +00:00
Alexandre Lissy
3159f89ec9 Bug 1788596 - Remove extra lock() on UtilityProcessChild r=nika
Differential Revision: https://phabricator.services.mozilla.com/D156482
2022-10-06 06:14:07 +00:00
Alexandre Lissy
dd8daf38e3 Bug 1788596 - Use Utility process actor names for crash annotations r=gsvelto
Differential Revision: https://phabricator.services.mozilla.com/D156286
2022-10-06 06:14:06 +00:00