Commit Graph

19 Commits

Author SHA1 Message Date
Marco Castelluccio
0abc80eebf Bug 1357517 - Remove or delay Preferences.jsm usage from some browser/components/* files. r=Gijs
--HG--
extra : rebase_source : 8ae926bfde827b9a5323d6fb96dc231d429ab9b0
2017-07-31 13:25:41 +02:00
Mark Banner
ec019988a1 Bug 1348097 - Fix intermittent failures caused by Experiments.jsm by ensuring the preference monitoring is in sync. r=gfritzsche
Change the ExperimentsService to get the current value of the preferences (since it only uses them once or twice), so that they match the values in Experiments, and avoid differences causing promises to be rejected in the updateManifest call.
Also fix Experiments to correctly re-enable itself when toolkit.telemetry.enabled is changed from false to true (also fixes bug 1232648).
Finally, add a catch for a promise when calling updateManifest so that we don't get an uncaught promise exception.

MozReview-Commit-ID: GD6gfcRSgbx

--HG--
extra : rebase_source : a5045275c2f864b75443c2cb8fc531ea0e84a704
2017-04-19 12:06:16 +01:00
Wes Kocher
ef1cc83d8b Backed out changeset e1c9c6e89f50 (bug 1348097) for asan failures in test_SubsessionChaining.js a=backout
MozReview-Commit-ID: AiAjjlBmODC
2017-04-20 13:34:16 -07:00
Mark Banner
d8477f9e65 Bug 1348097 - Fix intermittent failures caused by Experiments.jsm by ensuring the preference monitoring is in sync. r=gfritzsche
Change the ExperimentsService to get the current value of the preferences (since it only uses them once or twice), so that they match the values in Experiments, and avoid differences causing promises to be rejected in the updateManifest call.
Also fix Experiments to correctly re-enable itself when toolkit.telemetry.enabled is changed from false to true (also fixes bug 1232648).
Finally, add a catch for a promise when calling updateManifest so that we don't get an uncaught promise exception.

MozReview-Commit-ID: GD6gfcRSgbx

--HG--
extra : rebase_source : 44226ad68bc0bc8b9b763016ea54ca022bfcbcf9
2017-04-19 12:06:16 +01:00
Florian Queze
37ff4fc7cc Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Sebastian Hengst
a07223d699 Backed out changeset 322fde2d53bf (bug 1356569) so bug 1355161 can be backed out. r=backout 2017-04-14 23:39:22 +02:00
Florian Queze
95d4d20c17 Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Jared Wein
ecab54a7c9 Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 7E7LPorrEje

--HG--
extra : rebase_source : 0572a35415a766a3f31d266760ecd07f0dcc3f72
2016-12-29 18:34:54 -05:00
Wes Kocher
0dfb7c2b5c Backed out 3 changesets (bug 1325464) for xpcshell failures a=backout
Backed out changeset 562ddc32cc21 (bug 1325464)
Backed out changeset cd10db6087dd (bug 1325464)
Backed out changeset 4079437c4648 (bug 1325464)
2016-12-29 14:05:44 -08:00
Jared Wein
7255df4e9a Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 8WoGr8i6oCR

--HG--
extra : rebase_source : da7172285d43b820421557ed3b05887e091ff939
2016-12-29 15:20:47 -05:00
Dave Townsend
8de07a19a0 Bug 1316882: Turn on space-before-function-paren eslint rule (browser). r=jaws
MozReview-Commit-ID: 2ZvTiZDHchz

--HG--
extra : rebase_source : db6482481b7338df491afd6f6fd376eccec84d7e
2016-11-11 08:10:51 -08:00
Alessio Placitelli
90ac94e427 Bug 1234526 - Remove unused healthreporter prefs. r=gfritzsche
--HG--
rename : services/healthreport/healthreport-prefs.js => toolkit/components/telemetry/healthreport-prefs.js
2016-01-05 06:41:00 +01:00
Alessio Placitelli
2bd3068c47 Bug 1178456 - Experiments service shouldn't use FHR prefs. r=gfritzsche 2015-07-01 05:46:00 +02:00
David Rajchenbach-Teller
2504927a19 Bug 1087110 - Don't update experiments manifests if no experiment is running. r=gfritzsche 2015-03-10 13:36:17 +01:00
Georg Fritzsche
6a300dfda4 Bug 1005270 - Trigger experiments initialization on opening the addon manager UI. r=bsmedberg 2014-05-16 12:56:25 +02:00
Georg Fritzsche
ad820c03ef Bug 993084 - Delay initialization of telemetry experiments if there is no active experiment. r=bsmedberg
To sync experiment state with the addon manager, we need to start it early when there is a
active experiment.
However, initializing the telemetry experiments system too early can lead to performance
regressions, so we delay the initialization if we don't have an active experiment.
2014-04-15 18:12:26 +02:00
Georg Fritzsche
c825d4572d Bug 993084 - Don't load experiments module if the feature is preffed off. r=bsmedberg 2014-04-10 16:56:25 +02:00
Benjamin Smedberg
0c8a4684ea Bug 984879 - Experiment manager shutdown, r=felipe 2014-03-18 22:52:30 +01:00
Georg Fritzsche
c06192b051 Bug 974009 - Telemetry experiments: test experiment conditions and enable experiments. r=felipe,unfocused 2014-03-18 22:52:28 +01:00