Commit Graph

1229 Commits

Author SHA1 Message Date
Sylvestre Ledru
6f034f2f1c Bug 1617836 - Create a new category for sanitizer in the doc r=decoder
Move the *san files from fuzzing to sanitizer

Depends on D64072

Differential Revision: https://phabricator.services.mozilla.com/D64407

--HG--
rename : tools/fuzzing/docs/asan.rst => tools/sanitizer/docs/asan.rst
rename : tools/fuzzing/docs/asan_nightly.rst => tools/sanitizer/docs/asan_nightly.rst
extra : moz-landing-system : lando
2020-02-27 15:34:12 +00:00
Sylvestre Ledru
0f0ce6d1f5 Bug 1617836 - Polish of the asan doc (fix links, bad char, etc) r=decoder
Depends on D64031

Differential Revision: https://phabricator.services.mozilla.com/D64032

--HG--
extra : moz-landing-system : lando
2020-02-27 11:36:28 +00:00
Sylvestre Ledru
31e4471215 Bug 1617369 - Reformat js/ using rustfmt r=arai,bbouvier
Differential Revision: https://phabricator.services.mozilla.com/D63952

--HG--
extra : moz-landing-system : lando
2020-02-27 10:29:46 +00:00
Sylvestre Ledru
3551670431 Bug 1617369 - Reformat xpcom using rustfmt r=froydnj
Depends on D63955

Differential Revision: https://phabricator.services.mozilla.com/D63956

--HG--
extra : moz-landing-system : lando
2020-02-25 16:17:12 +00:00
Sylvestre Ledru
98a5cfa00d Bug 1617369 - Reformat testing/ using rustfmt r=whimboo,webdriver-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D63940

--HG--
extra : moz-landing-system : lando
2020-02-24 21:40:06 +00:00
Sylvestre Ledru
767a63976f Bug 1617369 - Reformat toolkit/crashreporter/ & toolkit/library/rust/ using rustfmt r=gsvelto
Depends on D63952

Differential Revision: https://phabricator.services.mozilla.com/D63955

--HG--
extra : moz-landing-system : lando
2020-02-25 07:44:53 +00:00
Michael Kaply
6d38738dd2 Bug 1617275 - Don't allow TLS downgrade if TLS min pref is locked. r=mt
Differential Revision: https://phabricator.services.mozilla.com/D63731

--HG--
extra : moz-landing-system : lando
2020-02-24 19:47:58 +00:00
Nick Alexander
4d7d9f4968 Bug 1612191 - Implement mach browsertime --update-upstream-url $URL for bumping version. r=Standard8,tarek
Might as well automate what we can automate.  I considered making the
"update package.json" logic part of setup_helper.py, so that it can be
used more broadly, but it's not clear it would be used with the
general push towards vendoring into the tree as part of `mach vendor`.

Depends on D63370

Differential Revision: https://phabricator.services.mozilla.com/D63371

--HG--
extra : moz-landing-system : lando
2020-02-24 10:53:50 +00:00
Nick Alexander
9404dff40f Bug 1612191 - Pre: Use NPM's --scripts-prepend-node-path rather than setting PATH. r=Standard8
I couldn't find an exact version for the introduction of the flag, but
it appears to be at least NPM v3.  We recently started to install and
require at least NPM v6.13.4 in tree.

Differential Revision: https://phabricator.services.mozilla.com/D63370

--HG--
extra : moz-landing-system : lando
2020-02-21 16:22:42 +00:00
Sylvestre Ledru
a5ae0686ba Bug 1615903 - Add unit tests for rustfmt r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D63028

--HG--
extra : moz-landing-system : lando
2020-02-21 18:28:49 +00:00
Sylvestre Ledru
4c4a229a35 Bug 1615902 - When running the mozlint test, enforce the debug mode r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D63026

--HG--
extra : moz-landing-system : lando
2020-02-21 17:08:36 +00:00
Geoff Brown
e5b5796a47 Bug 1606970 - Use subprocess instead of mozprocess to run eslint; r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D61396

--HG--
extra : moz-landing-system : lando
2020-02-20 22:23:06 +00:00
Bastien Abadie
8a92639faf Bug 1609116 - Activate warnings for rustfmt on code review mode, r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D59859

--HG--
extra : moz-landing-system : lando
2020-01-17 08:05:40 +00:00
Sylvestre Ledru
7dfc110763 Bug 1361341 - Create the list of supported/unsupported directory with clippy r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D58293

--HG--
extra : moz-landing-system : lando
2020-02-18 17:01:30 +00:00
Sylvestre Ledru
ef6f6d2886 Bug 1361341 - Add rust clippy to mozlint r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D58250

--HG--
extra : moz-landing-system : lando
2020-02-19 08:50:35 +00:00
Ciure Andrei
7ab2d76537 Backed out changeset a63ccd650889 (bug 1361341) for causing mozlint failures CLOSED TREE 2020-02-14 11:10:29 +02:00
Sylvestre Ledru
d284704bb3 Bug 1361341 - Add rust clippy to mozlint r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D58250

--HG--
extra : moz-landing-system : lando
2020-02-13 23:22:56 +00:00
Coroiu Cristina
ec8506ea56 Backed out 4 changesets (bug 1361341, bug 1578058) for mozilint failure at test_clippy.py on a CLOSED TREE
Backed out changeset 76d91acac82c (bug 1361341)
Backed out changeset aa0f5c68a325 (bug 1578058)
Backed out changeset 6df34f8ff016 (bug 1578058)
Backed out changeset 066a58eea385 (bug 1361341)
2020-02-14 01:15:11 +02:00
Sylvestre Ledru
71a6ce834d Bug 1361341 - Create the list of supported/unsupported directory with clippy r=ahal
Depends on D58267

Differential Revision: https://phabricator.services.mozilla.com/D58293

--HG--
extra : moz-landing-system : lando
2020-02-13 14:48:39 +00:00
Sylvestre Ledru
39658a665b Bug 1361341 - Add rust clippy to mozlint r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D58250

--HG--
extra : moz-landing-system : lando
2020-02-13 21:39:51 +00:00
alexandru.ionescu
5b6ff5a709 Bug 1599099 - Generate in-tree perfdocs using ./mach lint --fix. r=octavian_negru,sparky
This patch adds the PerfDocs Generator. Some modificiations to `run_perfdocs` were also made because verification always has to occur before the documentation generation, and generation always has to be run after verification (if verification passes).

Differential Revision: https://phabricator.services.mozilla.com/D57111

--HG--
extra : moz-landing-system : lando
2020-02-12 07:00:15 +00:00
Sylvestre Ledru
f9328d2021 Bug 1613526 - Create a code quality documentation and move the appropriate docs r=ahal
This for a few reasons:
* The summary becomes the landing page for code quality:
  https://firefox-source-docs.mozilla.org/tools/static-analysis/summary.html
* I don't think we need a full code quality category
* Closer to the source-code-doc
* All the files at the same place

Differential Revision: https://phabricator.services.mozilla.com/D61767

--HG--
rename : tools/lint/docs/coding-style/coding_style_java.rst => docs/code-quality/coding-style/coding_style_java.rst
rename : tools/lint/docs/coding-style/coding_style_other.rst => docs/code-quality/coding-style/coding_style_other.rst
rename : tools/lint/docs/coding-style/coding_style_python.rst => docs/code-quality/coding-style/coding_style_python.rst
rename : tools/lint/docs/coding-style/format_cpp_code_with_clang-format.rst => docs/code-quality/coding-style/format_cpp_code_with_clang-format.rst
rename : tools/clang-tidy/docs/summary.rst => docs/code-quality/index.rst
rename : tools/lint/docs/create.rst => docs/code-quality/lint/create.rst
rename : tools/lint/docs/index.rst => docs/code-quality/lint/index.rst
rename : tools/lint/docs/index.rst => docs/code-quality/lint/lint.rst
rename : tools/lint/docs/linters/codespell.rst => docs/code-quality/lint/linters/codespell.rst
rename : tools/lint/docs/linters/cpp-virtual-final.rst => docs/code-quality/lint/linters/cpp-virtual-final.rst
rename : tools/lint/docs/linters/eslint-plugin-mozilla.rst => docs/code-quality/lint/linters/eslint-plugin-mozilla.rst
rename : tools/lint/docs/linters/eslint-plugin-spidermonkey-js.rst => docs/code-quality/lint/linters/eslint-plugin-spidermonkey-js.rst
rename : tools/lint/docs/linters/eslint.rst => docs/code-quality/lint/linters/eslint.rst
rename : tools/lint/docs/linters/file-perm.rst => docs/code-quality/lint/linters/file-perm.rst
rename : tools/lint/docs/linters/file-whitespace.rst => docs/code-quality/lint/linters/file-whitespace.rst
rename : tools/lint/docs/linters/flake8.rst => docs/code-quality/lint/linters/flake8.rst
rename : tools/lint/docs/linters/l10n.rst => docs/code-quality/lint/linters/l10n.rst
rename : tools/lint/docs/linters/license.rst => docs/code-quality/lint/linters/license.rst
rename : tools/lint/docs/linters/lintpref.rst => docs/code-quality/lint/linters/lintpref.rst
rename : tools/lint/docs/linters/mingw-capitalization.rst => docs/code-quality/lint/linters/mingw-capitalization.rst
rename : tools/lint/docs/linters/perfdocs.rst => docs/code-quality/lint/linters/perfdocs.rst
rename : tools/lint/docs/linters/rstlinter.rst => docs/code-quality/lint/linters/rstlinter.rst
rename : tools/lint/docs/linters/rustfmt.rst => docs/code-quality/lint/linters/rustfmt.rst
rename : tools/lint/docs/usage.rst => docs/code-quality/lint/usage.rst
rename : tools/clang-tidy/docs/index.rst => docs/code-quality/static-analysis.rst
extra : moz-landing-system : lando
2020-02-11 09:11:44 +00:00
Sylvestre Ledru
095594eed0 no bug - Add review groups + info about unit tests in mozlint r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D61390

--HG--
extra : moz-landing-system : lando
2020-02-10 19:52:46 +00:00
Sylvestre Ledru
423ec1500d no bug - coding style C++ doc: fix the note syntax r=sg
Differential Revision: https://phabricator.services.mozilla.com/D61246

--HG--
extra : moz-landing-system : lando
2020-01-30 08:00:21 +00:00
Julian Descottes
6d77dc5271 Bug 1611229 - Add linting rule to prevent using ChromeUtils.import(..., null) r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D60891

--HG--
extra : moz-landing-system : lando
2020-01-29 13:15:54 +00:00
alexandru.ionescu
1535129890 Bug 1573418 Run Talos harness tests in CI r=rwood,igoldan,perftest-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D56680

--HG--
extra : moz-landing-system : lando
2020-01-29 08:29:13 +00:00
Andrew Halberstadt
8f09bc743f Bug 1608535 - [lint] Forward new --no-error-on-unmatched-pattern to eslint, r=Standard8
This prevents eslint from dumping an error and bailing when a path was specified that
doesn't contain any lintable files.

This patch fixes a bad interaction with 'mozlint' where passing a directory containing
failures alongside a directory that doesn't have lintable files results in the errors
being hidden and mozlint reporting that everying is OK.

Differential Revision: https://phabricator.services.mozilla.com/D60686

--HG--
extra : moz-landing-system : lando
2020-01-23 13:30:27 +00:00
Sylvestre Ledru
df94d62f7f Bug 1611088 - Upgrade to autopep8 1.5 r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D60807

--HG--
extra : moz-landing-system : lando
2020-01-23 14:06:09 +00:00
Kris Maglione
ab5a99dd15 Bug 1602898: Rename Window.getWindowGlobalChild() to .windowGlobalChild. r=farre
Differential Revision: https://phabricator.services.mozilla.com/D56609

--HG--
extra : moz-landing-system : lando
2020-01-21 21:32:28 +00:00
Mark Banner
793a87d40a Bug 1607172 - Update ESLint to the latest version and use ignorePatterns to ignore paths listed in ThirdPartyPaths.txt. r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D59691

--HG--
extra : moz-landing-system : lando
2020-01-21 20:46:06 +00:00
Mihai Alexandru Michis
745c94b1df Backed out changeset 006f4e50e8e5 (bug 1602898) for causing multiple failures.
CLOSED TREE
2020-01-21 22:55:37 +02:00
Kris Maglione
aa0306477e Bug 1602898: Rename Window.getWindowGlobalChild() to .windowGlobalChild. r=farre
Differential Revision: https://phabricator.services.mozilla.com/D56609

--HG--
extra : moz-landing-system : lando
2020-01-21 18:48:26 +00:00
Mihai Alexandru Michis
2dab66d06e Backed out 9 changesets (bug 1607172, bug 1609998, bug 1608799) for causing xpcshell failures in test_parser.js
CLOSED TREE

Backed out changeset 7753083b67dd (bug 1609998)
Backed out changeset e6f5aac734ab (bug 1608799)
Backed out changeset 90ea35966b73 (bug 1608799)
Backed out changeset 6fafa451b3f9 (bug 1608799)
Backed out changeset e07a4aea2ae1 (bug 1608799)
Backed out changeset d69d6dfdccad (bug 1607172)
Backed out changeset 93023b1b6153 (bug 1607172)
Backed out changeset 99ce7a56080e (bug 1607172)
Backed out changeset 20aa5934c785 (bug 1607172)
2020-01-21 21:44:03 +02:00
Mark Banner
96709101c1 Bug 1607172 - Update ESLint to the latest version and use ignorePatterns to ignore paths listed in ThirdPartyPaths.txt. r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D59691

--HG--
extra : moz-landing-system : lando
2020-01-21 17:10:10 +00:00
Simon Giesecke
3f5316df28 Bug 1609943 - Improved section on comparison against true/false, and added note on clang-tidy check. r=sylvestre
Depends on D60281

Differential Revision: https://phabricator.services.mozilla.com/D60282

--HG--
extra : moz-landing-system : lando
2020-01-20 12:37:31 +00:00
Simon Giesecke
3e22e77cc5 Bug 1609943 - Merged two mentions of naming nsresult error variables, and improved wording a bit. r=sylvestre
Depends on D60273

Differential Revision: https://phabricator.services.mozilla.com/D60281

--HG--
extra : moz-landing-system : lando
2020-01-18 12:04:36 +00:00
Simon Giesecke
3da8e73cda Bug 1609943 - Move static analysis to its own section, and add notes on a few more clang-tidy checks. r=sylvestre
Differential Revision: https://phabricator.services.mozilla.com/D60273

--HG--
extra : moz-landing-system : lando
2020-01-20 12:37:21 +00:00
Simon Giesecke
e9e7a0258f Bug 1609943 - Move all string-related rules into one section. r=sylvestre
Differential Revision: https://phabricator.services.mozilla.com/D60264

--HG--
extra : moz-landing-system : lando
2020-01-20 10:17:20 +00:00
Simon Giesecke
843989bf9a Bug 1609943 - Refer to UpperCamelCase to remove ambiguity. r=sylvestre
Differential Revision: https://phabricator.services.mozilla.com/D60263

--HG--
extra : moz-landing-system : lando
2020-01-18 12:02:39 +00:00
Simon Giesecke
34cd11297e Bug 1609943 - Move mode line section from C++ to general coding style. r=sylvestre
Differential Revision: https://phabricator.services.mozilla.com/D60262

--HG--
extra : moz-landing-system : lando
2020-01-18 11:43:19 +00:00
Simon Giesecke
615906c9b7 Bug 1609943 - Split guideline on unary operators into C++ and JavaScript part. r=sylvestre
C++: Remove reference to JavaScript typeof from 'Operators' section and specifically refer to sizeof only.

JavaScript: Added remainder of the guideline referring to typeof.

Differential Revision: https://phabricator.services.mozilla.com/D60261

--HG--
extra : moz-landing-system : lando
2020-01-21 08:19:55 +00:00
Simon Giesecke
dfc0fdd507 Bug 1609943 - Cleanup in-line code fragments to use proper encapsulation. r=sylvestre
Differential Revision: https://phabricator.services.mozilla.com/D60260

--HG--
extra : moz-landing-system : lando
2020-01-17 15:51:35 +00:00
Cosmin Sabou
9b6e5f8e66 Backed out changeset 4c303f6ec2e6 (bug 1602898) for browser chrome failures on browser_ssb_windowlocation. 2020-01-18 01:06:34 +02:00
Kris Maglione
036e960542 Bug 1602898: Rename Window.getWindowGlobalChild() to .windowGlobalChild. r=farre
Differential Revision: https://phabricator.services.mozilla.com/D56609

--HG--
extra : moz-landing-system : lando
2020-01-17 21:36:10 +00:00
Siddhant085
676ce0d13c Bug 1511700 - Use the new notification system (PlacesObserver) for bookmark removed notifications. r=Standard8,mak
Phasing out the old notification system for OnItemRemoved events.

Differential Revision: https://phabricator.services.mozilla.com/D17753

--HG--
extra : moz-landing-system : lando
2020-01-16 18:38:54 +00:00
Tomislav Jovanovic
48d05a45cb Bug 1602639 - Switch native messaging from MessageManagers to Conduits r=robwu
Differential Revision: https://phabricator.services.mozilla.com/D58356

--HG--
extra : moz-landing-system : lando
2020-01-16 22:41:27 +00:00
shindli
3d28702804 Backed out changeset 1bdfd7c37b02 (bug 1511700) for causing newtab node test failure CLOSED TREE 2020-01-13 22:33:58 +02:00
Siddhant085
d48342d7db Bug 1511700 - Use the new notification system (PlacesObserver) for bookmark removed notifications. r=Standard8,mak
Phasing out the old notification system for OnItemRemoved events.

Differential Revision: https://phabricator.services.mozilla.com/D17753

--HG--
extra : moz-landing-system : lando
2020-01-13 16:25:39 +00:00
Ethan Glasser-Camp
7cd2a98da0 Bug 1606026: Move existing documentation into new locations r=sylvestre
Differential Revision: https://phabricator.services.mozilla.com/D58338

--HG--
rename : tools/docs/docs/contribute/mozilla_source_code_directory_structure.rst => docs/contributing/directory_structure.rst
rename : tools/docs/docs/contribute/how_to_contribute_firefox.rst => docs/contributing/how_to_contribute_firefox.rst
rename : tools/docs/docs/adding-documentation.rst => tools/moztreedocs/docs/adding-documentation.rst
rename : tools/docs/docs/index.rst => tools/moztreedocs/docs/index.rst
rename : tools/docs/docs/mdn-import.rst => tools/moztreedocs/docs/mdn-import.rst
extra : moz-landing-system : lando
2020-01-06 16:38:34 +00:00
Ethan Glasser-Camp
6f164aa98f Bug 1606026: Move documentation entry point to docs/ r=sylvestre
Differential Revision: https://phabricator.services.mozilla.com/D58552

--HG--
rename : tools/docs/conf.py => docs/conf.py
rename : tools/docs/config.yml => docs/config.yml
rename : tools/docs/index.rst => docs/index.rst
rename : tools/docs/jsdoc.json => docs/jsdoc.json
extra : moz-landing-system : lando
2020-01-06 16:14:11 +00:00