We were breaking twice in the browser toolbox because we were attaching to
all the content process targets as well as all frame targets.
But as frames (i.e. web pages) are running within the content processes,
we were having two thread actor attached to the same thread.
This is a stopgap solution for the browser toolbox and we would need
to do something better for the content toolboxes.
Differential Revision: https://phabricator.services.mozilla.com/D57505
--HG--
extra : moz-landing-system : lando
The ReflowTracker was based on the assumption that there was only ever going to
be one target to be observed.
With Fission, this is no longer true.
Turning the ReflowTracker into something that is multi-target aware seemed more
complex than really worth it. After all, all it was doing is getting a ReflowFront
and listening for events on it.
The only 3 things that needed it are the grid inspector, flex inspector and box
model widget. They all needed it for the same reason: updating the data displayed
in the UI when the size/geometry/box-model regions of the selected node changed.
So, it seems simpler to let the inspector instantiate the right ReflowFront when
it needs it (upon a new node selection).
There's only one node selected at any given time in the inspector, so it's simple
to just listen for reflow in that node's target, and dispatch events to the grid,
flex and box-model tools so they can update themselves.
Note that once a new node is selected, we do the `getFront("Reflow")` again
since that node can be in a different target than the previous one. If it is,
however, in the same target, then `getFront` will return the same instance which
is nice.
Differential Revision: https://phabricator.services.mozilla.com/D55987
--HG--
extra : moz-landing-system : lando
This is exactly the kind of test that makes no sense once we have finished
the rework of RDM (to be embedded into the browser UI). Indeed, once done,
there won't be a nested iframe in RDM through which we need to make sure
all messages that lead to the tab status/title/icon (and many other things)
are forwarded.
So, because this test currently fails with fission, let's just disable it
for now when in fission mode, and then once the RDM project is done, let's
delete it entirely. No use spending time making it work now if we're going
to remove it later.
Differential Revision: https://phabricator.services.mozilla.com/D57758
--HG--
extra : moz-landing-system : lando
If the test only fails today with fission with the old RDM, then it makes no
sense to fix that now. Better wait for the new RDM to be enabled as it will
probably change how this test runs.
Differential Revision: https://phabricator.services.mozilla.com/D57798
--HG--
extra : moz-landing-system : lando
Variables are retrieved from CodeMirror state and sent to the
webconsole actor, where the filtering is done.
Differential Revision: https://phabricator.services.mozilla.com/D57427
--HG--
extra : moz-landing-system : lando
This ensures the selected item of the autocomplete
popup is updated, so if the user accepts the completion
it will retrieve the right text.
Differential Revision: https://phabricator.services.mozilla.com/D57342
--HG--
extra : moz-landing-system : lando
The failure indicates a pending request to the highlighter
actor. This patch moves the mouse at the top left corner of
the console to avoid hovering any dom elements that might
trigger the highlighter.
Differential Revision: https://phabricator.services.mozilla.com/D57345
--HG--
extra : moz-landing-system : lando
This patch places the mouse cursor at the top left corner so
it does not inadvertently triggers an highlighter.
Differential Revision: https://phabricator.services.mozilla.com/D57343
--HG--
extra : moz-landing-system : lando
Show the size only in Raw Data, because showing it on all tabs is redundant and on Raw makes most sense.
Differential Revision: https://phabricator.services.mozilla.com/D52607
--HG--
extra : moz-landing-system : lando
Fission changes made it so the `PageStyle` is referenced contextually from the `InspectorFront` of the `NodeFront` wherever needed. Most references in the code no longer use the static reference to `PageStyle` from the Inspector client (which only points to the top-level document anyway).
This patch removes that reference from the Inspector client and updates any leftover bits to use the contextual `PageStyle` from the abandoned /new Rules view and some tests.
The Shapes Highlighter tests will be refactored separately in [Bug 1603066](https://bugzilla.mozilla.org/show_bug.cgi?id=1603066). This patch just corrects the references without attempting to cleanup the tests themselves.
Differential Revision: https://phabricator.services.mozilla.com/D56714
--HG--
extra : moz-landing-system : lando
We don't want to run stream conversion in the parent (since a lot of them require access to the document), so this instead adds a way to find out what their output type will be.
Differential Revision: https://phabricator.services.mozilla.com/D56134
--HG--
extra : moz-landing-system : lando
We don't want to run stream conversion in the parent (since a lot of them require access to the document), so this instead adds a way to find out what their output type will be.
Differential Revision: https://phabricator.services.mozilla.com/D56134
--HG--
extra : moz-landing-system : lando
