Commit Graph

7153 Commits

Author SHA1 Message Date
Jet Villegas
6d95828266 merge from inbound 2016-06-04 03:33:38 -07:00
Jet Villegas
a22a6660d7 Bug 1268736: An editable table cell means that both the cell and its contents are children of an editable node. r=mats 2016-06-04 03:23:56 -07:00
Masayuki Nakano
258c1f97d6 Bug 1277756 part.7 Rename TextRangeType::NS_TEXTRANGE_SELECTEDCONVERTEDTEXT to TextRangeType::eSelectedClause r=smaug
MozReview-Commit-ID: GyRYWzfeWrm

--HG--
extra : rebase_source : 8bebacaf675ec4a3cf91cfd434d07beeb7fb1567
2016-06-03 19:15:21 +09:00
Masayuki Nakano
3fa2003d17 Bug 1277756 part.6 Rename TextRangeType::NS_TEXTRANGE_CONVERTEDTEXT to TextRangeType::eConvertedClause r=smaug
MozReview-Commit-ID: 3mexBm278As

--HG--
extra : rebase_source : ef363b0ac50396631e9b145b7e869330509fe259
2016-06-03 19:05:32 +09:00
Masayuki Nakano
98f069e029 Bug 1277756 part.5 Rename TextRangeType::NS_TEXTRANGE_SELECTEDRAWTEXT to TextRangeType::eSelectedRawClause r=smaug
MozReview-Commit-ID: MbG4siLb4Q

--HG--
extra : rebase_source : 23c20c55c3936dc6af5f57414ef7630003480275
2016-06-03 18:57:21 +09:00
Masayuki Nakano
f4254e7f7f Bug 1277756 part.4 Rename TextRangeType::NS_TEXTRANGE_RAWINPUT to TextRangeType::eRawClause r=smaug
MozReview-Commit-ID: KLC1VPiYTdz

--HG--
extra : rebase_source : 3f750e526bb04b26ed66d2c0fada14e7d5b43d73
2016-06-03 18:48:37 +09:00
Masayuki Nakano
6b5425853a Bug 1277756 part.3 Rename TextRangeType::NS_TEXTRANGE_CARETPOSITION to TextRangeType::eCaret r=smaug
MozReview-Commit-ID: CaqmOSxYYU7

--HG--
extra : rebase_source : 5820d491b97be7899150516d05f1426e74dab5b5
2016-06-03 18:40:06 +09:00
Masayuki Nakano
4fc95828b6 Bug 1277756 part.1 Make anonymous enum for NS_TEXTRANGE_* to an enum class named "TextRangeType" r=smaug
For making our code clearer by the stronger type check, we should change the anonymous enum for NS_TEXTRANGE_* to enum class whose name is "TextRangeType" and whose type is "RawTextRangeType" which is an alias of uint8_t.

Additionally, this also adds some utility methods for them.

Note that some lines which are changed by this patch become over 80 characters but it will be fixed by the following patches.

MozReview-Commit-ID: 76izA1WqTkp

--HG--
extra : rebase_source : 27cd8cc8f7f8e82055dbfe82aba94c02beda5fa4
2016-06-04 09:49:21 +09:00
Joel Maher
a6fcbcf0a3 Bug 1270962 - move tests which access the clipboard to subsuite 'clipboard'. r=bgrins,ryanvm,armenzg a=merge
MozReview-Commit-ID: IZziPmwFtHj

--HG--
extra : source : a50249d48b1e86a3749bccc51ece4d1a827a621c
2016-05-25 15:28:24 -04:00
Masayuki Nakano
d7fdaf7cf8 Bug 1272490 nsHTMLEditRules::ReapplyCachedStyles() should do nothing if nsIEditor::GetSelection() returns nullptr r=Ehsan
nsHTMLEditRules::ReapplyCachedStyles() may be called after the document is removed from the DOM tree.  For example, the document can be removed from the tree even during handling an edit operation if the web contents uses DOMMutationEvent. In such case, nsIEditor::GetSelection() returns nullptr and it should do nothing.

MozReview-Commit-ID: Jk3eGalAPhB

--HG--
extra : rebase_source : 54b8eb0ace2c656a68cd8aaf0edd3d1177b127ff
2016-05-17 11:47:39 +09:00
Trevor Saunders
256fff4fc9 bug 1271436 - add nsIDocShell::GetCommandManager() r=smaug 2016-05-17 18:16:07 -04:00
Masayuki Nakano
8a70a17c6a Bug 1254755 part.2 Rename WidgetKeyboardEvent::charCode to WidgetKeyboardEvent::mCharCode r=smaug
And mCharCode shouldn't be compared with NS_VK_*, nsIDOMKeyEvent::DOM_VK_*. Additionally, when it's compared with a character constant, cast isn't necessary.

MozReview-Commit-ID: JMT614copjG

--HG--
extra : rebase_source : 69ee3c589e5a71c814ec9a40ac3aab39c789c11d
2016-05-13 16:06:18 +09:00
Masayuki Nakano
3359bad586 Bug 1254755 part.1 Rename WidgetKeyboardEvent::keyCode to WidgetKeyboardEvent::mKeyCode r=smaug
And also WidgetKeyboardEvent::mKeyCode should be compared with NS_VK_* rather than nsIDOMKeyEvent::DOM_VK_*.

MozReview-Commit-ID: IKjQ1nr8XYe

--HG--
extra : rebase_source : 83125cd2523f6b70759f621470aad23b00aae8ae
2016-05-12 17:13:49 +09:00
Chris Peterson
8a9e2d2bd4 Bug 1272513 - Part 2: Remove redundant -Wshadow CXXFLAGS from moz.build files. r=glandium 2016-05-14 00:54:55 -07:00
Chris Peterson
353ee65255 Bug 1272513 - Part 1: Suppress -Wshadow warnings-as-errors in some directories. r=glandium 2016-05-11 00:00:01 -07:00
Olli Pettay
43edbfcf37 Bug 1271460, don't leak editor created element objects, r=ehsan
--HG--
extra : rebase_source : a1294b6e57df3a5a85e35e808320bef9e1b0747e
2016-05-13 20:10:22 +03:00
L. David Baron
d097996b85 Bug 1111440 - Replace -moz- prefixed logical margin/padding/border properties with their standard versions. r=heycam
This patch was generated by the command:
  find . -name "*.css" -exec sed -i -f mozpropsub {} \;
in the root of a mozilla-central tree, with the file mozpropsub
containing the contents:
s/-moz-padding-end\>/padding-inline-end/g
s/-moz-padding-start\>/padding-inline-start/g
s/-moz-margin-end\>/margin-inline-end/g
s/-moz-margin-start\>/margin-inline-start/g
s/-moz-border-end\>/border-inline-end/g
s/-moz-border-end-color\>/border-inline-end-color/g
s/-moz-border-end-style\>/border-inline-end-style/g
s/-moz-border-end-width\>/border-inline-end-width/g
s/-moz-border-start\>/border-inline-start/g
s/-moz-border-start-color\>/border-inline-start-color/g
s/-moz-border-start-style\>/border-inline-start-style/g
s/-moz-border-start-width\>/border-inline-start-width/g

While I didn't manually review all the changes, I did review the list of
files, and manually reviewed the changes in the files that I thought
were more interesting.

Note that there are a few tests that should be fixed up as well, but
I'll do that in a later patch.

MozReview-Commit-ID: EiQTuuV0MNQ
2016-05-12 22:19:58 -07:00
Xidorn Quan
fa7ba2cb82 Bug 1269975 part 1 - Move nsCSSProps::EnabledState to a top level enum class mozilla::CSSEnabledState. r=heycam
MozReview-Commit-ID: 3KH5cqDFzUI

--HG--
extra : rebase_source : 3c8355f7807982152a16a913b31cbcdd6ef78030
extra : source : 73e89d25a34ca5587f306b848b0b801342f9432f
2016-05-10 18:44:05 +10:00
Ryan VanderMeulen
f514ed495c Backed out 4 changesets (bug 1269975) for bustage.
Backed out changeset a55ecedea260 (bug 1269975)
Backed out changeset 5321545b938c (bug 1269975)
Backed out changeset 7e4a2ee61ef3 (bug 1269975)
Backed out changeset d181f8e7e4c3 (bug 1269975)
2016-05-10 00:08:54 -04:00
Xidorn Quan
30a6d76b26 Bug 1269975 part 1 - Move nsCSSProps::EnabledState to a top level enum class mozilla::CSSEnabledState. r=heycam
MozReview-Commit-ID: 3KH5cqDFzUI

--HG--
extra : source : 73e89d25a34ca5587f306b848b0b801342f9432f
2016-05-10 13:36:25 +10:00
L. David Baron
9ee89fe42f Bug 567283 patch 2 - Rename NS_HexToRGB to NS_HexToRGBA and add parameter saying whether 4 and 8 digit colors are allowed. r=xidorn
This patch tells all callers to use the existing behavior, so it is
intended not to change behavior.  Callers that will be modified in later
patches are marked with "FIXME" comments that will be removed in those
later patches (patches 3 and 4).

MozReview-Commit-ID: FaLryfxaeHv
2016-05-08 22:16:41 -07:00
Kyle Huey
941ab1f522 Bug 1268313: Part 7 - Move NS_NewRunnableMethod and friends to mozilla::NewRunnableMethod. r=froydnj 2016-05-05 01:45:00 -07:00
Ting-Yu Lin
c4e4d765b0 Bug 1270030 - Remove "layout.accessiblecaret.extendedvisibility" pref from IMETextTxn. r=mats
The pref had been removed in bug 1249201. Need to clean it up for IMETextTxn.

MozReview-Commit-ID: EaFaN1yzoyP

--HG--
extra : rebase_source : 55da9499245d4d773bbce74e99c013f9814084b4
2016-05-04 17:05:35 +08:00
Eric Rahm
6c9db7a162 Bug 1269047 - Remove chained ENSURE calls from GetStartNodeAndOffset. r=ehsan 2016-05-02 21:25:56 -07:00
Aryeh Gregor
f14f1babe8 Bug 1193762 part 8 - Fix things that will break; r=froydnj
It looks like VC++ doesn't like comparisons of nsCOMPtr to 0 after this
change, but those are bad style anyway, so I removed them from
TestCOMPtr.cpp instead of trying to make them work.
2016-05-01 21:29:23 +03:00
Aryeh Gregor
585263dafa Bug 1193762 part 4 - Avoid nsCOMPtr in ternary operator; r=froydnj 2016-05-01 21:29:22 +03:00
Aryeh Gregor
0a025f6cca Bug 1193762 part 3 - Remove nsEditor::IsDescendantOfEditorRoot(nsIDOMNode*); r=ehsan 2016-05-01 17:59:29 +03:00
Aryeh Gregor
419ed0f1bb Bug 1193762 part 2 - Remove nsHTMLEditor::IsVisBreak(nsIDOMNode*); r=ehsan 2016-05-01 17:59:17 +03:00
Aryeh Gregor
9f98b80267 Bug 1193762 part 1 - Remove nsEditor::IsBlockNode(nsIDOMNode*); r=ehsan 2016-05-01 17:59:05 +03:00
Aryeh Gregor
0a569d869c Bug 1191356 part 9 - Convert nsHTMLEditRules::mNewBlock to Element; r=ehsan 2016-05-01 17:58:53 +03:00
Aryeh Gregor
81dd1ee865 Bug 1191356 part 8 - Clean up nsHTMLEditRules::WillAbsolutePosition; r=ehsan 2016-05-01 17:58:41 +03:00
Aryeh Gregor
bf808d8cc0 Bug 1191356 part 7 - Clean up nsHTMLEditor::GetSelectionContainer; r=ehsan
This makes the XPCOM GetSelectionContainer return an error in cases
where previously it would return success but a null pointer.  This could
theoretically cause problems, but there's no obvious non-ugly way to
avoid it.
2016-05-01 17:58:29 +03:00
Aryeh Gregor
1d5314df0c Bug 1191356 part 6 - Clean up nsHTMLEditRules::WillMakeBasicBlock; r=ehsan 2016-05-01 17:58:17 +03:00
Sebastian Hengst
2fd74ed0d1 Backed out changeset 6dbba6c4a200 (bug 1191356) for build bustage. r=backout on a CLOSED TREE 2016-05-01 16:27:40 +02:00
Sebastian Hengst
ce0ea5ad03 Backed out changeset aa61db1f8f83 (bug 1191356) 2016-05-01 16:27:29 +02:00
Sebastian Hengst
0526cdbd22 Backed out changeset 7b3284a488dc (bug 1191356) 2016-05-01 16:27:21 +02:00
Sebastian Hengst
bed664c09b Backed out changeset acf185618acd (bug 1191356) 2016-05-01 16:27:11 +02:00
Sebastian Hengst
46b9ec79bb Backed out changeset 50b15734fe1d (bug 1193762) 2016-05-01 16:27:03 +02:00
Sebastian Hengst
e1428250cb Backed out changeset 6b3d9803990b (bug 1193762) 2016-05-01 16:26:56 +02:00
Sebastian Hengst
ff6ae40a51 Backed out changeset ef0eaadbed31 (bug 1193762) 2016-05-01 16:26:45 +02:00
Aryeh Gregor
4f5b418627 Bug 1193762 part 3 - Remove nsEditor::IsDescendantOfEditorRoot(nsIDOMNode*); r=ehsan 2016-05-01 16:18:39 +03:00
Aryeh Gregor
45c59d499f Bug 1193762 part 2 - Remove nsHTMLEditor::IsVisBreak(nsIDOMNode*); r=ehsan 2016-05-01 16:18:26 +03:00
Aryeh Gregor
0c5699255e Bug 1193762 part 1 - Remove nsEditor::IsBlockNode(nsIDOMNode*); r=ehsan 2016-05-01 16:18:14 +03:00
Aryeh Gregor
99add47b6d Bug 1191356 part 9 - Convert nsHTMLEditRules::mNewBlock to Element; r=ehsan 2016-05-01 16:18:03 +03:00
Aryeh Gregor
dccb99b0b6 Bug 1191356 part 8 - Clean up nsHTMLEditRules::WillAbsolutePosition; r=ehsan 2016-05-01 16:17:50 +03:00
Aryeh Gregor
0d6d4b284b Bug 1191356 part 7 - Clean up nsHTMLEditor::GetSelectionContainer; r=ehsan
This makes the XPCOM GetSelectionContainer return an error in cases
where previously it would return success but a null pointer.  This could
theoretically cause problems, but there's no obvious non-ugly way to
avoid it.
2016-05-01 16:17:39 +03:00
Aryeh Gregor
77e622044a Bug 1191356 part 6 - Clean up nsHTMLEditRules::WillMakeBasicBlock; r=ehsan 2016-05-01 16:17:27 +03:00
Aryeh Gregor
5905c70893 Bug 1191356 part 5 - Clean up nsHTMLEditRules::RelativeChangeIndentationOfElementNode; r=ehsan 2016-05-01 16:17:15 +03:00
Aryeh Gregor
8591247a42 Bug 1191356 part 4 - Clean up nsHTMLEditRules::MoveNodeSmart, MoveContents; r=ehsan 2016-05-01 16:17:03 +03:00
Aryeh Gregor
bfb967416f Bug 1191356 part 3 - Clean up nsHTMLEditRules::MoveBlock; r=ehsan 2016-05-01 16:16:50 +03:00