AddonManagergetInstallForURL() has a number of optional arguments, most
of which are passed infrequently. Convert them from positional arguments
to a single options object.
Differential Revision: https://phabricator.services.mozilla.com/D18475
--HG--
extra : rebase_source : 503c09b54fab90cefe69286b05def43ef70074df
This patch includes the following changes:
- added a new "num_strings" extra key to the "addonsManager install" and "addonsManager manage"
telemetry events, where "num_strings" represents the "number of permissions actually visible
in the extension permission doorhanger"
- do not record a telemetry event for the "permission_prompt" (or "sideload_prompt") if the
permissions_prompt is not going to be shown
- add num_strings and removed "num_perms" and "num_origins" extras from the test assertions in the existing tests
- added some additional assertions to test in automation that we don't record the telemetry
event for "permission_prompt" when no permission prompt is being shown for an
extension update (as part of the browser_extension_update_background_noprompt.js test)
Differential Revision: https://phabricator.services.mozilla.com/D16992
--HG--
extra : moz-landing-system : lando
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8
This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:
ChromeUtils.import("resource://gre/modules/Services.jsm");
is approximately the same as the following, in the new model:
var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");
Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs
This was done using the followng script:
https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16750
--HG--
extra : rebase_source : 359574ee3064c90f33bf36c2ebe3159a24cc8895
extra : histedit_source : b93c8f42808b1599f9122d7842d2c0b3e656a594%2C64a3a4e3359dc889e2ab2b49461bab9e27fc10a7
This is a quick pass to weed out some obsolete tests and update others.
browser_doorhanger_installs.js still needs a more comprehensive pass to
get rid of obsolete test cases.
--HG--
rename : toolkit/mozapps/extensions/test/browser/browser_bug596336.js => toolkit/mozapps/extensions/test/browser/browser_reinstall.js
extra : rebase_source : f8af8991e98424f151c6dd8822599e20c870be08
extra : source : 36ba8ad1c6000fb3810cf0fdd1542e49e50d0963
extra : histedit_source : abdb813afb162f3dff58906def889ce50a7b512b
In Bug 1479125 we put calls to .children that were intended to access child elements into the custom
method, which is a slower path. We may eventually want to remove itemChildren altogether and just assume
that all children are items, but that's out of scope for a perf fix like this.
Differential Revision: https://phabricator.services.mozilla.com/D10751
--HG--
extra : moz-landing-system : lando
- Added definitions for the new telemetry events
- Send telemetry events for each AddonManager action on an extension.
- Ensure that telemetry events are sent also for the extension prompts.
Differential Revision: https://phabricator.services.mozilla.com/D4448
--HG--
extra : moz-landing-system : lando
This is a follow up to Bug 1482667. The list of callers was gathered by instrumenting
the webidl calls to these methods and dumping JS stack when they are called in browser.xul.
Differential Revision: https://phabricator.services.mozilla.com/D5185
--HG--
extra : moz-landing-system : lando
Automatic changes by ESLint, except for manual corrections for .xml files.
Differential Revision: https://phabricator.services.mozilla.com/D4439
--HG--
extra : moz-landing-system : lando
These issues were previously ignored due to the nature of our global import
rules. They need to be fixed before that rule can be updated.
MozReview-Commit-ID: DCChktTc5TW
--HG--
extra : rebase_source : cffb1c9762191c579d1397c8169e6e7635d229da
extra : histedit_source : dea59ddd2daaae52069c5faceae9149a4f08dd73
Several of these tests are obsolete. They only test non-AMO-signed extensions
(which are equivalent to unsigned extensions now), non-restartless extensions
(which aren't supported), or specific behaviors of the old XPInstall dialogs (which are
essentially unsupported).
The rest have been updated to use WebExtensions.
MozReview-Commit-ID: CBGTtl5XbG7
--HG--
rename : toolkit/mozapps/extensions/test/browser/addons/browser_installssl/install.rdf => toolkit/mozapps/extensions/test/browser/addons/browser_installssl/manifest.json
rename : toolkit/mozapps/extensions/test/xpinstall/amosigned.xpi => toolkit/mozapps/extensions/test/xpinstall/amosigned-restart-required.xpi
rename : browser/base/content/test/general/browser_bug553455.js => toolkit/mozapps/extensions/test/xpinstall/browser_doorhanger_installs.js
extra : rebase_source : 92bde0e0ca3b8e412b97e10f232ccdf8f3c0e84a
extra : absorb_source : 12fc93c4de6d5bab90c7bc0d83eef2316cc257cd
extra : histedit_source : c6305693d966956c7d6e84d87364d703606937cf%2C838f8f30f7d1c467618eb59062586d2876abbfce
The shims that this rule tests for no longer exist.
MozReview-Commit-ID: DMgP7Hczavc
--HG--
extra : rebase_source : 765ddd5c62c9449c07ed050e44d86a3bd5c0ae64
extra : amend_source : 627a7694ac07182200f876901ded7a34721cd228
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm
MozReview-Commit-ID: 1Nc3XDu0wGl
--HG--
extra : source : 12fc4dee861c812fd2bd032c63ef17af61800c70
extra : intermediate-source : 34c999fa006bffe8705cf50c54708aa21a962e62
extra : histedit_source : b2be2c5e5d226e6c347312456a6ae339c1e634b0
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm
MozReview-Commit-ID: 1Nc3XDu0wGl
--HG--
extra : source : 12fc4dee861c812fd2bd032c63ef17af61800c70
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm
MozReview-Commit-ID: 1Nc3XDu0wGl
--HG--
extra : rebase_source : c004a023389f1f6bf3d2f3efe93c13d423b23ccd
Also consolidated the two .ini files in toolkit/mozapps/extension/test/browser
since we only run these tests in tabs now.
MozReview-Commit-ID: HHwM4Q1K5C8
--HG--
extra : rebase_source : 6db3527ee6973946d188fa70dc8af1c008094d49