Commit Graph

1209 Commits

Author SHA1 Message Date
alexandru.ionescu
5b6ff5a709 Bug 1599099 - Generate in-tree perfdocs using ./mach lint --fix. r=octavian_negru,sparky
This patch adds the PerfDocs Generator. Some modificiations to `run_perfdocs` were also made because verification always has to occur before the documentation generation, and generation always has to be run after verification (if verification passes).

Differential Revision: https://phabricator.services.mozilla.com/D57111

--HG--
extra : moz-landing-system : lando
2020-02-12 07:00:15 +00:00
Sylvestre Ledru
f9328d2021 Bug 1613526 - Create a code quality documentation and move the appropriate docs r=ahal
This for a few reasons:
* The summary becomes the landing page for code quality:
  https://firefox-source-docs.mozilla.org/tools/static-analysis/summary.html
* I don't think we need a full code quality category
* Closer to the source-code-doc
* All the files at the same place

Differential Revision: https://phabricator.services.mozilla.com/D61767

--HG--
rename : tools/lint/docs/coding-style/coding_style_java.rst => docs/code-quality/coding-style/coding_style_java.rst
rename : tools/lint/docs/coding-style/coding_style_other.rst => docs/code-quality/coding-style/coding_style_other.rst
rename : tools/lint/docs/coding-style/coding_style_python.rst => docs/code-quality/coding-style/coding_style_python.rst
rename : tools/lint/docs/coding-style/format_cpp_code_with_clang-format.rst => docs/code-quality/coding-style/format_cpp_code_with_clang-format.rst
rename : tools/clang-tidy/docs/summary.rst => docs/code-quality/index.rst
rename : tools/lint/docs/create.rst => docs/code-quality/lint/create.rst
rename : tools/lint/docs/index.rst => docs/code-quality/lint/index.rst
rename : tools/lint/docs/index.rst => docs/code-quality/lint/lint.rst
rename : tools/lint/docs/linters/codespell.rst => docs/code-quality/lint/linters/codespell.rst
rename : tools/lint/docs/linters/cpp-virtual-final.rst => docs/code-quality/lint/linters/cpp-virtual-final.rst
rename : tools/lint/docs/linters/eslint-plugin-mozilla.rst => docs/code-quality/lint/linters/eslint-plugin-mozilla.rst
rename : tools/lint/docs/linters/eslint-plugin-spidermonkey-js.rst => docs/code-quality/lint/linters/eslint-plugin-spidermonkey-js.rst
rename : tools/lint/docs/linters/eslint.rst => docs/code-quality/lint/linters/eslint.rst
rename : tools/lint/docs/linters/file-perm.rst => docs/code-quality/lint/linters/file-perm.rst
rename : tools/lint/docs/linters/file-whitespace.rst => docs/code-quality/lint/linters/file-whitespace.rst
rename : tools/lint/docs/linters/flake8.rst => docs/code-quality/lint/linters/flake8.rst
rename : tools/lint/docs/linters/l10n.rst => docs/code-quality/lint/linters/l10n.rst
rename : tools/lint/docs/linters/license.rst => docs/code-quality/lint/linters/license.rst
rename : tools/lint/docs/linters/lintpref.rst => docs/code-quality/lint/linters/lintpref.rst
rename : tools/lint/docs/linters/mingw-capitalization.rst => docs/code-quality/lint/linters/mingw-capitalization.rst
rename : tools/lint/docs/linters/perfdocs.rst => docs/code-quality/lint/linters/perfdocs.rst
rename : tools/lint/docs/linters/rstlinter.rst => docs/code-quality/lint/linters/rstlinter.rst
rename : tools/lint/docs/linters/rustfmt.rst => docs/code-quality/lint/linters/rustfmt.rst
rename : tools/lint/docs/usage.rst => docs/code-quality/lint/usage.rst
rename : tools/clang-tidy/docs/index.rst => docs/code-quality/static-analysis.rst
extra : moz-landing-system : lando
2020-02-11 09:11:44 +00:00
Sylvestre Ledru
095594eed0 no bug - Add review groups + info about unit tests in mozlint r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D61390

--HG--
extra : moz-landing-system : lando
2020-02-10 19:52:46 +00:00
Sylvestre Ledru
423ec1500d no bug - coding style C++ doc: fix the note syntax r=sg
Differential Revision: https://phabricator.services.mozilla.com/D61246

--HG--
extra : moz-landing-system : lando
2020-01-30 08:00:21 +00:00
Julian Descottes
6d77dc5271 Bug 1611229 - Add linting rule to prevent using ChromeUtils.import(..., null) r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D60891

--HG--
extra : moz-landing-system : lando
2020-01-29 13:15:54 +00:00
alexandru.ionescu
1535129890 Bug 1573418 Run Talos harness tests in CI r=rwood,igoldan,perftest-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D56680

--HG--
extra : moz-landing-system : lando
2020-01-29 08:29:13 +00:00
Andrew Halberstadt
8f09bc743f Bug 1608535 - [lint] Forward new --no-error-on-unmatched-pattern to eslint, r=Standard8
This prevents eslint from dumping an error and bailing when a path was specified that
doesn't contain any lintable files.

This patch fixes a bad interaction with 'mozlint' where passing a directory containing
failures alongside a directory that doesn't have lintable files results in the errors
being hidden and mozlint reporting that everying is OK.

Differential Revision: https://phabricator.services.mozilla.com/D60686

--HG--
extra : moz-landing-system : lando
2020-01-23 13:30:27 +00:00
Sylvestre Ledru
df94d62f7f Bug 1611088 - Upgrade to autopep8 1.5 r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D60807

--HG--
extra : moz-landing-system : lando
2020-01-23 14:06:09 +00:00
Kris Maglione
ab5a99dd15 Bug 1602898: Rename Window.getWindowGlobalChild() to .windowGlobalChild. r=farre
Differential Revision: https://phabricator.services.mozilla.com/D56609

--HG--
extra : moz-landing-system : lando
2020-01-21 21:32:28 +00:00
Mark Banner
793a87d40a Bug 1607172 - Update ESLint to the latest version and use ignorePatterns to ignore paths listed in ThirdPartyPaths.txt. r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D59691

--HG--
extra : moz-landing-system : lando
2020-01-21 20:46:06 +00:00
Mihai Alexandru Michis
745c94b1df Backed out changeset 006f4e50e8e5 (bug 1602898) for causing multiple failures.
CLOSED TREE
2020-01-21 22:55:37 +02:00
Kris Maglione
aa0306477e Bug 1602898: Rename Window.getWindowGlobalChild() to .windowGlobalChild. r=farre
Differential Revision: https://phabricator.services.mozilla.com/D56609

--HG--
extra : moz-landing-system : lando
2020-01-21 18:48:26 +00:00
Mihai Alexandru Michis
2dab66d06e Backed out 9 changesets (bug 1607172, bug 1609998, bug 1608799) for causing xpcshell failures in test_parser.js
CLOSED TREE

Backed out changeset 7753083b67dd (bug 1609998)
Backed out changeset e6f5aac734ab (bug 1608799)
Backed out changeset 90ea35966b73 (bug 1608799)
Backed out changeset 6fafa451b3f9 (bug 1608799)
Backed out changeset e07a4aea2ae1 (bug 1608799)
Backed out changeset d69d6dfdccad (bug 1607172)
Backed out changeset 93023b1b6153 (bug 1607172)
Backed out changeset 99ce7a56080e (bug 1607172)
Backed out changeset 20aa5934c785 (bug 1607172)
2020-01-21 21:44:03 +02:00
Mark Banner
96709101c1 Bug 1607172 - Update ESLint to the latest version and use ignorePatterns to ignore paths listed in ThirdPartyPaths.txt. r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D59691

--HG--
extra : moz-landing-system : lando
2020-01-21 17:10:10 +00:00
Simon Giesecke
3f5316df28 Bug 1609943 - Improved section on comparison against true/false, and added note on clang-tidy check. r=sylvestre
Depends on D60281

Differential Revision: https://phabricator.services.mozilla.com/D60282

--HG--
extra : moz-landing-system : lando
2020-01-20 12:37:31 +00:00
Simon Giesecke
3e22e77cc5 Bug 1609943 - Merged two mentions of naming nsresult error variables, and improved wording a bit. r=sylvestre
Depends on D60273

Differential Revision: https://phabricator.services.mozilla.com/D60281

--HG--
extra : moz-landing-system : lando
2020-01-18 12:04:36 +00:00
Simon Giesecke
3da8e73cda Bug 1609943 - Move static analysis to its own section, and add notes on a few more clang-tidy checks. r=sylvestre
Differential Revision: https://phabricator.services.mozilla.com/D60273

--HG--
extra : moz-landing-system : lando
2020-01-20 12:37:21 +00:00
Simon Giesecke
e9e7a0258f Bug 1609943 - Move all string-related rules into one section. r=sylvestre
Differential Revision: https://phabricator.services.mozilla.com/D60264

--HG--
extra : moz-landing-system : lando
2020-01-20 10:17:20 +00:00
Simon Giesecke
843989bf9a Bug 1609943 - Refer to UpperCamelCase to remove ambiguity. r=sylvestre
Differential Revision: https://phabricator.services.mozilla.com/D60263

--HG--
extra : moz-landing-system : lando
2020-01-18 12:02:39 +00:00
Simon Giesecke
34cd11297e Bug 1609943 - Move mode line section from C++ to general coding style. r=sylvestre
Differential Revision: https://phabricator.services.mozilla.com/D60262

--HG--
extra : moz-landing-system : lando
2020-01-18 11:43:19 +00:00
Simon Giesecke
615906c9b7 Bug 1609943 - Split guideline on unary operators into C++ and JavaScript part. r=sylvestre
C++: Remove reference to JavaScript typeof from 'Operators' section and specifically refer to sizeof only.

JavaScript: Added remainder of the guideline referring to typeof.

Differential Revision: https://phabricator.services.mozilla.com/D60261

--HG--
extra : moz-landing-system : lando
2020-01-21 08:19:55 +00:00
Simon Giesecke
dfc0fdd507 Bug 1609943 - Cleanup in-line code fragments to use proper encapsulation. r=sylvestre
Differential Revision: https://phabricator.services.mozilla.com/D60260

--HG--
extra : moz-landing-system : lando
2020-01-17 15:51:35 +00:00
Cosmin Sabou
9b6e5f8e66 Backed out changeset 4c303f6ec2e6 (bug 1602898) for browser chrome failures on browser_ssb_windowlocation. 2020-01-18 01:06:34 +02:00
Kris Maglione
036e960542 Bug 1602898: Rename Window.getWindowGlobalChild() to .windowGlobalChild. r=farre
Differential Revision: https://phabricator.services.mozilla.com/D56609

--HG--
extra : moz-landing-system : lando
2020-01-17 21:36:10 +00:00
Siddhant085
676ce0d13c Bug 1511700 - Use the new notification system (PlacesObserver) for bookmark removed notifications. r=Standard8,mak
Phasing out the old notification system for OnItemRemoved events.

Differential Revision: https://phabricator.services.mozilla.com/D17753

--HG--
extra : moz-landing-system : lando
2020-01-16 18:38:54 +00:00
Tomislav Jovanovic
48d05a45cb Bug 1602639 - Switch native messaging from MessageManagers to Conduits r=robwu
Differential Revision: https://phabricator.services.mozilla.com/D58356

--HG--
extra : moz-landing-system : lando
2020-01-16 22:41:27 +00:00
shindli
3d28702804 Backed out changeset 1bdfd7c37b02 (bug 1511700) for causing newtab node test failure CLOSED TREE 2020-01-13 22:33:58 +02:00
Siddhant085
d48342d7db Bug 1511700 - Use the new notification system (PlacesObserver) for bookmark removed notifications. r=Standard8,mak
Phasing out the old notification system for OnItemRemoved events.

Differential Revision: https://phabricator.services.mozilla.com/D17753

--HG--
extra : moz-landing-system : lando
2020-01-13 16:25:39 +00:00
Ethan Glasser-Camp
7cd2a98da0 Bug 1606026: Move existing documentation into new locations r=sylvestre
Differential Revision: https://phabricator.services.mozilla.com/D58338

--HG--
rename : tools/docs/docs/contribute/mozilla_source_code_directory_structure.rst => docs/contributing/directory_structure.rst
rename : tools/docs/docs/contribute/how_to_contribute_firefox.rst => docs/contributing/how_to_contribute_firefox.rst
rename : tools/docs/docs/adding-documentation.rst => tools/moztreedocs/docs/adding-documentation.rst
rename : tools/docs/docs/index.rst => tools/moztreedocs/docs/index.rst
rename : tools/docs/docs/mdn-import.rst => tools/moztreedocs/docs/mdn-import.rst
extra : moz-landing-system : lando
2020-01-06 16:38:34 +00:00
Ethan Glasser-Camp
6f164aa98f Bug 1606026: Move documentation entry point to docs/ r=sylvestre
Differential Revision: https://phabricator.services.mozilla.com/D58552

--HG--
rename : tools/docs/conf.py => docs/conf.py
rename : tools/docs/config.yml => docs/config.yml
rename : tools/docs/index.rst => docs/index.rst
rename : tools/docs/jsdoc.json => docs/jsdoc.json
extra : moz-landing-system : lando
2020-01-06 16:14:11 +00:00
Ethan Glasser-Camp
0549c56796 Bug 1606026: move tools/docs code to tools/moztreedocs r=sylvestre
Differential Revision: https://phabricator.services.mozilla.com/D58337

--HG--
rename : tools/docs/Pipfile => tools/moztreedocs/Pipfile
rename : tools/docs/Pipfile.lock => tools/moztreedocs/Pipfile.lock
rename : tools/docs/moztreedocs/__init__.py => tools/moztreedocs/__init__.py
rename : tools/docs/_static/custom_theme.css => tools/moztreedocs/_static/custom_theme.css
rename : tools/docs/mach_commands.py => tools/moztreedocs/mach_commands.py
rename : tools/docs/moztreedocs/package.py => tools/moztreedocs/package.py
rename : tools/docs/moztreedocs/upload.py => tools/moztreedocs/upload.py
extra : moz-landing-system : lando
2020-01-06 16:29:21 +00:00
Thomas Nguyen
b4435e40e5 Bug 1603674 - Add a new API to check if permission delegation and Feature Policy are enabled r=baku
Differential Revision: https://phabricator.services.mozilla.com/D57077

--HG--
extra : moz-landing-system : lando
2020-01-06 15:28:12 +00:00
Julian Descottes
3b345a689e Bug 1605995 - Add linting rule against relative paths in DevTools require r=Standard8
Depends on D58243

Differential Revision: https://phabricator.services.mozilla.com/D58253

--HG--
extra : moz-landing-system : lando
2020-01-06 12:54:39 +00:00
Sylvestre Ledru
81354de9c7 No bug - Document how add a new linter in the CI r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D58247

--HG--
extra : moz-landing-system : lando
2020-01-02 21:42:18 +00:00
Sylvestre Ledru
cd2807905f No bug - mozlint: Document the result object r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D58239

--HG--
extra : moz-landing-system : lando
2020-01-02 21:37:12 +00:00
Sylvestre Ledru
2c9610dc34 Bug 1606168 - Enable rustfmt on more directories r=andi
Before we improve the display at review phase

Depends on D58328

Differential Revision: https://phabricator.services.mozilla.com/D58329

--HG--
extra : moz-landing-system : lando
2020-01-02 17:04:13 +00:00
Sylvestre Ledru
b329036033 Bug 1606168 - Document ./mach lint -l rustfmt r=andi
Differential Revision: https://phabricator.services.mozilla.com/D58328

--HG--
extra : moz-landing-system : lando
2020-01-02 17:03:50 +00:00
Andrew Halberstadt
4ebbd3b587 Bug 1605106 - [lint.rustfmt] Return early if expanding exclusions results in no paths to lint, r=jwatt
Differential Revision: https://phabricator.services.mozilla.com/D58052

--HG--
extra : moz-landing-system : lando
2020-01-02 16:48:35 +00:00
Dzmitry Malyshau
785a7cfbc2 Bug 1596126 - Github synchronization for gfx/wgpu r=Callek,tomprince
This change introduces a "github-sync" component into tools,
which aims to support synchronizing both wgpu and WebRender with github.
~~It also features a "cargo test" job for standalone wgpu (bug  1596127)~~

The code is ported from "gfx/wr/scripts/wrupdater" folder. Changes are:
  1. remove explicit WR parts and make them configurable by command line params
  2. detect "mozilla-xxx" tags and use them in addition to the commits

As a follow up, wrupdater will be removed in favor of github-sync.

Status:
  - [x] get the CI test job working
  - [x] get @kats to fork "wgpu" github for "moz-gfx" bot
  - [x] remove the wgpu testing CI job (into separate PR)
  - [x] create new secret and reference it

Differential Revision: https://phabricator.services.mozilla.com/D57057

--HG--
extra : moz-landing-system : lando
2019-12-28 02:44:59 +00:00
Sylvestre Ledru
c18ed341f9 no bug - Fix a typo in the codespell doc
Differential Revision: https://phabricator.services.mozilla.com/D58327

--HG--
extra : moz-landing-system : lando
2019-12-27 23:06:12 +00:00
Sylvestre Ledru
dc4783cbbd Bug 1606009 - Extend the yaml test r=Callek
Differential Revision: https://phabricator.services.mozilla.com/D58265

--HG--
extra : moz-landing-system : lando
2019-12-26 19:25:43 +00:00
Sylvestre Ledru
434c978319 Bug 1606009 - Upgrade yamllint version r=Callek
Differential Revision: https://phabricator.services.mozilla.com/D58264

--HG--
extra : moz-landing-system : lando
2019-12-26 19:25:40 +00:00
Sylvestre Ledru
83fc0c5e2b Bug 1606009 - yamllint: Fix a python issue 3 Fix the yaml test r=Callek
Differential Revision: https://phabricator.services.mozilla.com/D58263

--HG--
extra : moz-landing-system : lando
2019-12-26 19:37:27 +00:00
Justin Wood
80b492019d Bug 1559975 - Make layout/reftests/ lint with 'py2' and 'py3' r=catlee
Depends on D36094

Differential Revision: https://phabricator.services.mozilla.com/D36095

--HG--
extra : moz-landing-system : lando
2019-12-26 21:17:52 +00:00
Justin Wood
997253f286 Bug 1559975 - Make layout/tools/reftest lint with 'py2' and 'py3' r=catlee
Depends on D36093

Differential Revision: https://phabricator.services.mozilla.com/D36094

--HG--
extra : moz-landing-system : lando
2019-12-26 21:17:55 +00:00
Mark Banner
06d4bda4b5 Bug 1605231 - Update bundled node_modules for the builders to sync with the yarn update. r=dmose
Differential Revision: https://phabricator.services.mozilla.com/D58205

--HG--
extra : moz-landing-system : lando
2019-12-24 23:17:12 +00:00
Sylvestre Ledru
1ac15b2d38 Bug 1604916 - Update the yamllint to version 1.9.0 r=Callek
Depends on D57668

Differential Revision: https://phabricator.services.mozilla.com/D57669

--HG--
extra : moz-landing-system : lando
2019-12-18 21:32:12 +00:00
Sylvestre Ledru
038bd866b5 Bug 1601612 - Fix some py2/py3 lints with a newer version of Python r=marco
Differential Revision: https://phabricator.services.mozilla.com/D57509

--HG--
extra : moz-landing-system : lando
2019-12-17 19:17:43 +00:00
Sylvestre Ledru
08e2e04f2a Bug 1604079 - Add a unit test for mozlint yamllint r=ahal
+ some python 3 changes

Differential Revision: https://phabricator.services.mozilla.com/D57263

--HG--
extra : moz-landing-system : lando
2019-12-17 16:57:25 +00:00
Emily McMinn
9271624bf9 Bug 1575658 - Moved firefox-wordmark.svg to browser/branding r=MattN,Mardak
Differential Revision: https://phabricator.services.mozilla.com/D44235

--HG--
rename : browser/components/newtab/data/content/assets/firefox-wordmark.svg => browser/branding/aurora/content/firefox-wordmark.svg
rename : browser/components/newtab/data/content/assets/firefox-wordmark.svg => browser/branding/nightly/content/firefox-wordmark.svg
rename : browser/components/newtab/data/content/assets/firefox-wordmark.svg => browser/branding/official/content/firefox-wordmark.svg
extra : moz-landing-system : lando
2019-12-10 21:08:57 +00:00