Commit Graph

27189 Commits

Author SHA1 Message Date
Alexandre Poirot
5ba5d87d0c Bug 1851566 - [devtools] Avoid passing large dataset out of the parser worker. r=devtools-reviewers,bomsy
These three attributes are very large arrays and we could easily keep them
within the worker thread by exposing new dedicated method.

Differential Revision: https://phabricator.services.mozilla.com/D187436
2023-09-11 13:51:24 +00:00
Alexandre Poirot
d440bf3bc3 Bug 1851522 - [devtools] Only pass symbols used by the main thread. r=devtools-reviewers,bomsy
Clarify which attributes are used only within the worker
and shouldn't be passed to the main thread.
Also clarify what are the usages of each attribute so that we can
more easily transfer some on-demand.

`callExpressions` wasn't used anywhere.

Differential Revision: https://phabricator.services.mozilla.com/D187401
2023-09-11 13:51:24 +00:00
serge-sans-paille
f6cfd02309 Bug 1852225 - Vendor devtools/client/shared/vendor/source-map using mach vendor r=ochameau,devtools-reviewers
The update script was mentioning a few manual actions that I made
explicit through patches, this should make further updates more robust.

Differential Revision: https://phabricator.services.mozilla.com/D187758
2023-09-11 13:13:46 +00:00
Sebastian Zartner
b6eed9cd14 Bug 1849235 - [devtools] Handle ::cue pseudo-element's ignored properties in inactive CSS. r=devtools-reviewers,fluent-reviewers,flod,nchevobbe.
Differential Revision: https://phabricator.services.mozilla.com/D186509
2023-09-09 21:16:57 +00:00
Sebastian Zartner
009a652471 Bug 1842175 - [devtools] Handle ::first-letter pseudo-element's ignored properties in inactive CSS. r=devtools-reviewers,fluent-reviewers,flod,nchevobbe.
Differential Revision: https://phabricator.services.mozilla.com/D186493
2023-09-08 19:32:26 +00:00
Zachary Svoboda
0055ca2e76 Bug 1852298 - Update error message proptype r=devtools-reviewers,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D187795
2023-09-08 17:56:05 +00:00
scottlynotlie
161b069046 Bug 1695150 - ObjectInspector should show wrapped primitive. r=nchevobbe,devtools-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D186613
2023-09-08 11:51:53 +00:00
Nicolas Chevobbe
5454ba067a Bug 1851973 - [devtools] Use CustomEvent instead of EventEmitter for unit-change event on color/angle swatch. r=ochameau,devtools-reviewers.
Differential Revision: https://phabricator.services.mozilla.com/D187653
2023-09-08 09:12:54 +00:00
Zachary Svoboda
07caee3b31 Bug 1764897 - Switch to raw data view when JSON is invalid r=jdescottes,devtools-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D187740
2023-09-08 08:58:16 +00:00
Iulian Moraru
91628a06ab Backed out changeset 772040823b6e (bug 1851973) for causing dt failures on browser_rules_edit-value-after-name_02.js. CLOSED TREE 2023-09-08 11:32:57 +03:00
Nicolas Chevobbe
66187129be Bug 1851973 - [devtools] Use CustomEvent instead of EventEmitter for unit-change event on color/angle swatch. r=ochameau,devtools-reviewers.
Differential Revision: https://phabricator.services.mozilla.com/D187653
2023-09-08 06:22:29 +00:00
Nicolas Chevobbe
2418a2c8c5 Bug 1851972 - [devtools] Cache toggle button localized label. r=ochameau,devtools-reviewers.
Differential Revision: https://phabricator.services.mozilla.com/D187651
2023-09-08 01:12:47 +00:00
Nicolas Chevobbe
ee7d388db9 Bug 1834690 - [devtools] Show custom properties value in computed panel. r=devtools-reviewers,ochameau.
At the moment, the (regular) computed properties PropertyView are created at
panel initialization, and then are shown/hidden depending of the selected element.
The list of properties is gathered from the panel's window computed property,
and not from the content page one.
That means that we can't build PropertyView for custom property at initialization
time, but potentially each time the computed property is refreshed.
In order to minimize dom mutations, when the view is refreshed, we:
- only remove the custom properties that are not set on the selected node
- update the value for the custom properties that are still set
- create new PropertyView for custom properties that weren't previously set

In order to keep the list ordered, we have to compute the index to put the new
elements in the right position. This is a bit tedious, but seems to work well
for performance.

A test is added for checking those custom properties.

Differential Revision: https://phabricator.services.mozilla.com/D182994
2023-09-08 01:12:46 +00:00
Alexandre Poirot
2e2e9b1590 Bug 1320607 - [devtools] Remove the generated CSS Properties database. r=devtools-reviewers,nchevobbe
This wasn't really used anymore.
We are fetching the database from the server runtime in order to support
remote debugging correctly, where frontend CSS may be different from debuggee CSS.

Differential Revision: https://phabricator.services.mozilla.com/D187492
2023-09-07 20:59:34 +00:00
Sebastian Zartner
7c82134cd8 Bug 1849255 - [devtools] Handle ::placeholder pseudo-element's ignored properties in inactive CSS. r=devtools-reviewers,fluent-reviewers,nchevobbe.
Differential Revision: https://phabricator.services.mozilla.com/D186742
2023-09-07 20:14:31 +00:00
Butkovits Atila
ef58dad0ea Backed out changeset fb19de542f01 (bug 1320607) for causing python failures complaining about test_devtools_database_parsing . CLOSED TREE 2023-09-07 18:58:05 +03:00
Alexandre Poirot
622b937669 Bug 1320607 - [devtools] Remove the generated CSS Properties database. r=devtools-reviewers,nchevobbe
This wasn't really used anymore.
We are fetching the database from the server runtime in order to support
remote debugging correctly, where frontend CSS may be different from debuggee CSS.

Differential Revision: https://phabricator.services.mozilla.com/D187492
2023-09-07 13:08:37 +00:00
Mark Banner
b4c82a1103 Bug 1851794 - Change debugger ESLint rules that are warnings to errors, and turn off react/prop-types. r=devtools-reviewers,ochameau
Differential Revision: https://phabricator.services.mozilla.com/D187545
2023-09-07 10:24:18 +00:00
Hubert Boma Manilla
6ffde8feae Bug 1844536 - [devtools] Use shared utils for accessing scope nodes r=devtools-reviewers,ochameau
Differential Revision: https://phabricator.services.mozilla.com/D187600
2023-09-07 09:54:14 +00:00
Hubert Boma Manilla
55e306c62c Bug 1844536 - [devtools] Remove isGenerated util and access .isOriginal property directly r=devtools-reviewers,ochameau
Differential Revision: https://phabricator.services.mozilla.com/D186899
2023-09-07 09:54:13 +00:00
Paul Zuehlcke
08c2760082 Bug 1839918 - Update devtools cookie-changed observer for nsICookieNotification. r=devtools-reviewers,ochameau
Differential Revision: https://phabricator.services.mozilla.com/D185301
2023-09-07 08:25:54 +00:00
Hubert Boma Manilla
4ba98e499d Bug 1844536 - [devtools] Cleanup all the util code around scopes r=devtools-reviewers,ochameau
Differential Revision: https://phabricator.services.mozilla.com/D186872
2023-09-06 18:43:16 +00:00
Logan Rosen
f024d94b2b Bug 1786490 - reformat the tree using black 23.3.0 r=sylvestre,webdriver-reviewers,taskgraph-reviewers,whimboo,jmaher,ahal,perftest-reviewers,geckoview-reviewers,afinder,m_kato
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D186092
2023-09-06 16:14:30 +00:00
Emilio Cobos Álvarez
726f71faf3 Bug 1850827 - Simplify how we draw window decorations. r=stransky,rmader,desktop-theme-reviewers,dao
This makes the rounded bottom corners work on X11, and makes the top
corner drawing less insane.

Differential Revision: https://phabricator.services.mozilla.com/D187345
2023-09-06 11:07:58 +00:00
Hubert Boma Manilla
d820233ea8 Bug 1844536 - [devtools] Remove unused toggle scope props r=devtools-reviewers,ochameau
Differential Revision: https://phabricator.services.mozilla.com/D186871
2023-09-06 08:46:13 +00:00
Hubert Boma Manilla
34cef822f7 Bug 1849946 - [devtools] Switch to do strict inequality check r=devtools-reviewers,ochameau
Differential Revision: https://phabricator.services.mozilla.com/D187102
2023-09-05 10:51:12 +00:00
Sylvestre Ledru
10018013ed Bug 1842396 - doc: fix two typos
Differential Revision: https://phabricator.services.mozilla.com/D187398
2023-09-04 20:06:35 +00:00
Sebastian Zartner
c87a8cb7be Bug 1850952 - [devtools] Checked expiry to be in range instead of exact timestamp in browser_storage_cookies_add. r=bomsy,devtools-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D187318
2023-09-04 18:48:24 +00:00
Hubert Boma Manilla
46f1668f97 Bug 1849987 - [devtools] Pass selectedFrame to getGeneratedFrameScope instead of currentThread r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D186788
2023-09-01 15:57:34 +00:00
Sebastian Zartner
a591ed255c Bug 1748422 - [devtools] Set path of manually added cookies to root. r=devtools-reviewers,bomsy.
Differential Revision: https://phabricator.services.mozilla.com/D186887
2023-08-31 11:18:34 +00:00
Cristina Horotan
f1622cf0e7 Backed out changeset 9125d5c558ea (bug 1849987) for causing dt failures at browser_dbg-sourcemapped-toggle.js 2023-08-31 14:12:06 +03:00
Hubert Boma Manilla
1a06317f45 Bug 1849987 - [devtools] Pass selectedFrame to getGeneratedFrameScope instead of currentThread r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D186788
2023-08-31 09:42:50 +00:00
Emilio Cobos Álvarez
6070e00f0a Bug 1850342 - Remove non-standard, un-tested :-moz-loading pseudo-class. r=layout-reviewers,jfkthame
This is technically web-exposed, but if we needed to introduce it for
compat we could always re-introduce it matching false.

Differential Revision: https://phabricator.services.mozilla.com/D186938
2023-08-30 10:38:52 +00:00
Iulian Moraru
9a9b90c906 Backed out changeset f0edb489e577 (bug 1850342) for causing dt failures on browser_rules_inactive_css_visited.js. CLOSED TREE 2023-08-30 01:24:44 +03:00
Emilio Cobos Álvarez
afdec6f2a3 Bug 1850342 - Remove non-standard, un-tested :-moz-loading pseudo-class. r=layout-reviewers,jfkthame
This is technically web-exposed, but if we needed to introduce it for
compat we could always re-introduce it matching false.

Differential Revision: https://phabricator.services.mozilla.com/D186938
2023-08-29 20:57:30 +00:00
Julian Descottes
f7a93256db Bug 1849334 - [devtools] Re-introduce wait for paused in browser_dbg-inspector-integration r=Honza,devtools-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D186934
2023-08-28 14:08:11 +00:00
Julian Descottes
183c09a2fb Bug 1767644 - [devtools] Wait for DOM in browser_net_filter-value-preserved r=Honza,devtools-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D186935
2023-08-28 14:06:49 +00:00
Sylvestre Ledru
35bff347ec Bug 1847178 - doc/perf: fix a simple typo DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D186927
2023-08-28 10:12:06 +00:00
Emilio Cobos Álvarez
69fd9897e3 Bug 1850007 - Make sure that the highlighter styles are loaded. r=devtools-reviewers,nchevobbe
On an SVG document, createElement() returns an null-namespace element.

Differential Revision: https://phabricator.services.mozilla.com/D186800
2023-08-24 19:21:53 +00:00
Nicolas Chevobbe
85b1efda13 Bug 1849751 - [devtools] Drop usage of createElementNS in computed panel. r=ochameau,devtools-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D186657
2023-08-24 18:54:48 +00:00
Nicolas Chevobbe
ba14d67a01 Bug 1849301 - [devtools] Update Computed view markup. r=devtools-reviewers,ochameau.
Use an actual list for the markup and remove unecessary elements.
Update CSS and tests in consequence.

Differential Revision: https://phabricator.services.mozilla.com/D186526
2023-08-24 18:54:48 +00:00
Nicolas Chevobbe
2be3ac1811 Bug 1849301 - [devtools] Handle computed view list zebra in CSS. r=devtools-reviewers,ochameau
Differential Revision: https://phabricator.services.mozilla.com/D186524
2023-08-24 18:54:47 +00:00
Nicolas Chevobbe
44825b88ac Bug 1849301 - [devtools] Use AbortController for PropertyView event listeners. r=devtools-reviewers,ochameau.
Differential Revision: https://phabricator.services.mozilla.com/D186523
2023-08-24 18:54:47 +00:00
Nicolas Chevobbe
0bef3bc209 Bug 1849301 - [devtools] Turn PropertyView into an ES6 class. r=devtools-reviewers,ochameau.
Make "private" methods actually private, and add a public `createElements` method
that calls both `buildMain` and `buildSelectorContainer` as they were always
called on after the other (this will be helpful when working on Bug 1834690).

Differential Revision: https://phabricator.services.mozilla.com/D186522
2023-08-24 18:54:47 +00:00
Natalia Csoregi
2777b4b593 Backed out 4 changesets (bug 1849301) for causing failures on browser_computed_matched-selectors_01.js. CLOSED TREE
Backed out changeset 9f2a5b983a7a (bug 1849301)
Backed out changeset e5181454f4c3 (bug 1849301)
Backed out changeset 71266152b915 (bug 1849301)
Backed out changeset e96c371d51ac (bug 1849301)
2023-08-24 19:08:20 +03:00
Nicolas Chevobbe
66db05b547 Bug 1849301 - [devtools] Update Computed view markup. r=devtools-reviewers,ochameau.
Use an actual list for the markup and remove unecessary elements.
Update CSS and tests in consequence.

Differential Revision: https://phabricator.services.mozilla.com/D186526
2023-08-24 15:22:09 +00:00
Nicolas Chevobbe
4941fc8488 Bug 1849301 - [devtools] Handle computed view list zebra in CSS. r=devtools-reviewers,ochameau
Differential Revision: https://phabricator.services.mozilla.com/D186524
2023-08-24 15:22:09 +00:00
Nicolas Chevobbe
7685152c96 Bug 1849301 - [devtools] Use AbortController for PropertyView event listeners. r=devtools-reviewers,ochameau.
Differential Revision: https://phabricator.services.mozilla.com/D186523
2023-08-24 15:22:08 +00:00
Nicolas Chevobbe
04fdaeb561 Bug 1849301 - [devtools] Turn PropertyView into an ES6 class. r=devtools-reviewers,ochameau.
Make "private" methods actually private, and add a public `createElements` method
that calls both `buildMain` and `buildSelectorContainer` as they were always
called on after the other (this will be helpful when working on Bug 1834690).

Differential Revision: https://phabricator.services.mozilla.com/D186522
2023-08-24 15:22:08 +00:00
Krishna Ravishankar
91fb9665f9 Bug 1578994 - Add Base64 and Hex copy options for WS binary frames r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D185479
2023-08-23 15:45:15 +00:00