With same-compartment realms, cross-compartment wrappers don't have a meaningful global associated with them because CCWs are shared by all realms in the compartment.
Automatic update from web-platform-testsCorrectly pick the block-end margin when calculating overflow.
We need to use the writing mode of the containing block to do this, not that of
the child, which is completely irrelevant.
Change-Id: Ia5907d9ce60d00ad453f48fb72193e2eab1aaa3e
Reviewed-on: https://chromium-review.googlesource.com/1127047
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572931}
--
wpt-commits: efea7337078c4b4e18ed9c1703870ec4e0da57eb
wpt-pr: 11817
Automatic update from web-platform-tests[sensors] Check that sensor frame and focused frame of same origin (#11803)
#11426 introduced new tests for mitigation stragegy defined in [1]
for partial concrete sensors. This PR add the same tests for remain
concrete sensors: Ambient Light Sensor, Geolocation Sensor, and Proximity.
[1] https://www.w3.org/TR/generic-sensor/#focused-area
--
wpt-commits: c9c1a7d1b2306fada9bc3b469bf39ca31b4508cc
wpt-pr: 11803
Automatic update from web-platform-testsMake preload play nice with CSP strict-dynamic
Dynamically loaded preloaded scripts were not loaded when a strict-dynamic
CSP directive was used. This was because the state regarding whether the
element was parser created or not was not properly propoagated to the CSP
checks. This CL fixes that and adds tests that make sure that such scripts
can be preloaded (and that markup based preloaded scripts with no nonce cannot).
Bug: 752922
Change-Id: Ib4f3bce8583ccc9770c261d76167243033e5a112
Reviewed-on: https://chromium-review.googlesource.com/1125064
Reviewed-by: Andy Paicu <andypaicu@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Yoav Weiss <yoav@yoav.ws>
Cr-Commit-Position: refs/heads/master@{#572908}
--
wpt-commits: e6ac489577c1ac1e0dadd9bef80e63af2a2eb42a
wpt-pr: 11777
Automatic update from web-platform-testsMerge pull request #11583 from ewilligers/z-index-test
SVG: Test that z-index controls rendering order
--
wpt-commits: 2b9ac244538d91c069ae6aa9273c4298b749bf99
wpt-pr: 11583
Automatic update from web-platform-testsChange parsing order for scroll-snap-align to block/inline.
As in the newest spec[1], the parsing order for scroll-snap-align is
changed to block/inline.
[1] https://drafts.csswg.org/css-scroll-snap-1/#scroll-snap-align
Bug: 854379
Cq-Include-Trybots: luci.chromium.try :android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I70d2e9d526ffa0564e260faacdb5f79857a69324
Reviewed-on: https://chromium-review.googlesource.com/1115701
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572869}
--
wpt-commits: 0ffa5aaa7809a1957bdf260aaf55c16403fbf3fe
wpt-pr: 11691
MozReview-Commit-ID: 4HG0lm1atpj
Automatic update from web-platform-testsAdd an API to query whether the window has seen a user gesture.
Add a variable on the navigator object to query whether the frame has
seen a user activation ever.
The postMessage part of the proposal will be done in a separate patch,
this change is limited to just adding the object definition and
exposing it on navigator.
https://github.com/dtapuska/useractivationhttps://github.com/whatwg/html/issues/1983
BUG=846858
Change-Id: I6ca4c80f4096bfae9ca13b175b46df6b4486a6dd
Reviewed-on: https://chromium-review.googlesource.com/1076979
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Rick Byers <rbyers@chromium.org>
Reviewed-by: Mustaq Ahmed <mustaq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572847}
--
wpt-commits: dfca5197519caef6c189636b5d80b33e3424e91e
wpt-pr: 11361
Automatic update from web-platform-testswebdriver: correct expected exception type for delete session test (#11809)
The SessionNotCreatedException should be thrown if an attempt to create a
session fails. If a user tries to access a session that existed, but has
already been deleted, the correct exception is InvalidSessionIdException.
--
wpt-commits: dfe2b1ce939ce7b80a64d079655cfa14451e9960
wpt-pr: 11809
Automatic update from web-platform-tests[LayoutNG] Support anonymous table cells natively.
Use LayoutObjectFactory when creating anonymous table cells, just
like we already do for non-anonymous cells.
We used to create legacy LayoutTableCell objects for anonymous cells,
but allowed children to be NG. This was bad, since we should only
switch engines at formatting context boundaries.
One NG change was necessary here: Only anonymous *blocks* should
inherit % resolution size. Anonymous table cells should NOT. This
prevents fast/table/percent-height-inside-anonymous-cell.html from
regressing.
This made one existing test pass. Also added a new one.
Two tests not related to tables regressed. Separate bugs reported.
Some rebaselining was also necessary, since NG handles text runs and
whitespace slightly differently.
Cq-Include-Trybots: luci.chromium.try :linux_layout_tests_layout_ng
Change-Id: Ibbb77073f1fbe1841ebf102c8bce440046f73319
Reviewed-on: https://chromium-review.googlesource.com/1122218
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: David Grogan <dgrogan@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572753}
--
wpt-commits: 6562ed003eebcd25d093ae52d68de28a0ae0d786
wpt-pr: 11755
MozReview-Commit-ID: 6XbTBEjeesL
Automatic update from web-platform-tests[css-properties-values-api] Require PropertyDescriptor.inherits.
As of a recent spec change, the 'inherits' field must now be set.
See https://drafts.css-houdini.org/css-properties-values-api-1/#registering-custom-properties.
This patch changes all calls to CSS.registerProperty (that are missing
'inherits') such that 'inherits' is explicitly set to 'false', which was
the old default.
In wpt/css/css-properties-values-api/register-property.html, I have added
a new test to very that we throw an exception if it's omitted.
Note that CSS.registerProperty API is an unshipped feature behind the
CSSVariables2 flag.
R=mstensho@chromium.org
Bug: 860289
Change-Id: I14aa02d40c69e0ff6d1160160a8f772cb5159092
Reviewed-on: https://chromium-review.googlesource.com/1126303
Commit-Queue: Anders Ruud <andruud@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572731}
--
wpt-commits: ac8b4953a09fa7e7d7490cea8af26ab88d061dcb
wpt-pr: 11792
Automatic update from web-platform-testsMerge pull request #10296 from dstorey/types-svg-to-dom-changes
Test removed interfaces and SVG* -> DOM* in Types chapter
--
wpt-commits: fc77ed0960d401343b4327a3dbb105276024bfb9
wpt-pr: 10296
Automatic update from web-platform-testsWPT tests for http-equiv Accept-CH-Lifetime
WPT tests are added for:
(i) When ACL http-equiv header is sent by a same-origin iframe.
(ii) When ACL http-equiv header is sent by a cross-origin iframe.
(iii) When ACL http-equiv header is sent by a subresource.
(iv) When ACL http-equiv header is sent on the main frame.
Change-Id: Ie4adce0c1b5983a66ce3dce7bb6b77e30f63c03a
Bug: 852484
Reviewed-on: https://chromium-review.googlesource.com/1125212
Reviewed-by: Yoav Weiss <yoav@yoav.ws>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572706}
--
wpt-commits: f2fdea2d681d3618c7215e9333535c9585ec7171
wpt-pr: 11778
Automatic update from web-platform-testsUnflake wpt/fetch/security/redirect-to-url-with-credentials.https.html
The test is flaky because of step_timeout. This CL removes that, and
marks the test as consistent TIMEOUT.
Bug: 846497, 626703
Change-Id: Iaa8b0e275d1d4fc9db6cb77db5399d06744fd60a
Reviewed-on: https://chromium-review.googlesource.com/1125548
Reviewed-by: Adam Rice <ricea@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572688}
--
wpt-commits: 250d8640a9c8e43a13cc02595b72097bed69695d
wpt-pr: 11782
Automatic update from web-platform-testsTest that will-change:will-change has no effect. (#11798)
* Test that will-change:will-change has no effect.
* Add test owners.
--
wpt-commits: adaa7b65ac4a455b26720a7691278f9f992b4f03
wpt-pr: 11798
Automatic update from web-platform-testsMove wptrunner marionette usage onto a single thread
Running marionette on a background thread is problematic in the case
that a test times out. In this case the background thread is not
terminated. If we then call into marionette again on the main thread
we may race with something that happens on the runner thread. The
marionette client isn't threadsafe, so this leads to buggy behaviour.
The simplest fx for the problem is just to move all the marionette
calls onto the main thread and instead of waiting on the main thread,
spin up a thread with a timer.
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1265584
gecko-commit: 9b8539a9a2a6c20220cdcb07e19b7bf3a91c7436
gecko-integration-branch: mozilla-inbound
gecko-reviewers: ato
--
Make base_executor_kwargs arguments match executor_kwargs
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1265584
gecko-commit: b99661f1fcc56bca0176bd813c166525a4ebf2e4
gecko-integration-branch: mozilla-inbound
gecko-reviewers: ato
--
Add support for recording asserts in wptrunner
Gecko has an API for producing a non-fatal "assert". For quality
control, it should be possible to annotate the range of possible
numbers of these asserts produced during a test execution, and fail if
the actual number of asserts falls outside this range.
This patch adds assert checking by default in debug builds. It adds
two metadata properties; max-asserts and min-asserts for specifying
the range of possible asserts produced in a test.
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1265584
gecko-commit: bc43ae3ccc9f203268a2b495b99515c617306c88
gecko-integration-branch: mozilla-inbound
gecko-reviewers: ato, maja_zf
--
Reverse the order of metadata iteration
wptrunner previously iterated over properties from least significant
to most significant. However this was broken since it caused
per-directory properties to override per-test properties, which wasn't
expected. Therefore we reverse the order of iteration from most
significant to least.
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1265584
gecko-commit: cc1d47bf0aa7efe3e770316c9ea5d895beafcaba
gecko-integration-branch: mozilla-inbound
gecko-reviewers: maja_zf
--
Support updating asserts with wpt-update
With support for asserts, it's also necessary to be able to update the
expected number of asserts automatically using
wpt-update. Unfortunately asserts don't work quite like test statuses,
so this involves a reasonable amount of refactoring.
For asserts the desired behaviour is that the max asserts is either
one plus the highest recorded number of asserts, or the current
value, whichever is higher, and for the minimm asserts, it's the
minumum of the current value and one lower than the lowest recorded
value (clamped at zero). Instead of creating per-platform
expectations, the code only updates the defaults (or any existing
conditional that happens to match). It's not clear that we have enough
information to meaningfully make per-platform expectations, and we
want to reduce the risk of intermittents.
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1265584
gecko-commit: cc9b28394533a30a6ae33def5ce1117882653134
gecko-integration-branch: mozilla-inbound
gecko-reviewers: maja_zf
--
Use ujson where possible for faster metadata update
Profiling shows that switching to this library means we no longer
spend most of the update time parsing json (vs 80% or so before),
making other optimisations worthwhile. This is never used in
automation (except wptsync) so availability of the library in the
internal pypi isn't a problem.
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1265584
gecko-commit: 605324b9d70e822a9d25e1c6ff7ca2bcbff6085c
gecko-integration-branch: mozilla-inbound
gecko-reviewers: maja_zf
--
Output asserts to wptreport.json
In the future we want to update metadata using the wptreport.json data, since
that's much much smaller and easier to parse. In addition, this is
required to determine if a test fully passed, so it makes sense to
store it here.
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1265584
gecko-commit: b7716dedbf5a24e0e9a940a907225f7b3dd7d35c
gecko-integration-branch: mozilla-inbound
gecko-reviewers: maja_zf
--
Add a test for wpttest metadata
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1265584
gecko-commit: b021a8615326a99919fe62b493874ac9d49441da
gecko-integration-branch: mozilla-inbound
gecko-reviewers: maja_zf
--
Fix flake8 failures
--
wpt-commits: 7204b317f506490e35f7ae380cab1a68d5f8fdbc, d675750a83e50878810091f7d96bbd5b57b2571a, e462113b6009d39305889e5b9966c2b7b671638e, 29fc7128d5d8f1760799a9840b3d930dd60b1016, 67010d9392b66ffa97a86e7ba2a9c18baa6bdf48, af25577da115208dc870a3c76c04bad8df532e59, 642bfb6e32ad2d20a22f1597d05e7243ac042be2, ac0f20081c03047ceed14dbe4b656c590304e175, cf4bcf12ed566497addb109183c23082a3a33371
wpt-pr: 11167
Automatic update from web-platform-tests[css-logical] Implement flow-relative margin, padding and border shorthand properties
They are implemented behind the CSSLogical runtime flag.
Intent to Implement:
https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/48OwfwZrbvI/A1XZFGkzAwAJ
Spec: https://drafts.csswg.org/css-logical/#box
BUG=850004
TEST=external/wpt/css/css-logical/logical-box-border-shorthands.html
TEST=external/wpt/css/css-logical/logical-box-border-color.html
TEST=external/wpt/css/css-logical/logical-box-border-style.html
TEST=external/wpt/css/css-logical/logical-box-border-width.html
TEST=external/wpt/css/css-logical/logical-box-margin.html
TEST=external/wpt/css/css-logical/logical-box-padding.html
The tests still have some failures because sideways writing modes have
not been implemented yet (http://crbug.com/680331).
Change-Id: Ibe3d7f39e1ce17de465aa635388b3f8510ed82a3
Reviewed-on: https://chromium-review.googlesource.com/1122872
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Manuel Rego Casasnovas <rego@igalia.com>
Reviewed-by: Anders Ruud <andruud@chromium.org>
Commit-Queue: Oriol Brufau <obrufau@igalia.com>
Cr-Commit-Position: refs/heads/master@{#572576}
--
wpt-commits: 8dba144063a41d57c8272329bbe5c8810f34adca
wpt-pr: 11759
Automatic update from web-platform-testsAdd a test for the bounds-checking in createImageBitmap.
--
wpt-commits: 3634f42a67eeb156aceb8d4e337b62f01908cdf8
wpt-pr: 11786
Automatic update from web-platform-testsDon't crash when aborting a fetch in a destroyed context
Once the context in which a fetch is executing has been destroyed the fetch
cannot be aborted. blink::BodyStreamBuffer was attempting to abort the fetch
anyway, leading to a crash. Check that the context hasn't been destroyed before
attempting the abort.
BUG=860063
Change-Id: I593dcbfe2f2dacd7be9df456399cd0328da7af39
Reviewed-on: https://chromium-review.googlesource.com/1125543
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572493}
--
wpt-commits: bfba9da11d4c53a7d33785dfe5b2a5e96171bc7f
wpt-pr: 11780
Automatic update from web-platform-tests[LayoutNG] Fix hit test clipping by fragmented border with round corner
Current NG hit test code decides whether a hit test location is clipped
by rounded border by adding border radius to all four corners and then
compare with the hit test location. This is wrong if the box is
fragmented, where it may have only two or zero rounded corners.
This patch changes HitTestClippedOutByBorder() to take the above into
consideration. By utilizing |border_edges_|, it can generate the
corrected rounded border to be hit tested.
Test: This patch slightly modifies WPT
hit-test-inline-fragmentation-with-border-radius.html as a workaround
of some rounding issue, which is out of the scope of this patch.
Bug: 855279, 859233
Cq-Include-Trybots: luci.chromium.try :linux_layout_tests_layout_ng;luci.chromium.try :linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I1e3193f9fc2d5e52ff53d6cb2fcc2a0ae2b3aa43
Reviewed-on: https://chromium-review.googlesource.com/1123265
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572079}
--
wpt-commits: cffbd07683d6a0aa3fc032181dee1f4ac21d3bff
wpt-pr: 11760
MozReview-Commit-ID: nouPFy4brV