The MOZ_MUST_USE macro is defined as clang's and gcc's nonstandard __attribute__((warn_unused_result)). Now that we compile as C++17 by default (bug 1560664), we can replace MOZ_MUST_USE with C++17's standard [[nodiscard]] attribute.
BitsUtils.cpp only references MOZ_MUST_USE in a comment about forking a copy of mozilla::ScopeExit to remove some dependencies on other Mozilla header files (including MOZ_MUST_USE from mfbt/Attributes.h). [[nodiscard]] doesn't require a header file, so we can just remove this comment about MOZ_MUST_USE.
Differential Revision: https://phabricator.services.mozilla.com/D89296
The license used to be LGPL so the code lived in other-licenses, but it was changed to BSD eleven years ago. Let's move it over to third_party/python/ply where it belongs.
./mach vendor python ply==3.10
`diff -r` between the original `ply` directory and the new one only comes up with the new file `third_party/python/ply/CHANGES` which isn't relevant to the functionality of the code, so this should be a no-op all told.
Differential Revision: https://phabricator.services.mozilla.com/D73341
This is all the code and build files for an NSIS plugin that enables
rendering a web page as the content of an NSIS dialog.
Documentation and the compiled binary are in later commits in this series.
Depends on D56576
Differential Revision: https://phabricator.services.mozilla.com/D56577
Minify this file by removing the dialogs we don't need and hiding all the
unnecessary controls in the one we do need, so the stub installer code
doesn't have to do that manually (I would have removed those controls
altogether, but the NSIS compiler errors out if you do that).
The dialog resources were edited directly in-place using
Resource Hacker <http://angusj.com/resourcehacker/>.
Differential Revision: https://phabricator.services.mozilla.com/D56576
The changes made to CityHash are no longer necessary with mingw-clang, so we
can revert them to the original upstream implementation.
Differential Revision: https://phabricator.services.mozilla.com/D56991
--HG--
extra : moz-landing-system : lando
This patch includes:
* The new icon file itself
* A modified Win32 SFX binary with the icon resource replaced and no other changes
* A rebuilt ARM64 binary (because rebuilding it is just as easy as resource hacking it)
* And I also took the opportunity to update the VC project to the 2019 toolchain
and removed the requirement for a particular Windows 10 SDK version.
Differential Revision: https://phabricator.services.mozilla.com/D46846
--HG--
extra : moz-landing-system : lando
Also reduce the timeout for terminating the thread to 5 seconds, because 10
seconds is too long to be completely hanging the UI.
Differential Revision: https://phabricator.services.mozilla.com/D33844
--HG--
extra : moz-landing-system : lando
Added defines to mar_extract.c, mar_read.c, bsdiff.c so they use the ISO C and C++ conformant name.
Ran clang format on bspatch.cpp and the files under modules/libmar except for nss_secutil.c and nss_secutil.h since they are copies of nss code.
Make CityHash64, CityHash64WithSeed, and CityHash64WithSeeds usable from C code
Remove unnecessary includes from mar_read.c as well
Add DisableStlWrapping to mar tool's moz.build to fix linkage break when
building in Windows with MSVC
Differential Revision: https://phabricator.services.mozilla.com/D10774
We need to be able to send POST data that's encoded as UTF-8, but the older
version of nsJSON we currently have only support UTF-16.
--HG--
extra : source : 5d5494bb34e57e4ee1b51233bf9f6b86301f900c
Because of a silly logic error I made in bug 1494900, the optional command line
parameter support introduced there doesn't actually work at all; I reversed the
sense of the check for the NSIS stack being empty. This fixes that by just using
the check that the popstring function was already doing.
--HG--
extra : rebase_source : e63b70579810af5774e237c619b29fb71012ea8c
extra : source : 58a29f64dd06d4e66e6faf047e2356decc5904f4
Also take the opportunity to add that change to mozilla_customizations.diff and
to correct the line endings in the files that it contains changes to.
--HG--
extra : rebase_source : 10df36760e1f8cc0e8b2f93b47e76c27dcc912cc
extra : source : 9a448a33f4b43ef8572d80bc7b27c7a831f122c2
