Commit Graph

8177 Commits

Author SHA1 Message Date
James Teh
5d7440007c Bug 1626802 part 2: Implement HandlerProvider::IsInterfaceMaybeSupported for a11y. r=aklotz,MarcoZ
Differential Revision: https://phabricator.services.mozilla.com/D69286

--HG--
extra : moz-landing-system : lando
2020-04-02 04:09:20 +00:00
Christoph Kerschbaumer
4b9c5814af Bug 1571461 - Change accessibility of search widget to look for all event handlers and remove hack to hide.r=surkov,MarcoZ
Differential Revision: https://phabricator.services.mozilla.com/D68023

--HG--
extra : moz-landing-system : lando
2020-03-31 11:06:38 +00:00
Marco Zehe
038d0f0c06 Bug 1626137 - Account for tables that are display:block; when looking for the table of a row accessible, r=Jamie
When checking if a parent of a table row counts for a table, take into account that a table might be an ARIAGridAccessible, which remains a generic hyperText, but is still a valid table. Tables with display: block; are such candidates.

Differential Revision: https://phabricator.services.mozilla.com/D68955

--HG--
extra : moz-landing-system : lando
2020-03-31 06:32:15 +00:00
James Teh
979d04b401 Bug 1625396: AccessibleOrProxy::ChildAtPoint: Accessible::ChildAtPoint can return null, so don't try to check for a remote child doc in that case. r=yzen
Differential Revision: https://phabricator.services.mozilla.com/D68739

--HG--
extra : moz-landing-system : lando
2020-03-30 13:19:15 +00:00
Tim Nguyen
66d337e655 Bug 1625314 - Follow up: Temporarily hack around search-textbox a11y failures. CLOSED TREE
Differential Revision: https://phabricator.services.mozilla.com/D68899

--HG--
extra : amend_source : 61e287fc550a40c6cbce2dc34205f7abf9cb2003
2020-03-30 21:34:38 +00:00
Botond Ballo
672a7de4ff Bug 1626021 - Remove non-ASCII characters from comments in Accessible.cpp. r=kats
Differential Revision: https://phabricator.services.mozilla.com/D68847

--HG--
extra : moz-landing-system : lando
2020-03-30 17:33:19 +00:00
Morgan Reschenberg
48fa33b966 Bug 1618706: Adjust role of grid cells from group to table-cell. r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D68618

--HG--
extra : moz-landing-system : lando
2020-03-27 20:37:24 +00:00
James Teh
c48bee7775 Bug 1598299 part 2: Remove ProxyAccessible::AccessibleAtPoint. r=yzen,nika
This wasn't useful cross-platform.
ATK was the only consumer of this and it now uses ProxyAccessible::ChildAtPoint.
This also means the related aNeedsScreenCoords functionality in PDocAccessible::AccessibleAtPoint is no longer needed and has thus been removed.
Finally, this renames PDocAccessible::AccessibleAtPoint to PDocAccessible::ChildAtPoint for consistency with Accessible::ChildAtPoint now that the functionality is mirrored.

Differential Revision: https://phabricator.services.mozilla.com/D67987

--HG--
extra : moz-landing-system : lando
2020-03-29 23:08:44 +00:00
James Teh
ef9d9e1d06 Bug 1598299 part 1: Make atk_component_ref_accessible_at_point return the deepest child instead of the direct child. r=yzen
This changes the ATK code to use AccessibleOrProxy::ChildAtPoint, since that already handles walking into OuterDocAccessibles appropriately.
Previously, atk_component_ref_accessible_at_point didn't work at all on OuterDocAccessibles.
Also, for ProxyAccessibles, we no longer adjust the coordinates for ATK_XY_WINDOW in the content process, as this depends on stuff that doesn't exist cross-platform and thus can't be used with AccessibleOrProxy.
Instead, we now handle this in the parent process before making the IPC call.

Differential Revision: https://phabricator.services.mozilla.com/D67986

--HG--
extra : moz-landing-system : lando
2020-03-26 15:27:45 +00:00
Drew Willcoxon
5739954280 Bug 1616752 - Part 2: Add payload schemas for each result type and validate payloads against them. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D64300

--HG--
extra : moz-landing-system : lando
2020-03-26 15:27:12 +00:00
Morgan Reschenberg
53fcf5a7d2 Bug 1617311: Add details/summary attributes and values. r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D67233

--HG--
extra : moz-landing-system : lando
2020-03-27 22:08:40 +00:00
Eitan Isaacson
bc2cae2059 Bug 1624729 - Introduce some initial mac mochitests. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D68128

--HG--
extra : moz-landing-system : lando
2020-03-27 20:19:56 +00:00
Eitan Isaacson
14ca656c7f Bug 1624729 - Notify observer service of mac accessibility events. r=morgan,yzen
Differential Revision: https://phabricator.services.mozilla.com/D68127

--HG--
extra : moz-landing-system : lando
2020-03-27 17:11:44 +00:00
Eitan Isaacson
0ade2fd945 Bug 1624729 - Refactor event firing and encapsulate it in mozAccessible. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D68126

--HG--
extra : moz-landing-system : lando
2020-03-27 17:12:33 +00:00
Eitan Isaacson
a89dd56577 Bug 1624729 - Map NSAccessible properties and action methods to attributes and action lists. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D68125

--HG--
extra : moz-landing-system : lando
2020-03-27 17:13:39 +00:00
Eitan Isaacson
d3ae7576c0 Bug 1624729 - Implement attributes and actions getters in xpcAccessibleMacInterface. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D68124

--HG--
extra : moz-landing-system : lando
2020-03-27 17:15:18 +00:00
Eitan Isaacson
95c476b280 Bug 1624729 - Introduce nsIAccessibleMacInterface as mac native xpc interface. r=yzen,morgan
Differential Revision: https://phabricator.services.mozilla.com/D68123

--HG--
extra : moz-landing-system : lando
2020-03-27 17:15:31 +00:00
Eitan Isaacson
325f958e21 Bug 1624729 - Add a nativeInterface attribute to nsIAccessible. r=yzen
Differential Revision: https://phabricator.services.mozilla.com/D68122

--HG--
extra : moz-landing-system : lando
2020-03-27 00:53:31 +00:00
Eitan Isaacson
5ff55aadfc Bug 1625293 - Populate mParallelView in mozRootAccessible when initializing. r=morgan
This makes it possible to get the `representedView` even after the accessible goes away on shutdown.

Differential Revision: https://phabricator.services.mozilla.com/D68489

--HG--
extra : moz-landing-system : lando
2020-03-27 20:26:40 +00:00
Eitan Isaacson
9c101448f7 Bug 1407724 - Provide role of TEXT_CONTAINER to descendants of "strong" aria roles. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D66793

--HG--
extra : moz-landing-system : lando
2020-03-27 16:00:09 +00:00
Morgan Reschenberg
9e89b53321 Bug 1623402: Add ShowMenu to action names, perform action. r=eeejay
Depends on D67200

Differential Revision: https://phabricator.services.mozilla.com/D67409

--HG--
extra : moz-landing-system : lando
2020-03-27 17:08:58 +00:00
Marco Zehe
0948ee96fa Bug 1625153 - Implement the WAI-ARIA 1.2 code role, r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D68432

--HG--
extra : moz-landing-system : lando
2020-03-26 21:26:15 +00:00
James Teh
a3a5a8ee35 Bug 1616829: Don't remove ATK_STATE_EDITABLE from list items in editors. r=MarcoZ
Differential Revision: https://phabricator.services.mozilla.com/D68327

--HG--
extra : moz-landing-system : lando
2020-03-26 20:54:02 +00:00
James Teh
25c7a7bb42 Bug 1622699 part 3: Remove accessibility.xpcom.traverse_outerdoc pref. r=yzen
Differential Revision: https://phabricator.services.mozilla.com/D68304

--HG--
extra : moz-landing-system : lando
2020-03-26 18:01:37 +00:00
James Teh
cc07441b96 Bug 1622699 part 1: Add nsIAccessible::GetDeepestChildAtPointInProcess. r=yzen
Dev Tools A11y Panel interacts with accessibles in the process in which they reside.
It does not (and cannot) deal with ProxyAccessibles.
However, GetDeepestChildAtPoint now walks into the ProxyAccessible tree if appropriate, which is what we want for tests and what normally makes sense.
This patch introduces GetDeepestChildAtPointInProcess, which Dev Tools will use instead.

Differential Revision: https://phabricator.services.mozilla.com/D68302

--HG--
extra : moz-landing-system : lando
2020-03-26 18:00:59 +00:00
Razvan Maries
3ee91b8422 Backed out changeset 0bf2517f7a99 (bug 1623402) for build bustages. CLOSED TREE 2020-03-26 19:25:30 +02:00
Morgan Reschenberg
791753ad49 Bug 1623402: Add ShowMenu to action names, perform action. r=eeejay
Depends on D67200

Differential Revision: https://phabricator.services.mozilla.com/D67409

--HG--
extra : moz-landing-system : lando
2020-03-25 22:10:27 +00:00
Morgan Reschenberg
9aa0ae8a10 Bug 1624434: Remove description attribute for table elements. r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D67928

--HG--
extra : moz-landing-system : lando
2020-03-26 15:45:04 +00:00
Morgan Reschenberg
70cc6039b1 Bug 1616679: Map accessible actions to Mac actions based on action name. r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D67200

--HG--
extra : moz-landing-system : lando
2020-03-25 22:09:59 +00:00
Eitan Isaacson
9de7172c6b Bug 1623399 - Hide chrome invisible alerts and dialogs. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D68272

--HG--
extra : moz-landing-system : lando
2020-03-25 21:29:43 +00:00
Cosmin Sabou
88a9cd318e Backed out changeset 570f25f87e0a (bug 1616679) for bustages on mozAccessible.mm. CLOSED TREE 2020-03-25 19:26:48 +02:00
Morgan Reschenberg
2856a68236 Bug 1616679: Map accessible actions to Mac actions based on action name. r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D67200

--HG--
extra : moz-landing-system : lando
2020-03-25 17:08:15 +00:00
Mirko Brodesser
d5bfd89436 Bug 1623858: part 13) Declare some methods in HyperTextAccessible const. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D68039

--HG--
extra : moz-landing-system : lando
2020-03-25 15:39:37 +00:00
Marco Zehe
834e69c0ae Bug 1624826 - Remove trailing whitespace from accessible name of fieldset element if provided by legend, r=eeejay
This was an oversight in the HTMLGroupBoxAccessible implementation of NativeName, others trim their whitespaces by default.

Differential Revision: https://phabricator.services.mozilla.com/D68198

--HG--
extra : moz-landing-system : lando
2020-03-25 15:13:50 +00:00
Brindusan Cristian
907f988362 Backed out changeset 155281fd18fd (bug 1571461) for mochitest failures at test_general.xhtml. CLOSED TREE 2020-03-24 21:27:46 +02:00
Eitan Isaacson
c5e8c91afb Bug 1622731 - Make nsCoreUtils tree/column functions null-safe. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D67673

--HG--
extra : moz-landing-system : lando
2020-03-24 19:07:30 +00:00
Eitan Isaacson
98a33541fd Bug 1622731 - In TableAccessible::IsProbablyLayoutTable, check if accessible is defunct. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D67672

--HG--
extra : moz-landing-system : lando
2020-03-24 19:03:39 +00:00
Christoph Kerschbaumer
f64b1b7ff8 Bug 1571461 - Change accessibility of search widget to look for all event handlers and remove hack to hide.r=surkov,MarcoZ
Differential Revision: https://phabricator.services.mozilla.com/D68023

--HG--
extra : moz-landing-system : lando
2020-03-24 17:32:59 +00:00
Eitan Isaacson
f8243143b8 Bug 1622731 - Notify of destruction after detaching accessible wrap/proxy. r=morgan
Depends on D67673

Differential Revision: https://phabricator.services.mozilla.com/D67674

--HG--
extra : moz-landing-system : lando
2020-03-21 05:26:19 +00:00
Emilio Cobos Álvarez
04828e3a4a Bug 253870 - Make disabled form controls selectable. r=masayuki,MarcoZ
This rejiggers a bit the way selection focus is handled so that focusing a
disabled form control with the mouse handles selection properly, and hides the
document selection and so on.

This matches the behavior of other browsers as far as I can tell.

Given now readonly and disabled editors behave the same, we can simplify a bit
the surrounding editor code.

Differential Revision: https://phabricator.services.mozilla.com/D66464

--HG--
extra : moz-landing-system : lando
2020-03-19 13:18:16 +00:00
James Teh
2372f54c8a Bug 1622941: Fire ATK text-attributes-changed events for ProxyAccessibles. r=MarcoZ
Previously, we fired these for Accessibles, but this was never implemented for ProxyAccessibles (remote content documents).

Differential Revision: https://phabricator.services.mozilla.com/D67271

--HG--
extra : moz-landing-system : lando
2020-03-18 06:07:45 +00:00
James Teh
6e3cde7338 Bug 1622751: Teach IPDL that PDocAccessible::AccessibleAtPoint can return a null result doc. r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D67081

--HG--
extra : moz-landing-system : lando
2020-03-17 22:13:55 +00:00
Morgan Reschenberg
852913f515 Bug 1618708: Implement slider class and support required actions, valueDidChange event handling. r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D66667

--HG--
extra : moz-landing-system : lando
2020-03-17 17:32:33 +00:00
Eitan Isaacson
d014504afb Bug 1617314 - Support aria-current in OSX. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D66813

--HG--
extra : moz-landing-system : lando
2020-03-16 22:15:57 +00:00
Eitan Isaacson
b70e223767 Bug 1618718 - Support AXToggle subrole and states. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D66841

--HG--
extra : moz-landing-system : lando
2020-03-14 05:39:59 +00:00
Mihai Alexandru Michis
58bc354025 Backed out changeset 9eeee9ec66d9 (bug 253870) for causing failures in browser_bug1261299.js
CLOSED TREE
2020-03-16 22:32:41 +02:00
Emilio Cobos Álvarez
9f28f89085 Bug 253870 - Make disabled form controls selectable. r=masayuki,MarcoZ
This rejiggers a bit the way selection focus is handled so that focusing a
disabled form control with the mouse handles selection properly, and hides the
document selection and so on.

This matches the behavior of other browsers as far as I can tell.

Given now readonly and disabled editors behave the same, we can simplify a bit
the surrounding editor code.

Differential Revision: https://phabricator.services.mozilla.com/D66464

--HG--
extra : moz-landing-system : lando
2020-03-16 17:41:07 +00:00
James Teh
89cfbd0947 Bug 1617795: Use BrowsingContext instead of DOM window to get the focused document for a11y. r=yzen,hsivonen
nsFocusManager::GetFocusedWindow may return a window even if focus is actually inside an embedded OOP iframe.
Instead, use nsFocusManager::GetFocusedBrowsingContext, which always knows about the current focus across all processes.
If the focused context is in this process, we get its document and return it.

Differential Revision: https://phabricator.services.mozilla.com/D64514

--HG--
extra : moz-landing-system : lando
2020-03-13 15:40:46 +00:00
James Teh
de55f7895d Bug 1614871 part 2: Make non-Windows ProxyAccessible::ChildAtPoint cross into OOP iframes. r=eeejay
When we hit an OOP iframe, we must walk into the child document and continue the search from there.

Differential Revision: https://phabricator.services.mozilla.com/D66711

--HG--
extra : moz-landing-system : lando
2020-03-13 06:14:38 +00:00
James Teh
05f1674b2d Bug 1614871 part 1: Make non-Windows ProxyAccessible::ChildAtPoint cross into in-process iframes. r=eeejay
Accessible::ChildAtPoint can return an Accessible in a descendant document.
Thus, we must return the result PDocAccessible via IPC, not just the id.
Previously, we only returned the id, but we'd fail when we tried to look it up if it belonged to a descendant document.

Differential Revision: https://phabricator.services.mozilla.com/D66710

--HG--
extra : moz-landing-system : lando
2020-03-13 06:14:30 +00:00