Commit Graph

185 Commits

Author SHA1 Message Date
Morgan Reschenberg
53fcf5a7d2 Bug 1617311: Add details/summary attributes and values. r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D67233

--HG--
extra : moz-landing-system : lando
2020-03-27 22:08:40 +00:00
Eitan Isaacson
14ca656c7f Bug 1624729 - Notify observer service of mac accessibility events. r=morgan,yzen
Differential Revision: https://phabricator.services.mozilla.com/D68127

--HG--
extra : moz-landing-system : lando
2020-03-27 17:11:44 +00:00
Eitan Isaacson
0ade2fd945 Bug 1624729 - Refactor event firing and encapsulate it in mozAccessible. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D68126

--HG--
extra : moz-landing-system : lando
2020-03-27 17:12:33 +00:00
Eitan Isaacson
95c476b280 Bug 1624729 - Introduce nsIAccessibleMacInterface as mac native xpc interface. r=yzen,morgan
Differential Revision: https://phabricator.services.mozilla.com/D68123

--HG--
extra : moz-landing-system : lando
2020-03-27 17:15:31 +00:00
Eitan Isaacson
5ff55aadfc Bug 1625293 - Populate mParallelView in mozRootAccessible when initializing. r=morgan
This makes it possible to get the `representedView` even after the accessible goes away on shutdown.

Differential Revision: https://phabricator.services.mozilla.com/D68489

--HG--
extra : moz-landing-system : lando
2020-03-27 20:26:40 +00:00
Morgan Reschenberg
9e89b53321 Bug 1623402: Add ShowMenu to action names, perform action. r=eeejay
Depends on D67200

Differential Revision: https://phabricator.services.mozilla.com/D67409

--HG--
extra : moz-landing-system : lando
2020-03-27 17:08:58 +00:00
Marco Zehe
0948ee96fa Bug 1625153 - Implement the WAI-ARIA 1.2 code role, r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D68432

--HG--
extra : moz-landing-system : lando
2020-03-26 21:26:15 +00:00
Razvan Maries
3ee91b8422 Backed out changeset 0bf2517f7a99 (bug 1623402) for build bustages. CLOSED TREE 2020-03-26 19:25:30 +02:00
Morgan Reschenberg
791753ad49 Bug 1623402: Add ShowMenu to action names, perform action. r=eeejay
Depends on D67200

Differential Revision: https://phabricator.services.mozilla.com/D67409

--HG--
extra : moz-landing-system : lando
2020-03-25 22:10:27 +00:00
Morgan Reschenberg
9aa0ae8a10 Bug 1624434: Remove description attribute for table elements. r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D67928

--HG--
extra : moz-landing-system : lando
2020-03-26 15:45:04 +00:00
Morgan Reschenberg
70cc6039b1 Bug 1616679: Map accessible actions to Mac actions based on action name. r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D67200

--HG--
extra : moz-landing-system : lando
2020-03-25 22:09:59 +00:00
Eitan Isaacson
9de7172c6b Bug 1623399 - Hide chrome invisible alerts and dialogs. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D68272

--HG--
extra : moz-landing-system : lando
2020-03-25 21:29:43 +00:00
Cosmin Sabou
88a9cd318e Backed out changeset 570f25f87e0a (bug 1616679) for bustages on mozAccessible.mm. CLOSED TREE 2020-03-25 19:26:48 +02:00
Morgan Reschenberg
2856a68236 Bug 1616679: Map accessible actions to Mac actions based on action name. r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D67200

--HG--
extra : moz-landing-system : lando
2020-03-25 17:08:15 +00:00
Eitan Isaacson
f8243143b8 Bug 1622731 - Notify of destruction after detaching accessible wrap/proxy. r=morgan
Depends on D67673

Differential Revision: https://phabricator.services.mozilla.com/D67674

--HG--
extra : moz-landing-system : lando
2020-03-21 05:26:19 +00:00
Morgan Reschenberg
852913f515 Bug 1618708: Implement slider class and support required actions, valueDidChange event handling. r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D66667

--HG--
extra : moz-landing-system : lando
2020-03-17 17:32:33 +00:00
Eitan Isaacson
d014504afb Bug 1617314 - Support aria-current in OSX. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D66813

--HG--
extra : moz-landing-system : lando
2020-03-16 22:15:57 +00:00
Eitan Isaacson
b70e223767 Bug 1618718 - Support AXToggle subrole and states. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D66841

--HG--
extra : moz-landing-system : lando
2020-03-14 05:39:59 +00:00
Eitan Isaacson
83b8e2b9c3 Bug 1618700 - Implement expected attributes and events for tabs. r=morgan
I made more generalized mozSelectableAccessible and
mozSelectableChildAccessible classes for other things that will need
this kind of support.

Differential Revision: https://phabricator.services.mozilla.com/D66304

--HG--
extra : moz-landing-system : lando
2020-03-12 22:16:39 +00:00
Morgan Reschenberg
7cdb983c71 Bug 1124681: Query State() instead of NativeState() when deciding if a checkbox is checked. r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D66489

--HG--
extra : moz-landing-system : lando
2020-03-12 17:19:35 +00:00
Morgan Reschenberg
bca4131fda Bug 1617312: Ensure labelling attributes return nil for text leaves. r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D66323

--HG--
extra : moz-landing-system : lando
2020-03-12 16:10:40 +00:00
Eitan Isaacson
b0389fe116 Bug 1617310 - Support AXHasPopup attribute. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D66498

--HG--
extra : moz-landing-system : lando
2020-03-12 17:28:42 +00:00
Eitan Isaacson
640b0ba055 Bug 1617310 - Introduce state method in mozAccessible interface. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D66497

--HG--
extra : moz-landing-system : lando
2020-03-12 17:28:35 +00:00
Morgan Reschenberg
705648b472 Bug 1621724: Iterate through DefaultTextAttributes of hypertext accessible instead of accessible wrap's attributes to find aria-invalid's value. r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D66474

--HG--
extra : moz-landing-system : lando
2020-03-12 16:08:42 +00:00
Eitan Isaacson
088ece22c2 Bug 1618719 - Support aria radio groups. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D66337

--HG--
extra : moz-landing-system : lando
2020-03-11 22:54:37 +00:00
Eitan Isaacson
e275f3ca37 Bug 1617308 - Provide AXDescription for named groupings. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D66336

--HG--
extra : moz-landing-system : lando
2020-03-11 22:54:35 +00:00
Marco Zehe
2c553e7cf6 Bug 1371712 - Fall through to ARIA landmark role determination if native landmark roles fail, r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D65946

--HG--
extra : moz-landing-system : lando
2020-03-11 16:23:38 +00:00
Eitan Isaacson
d18ab374a8 Bug 1620318 - Filter out hidden popup menus and announce them when they appear. r=morgan
As the message above suggests this does two things:
1. We filter out the invisible popup menus from the root's children.
2. We dispatch menu opened and closed events.

The latter helps VoiceOver retain some context about the mutating tree and notify the user about the menu.

Differential Revision: https://phabricator.services.mozilla.com/D65612

--HG--
extra : moz-landing-system : lando
2020-03-10 22:42:31 +00:00
Eitan Isaacson
9690c5105b Bug 1620318 - Rename mozDocAccessible.{mm,h} to mozRootAccessible.{mm,h} r=morgan
This is to match the actual class it implements.

Differential Revision: https://phabricator.services.mozilla.com/D65611

--HG--
rename : accessible/mac/mozDocAccessible.h => accessible/mac/mozRootAccessible.h
rename : accessible/mac/mozDocAccessible.mm => accessible/mac/mozRootAccessible.mm
extra : moz-landing-system : lando
2020-03-10 20:25:32 +00:00
Morgan Reschenberg
7d0b534f27 Bug 1618716: Return the value associated with the aria-invalid attribute instead of relying on the state flag alone. r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D66297

--HG--
extra : moz-landing-system : lando
2020-03-10 21:50:54 +00:00
Eitan Isaacson
9e27b2cdde Bug 1618712 - Use GroupPosition for heading levels in mac. r=morgan,nika
We were using the wrong Accessible method to get the level. We also need to swap IPDL methods to use the right one.

Differential Revision: https://phabricator.services.mozilla.com/D65645

--HG--
extra : moz-landing-system : lando
2020-03-10 18:32:38 +00:00
Eitan Isaacson
fefb04c15e Bug 1619458 - Don't create OSX accessibles for XUL tooltips. r=morgan
Depends on D65038

Differential Revision: https://phabricator.services.mozilla.com/D65039

--HG--
extra : moz-landing-system : lando
2020-03-03 17:47:09 +00:00
Eitan Isaacson
01c6855e5e Bug 1619438 - Don't get dom node id from accessible with no associated content. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D65029

--HG--
extra : moz-landing-system : lando
2020-03-03 17:45:15 +00:00
Eitan Isaacson
f270ef49e9 Bug 1617301 - Fix accessibilityFocusedUIElement to work across processes. r=morgan
This is similar to the fix in bug 1614079 where we need to account
for a descendant that might match past a process boundary.

Differential Revision: https://phabricator.services.mozilla.com/D63974

--HG--
extra : moz-landing-system : lando
2020-03-02 22:10:37 +00:00
Eitan Isaacson
ee44ad7d4c Bug 1618040 - Advertise AXScrollToVisible on link. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D64246

--HG--
extra : moz-landing-system : lando
2020-03-02 22:18:11 +00:00
Eitan Isaacson
8ec8f6b45c Bug 1618364 - Add OSX accessible lifecycle notifications. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D64481

--HG--
extra : moz-landing-system : lando
2020-02-27 16:54:59 +00:00
Eitan Isaacson
9701de3f19 Bug 1614834 - Advertise and implement AXScrollToVisible. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D63580

--HG--
extra : moz-landing-system : lando
2020-02-25 00:05:00 +00:00
Dorel Luca
2075a0e4ab Backed out changeset 0a9ee19aaa48 (bug 1614834) for Build bustages on /build/src/accessible/mac/mozAccessible.mm. CLOSED TREE 2020-02-24 21:03:51 +02:00
Eitan Isaacson
54ca0747e1 Bug 1614834 - Advertise and implement AXScrollToVisible. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D63580

--HG--
extra : moz-landing-system : lando
2020-02-24 17:30:25 +00:00
Morgan Reschenberg
7c8049bbaf Bug 1611428: Add accessibilityLabel function to support aria-label on MacOS. r=eeejay,Jamie
Differential Revision: https://phabricator.services.mozilla.com/D62470

--HG--
extra : moz-landing-system : lando
2020-02-14 21:20:27 +00:00
Eitan Isaacson
6bbdeee348 Bug 1614835 - Advertise focusable state to OSX correctly. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D62523

--HG--
extra : moz-landing-system : lando
2020-02-13 00:09:16 +00:00
Eitan Isaacson
ff0625bca4 Bug 1614079 - Pass accessibilityHitTest to content process. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D62311

--HG--
extra : moz-landing-system : lando
2020-02-10 23:36:36 +00:00
Gabriele Svelto
69790bc62e Bug 1600545 - Remove useless inclusions of header files generated from IDL files in accessible/, browser/, caps/, chrome/, devtools/, docshell/, editor/, extensions/, gfx/, hal/, image/, intl/, ipc/, js/, layout/, and media/ r=Ehsan
The inclusions were removed with the following very crude script and the
resulting breakage was fixed up by hand. The manual fixups did either
revert the changes done by the script, replace a generic header with a more
specific one or replace a header with a forward declaration.

find . -name "*.idl" | grep -v web-platform | grep -v third_party | while read path; do
    interfaces=$(grep "^\(class\|interface\).*:.*" "$path" | cut -d' ' -f2)
    if [ -n "$interfaces" ]; then
        if [[ "$interfaces" == *$'\n'* ]]; then
          regexp="\("
          for i in $interfaces; do regexp="$regexp$i\|"; done
          regexp="${regexp%%\\\|}\)"
        else
          regexp="$interfaces"
        fi
        interface=$(basename "$path")
        rg -l "#include.*${interface%%.idl}.h" . | while read path2; do
            hits=$(grep -v "#include.*${interface%%.idl}.h" "$path2" | grep -c "$regexp" )
            if [ $hits -eq 0 ]; then
                echo "Removing ${interface} from ${path2}"
                grep -v "#include.*${interface%%.idl}.h" "$path2" > "$path2".tmp
                mv -f "$path2".tmp "$path2"
            fi
        done
    fi
done

Differential Revision: https://phabricator.services.mozilla.com/D55443

--HG--
extra : moz-landing-system : lando
2019-12-06 09:16:44 +00:00
Marco Zehe
78545b8343 Bug 982125 - make HTML5 <mark> accessible, r=Jamie
Mark the html:mark element to the new ROLE_MARK, which currently maps the same as role_text, and the xml-role of "mark", make sure we expose the roleDescription on Mac, and adjust the test so it tests that the attributes don't pick up any unexpected color for this particular element. So, the background attribute is empty when there is no unexpected, non-default background color.

Differential Revision: https://phabricator.services.mozilla.com/D52989

--HG--
extra : moz-landing-system : lando
2019-11-18 05:34:15 +00:00
James Teh
4a0ed4f097 Bug 1581040: handle late creation/re-creation of OuterDocAccessible for OOP iframe. r=yzen,nika
1. When creating a DocAccessibleParent for an embedded document in an OOP iframe, it's possible that the embedder accessible hasn't been set yet.
    This can occur if the iframe is initially hidden.
    Previously, we incorrectly set the document up as a top level document (e.g. tab document) in this case.
    Now, we set up the document as top level in its content process, set up the proxy, etc.
    The document will be added to its child document later when the embedder is set.

2. When setting the embedder accessible for an OOP iframe, check if the embedded DocAccessibleParent already exists.
    This can happen if an iframe is hidden and then shown or an iframe is reflowed by layout.
    If it already exists, add the embedded (child) document to its embedder.

3. Mac's implementation of ProxyCreated requires that AddChildDoc be called *before* ProxyCreated so it can invalidate the native children of the parent.
    Because it's possible for an OOP iframe document to be added to its embedder after the document is created, we can't satisfy this requirement for OOP iframe documents.
    Therefore, we now allow a null parent in Mac's ProxyCreated and use the reorder event fired later to invalidate the native children.

Differential Revision: https://phabricator.services.mozilla.com/D51357

--HG--
extra : moz-landing-system : lando
2019-11-07 00:38:59 +00:00
Sylvestre Ledru
7c309095ea Bug 1519636 - Reformat recent changes to the Google coding style r=Ehsan
Please note that it is the first reformat with clang-format 9
I only saw a fix in the .mm file

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D49056

--HG--
extra : moz-landing-system : lando
2019-10-21 14:13:44 +00:00
Masayuki Nakano
d8d0bcab65 Bug 1543013 - part 2: Make accessible use mozilla::PresShell directly rather than via nsIPresShell r=Jamie
This patch makes accessible module use `mozilla::PresShell` directly rather
than via `nsIPresShell`.  Additionally, renames `DocAccessible::PresShell()`
to `DocAccessible::PresShellPtr()` for avoiding conflict with using
`PresShell` in it and its sub classes.

Differential Revision: https://phabricator.services.mozilla.com/D26663

--HG--
extra : moz-landing-system : lando
2019-04-13 12:13:15 +00:00
Sylvestre Ledru
0b4021fcad Bug 1521460 - Also reformat objective-c files r=mstange,ehsan,spohl
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D17139

--HG--
extra : histedit_source : 084f340503d2e1a2d9e1753c38b2c4ee9c7819f3
2019-01-21 18:18:16 +01:00
Emilio Cobos Álvarez
d2ed260822 Bug 1517241 - Rename nsIDocument to mozilla::dom::Document. r=smaug
Summary: Really sorry for the size of the patch. It's mostly automatic
s/nsIDocument/Document/ but I had to fix up in a bunch of places manually to
add the right namespacing and such.

Overall it's not a very interesting patch I think.

nsDocument.cpp turns into Document.cpp, nsIDocument.h into Document.h and
nsIDocumentInlines.h into DocumentInlines.h.

I also changed a bunch of nsCOMPtr usage to RefPtr, but not all of it.

While fixing up some of the bits I also removed some unneeded OwnerDoc() null
checks and such, but I didn't do anything riskier than that.
2019-01-03 17:48:33 +01:00
Tooru Fujisawa
7983faeb5d Bug 1511393 - Use c-basic-offset: 2 in Emacs mode line for C/C++ code. r=nbp 2018-12-01 04:52:05 +09:00