Commit Graph

21769 Commits

Author SHA1 Message Date
Nihanth Subramanya
954bfd66fb Bug 1576100 - Ensure correct document order of category items for keyboard nav. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D43932

--HG--
extra : moz-landing-system : lando
2019-08-30 15:29:39 +00:00
Nihanth Subramanya
98195dc683 Bug 1574111 - Improve the definition of ThirdPartyCookies.isDetected. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D43464

--HG--
extra : moz-landing-system : lando
2019-08-30 14:19:43 +00:00
Emily McMinn
90152ac00d Bug 1551588 - Added a tab stop to the "info" and "dismiss" buttons in the FxA Bookmark Panel Message r=k88hudson
The Bookmark Panel Message now has tab stops on the info button, message dismiss icon, and message link, as well as all form fields and CTA buttons.

Differential Revision: https://phabricator.services.mozilla.com/D42692

--HG--
extra : moz-landing-system : lando
2019-08-30 13:58:08 +00:00
Johann Hofmann
6f4497fa71 Bug 1577636 - Update some strings for the identity panel. r=nhnt11
Differential Revision: https://phabricator.services.mozilla.com/D44130

--HG--
extra : moz-landing-system : lando
2019-08-30 10:35:30 +00:00
Nihanth Subramanya
998575983d Bug 1577466 - [Protections Panel] Check hasException state when setting social tracking subview title. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D43947

--HG--
extra : moz-landing-system : lando
2019-08-29 21:15:11 +00:00
James Teh
681ed6270e Bug 1575749: Implement toolbar navigation by typed character. r=Gijs
When focused on a toolbar button, users can now type the first (or first few) characters of another button's name to jump directly to that button.
The search characters are cleared after 1 second or if a non-character key is pressed.
This is similar to the typed character navigation implemented for HTML select controls.

Differential Revision: https://phabricator.services.mozilla.com/D43187

--HG--
extra : moz-landing-system : lando
2019-08-30 03:36:53 +00:00
Jared Wein
2afff22fde Bug 1577252 - Ignore login manager events in system principal code. r=MattN
Differential Revision: https://phabricator.services.mozilla.com/D43882

--HG--
extra : moz-landing-system : lando
2019-08-29 15:25:38 +00:00
Johann Hofmann
df1a4c6f84 Bug 1576072 - Add a new icon for granted permissions in the identity block + panel. r=nhnt11
Differential Revision: https://phabricator.services.mozilla.com/D43950

--HG--
extra : moz-landing-system : lando
2019-08-29 15:30:51 +00:00
Johann Hofmann
cd5966c452 Bug 1576072 - Backed out changeset 0a7463d82e5f. r=timhuang
Differential Revision: https://phabricator.services.mozilla.com/D43948

--HG--
extra : moz-landing-system : lando
2019-08-29 15:30:26 +00:00
Alexander Surkov
7a0e27bfdd Bug 1574819 - Bookmarks Menu Button popup doesn't auto-open on drag enter r=mak
Differential Revision: https://phabricator.services.mozilla.com/D43801

--HG--
extra : moz-landing-system : lando
2019-08-29 13:15:51 +00:00
Mark Banner
511a7ababf Bug 1562929 - Use the default private search engine in the context menu. r=daleharvey
Differential Revision: https://phabricator.services.mozilla.com/D43771

--HG--
extra : moz-landing-system : lando
2019-08-29 14:43:43 +00:00
Mark Banner
4256dfcab4 Bug 1562926 - Use the default private search engine in the address bar. r=daleharvey
Differential Revision: https://phabricator.services.mozilla.com/D43244

--HG--
extra : moz-landing-system : lando
2019-08-29 14:43:43 +00:00
Andreea Pavel
217ece7c1b Bug 1388973 - disabled test on all platforms r=jmaher
Differential Revision: https://phabricator.services.mozilla.com/D43965

--HG--
extra : moz-landing-system : lando
2019-08-29 13:20:55 +00:00
Paul Zuehlcke
9a2d43504e Bug 1575901 - Refactored pageInfo.js to use PermissionManager principal methods. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D43636

--HG--
extra : moz-landing-system : lando
2019-08-28 08:17:43 +00:00
Andreea Pavel
f652361ce2 Backed out changeset f20ce5c7a25c (bug 1575870) for assertion failure at nsNavHistory.cpp on a CLOSED TREE 2019-08-29 13:45:54 +03:00
Frederic Wang
ea067f91f0 Bug 1575870. Remove support for XLink on MathML elements. r=emilio
See https://groups.google.com/forum/#!topic/mozilla.dev.platform/70NFnet82cU

This commit introduces a new mathml.xlink.disabled option to disable support
for XLink attributes on MathML elements together with a use counter and
deprecation warning when support is enabled. For now, support is only disabled
in Nighly.

In the past, we relied on custom MathML deprecation warnings but those are
removed here. Corresponding tests for these legacy warning messages are
also removed from test_bug553917.html.

link-1.xhtml is run with XLink support enabled (since it check xlink:href)
while browser_contentAltClick.js is updated to check whether XLink has any
effect on MathML, depending on whether the option is enabled.

Differential Revision: https://phabricator.services.mozilla.com/D43332

--HG--
extra : moz-landing-system : lando
2019-08-29 08:20:01 +00:00
Nihanth Subramanya
8cf10e4066 Bug 1574313 - Hide cookie subview category header if there's only one. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D43336

--HG--
extra : moz-landing-system : lando
2019-08-29 08:45:37 +00:00
Mihai Alexandru Michis
a105826a55 Backed out 6 changesets (bug 1576407) for causing wpt and mochitest failures. CLOSED TREE
Backed out changeset 3b0498064cbf (bug 1576407)
Backed out changeset 38e4ea431445 (bug 1576407)
Backed out changeset 19bf40067233 (bug 1576407)
Backed out changeset 0ddbc451dcab (bug 1576407)
Backed out changeset 08d4c25fc670 (bug 1576407)
Backed out changeset be7cbc61f825 (bug 1576407)
2019-08-29 03:00:47 +03:00
Johann Hofmann
c987315cec Bug 1468355 - Optimize checking for site data usage for the site identity panel. r=Gijs
The idea here is that we avoid updating all site data in SiteDataManager.jsm
just for checking a single host/origin and that we optimize performance by prioritizing
the most common data type (cookies) and synchronous lookups (AppCache) and returning
early if any data was found.

We will still refresh the site data list for clearing once the user clicks on "Clear Site Data".

Differential Revision: https://phabricator.services.mozilla.com/D42800

--HG--
extra : moz-landing-system : lando
2019-08-28 21:45:30 +00:00
Kris Maglione
47e9394082 Bug 1576407: Part 5 - Update test expectations to handler cross-process window.opener being available. r=farre
This also sets the fission.rebuild_frameloaders_on_remoteness_change=true
preference for some mochitest directories which require it for cross-process
window.opener to work in top-level windows, and makes a minor change to the
hack in browser_temporary_permissions.js to keep it passing reliably in try
runs.

Differential Revision: https://phabricator.services.mozilla.com/D43694

--HG--
extra : moz-landing-system : lando
2019-08-28 18:07:41 +00:00
Barret Rennie
c48dcf7d7c Bug 1510569 - Port onSecurityChange from WebProgressChild.jsm to C++; remove WebProgressChild r=Ehsan,ochameau
This is the last message that WebProgressChild was sending to the
RemoteWebProgress in the parent process, so we can remove the module entirely.

Differential Revision: https://phabricator.services.mozilla.com/D35091

--HG--
extra : moz-landing-system : lando
2019-08-28 18:55:45 +00:00
Dorel Luca
b09fe526aa Backed out 4 changesets (bug 1510569) for build bustage. CLOSED TREE
Backed out changeset d7db6a1935ce (bug 1510569)
Backed out changeset 03b7cf756a7f (bug 1510569)
Backed out changeset fa318eec0e76 (bug 1510569)
Backed out changeset cecb17bd8c03 (bug 1510569)
2019-08-28 21:46:40 +03:00
Barret Rennie
e0d50ea7ce Bug 1510569 - Port onSecurityChange from WebProgressChild.jsm to C++; remove WebProgressChild r=Ehsan,ochameau
This is the last message that WebProgressChild was sending to the
RemoteWebProgress in the parent process, so we can remove the module entirely.

Differential Revision: https://phabricator.services.mozilla.com/D35091

--HG--
extra : moz-landing-system : lando
2019-08-28 18:00:23 +00:00
Dão Gottwald
cb8c8ab22c Bug 1575238 - Remove tabs-newtab-button class. r=mikedeboer
Differential Revision: https://phabricator.services.mozilla.com/D42656

--HG--
extra : moz-landing-system : lando
2019-08-28 13:45:21 +00:00
Gijs Kruitbosch
ee491403d2 Bug 1576936 - fix browser_windowopen for devtools button having moved, r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D43625

--HG--
extra : moz-landing-system : lando
2019-08-27 23:30:49 +00:00
Paul Bone
08bc01ab37 Bug 1576814 - Skip tests that timeout r=kmag
Depends on D43572

Differential Revision: https://phabricator.services.mozilla.com/D43573

--HG--
extra : moz-landing-system : lando
2019-08-27 19:07:43 +00:00
Paul Zuehlcke
a154c0ec39 Bug 1573124 - Updated identity popup security view heading to include domain name. r=nhnt11
Differential Revision: https://phabricator.services.mozilla.com/D41546

--HG--
extra : moz-landing-system : lando
2019-08-26 15:00:13 +00:00
Tim Huang
269db2010b Bug 1576871 - Clean up the allow list after the test 'testQuickSwitchTabAfterTogglingTPSwitch' in test browser_protections_UI.js r=nhnt11
Differential Revision: https://phabricator.services.mozilla.com/D43594

--HG--
extra : moz-landing-system : lando
2019-08-27 13:22:05 +00:00
Tim Huang
f2f193298e Bug 1576832 - Fix the info and check of the ETP state to use the right browser object for the test 'browser_protections_UI.js' r=nhnt11
Differential Revision: https://phabricator.services.mozilla.com/D43586

--HG--
extra : moz-landing-system : lando
2019-08-27 09:31:15 +00:00
Nihanth Subramanya
eb5b7f0842 Bug 1575246 - Clear telemetry events before and after protections panel tests. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D43392

--HG--
extra : moz-landing-system : lando
2019-08-26 21:04:55 +00:00
Andreas Farre
6e42fb98f8 Bug 1563619 - Handle subframe crashes in BrowserParent::ActorDestroy. r=mconley,kmag,peterv
Differential Revision: https://phabricator.services.mozilla.com/D40937

--HG--
extra : moz-landing-system : lando
2019-08-26 13:08:32 +00:00
Tim Huang
7717d849d2 Bug 1575788 - Fix the issue that the TP state been applied wrongly if quickly change tabs after toggling the TP switch for protections panel. r=nhnt11
This patch fixes the issue by updating the allow list as soon as the
switch been toggled. And the reload still happens after the 500ms delay.
We cache the target tab in order to reload the correct tab in case tabs
change and reload the target tab after the delay. In additon, we won't
reload the tab if is has been closed since it is totally unnecessary.

We also add a test for this.

Differential Revision: https://phabricator.services.mozilla.com/D43139

--HG--
extra : moz-landing-system : lando
2019-08-24 19:24:24 +00:00
Nihanth Subramanya
fefa4770d3 Bug 1575813 - isAllowing state of Fingerprinting and Cryptomining categories shouldn't consider enabled state. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D43046

--HG--
extra : moz-landing-system : lando
2019-08-24 16:37:38 +00:00
Alex Vincent
cec0c5cbdb Bug 1508169, Remove performAction* from nsITreeView.idl in mozilla-central. r=peterv, johannh
performAction, performActionOnRow and performActionOnCell are methods of the
nsITreeView interface that are never called.  This is to remove these methods.
A comm-central patch will be along shortly.

Differential Revision: https://phabricator.services.mozilla.com/D39273
2019-08-24 00:49:55 +02:00
Emilio Cobos Álvarez
dcb8e23c93 Bug 1561882 - Make sure to dispatch input and change consistently even if the first causes us to get uninited. r=mconley,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D43061

--HG--
extra : moz-landing-system : lando
2019-08-23 10:14:39 +00:00
Olli Pettay
e4e8c551d6 Bug 1575606, browser_trackingUI_pbmode_exceptions.js' tests should wait for windows to close, r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D42917

--HG--
extra : moz-landing-system : lando
2019-08-23 06:34:26 +00:00
Dão Gottwald
88be4edfa8 Bug 1575822 - Rename #urlbar-display-box and friends and consolidate related styling. r=ntim
Differential Revision: https://phabricator.services.mozilla.com/D43045

--HG--
extra : moz-landing-system : lando
2019-08-22 17:17:41 +00:00
Vijay Budhram
d93c450ace Bug 1573959 - Update FxA toolbar menu utm param r=markh
Differential Revision: https://phabricator.services.mozilla.com/D43093

--HG--
extra : moz-landing-system : lando
2019-08-22 16:53:17 +00:00
Johann Hofmann
e91d880e08 Bug 1570674 - Default to "Never Allow" for notification permission prompt denials. r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D43081

--HG--
extra : moz-landing-system : lando
2019-08-22 16:24:56 +00:00
Drew Willcoxon
292a6bb2ce Bug 1575038 - Quantumbar: Record engagement event telemetry when openViewOnFocus is triggered without mouse clicks. r=dao
We need to start engagement event recording when the view opens due to `openViewOnFocus`. We already do for mouse clicks since we call `engagementEvent.start` from `_on_mousedown`. But we don't for the Ctrl/Command-L key shortcut. The shortcut command calls `openLocation` in browser.js, which calls `gURLBar.startQuery` but not `engagementEvent.start`.

Every time we call `engagementEvent.start`, we do it before calling `input.startQuery`. The one exception is in `input._on_drop` because there we just handle the dropped value directly instead of starting a new query with it.

The inverse is also mostly true, i.e., every time we call `input.startQuery`, we also call `engagementEvent.start`. The three exceptions are: in UITour (where it looks like we should be calling `urlbar.search` instead), in `UrlbarInput` after picking a keyword offer result, and in `openLocation` in browser.js (mentioned above). So really the only valid place is after picking a keyword entry.

So, it makes sense to move `engagementEvent.start()` into `input.startQuery` so that callers don't have to call it. I added an `event` param to `startQuery`, since `engagementEvent.start` needs one. I considered removing that need. It's possible, but then we would need a way to avoid calling `engagementEvent.start` in the keyword offer case, so `startQuery` would need something like a `suppressEngagementEvent` param. `event` basically functions as that, so I left it.

Another thing to point out about this patch is that I chose to record a "typed" value when the pageproxystate is invalid and the view opens due to `openViewOnFocus`. The view does not show the user's top sites in that case, so "topsites" seems wrong.

Differential Revision: https://phabricator.services.mozilla.com/D42749

--HG--
extra : moz-landing-system : lando
2019-08-22 14:50:42 +00:00
Tim Huang
02045f09e3 Bug 1574930 - Part 3: Add a test case for making sure that the track counter displays properly and fix an issue for BrowserTestUtils.waitForAttribute(). r=nhnt11,johannh
This patch adds a test case to check the visibility of the track counter
is correct in different situations, including zero tracker, one tracker
and multiple trackers.

Also, this patch fixes an issue that the
BrowserTestUtils.waitForAttributes() won't work if the waiting
attributes doesn't have a value or has an empty string as its value.
We check the value of the observing attribute to verify if it is
existing, however an empty string will be treated as a false, so it
won't pass the check if the attribute doesn't have a value. Hence, we
should use hasAttribute() instead of getAttribute() to check the
existence of the attribute.

Differential Revision: https://phabricator.services.mozilla.com/D42718

--HG--
extra : moz-landing-system : lando
2019-08-22 09:48:59 +00:00
Tim Huang
9fb9109290 Bug 1574930 - Part 2: Fix the issue the the number of blocked trackers is still shown if the count is zero. r=nhnt11
By only hiding the tracker counter when the tracker counter is zero and
show the counter always other than that. By doing so,  the counter
would be shown properly according the tracker number.

Differential Revision: https://phabricator.services.mozilla.com/D42717

--HG--
extra : moz-landing-system : lando
2019-08-22 09:34:21 +00:00
Tim Huang
e127d3cf82 Bug 1574930 - Part 1: Use the app locale for the tracker counter number in protections panel. r=nhnt11,Ehsan
We use the locale of the application to show the number of the trakcer
counter.

Differential Revision: https://phabricator.services.mozilla.com/D42716

--HG--
extra : moz-landing-system : lando
2019-08-21 09:08:56 +00:00
ruthra kumar
69f0254ddd Bug 1003968 - avoid Exists() calls for search plugin directories in the browser directory provider r=daleharvey,Gijs
This Change removes all call to Exists() in Directory Provider component, which creates the possibility for the componenet to return an empty list. SearchService.jsm is modified to handle this possibility.

Differential Revision: https://phabricator.services.mozilla.com/D42772

--HG--
extra : moz-landing-system : lando
2019-08-22 09:05:43 +00:00
Sam Foster
f84227e740 Bug 1571700 - Don't show fill logins context menu item in about: pages. r=MattN
* Skip showing the password manager items in the context menu from an about: page

Differential Revision: https://phabricator.services.mozilla.com/D42963

--HG--
extra : moz-landing-system : lando
2019-08-21 22:01:26 +00:00
Mike Hommey
66d7fe943e Bug 1575420 - Replace MOZ_WIDGET_TOOLKIT value of "gtk3" with "gtk". r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D42765

--HG--
extra : moz-landing-system : lando
2019-08-21 12:25:42 +00:00
Mark Banner
a05a7163d5 Bug 1551829 - Upgrade to ESLint 6.1.0. r=mossop
This picks up various improvements, especially to how configurations are handled and some new rules.

Differential Revision: https://phabricator.services.mozilla.com/D37271

--HG--
extra : moz-landing-system : lando
2019-08-21 19:08:44 +00:00
Oana Pop Rus
3223cd3dc2 Backed out 4 changesets (bug 1510569) for causing build bustage on a CLOSED TREE
Backed out changeset eae555c11f25 (bug 1510569)
Backed out changeset 2fb8938d16db (bug 1510569)
Backed out changeset b480af862022 (bug 1510569)
Backed out changeset 642cd6323cdc (bug 1510569)
2019-08-21 22:55:43 +03:00
Dão Gottwald
a25a70aaf0 Bug 1575563 - Improve Megabar input layout. r=harry
Differential Revision: https://phabricator.services.mozilla.com/D42864

--HG--
extra : moz-landing-system : lando
2019-08-21 19:13:15 +00:00
Barret Rennie
52899c1e0d Bug 1510569 - Port onSecurityChange from WebProgressChild.jsm to C++; remove WebProgressChild r=Ehsan,ochameau
This is the last message that WebProgressChild was sending to the
RemoteWebProgress in the parent process, so we can remove the module entirely.

Differential Revision: https://phabricator.services.mozilla.com/D35091

--HG--
extra : moz-landing-system : lando
2019-08-21 18:25:04 +00:00