Commit Graph

75 Commits

Author SHA1 Message Date
Victor Porof
f9f5914039 Bug 1561435 - Format browser/base/, a=automatic-formatting
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D36041

--HG--
extra : source : 96b3895a3b2aa2fcb064c85ec5857b7216884556
2019-07-05 09:48:57 +02:00
Kris Maglione
e930b89c34 Bug 1514594: Part 3 - Change ChromeUtils.import API.
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8

This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:

  ChromeUtils.import("resource://gre/modules/Services.jsm");

is approximately the same as the following, in the new model:

  var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");

Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs

This was done using the followng script:

https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8

Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16750

--HG--
extra : rebase_source : 359574ee3064c90f33bf36c2ebe3159a24cc8895
extra : histedit_source : b93c8f42808b1599f9122d7842d2c0b3e656a594%2C64a3a4e3359dc889e2ab2b49461bab9e27fc10a7
2019-01-17 10:18:31 -08:00
Mark Banner
691543ee89 Bug 1486739 - Add missing dangling commas in browser/, services/, taskcluster/ and toolkit/. r=mossop
Automatic changes by ESLint, except for manual corrections for .xml files.

Differential Revision: https://phabricator.services.mozilla.com/D4439

--HG--
extra : moz-landing-system : lando
2018-08-31 05:59:17 +00:00
Brian Grinstead
4995c61b0f Bug 1482667 - Migrate mochitest-browser tests in browser/ to use element variations of firstChild, etc;r=paolo
Differential Revision: https://phabricator.services.mozilla.com/D3530

--HG--
extra : moz-landing-system : lando
2018-08-17 16:45:52 +00:00
Jonathan Kingston
2f0987a202 Bug 1362034 - Tests for addTab() to provide the correct triggering principal. r=ckerschb r?=gijs
Summary: Depends on D2046

Reviewers: ckerschb!, Gijs!

Tags: #secure-revision

Bug #: 1362034

Differential Revision: https://phabricator.services.mozilla.com/D2047

--HG--
extra : source : 33884d05cc94463950b31fab1fd2f37ada9becef
extra : intermediate-source : 72471adb75d5ec3dc2b0c8f972a6f1f26bfd3ae2
extra : histedit_source : f384cbab58401575afc3443c9a431b73cff806d4
2018-07-06 21:16:29 +01:00
dvarga
12f19b94e9 Backed out 2 changesets (bug 1362034) for failure at browser/tools/mozscreenshots/primaryUI/browser_primaryUI.js on a CLOSED TREE
Backed out changeset 1c3329958b8a (bug 1362034)
Backed out changeset f68b1b76af36 (bug 1362034)

--HG--
extra : histedit_source : 6169c5ffe856266d3bc8b2ca32f4b67054c71bbe
2018-08-08 22:11:56 +03:00
Jonathan Kingston
c15f69d427 Bug 1362034 - Tests for addTab() to provide the correct triggering principal. r=ckerschb,Gijs
Summary: Depends on D2046

Reviewers: ckerschb, Gijs

Reviewed By: ckerschb, Gijs

Bug #: 1362034

Differential Revision: https://phabricator.services.mozilla.com/D2047

--HG--
extra : rebase_source : ccded0f06a0dc4567b827f42ee29f4b8954154fe
extra : amend_source : 94da8ecc053e56958fa4137d7e497362fa2c11f1
2018-08-08 20:05:30 +03:00
Andreea Pavel
f5c1119983 Backed out 2 changesets (bug 1362034) for failing damp | inspector/cold-open.js on a CLOSED TREE
Backed out changeset 8c8925b75aa2 (bug 1362034)
Backed out changeset ff6b05c96094 (bug 1362034)
2018-08-06 20:42:44 +03:00
Jonathan Kingston
4ca581ffed Bug 1362034 - Tests for addTab() to provide the correct triggering principal. r=ckerschb,Gijs
Summary: Depends on D2046

Reviewers: ckerschb, Gijs

Reviewed By: ckerschb, Gijs

Bug #: 1362034

Differential Revision: https://phabricator.services.mozilla.com/D2047

--HG--
extra : rebase_source : 4bb9e7feb0704239756e6e38623c0fea81669f7b
extra : amend_source : 9417f96547735fbdc55ea23666327a5cb86ac92f
2018-08-06 19:56:37 +03:00
Neil Deakin
cf9835ac8b Bug 1446961, remove obsolete calls to showPopup and replace usages of the popup box object with the same methods defined on popups, r=paolo 2018-04-27 11:04:36 -04:00
Kris Maglione
918ed6c474 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : source : 12fc4dee861c812fd2bd032c63ef17af61800c70
extra : intermediate-source : 34c999fa006bffe8705cf50c54708aa21a962e62
extra : histedit_source : b2be2c5e5d226e6c347312456a6ae339c1e634b0
2018-01-29 15:20:18 -08:00
Cosmin Sabou
9a65a40178 Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE
Backed out changeset a1eca62826a1 (bug 1431533)
Backed out changeset 34c999fa006b (bug 1431533)
Backed out changeset e2674287e57f (bug 1431533)
2018-01-30 07:17:48 +02:00
Kris Maglione
6476f95b13 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : source : 12fc4dee861c812fd2bd032c63ef17af61800c70
2018-01-29 15:20:18 -08:00
Brindusan Cristian
af8879d1eb Backed out 2 changesets (bug 1431533) for ESlint failures on a CLOSED TREE
Backed out changeset 6e56f4c8843e (bug 1431533)
Backed out changeset 12fc4dee861c (bug 1431533)
2018-01-30 02:32:43 +02:00
Kris Maglione
c276bb9375 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : rebase_source : c004a023389f1f6bf3d2f3efe93c13d423b23ccd
2018-01-29 15:20:18 -08:00
Thomas Nguyen
51c703955b Bug 1420702 - Test referrer when clicking cross domain link from pinned tab r=ckerschb
MozReview-Commit-ID: DokwVqZcrx7

--HG--
extra : rebase_source : 02f9ee54485288b7bf6fe2651acf3648db5a52c7
2017-11-30 21:43:00 +08:00
Tooru Fujisawa
9a3aa36ec4 Bug 1416153 - Part 0: Fix tests that uses BrowserTestUtils.waitForNewTab to perform the registration of the next event handler instantly inside the new tab event handler. r=Gijs 2017-11-24 07:50:12 +09:00
Mark Banner
4de6bf22b1 Bug 1411368 - Automatically fix no-multi-spaces issues raised when using ESLint 4. r=mossop
MozReview-Commit-ID: H5YVp3rnzGo

--HG--
extra : rebase_source : 5b45b6c0df834131812d094e975047eaad374e06
2017-10-26 11:47:01 +01:00
Luke Crouch
2ffb7f22e3 Bug 1409226 - When opening a link into a new private window, remove Referer. r=mikedeboer
Always set aNoReferrer = true in openLinkIn when where == 'window' and aIsPrivate

MozReview-Commit-ID: 7szUyO6w6d4

--HG--
extra : rebase_source : 25f00b0967bc7ed1e755227c6d16224b411d5e38
2017-10-17 18:07:58 -05:00
Sebastian Hengst
08e94c180c Backed out changeset 1fb52bba8d5c (bug 1409226) for eslint failure at browser/base/content/utilityOverlay.js:210: Function 'openLinkIn' has a complexity of 41. r=backout
--HG--
extra : amend_source : d453826eb6170a8e6d4aa049b71f477189351a0e
2017-10-24 18:30:24 +02:00
Luke Crouch
076182907c Bug 1409226 - When opening a link into a new private window, remove Referer. r=mikedeboer
Always set aNoReferrer = true in openLinkIn when where == 'window'

MozReview-Commit-ID: 7szUyO6w6d4

--HG--
extra : rebase_source : 7e8af95bedee17e01226d10e4cb168c950574dba
2017-10-17 18:07:58 -05:00
Florian Quèze
2924991bf6 Bug 1368456 - remove Promise.jsm imports in tests, r=mconley. 2017-06-23 11:25:52 +02:00
Swapnesh Kumar Sahoo
c11cf34901 Bug 1354331 - Remove network.http.enablePerElementReferrer usages. r=valentin r=baku 2017-05-01 00:12:34 +05:30
Florian Queze
37ff4fc7cc Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Sebastian Hengst
a07223d699 Backed out changeset 322fde2d53bf (bug 1356569) so bug 1355161 can be backed out. r=backout 2017-04-14 23:39:22 +02:00
Florian Queze
95d4d20c17 Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Mark Banner
bd625e4e9f Bug 1347712 - Change the testing configurations into ESLint configurations within eslint-plugin-mozilla - automatically update .eslintrc.js test config files for new config locations. r=jaws
MozReview-Commit-ID: LH0CQOPfoe6

--HG--
extra : rebase_source : 83eaf40c5cbb5e25cfb3f3b5afadf4fbf0422c92
2017-03-20 12:36:37 +01:00
Blake Kaplan
c57a486e18 Bug 1335801 - Make these tests wait correctly. r=Felipe,krizsa
--HG--
extra : rebase_source : 11506348c56a6763ae59311e3e827410de1dcac2
2017-03-01 17:11:23 -08:00
Wes Kocher
d1b8197b88 Backed out changeset ba253783b432 (bug 1335801) for browser_referrer_simple_click.js failures a=backout CLOSED TREE
MozReview-Commit-ID: 5jn0Okch3jt

--HG--
extra : amend_source : 509a1aa488b347029a7aea4526380366d5f4af2d
2017-03-06 15:30:03 -08:00
Blake Kaplan
9acea25eaf Bug 1335801 - Make these tests wait correctly. r=Felipe,krizsa
--HG--
extra : rebase_source : 36d4d2378d879d92d25e4ed0439e31f3f9f068f6
2017-03-01 17:11:23 -08:00
Sebastian Hengst
e3e6039ccd Backed out changeset 20e91e72e991 (bug 1335801) for failing browser_referrer_open_link_in_container_tab.js, at least on Windows. r=backout 2017-02-25 00:19:46 +01:00
Blake Kaplan
8ede39135a Bug 1335801 - Wait for the right events. r=Felipe,krizsa
MozReview-Commit-ID: JL0AdE8XB2n

--HG--
extra : rebase_source : ad6392315710cea34e583a9cabfc878ee225f186
2017-02-23 11:32:33 -08:00
Blake Kaplan
7b481c1193 Bug 1335801 - Actually wait for the right href to load. r=Felipe
MozReview-Commit-ID: GVkWzNoTSQ7
2017-02-22 15:39:18 -08:00
Gabor Krizsanits
dcb33c4382 Bug 1337354 - Fix races in referrer tests. r=mrbkap 2017-02-08 11:22:33 +01:00
Wes Kocher
b303437faf Bug 1315042 - redisable browser_referrer_middle_click_in_container.js for failures a=me
MozReview-Commit-ID: KAGz2fYru9Y
2017-02-01 15:14:08 -08:00
Wes Kocher
1dc1c76ae6 Backed out changeset 6c70f14a433e (bug 1315942) for landing with the wrong bug number
MozReview-Commit-ID: JThvlWdOycC
2017-02-01 15:13:47 -08:00
Wes Kocher
025b72ed3c Bug 1315942 - redisable browser_referrer_middle_click_in_container.js for failures a=me
MozReview-Commit-ID: KAGz2fYru9Y
2017-02-01 15:11:05 -08:00
Geoff Brown
7fa4e457a6 Bug 1275447 - Enable browser_referrer_open_link_in_container_tab.js on e10s; r=me,a=test-only 2017-02-01 13:40:52 -07:00
Sebastian Hengst
e405dfc3bd Bug 1315042 - Re-disable browser_referrer_middle_click.js because it fails often with e10s enabled. r=bustage-fix on a CLOSED TREE 2017-02-01 15:35:57 +01:00
Gabor Krizsanits
a7054ffd23 Bug 1315042 - Re-enable some tests part2. r=me 2017-02-01 13:38:59 +01:00
Gabor Krizsanits
fe4a3055ff Bug 1334052 - Fixing racy tab switching. r=mrbkap 2017-01-31 10:12:55 +01:00
Geoff Brown
314ef818ef Bug 1275447 - Skip browser_referrer_open_link_in_container_tab.js on e10s for frequent failures; r=me 2017-01-25 17:02:00 -07:00
Florian Quèze
0e0865f4fc Bug 1331599 - script-generated patch to replace removeEventListener calls with the once option when possible, r=jaws. 2017-01-25 07:01:52 +01:00
Gabor Krizsanits
216527edfc Bug 1303113 - Turn e10s-multi on in Nightly. r=me 2017-01-23 14:15:30 +01:00
Jared Wein
43bac26d30 Bug 1331661 - Enable the 'quotes' rule for eslint and fix most of the errors with --fix. r=Gijs
MozReview-Commit-ID: 6tv0Z06CO4a

--HG--
extra : rebase_source : 014c0b04d8538dc5f15bc6dd4ed6bd220c55c5d4
2017-01-17 09:48:17 -06:00
Jared Wein
3718f00db1 Bug 1316870 - Enable no-shadow eslint rule for browser/. r=mossop 2016-11-15 22:58:30 -05:00
Phil Ringnalda
e7fdca7c8d Backed out 6 changesets (bug 1301340, bug 1303113) for landing too close to a merge and causing leaks and test failures
Backed out changeset adfcc194af1c (bug 1303113)
Backed out changeset 085035586d2b (bug 1303113)
Backed out changeset 81f3bb541c86 (bug 1301340)
Backed out changeset 05c42cf92851 (bug 1301340)
Backed out changeset cb45e90f6596 (bug 1301340)
Backed out changeset f54a717c6fc6 (bug 1301340)

MozReview-Commit-ID: BkwhFJNtF7G

--HG--
extra : rebase_source : cc47ef8587f08b12b53406efee1d5b915d3c833a
2016-11-09 19:11:12 -08:00
Gabor Krizsanits
7d924932b4 Bug 1303113 - Turning off a test for e10s-multi temporarily. r=me 2016-11-09 17:58:45 +01:00
Gabor Krizsanits
b6946deed5 Bug 1301340 - part8: Few more tunr-offs. r=me 2016-11-09 14:44:25 +01:00
Gabor Krizsanits
a7a38b8a5f Bug 1301340 - part6: Disabled test should still run in non-e10s mode. r=me 2016-11-04 11:05:55 +01:00