Commit Graph

17720 Commits

Author SHA1 Message Date
David Walsh
ed90f3db5c Bug 1550030 - Show breakpoint icon in inspector for DOM Mutation Breakpoints r=gl
Differential Revision: https://phabricator.services.mozilla.com/D45036

--HG--
extra : moz-landing-system : lando
2019-09-18 21:32:42 +00:00
Brian Hackett
76aa860146 Bug 1581991 - Avoid spawning replaying children when rewinding is not allowed, r=jlast.
Differential Revision: https://phabricator.services.mozilla.com/D46240

--HG--
extra : moz-landing-system : lando
2019-09-17 23:59:56 +00:00
arthur.iakab
693b70fd35 Backed out changeset 1630eaa0a61c (bug 1543261) for causing devtools failure on browser_dbg-breakpoints-cond-source-maps.js CLOSED TREE 2019-09-18 21:44:15 +03:00
Alex Rosenfeld
e4b574cad7 Bug 1543261 - Conditional Panel: Load correct conditions when opened with keyboard shortcut r=davidwalsh
Previously, the conditional panel did not correctly load breakpoint conditions when opened with the keyboard shortcut.
This patch loads the conditions, and selects the closest active column breakpoint on same line as cursor position in the Editor.

Differential Revision: https://phabricator.services.mozilla.com/D32795

--HG--
extra : moz-landing-system : lando
2019-09-18 17:55:02 +00:00
Cosmin Sabou
1979100382 Backed out changeset 458af3b79e09 (bug 1543261) for landing without a bug no in the commit. CLOSED TREE 2019-09-18 20:38:44 +03:00
Alex Rosenfeld
f24bbf1727 Conditional Panel: Load correct conditions when opened with keyboard shortcut (Bug 1543261).Add functionality of selecting the closest active column breakpoint based on current cursorPosition in Editor. r=davidwalsh
Previously, the conditional panel did not correctly load breakpoint conditions when opened with the keyboard shortcut.
This patch loads the conditions, and selects the closest active column breakpoint on same line as cursor position in the Editor.

Differential Revision: https://phabricator.services.mozilla.com/D32795

--HG--
extra : moz-landing-system : lando
2019-09-18 17:17:35 +00:00
Michael Ratcliffe
079415e5ec Bug 1556201 - Inactive CSS: Clicking on the info icon should not close the tooltip r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D45678

--HG--
extra : moz-landing-system : lando
2019-09-18 11:05:48 +00:00
Belén Albeza
e0a909f7ea Bug 1575529: Display color values for manifest members r=Ola
Differential Revision: https://phabricator.services.mozilla.com/D45829

--HG--
extra : moz-landing-system : lando
2019-09-18 10:03:44 +00:00
lloan
9fe26db50d Bug 1579784 - Basic test for the Search panel, displaying the right search results. r=Honza
Differential Revision: https://phabricator.services.mozilla.com/D45815

--HG--
extra : moz-landing-system : lando
2019-09-18 10:17:07 +00:00
Karl Tomlinson
337fbc6879 Bug 1578623 add test for syntax errors and uncaught exceptions in worklet scripts r=bhackett
Depends on D44611

Differential Revision: https://phabricator.services.mozilla.com/D44612

--HG--
rename : devtools/client/webconsole/test/browser/browser_webconsole_worker_error.js => devtools/client/webconsole/test/browser/browser_webconsole_worklet_error.js
extra : moz-landing-system : lando
2019-09-09 00:42:03 +00:00
Brian Hackett
a0762fda35 Bug 1581999 - Fix event logging while replaying, r=jlast.
Differential Revision: https://phabricator.services.mozilla.com/D46245

--HG--
extra : moz-landing-system : lando
2019-09-18 03:22:33 +00:00
Brian Hackett
458ed0080a Bug 1581665 - Tidy up handling of pause and paint data, r=jlast.
Differential Revision: https://phabricator.services.mozilla.com/D46087

--HG--
extra : moz-landing-system : lando
2019-09-16 22:43:39 +00:00
Jason Laster
aca4c6e5c7 Bug 1581945 - It should not be possible to set watchpoints on non-configurable properties. r=bhackett
Differential Revision: https://phabricator.services.mozilla.com/D46214

--HG--
extra : moz-landing-system : lando
2019-09-17 22:28:36 +00:00
Nicolas Chevobbe
e26ae9c3f4 Bug 1581738 - Fix ErrorRep for Error objects with non-string stack property. r=Honza.
When the stack isn't a string (or a longstring), we
don't try to parse anything.
A test is added to ensure we don't regress.

Differential Revision: https://phabricator.services.mozilla.com/D46114

--HG--
extra : moz-landing-system : lando
2019-09-17 13:57:18 +00:00
Armando Ferreira
5a33b3c101 Bug 1567372 - Add a reverse search button to the Editor Toolbar. r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D45095

--HG--
extra : moz-landing-system : lando
2019-09-17 21:58:17 +00:00
Jason Laster
5cb8b24f19 Bug 1110276 - Log on Events (UI). r=davidwalsh
Differential Revision: https://phabricator.services.mozilla.com/D46077

--HG--
extra : moz-landing-system : lando
2019-09-17 21:17:58 +00:00
Boris Chiou
88285c24ba Bug 1480665 - Support ray() in offset-path and make it animatable. r=emilio,birtles
1. Add `generics::motion::OffsetPath`, and use specified `Angle` and
   computed `Angle` to define specified `OffsetPath` and computed `OffsetPath`.
2. Add `ray` function into `OffsetPath`.

We also tweak the degree from 150deg to 135deg in wpt (e.g.
offset-path-ray-001.html and others) to avoid floating point precision issues.
For example:
```
// offset-path: ray(150deg ...);
// offset-distance: 20px;
matrix:
{
  {0.500000 0.866025 0.000000 0.000000},
  {-0.866025 0.500000 0.000000 0.000000},
  {0.000000 0.000000 1.000000 0.000000},
  {10.000000 17.320509 0.000000 1.000000}
}

// rotate(60deg) translate(20px)
matrix:
{
  {0.500000 0.866025 0.000000 0.000000},
  {-0.866025 0.500000 0.000000 0.000000},
  {0.000000 0.000000 1.000000 0.000000},
  {10.000000 17.320507 0.000000 1.000000}
}
```
Their translate parts, 17.320509 vs 17.320507, are almost the same (only
tiny difference), which may cause the reftest failed.

Differential Revision: https://phabricator.services.mozilla.com/D42721

--HG--
rename : testing/web-platform/tests/css/motion/offset-path-ray-ref.html => testing/web-platform/tests/css/motion/offset-path-ray-001-ref.html
rename : testing/web-platform/tests/css/motion/offset-path-ray.html => testing/web-platform/tests/css/motion/offset-path-ray-001.html
rename : testing/web-platform/tests/css/motion/offset-path-ray.html => testing/web-platform/tests/css/motion/offset-path-ray-002.html
rename : testing/web-platform/tests/css/motion/offset-path-ray.html => testing/web-platform/tests/css/motion/offset-path-ray-003.html
rename : testing/web-platform/tests/css/motion/offset-path-ray.html => testing/web-platform/tests/css/motion/offset-path-ray-004.html
rename : testing/web-platform/tests/css/motion/offset-path-ray.html => testing/web-platform/tests/css/motion/offset-path-ray-005.html
rename : testing/web-platform/tests/css/motion/offset-path-ray.html => testing/web-platform/tests/css/motion/offset-path-ray-006.html
rename : testing/web-platform/tests/css/motion/offset-path-ray.html => testing/web-platform/tests/css/motion/offset-path-ray-007.html
extra : moz-landing-system : lando
2019-09-16 23:24:48 +00:00
Ting-Yu Lin
1c4d625432 Bug 1423383 - Enable layout.css.column-span.enabled on Nightly. r=dholbert
properties-db.js is patched via `./mach devtools-css-db` after flipping
column-span pref to @IS_NIGHTLY_BUILD@ in StaticPrefList.yaml.

Differential Revision: https://phabricator.services.mozilla.com/D41461

--HG--
extra : moz-landing-system : lando
2019-09-17 19:43:00 +00:00
Jason Laster
751b6be5a3 Bug 1578772 - Enable/disable replay from Devtools settings. r=bhackett
Differential Revision: https://phabricator.services.mozilla.com/D46162

--HG--
extra : moz-landing-system : lando
2019-09-17 19:37:00 +00:00
Gabriel Luong
2a62837bcb Bug 1578824 - Land initial boilerplate for embedding RDM UI into the browser. r=mtigley,mconley,bgrins
Differential Revision: https://phabricator.services.mozilla.com/D45091

--HG--
extra : moz-landing-system : lando
2019-09-17 16:56:16 +00:00
Mark Banner
88eab57b84 Bug 1579452 - Enable ESLint rule no-async-promise-executor on disabled locations for devtools. r=jlast
Depends on D45010

Differential Revision: https://phabricator.services.mozilla.com/D45999

--HG--
extra : moz-landing-system : lando
2019-09-17 17:50:23 +00:00
Dorel Luca
c47fb85a4c Backed out changeset 7b042044bd2d (bug 1578772) for eslint failures. CLOSED TREE 2019-09-17 21:10:58 +03:00
Jason Laster
df4007c720 Bug 1578772 - Enable/disable replay from Devtools settings. r=bhackett
Differential Revision: https://phabricator.services.mozilla.com/D46162

--HG--
extra : moz-landing-system : lando
2019-09-17 17:34:12 +00:00
David Walsh
4f1d186333 Bug 1580530 - Implement NetworkActionBar in the netmonitor r=Honza
Creates a left sidebar panel for both search and request blocking.

Differential Revision: https://phabricator.services.mozilla.com/D46065

--HG--
extra : moz-landing-system : lando
2019-09-17 14:14:50 +00:00
David Walsh
b572c4fefa Bug 1580890 - Restructure inline-preview action for better performance r=jlast
Differential Revision: https://phabricator.services.mozilla.com/D45702

--HG--
extra : moz-landing-system : lando
2019-09-16 20:35:17 +00:00
lloan
6ca2966cb0 Bug 1580185. Clicking on clear button in the Search panel doesn't cancel the current search. r=Honza.
Differential Revision: https://phabricator.services.mozilla.com/D46047

--HG--
extra : moz-landing-system : lando
2019-09-17 10:47:14 +00:00
Julian Descottes
e21e90c2e9 Bug 1581071 - Update devtools metrics test to check that modules are not loaded twice r=Honza,ochameau
Check for duplicated entries in the loaders during the metrics tests

Differential Revision: https://phabricator.services.mozilla.com/D45833

--HG--
extra : moz-landing-system : lando
2019-09-17 09:34:28 +00:00
Miko Mynttinen
94d12e12a7 Bug 1559706 - Workaround for invalid layerization in Inspector r=gl
Differential Revision: https://phabricator.services.mozilla.com/D45896

--HG--
extra : moz-landing-system : lando
2019-09-16 14:03:32 +00:00
Daisuke Akatsuka
59b47c5ef8 Bug 1581582: Change the loading way. r=pbro
Differential Revision: https://phabricator.services.mozilla.com/D46104

--HG--
extra : moz-landing-system : lando
2019-09-17 06:56:18 +00:00
Brian Hackett
9e43080ec9 Bug 1581418 - Include more properties when logging objects, r=jlast.
Differential Revision: https://phabricator.services.mozilla.com/D45961

--HG--
rename : devtools/client/webreplay/mochitest/browser_dbg_rr_console_warp-03.js => devtools/client/webreplay/mochitest/browser_rr_object_preview-01.js
extra : source : ece44b8f51e43f9dcb56a592cb4e5205f8ce19e6
2019-09-16 22:48:15 +00:00
Maxime Vaillancourt
f6ab7d35e3 Bug 1574054 - Fix arrow keys behavior on tabs when document direction is RTL. r=rcaliman
Fix arrow keys behavior on tabs when document direction is RTL

Differential Revision: https://phabricator.services.mozilla.com/D45781

--HG--
extra : moz-landing-system : lando
2019-09-16 19:46:41 +00:00
Mihai Alexandru Michis
4174e65ff5 Backed out changeset ece44b8f51e4 (bug 1581418) for causing xpcshell failures.
--HG--
rename : devtools/client/webreplay/mochitest/browser_rr_object_preview-01.js => devtools/client/webreplay/mochitest/browser_dbg_rr_console_warp-03.js
2019-09-17 06:17:05 +03:00
Brian Hackett
da5abd1fbc Bug 1546369 - Support InspectorUtils.getContentState while replaying, r=jlast.
Differential Revision: https://phabricator.services.mozilla.com/D46091

--HG--
extra : moz-landing-system : lando
2019-09-16 23:30:33 +00:00
Brian Hackett
1cd0fb99fd Bug 1581418 - Include more properties when logging objects, r=jlast.
Differential Revision: https://phabricator.services.mozilla.com/D45961

--HG--
rename : devtools/client/webreplay/mochitest/browser_dbg_rr_console_warp-03.js => devtools/client/webreplay/mochitest/browser_rr_object_preview-01.js
extra : moz-landing-system : lando
2019-09-16 22:48:15 +00:00
Zibi Braniecki
e0cdd093e0 Bug 1581204 - Remove unused DTDs from devtools. r=bgrins
Differential Revision: https://phabricator.services.mozilla.com/D45899

--HG--
extra : moz-landing-system : lando
2019-09-16 19:41:44 +00:00
Micah Tigley
c76a5272d4 Bug 1581155 - Fix flashing a CSS property from box-model link. r=gl
In this revision, mimic flashing a property element like in the markup view.

Differential Revision: https://phabricator.services.mozilla.com/D45884

--HG--
extra : moz-landing-system : lando
2019-09-16 14:07:04 +00:00
Gabriel Luong
4a1c59f251 Bug 1500142 - Remove inspector bindings from toolbox. r=yulia,ochameau
Differential Revision: https://phabricator.services.mozilla.com/D40320

--HG--
extra : moz-landing-system : lando
2019-09-16 17:39:42 +00:00
Rob Wu
64ad4811f6 Bug 1570715 - Treat (deprecation) warnings as errors r=rpl
Add new preference `extensions.webextensions.warnings-as-errors` that
defaults to `true` in tests. Tests that expect warnings are modified
to briefly flip the pref for the specific part of the test that needs
an exception.

As part of the refactor, log entries for schema entries that contain
`"onError": "warn"` will now be prefixed by "Warning" instead of
"Error", to be consistent with the change from bug 1495908.

Differential Revision: https://phabricator.services.mozilla.com/D40548

--HG--
extra : moz-landing-system : lando
2019-09-16 16:35:59 +00:00
Nicolas Chevobbe
765b39cd6d Bug 1572980 - Fix browser_jsterm_autocomplete-properties-with-non-alphanumeric-names intermittent. r=Honza.
Differential Revision: https://phabricator.services.mozilla.com/D46026

--HG--
extra : moz-landing-system : lando
2019-09-16 14:29:03 +00:00
Maxime Vaillancourt
19b3bd3cde Bug 1567859 - Add missing separator after computed style filter. r=gl
Add missing separator after computed style filter

Differential Revision: https://phabricator.services.mozilla.com/D45777

--HG--
extra : moz-landing-system : lando
2019-09-15 20:06:24 +00:00
Nicolas Chevobbe
8be561cece Bug 1577798 - Don't create a new Debugger instance in WebConsoleActor. r=ochameau,jlast.
Previously, when creating a new WebConsoleActor, we were
also creating a new Debugger instance.
The problem was that we would never call `enable` on it,
which is what allows to create debuggee for all existing
globals, and for the ones that will be created after.
This means that we had multiple workaround to get a
global debuggee, and in the case of function, would add
a global as a debuggee only to get its script location.

This patch remove the creation of the new Debugger,
and retrieve the parent actor Debugger instance instead.

This shuffles things around a bit, are the Debugger instance
was created by the ThreadActor, but is now by the target
actor (BrowsingContext, ContentProcess, ...).

We can then remove the now unused `getGlobalDebugObject`
hooks we were using in the Function previewer, as we
get a proper Debugger object, with the script location.

Differential Revision: https://phabricator.services.mozilla.com/D44480

--HG--
extra : moz-landing-system : lando
2019-09-16 12:12:22 +00:00
Ola Gasidlo
ea28744160 Bug 1580826 - Ensure awaiting on fetchManifest before closing tab, r=yulia
Intermittent devtools/client/application/test/browser/browser_application_panel_sidebar.js | A promise chain failed to handle a rejection: Connection closed, pending request to server0.conn2.child1/manifestActor19, type fetchCanonicalManifest failed

Differential Revision: https://phabricator.services.mozilla.com/D46001

--HG--
extra : moz-landing-system : lando
2019-09-16 11:55:50 +00:00
Noemi Erli
2c99088968 Bug 1581472 - ES lint fix CLOSED TREE 2019-09-16 13:45:49 +03:00
Sorin Davidoi
b7d09ae90b Bug 1580490 - Load search worker on demand. r=Honza
Load search worker on demand

Differential Revision: https://phabricator.services.mozilla.com/D45538

--HG--
extra : moz-landing-system : lando
2019-09-16 10:31:42 +00:00
Emilio Cobos Álvarez
8349d49124 Bug 1581472 - Only treat CSS parser errors as CSS errors. r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D45986

--HG--
extra : moz-landing-system : lando
2019-09-16 10:12:47 +00:00
Daisuke Akatsuka
7934273827 Bug 713106: Add test for visited element. r=pbro
Differential Revision: https://phabricator.services.mozilla.com/D45807

--HG--
extra : moz-landing-system : lando
2019-09-16 09:53:32 +00:00
Daisuke Akatsuka
d2d8fffbd5 Bug 713106: Lock/unlock :visited pseudo-class. r=pbro
Differential Revision: https://phabricator.services.mozilla.com/D45805

--HG--
extra : moz-landing-system : lando
2019-09-13 22:12:29 +00:00
Daisuke Akatsuka
409a2bc885 Bug 713106: Make :visited selector enabled to use from DevTools. r=pbro,emilio
Differential Revision: https://phabricator.services.mozilla.com/D45624

--HG--
extra : moz-landing-system : lando
2019-09-13 22:12:12 +00:00
Daisuke Akatsuka
ef36d9df93 Bug 713106: Show :visited rule while the pseudo is locked. r=pbro,emilio
Differential Revision: https://phabricator.services.mozilla.com/D45623

--HG--
extra : moz-landing-system : lando
2019-09-13 22:11:58 +00:00
Brian Hackett
c5861a20a0 Bug 1581434 - Convert new console message arguments into the proper format, r=jlast.
Differential Revision: https://phabricator.services.mozilla.com/D45967

--HG--
extra : moz-landing-system : lando
2019-09-16 03:18:11 +00:00
Brian Hackett
52bb5d1e45 Bug 1579654 - Use old set of scripts if reparsing for breakpoint positions fails, r=jlast.
Differential Revision: https://phabricator.services.mozilla.com/D45965

--HG--
extra : moz-landing-system : lando
2019-09-16 03:17:23 +00:00
Brian Hackett
b08a3cc809 Bug 1581013 - Support event logpoints when replaying, r=jlast.
Differential Revision: https://phabricator.services.mozilla.com/D45778

--HG--
extra : moz-landing-system : lando
2019-09-16 00:12:34 +00:00
Gurzau Raul
f195a247dd Backed out changeset 1bed7919ff1e (bug 1580890) frequently failing browser_dbg-debug-line.js (bug 1581026) 2019-09-15 03:21:27 +03:00
Brian Hackett
67035f9e70 Bug 1580104 - Send record/replay messages atomically, r=jlast.
Differential Revision: https://phabricator.services.mozilla.com/D45934

--HG--
extra : moz-landing-system : lando
2019-09-14 14:03:16 +00:00
Miriam
57718b6d7a Bug 1574192 - Initial watchpoints front end commit. r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D43487

--HG--
extra : moz-landing-system : lando
2019-09-14 14:13:54 +00:00
Narcis Beleuzu
1cb9dbb638 Backed out 2 changesets (bug 1570715) for causing tp6m raptor failures
Backed out changeset e7364a10a663 (bug 1570715)
Backed out changeset 51824b1dda97 (bug 1570715)
2019-09-14 16:00:00 +03:00
Micah Tigley
c1ddfa4079 Bug 1581059 - Fix networking throttling dropdown menu UI. r=gl
Differential Revision: https://phabricator.services.mozilla.com/D45876

--HG--
extra : moz-landing-system : lando
2019-09-13 17:43:57 +00:00
Michael Ratcliffe
eb70def3e1 Bug 1579058 - [Inactive CSS] Remove invalidProperties from CSS validator r=pbro
Differential Revision: https://phabricator.services.mozilla.com/D45852

--HG--
extra : moz-landing-system : lando
2019-09-13 14:12:52 +00:00
Julian Descottes
1dc087a788 Bug 1557083 - Emit actions from netmonitor store after requests are blocked/unblocked r=Honza
Depends on D45498
This makes the test run fine on top of the changes for the session history rewrite.

Differential Revision: https://phabricator.services.mozilla.com/D45499

--HG--
extra : moz-landing-system : lando
2019-09-13 13:38:03 +00:00
Julian Descottes
fa1aa153b3 Bug 1557083 - Webconsole actor should wait for block/unblock requests to be processed by netmonitors r=nchevobbe,Honza
Depends on D45497

Differential Revision: https://phabricator.services.mozilla.com/D45498

--HG--
extra : moz-landing-system : lando
2019-09-13 13:37:41 +00:00
Julian Descottes
bdb6e996db Bug 1557083 - Add thunk middleware to netmonitor; r=Honza
This middleware will be useful to wait for actions from tests

Differential Revision: https://phabricator.services.mozilla.com/D45497

--HG--
extra : moz-landing-system : lando
2019-09-13 13:37:22 +00:00
Jan Odvarko
8102c31740 Bug 1560421 - No frames are displayed for some WS connections r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D45164

--HG--
extra : moz-landing-system : lando
2019-09-13 12:55:43 +00:00
Belén Albeza
48e2a4a481 Bug 1566022 - Add "open json" link to the manifest r=Ola,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D45348

--HG--
extra : moz-landing-system : lando
2019-09-13 11:27:29 +00:00
Rob Wu
75fd473720 Bug 1570715 - Treat (deprecation) warnings as errors r=rpl
Add new preference `extensions.webextensions.warnings-as-errors` that
defaults to `true` in tests. Tests that expect warnings are modified
to briefly flip the pref for the specific part of the test that needs
an exception.

As part of the refactor, log entries forschema entries that contain
`"onError": "warn"` will now be prefixed by "Warning" instead of
"Error", to be consistent with the change from bug 1495908.

Differential Revision: https://phabricator.services.mozilla.com/D40548

--HG--
extra : moz-landing-system : lando
2019-09-12 21:39:51 +00:00
Ciure Andrei
a70e37b142 Backed out 3 changesets (bug 1557083) for causing browser_net_block.js to perma fail CLOSED TREE
Backed out changeset 82611a6d116f (bug 1557083)
Backed out changeset 576da2d2bf32 (bug 1557083)
Backed out changeset 613f24ecf1c3 (bug 1557083)
2019-09-13 12:49:35 +03:00
Michael Ratcliffe
e181ff7977 Bug 1552146 - [Inactive CSS] Fine tune the tooltip's position in hidpi and non-hidpi modes r=pbro
Differential Revision: https://phabricator.services.mozilla.com/D44846

--HG--
extra : moz-landing-system : lando
2019-09-12 10:14:34 +00:00
Julian Descottes
d7dd56640d Bug 1557083 - Emit actions from netmonitor store after requests are blocked/unblocked r=Honza
Depends on D45498
This makes the test run fine on top of the changes for the session history rewrite.

Differential Revision: https://phabricator.services.mozilla.com/D45499

--HG--
extra : moz-landing-system : lando
2019-09-13 08:39:54 +00:00
Julian Descottes
b1aeba486c Bug 1557083 - Webconsole actor should wait for block/unblock requests to be processed by netmonitors r=nchevobbe,Honza
Depends on D45497

Differential Revision: https://phabricator.services.mozilla.com/D45498

--HG--
extra : moz-landing-system : lando
2019-09-13 08:14:19 +00:00
Julian Descottes
170c8259b5 Bug 1557083 - Add thunk middleware to netmonitor; r=Honza
This middleware will be useful to wait for actions from tests

Differential Revision: https://phabricator.services.mozilla.com/D45497

--HG--
extra : moz-landing-system : lando
2019-09-11 09:28:31 +00:00
Nicolas Chevobbe
2f8760ac4b Bug 1570476 - Don't fetch the request stacktrace in StackTracePanel's componentWillReceiveProps if the request won't change. r=Honza.
This was causing an intermittent in console test because
multiple requests were sent to the server, and sometimes,
some of them after the connection being closed, which
was making the test fail.
With this patch, we only try to fetch a new stacktrace
on componenetWillReceiveProps if the component will have
to deal with a new request.

Differential Revision: https://phabricator.services.mozilla.com/D45808

--HG--
extra : moz-landing-system : lando
2019-09-13 08:21:31 +00:00
Nicolas Chevobbe
90cc5901b8 Bug 1517411 - Add test cases for globalThis in js-property-provider test. r=Honza.
Differential Revision: https://phabricator.services.mozilla.com/D45632

--HG--
extra : moz-landing-system : lando
2019-09-13 08:29:13 +00:00
Nicolas Chevobbe
d31e32951a Bug 1581033 - Fix browser_console_open_or_focus intermittent. r=Honza.
Differential Revision: https://phabricator.services.mozilla.com/D45801

--HG--
extra : moz-landing-system : lando
2019-09-13 08:22:50 +00:00
Jason Laster
1a291f1700 Bug 1110276 - Log on Events. r=bhackett
Differential Revision: https://phabricator.services.mozilla.com/D45619

--HG--
extra : moz-landing-system : lando
2019-09-13 02:37:08 +00:00
Jason Laster
19d13244b1 Bug 1580529 - Force LTR the Outline panel contents in the Debugger (fix test) r=jlast. CLOSED TREE
Differential Revision: https://phabricator.services.mozilla.com/D45760

--HG--
extra : rebase_source : 613e7725e5cbfa069dd86f7afb6788983329b094
extra : histedit_source : 758f1b90b07666f3f1c49a774f6b208e46752222
2019-09-13 02:11:50 +03:00
Itiel
3f7c740857 Bug 1580529 - Force LTR the Outline panel contents in the Debugger r=jlast
Differential Revision: https://phabricator.services.mozilla.com/D45554

--HG--
extra : moz-landing-system : lando
2019-09-12 21:54:49 +00:00
David Walsh
7eb854230e Bug 1580890 - Restructure inline-preview action for better performance r=jlast
Differential Revision: https://phabricator.services.mozilla.com/D45702

--HG--
extra : moz-landing-system : lando
2019-09-12 21:51:45 +00:00
Julian Descottes
73a8e158b7 Bug 1578373 - Stop using window.top in devtools/client/shared/widgets/Graphs.js r=julienw
Differential Revision: https://phabricator.services.mozilla.com/D45448

--HG--
extra : moz-landing-system : lando
2019-09-12 19:57:44 +00:00
Micah Tigley
2107eab165 Bug 1363970 - Disable touch simulation when color picker is active. r=gl,rcaliman
This patch manually disables touch simulation in places where the color picker is enabled. Alternatively, doing this from InspectorActor's `pickColorFromPage` method requires that we get the associated RDM emulationActor for the tab, which turned out to be more complicated than I thought.

Getting and setting the picker state on the emulation factor retrieved via `getActorByID` does not match the emulationActor handling the touch events. So setting the picker state is indeed working it's just not setting it on the correct one. I'm unsure of how to go about this as the RDM emulationActor and the Inspector actor are entirely separate of each other.

So for now, we disable touch simulation in places where color picker is being enabled. Let me know what you think about this @pbro and @gl .

Differential Revision: https://phabricator.services.mozilla.com/D45593

--HG--
extra : moz-landing-system : lando
2019-09-12 18:20:39 +00:00
Brad Werth
6d3b2babbc Bug 1567310 Part 4: Add a test that whitespace frames are not created by opening the inspector. r=gl
Differential Revision: https://phabricator.services.mozilla.com/D45257

--HG--
extra : moz-landing-system : lando
2019-09-12 19:06:09 +00:00
Brad Werth
df189909f4 Bug 1567310 Part 3: Make all devtools callers of getBoxQuads include option to suppress whitespace frames. r=gl
Differential Revision: https://phabricator.services.mozilla.com/D45120

--HG--
extra : moz-landing-system : lando
2019-09-12 19:05:52 +00:00
Sorin Davidoi
4bb2a97856 Bug 1580485 - Start search worker on lazily. r=jlast
Took care to only call .task once. Maybe it would be nice to move this functionality inside `WorkerDispatcher`?

Differential Revision: https://phabricator.services.mozilla.com/D45534

--HG--
extra : moz-landing-system : lando
2019-09-12 18:41:51 +00:00
Coroiu Cristina
b7a3c598ec Backed out changeset 0a227ecdcca5 (bug 1580485) for debugger failure on a CLOSED TREE 2019-09-12 21:20:32 +03:00
Sorin Davidoi
f783c40e10 Bug 1579990 - Start pretty print worker lazily. r=jlast,Honza
Start pretty print worker only when pretty printing for the first time.

Differential Revision: https://phabricator.services.mozilla.com/D45241

--HG--
extra : moz-landing-system : lando
2019-09-12 16:40:36 +00:00
Sorin Davidoi
c9a76c17f4 Bug 1580485 - Start search worker on lazily. r=jlast
Took care to only call .task once. Maybe it would be nice to move this functionality inside `WorkerDispatcher`?

Differential Revision: https://phabricator.services.mozilla.com/D45534

--HG--
extra : moz-landing-system : lando
2019-09-12 16:31:38 +00:00
Logan Smyth
62539da15f Bug 1580645 - Ensure that node removal only removes mutation BPs in subtree. r=davidwalsh
Differential Revision: https://phabricator.services.mozilla.com/D44296

--HG--
extra : moz-landing-system : lando
2019-09-12 15:33:51 +00:00
David Walsh
d8814e5764 Bug 1580636 - Set inline preview left before injection r=jlast
Differential Revision: https://phabricator.services.mozilla.com/D45606

--HG--
extra : moz-landing-system : lando
2019-09-12 14:29:31 +00:00
Razvan Maries
197ecba57e Backed out changeset c7e276985276 (bug 1580636) for ES Lint failure. CLOSED TREE 2019-09-12 17:08:46 +03:00
David Walsh
8f28239f59 Bug 1580636 - Set inline preview left before injection r=jlast
Differential Revision: https://phabricator.services.mozilla.com/D45606

--HG--
extra : moz-landing-system : lando
2019-09-12 02:52:27 +00:00
Ola Gasidlo
caf9aff884 Bug 1565213 - Add routing for sidebar component, r=ladybenko
Add routing for sidebar component

Differential Revision: https://phabricator.services.mozilla.com/D43726

--HG--
extra : moz-landing-system : lando
2019-09-12 12:55:46 +00:00
Mark Banner
efc1831d10 Bug 1330148 - Remove no-iterator ESLint exclusions on devtools since there are no violations now. r=jdescottes
Depends on D45400

Differential Revision: https://phabricator.services.mozilla.com/D45401

--HG--
extra : moz-landing-system : lando
2019-09-12 08:02:40 +00:00
Gabriel Luong
039a070103 Bug 1580545 - Convert ResponsiveUI and ResponsiveUIManager to ES6 classes. r=mtigley
Differential Revision: https://phabricator.services.mozilla.com/D45566

--HG--
extra : moz-landing-system : lando
2019-09-11 18:51:35 +00:00
jaril
240a0d48f8 Bug 1567966 - Add search to event listener breakpoints panel. r=davidwalsh
Differential Revision: https://phabricator.services.mozilla.com/D42436

--HG--
extra : moz-landing-system : lando
2019-09-11 18:55:20 +00:00
Gabriel Luong
dcd3f3a19f Bug 1580312 - Refactor ResponsiveUI into its own module. r=mtigley
Differential Revision: https://phabricator.services.mozilla.com/D45443

--HG--
rename : devtools/client/responsive/manager.js => devtools/client/responsive/ui.js
extra : moz-landing-system : lando
2019-09-10 21:36:07 +00:00
Jason Laster
43f6a1b816 Bug 1580362 - Rewinding while recording should rewind to the last breakpoint. r=bhackett
Differential Revision: https://phabricator.services.mozilla.com/D45473

--HG--
extra : moz-landing-system : lando
2019-09-11 04:16:15 +00:00
Jason Laster
6dd9c29f22 Bug 1579658 - Hovering on the console jump button should update the viewport. r=bhackett
Differential Revision: https://phabricator.services.mozilla.com/D45133

--HG--
extra : moz-landing-system : lando
2019-09-11 03:43:30 +00:00
Jason Laster
c91c3ac848 Bug 1578602 - Update buttons ux. r=bhackett
Differential Revision: https://phabricator.services.mozilla.com/D45131

--HG--
extra : moz-landing-system : lando
2019-09-11 15:58:22 +00:00
Yura Zenevich
92b64e718f Bug 1578494 - make MOUSE_INTERACTIVE_ONLY failure check less strict and only look at click action. r=nchevobbe
Depends on D45217

Differential Revision: https://phabricator.services.mozilla.com/D45218

--HG--
extra : moz-landing-system : lando
2019-09-11 08:04:40 +00:00
Yura Zenevich
1ed731d560 Bug 1578494 - ignore images inside anchors for semantic check as they get a propagated jump action. r=nchevobbe
Depends on D45216

Differential Revision: https://phabricator.services.mozilla.com/D45217

--HG--
extra : moz-landing-system : lando
2019-09-11 13:59:23 +00:00
Yura Zenevich
d7ee1a870c Bug 1578494 - ignore valid labels with "label for" relations as they are clickable. r=nchevobbe
Depends on D45215

Differential Revision: https://phabricator.services.mozilla.com/D45216

--HG--
extra : moz-landing-system : lando
2019-09-10 15:48:25 +00:00
Yura Zenevich
9e5e47e8ff Bug 1578494 - separate accessible roles into the ones that are expected to be interactive from keyboard accessible ones, better account for ARIA comboboxes and listboxes. r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D45215

--HG--
extra : moz-landing-system : lando
2019-09-11 14:09:03 +00:00