2 Commits

Author	SHA1	Message	Date
Kris Maglione	257d9118dc	Bug 1409249: Require singleton constructors to return explicit already_AddRefed. r=froydnj ... Right now, NS_GENERIC_FACTORY_SINGLETON_CONSTRUCTOR expects singleton constructors to return already-addrefed raw pointers, and while it accepts constructors that return already_AddRefed, most existing don't do so. Meanwhile, the convention elsewhere is that a raw pointer return value is owned by the callee, and that the caller needs to addref it if it wants to keep its own reference to it. The difference in convention makes it easy to leak (I've definitely caused more than one shutdown leak this way), so it would be better if we required the singleton getters to return an explicit already_AddRefed, which would behave the same for all callers. This also cleans up several singleton constructors that left a dangling pointer to their singletons when their initialization methods failed, when they released their references without clearing their global raw pointers. MozReview-Commit-ID: 9peyG4pRYcr --HG-- extra : rebase_source : 2f5bd89c17cb554541be38444672a827c1392f3f	2017-10-16 21:08:42 -07:00
Birunthan Mohanathas	296aa63730	Bug 1164717 - Flatten storage/src/ directory. r=mak ... --HG-- rename : storage/src/FileSystemModule.cpp => storage/FileSystemModule.cpp rename : storage/src/FileSystemModule.h => storage/FileSystemModule.h rename : storage/src/IStorageBindingParamsInternal.h => storage/IStorageBindingParamsInternal.h rename : storage/src/SQLCollations.cpp => storage/SQLCollations.cpp rename : storage/src/SQLCollations.h => storage/SQLCollations.h rename : storage/src/SQLiteMutex.h => storage/SQLiteMutex.h rename : storage/src/StorageBaseStatementInternal.cpp => storage/StorageBaseStatementInternal.cpp rename : storage/src/StorageBaseStatementInternal.h => storage/StorageBaseStatementInternal.h rename : storage/src/TelemetryVFS.cpp => storage/TelemetryVFS.cpp rename : storage/src/VacuumManager.cpp => storage/VacuumManager.cpp rename : storage/src/VacuumManager.h => storage/VacuumManager.h rename : storage/src/Variant.h => storage/Variant.h rename : storage/src/Variant_inl.h => storage/Variant_inl.h rename : storage/src/mozStorageArgValueArray.cpp => storage/mozStorageArgValueArray.cpp rename : storage/src/mozStorageArgValueArray.h => storage/mozStorageArgValueArray.h rename : storage/src/mozStorageAsyncStatement.cpp => storage/mozStorageAsyncStatement.cpp rename : storage/src/mozStorageAsyncStatement.h => storage/mozStorageAsyncStatement.h rename : storage/src/mozStorageAsyncStatementExecution.cpp => storage/mozStorageAsyncStatementExecution.cpp rename : storage/src/mozStorageAsyncStatementExecution.h => storage/mozStorageAsyncStatementExecution.h rename : storage/src/mozStorageAsyncStatementJSHelper.cpp => storage/mozStorageAsyncStatementJSHelper.cpp rename : storage/src/mozStorageAsyncStatementJSHelper.h => storage/mozStorageAsyncStatementJSHelper.h rename : storage/src/mozStorageAsyncStatementParams.cpp => storage/mozStorageAsyncStatementParams.cpp rename : storage/src/mozStorageAsyncStatementParams.h => storage/mozStorageAsyncStatementParams.h rename : storage/src/mozStorageBindingParams.cpp => storage/mozStorageBindingParams.cpp rename : storage/src/mozStorageBindingParams.h => storage/mozStorageBindingParams.h rename : storage/src/mozStorageBindingParamsArray.cpp => storage/mozStorageBindingParamsArray.cpp rename : storage/src/mozStorageBindingParamsArray.h => storage/mozStorageBindingParamsArray.h rename : storage/src/mozStorageConnection.cpp => storage/mozStorageConnection.cpp rename : storage/src/mozStorageConnection.h => storage/mozStorageConnection.h rename : storage/src/mozStorageError.cpp => storage/mozStorageError.cpp rename : storage/src/mozStorageError.h => storage/mozStorageError.h rename : storage/src/mozStoragePrivateHelpers.cpp => storage/mozStoragePrivateHelpers.cpp rename : storage/src/mozStoragePrivateHelpers.h => storage/mozStoragePrivateHelpers.h rename : storage/src/mozStorageResultSet.cpp => storage/mozStorageResultSet.cpp rename : storage/src/mozStorageResultSet.h => storage/mozStorageResultSet.h rename : storage/src/mozStorageRow.cpp => storage/mozStorageRow.cpp rename : storage/src/mozStorageRow.h => storage/mozStorageRow.h rename : storage/src/mozStorageSQLFunctions.cpp => storage/mozStorageSQLFunctions.cpp rename : storage/src/mozStorageSQLFunctions.h => storage/mozStorageSQLFunctions.h rename : storage/src/mozStorageService.cpp => storage/mozStorageService.cpp rename : storage/src/mozStorageService.h => storage/mozStorageService.h rename : storage/src/mozStorageStatement.cpp => storage/mozStorageStatement.cpp rename : storage/src/mozStorageStatement.h => storage/mozStorageStatement.h rename : storage/src/mozStorageStatementData.h => storage/mozStorageStatementData.h rename : storage/src/mozStorageStatementJSHelper.cpp => storage/mozStorageStatementJSHelper.cpp rename : storage/src/mozStorageStatementJSHelper.h => storage/mozStorageStatementJSHelper.h rename : storage/src/mozStorageStatementParams.cpp => storage/mozStorageStatementParams.cpp rename : storage/src/mozStorageStatementParams.h => storage/mozStorageStatementParams.h rename : storage/src/mozStorageStatementRow.cpp => storage/mozStorageStatementRow.cpp rename : storage/src/mozStorageStatementRow.h => storage/mozStorageStatementRow.h rename : storage/src/variantToSQLiteT_impl.h => storage/variantToSQLiteT_impl.h	2015-05-19 10:47:33 -07:00