Commit Graph

2283 Commits

Author SHA1 Message Date
Andrea Marchesini
410cb724a7 Bug 1585284 - Force global in Blob CTOR, r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D49629

--HG--
extra : moz-landing-system : lando
2019-10-21 05:33:19 +00:00
Razvan Maries
f9d8db28af Backed out 5 changesets (bug 1583251) for rust build bustages. CLOSED TREE
Backed out changeset bfe390ad771b (bug 1583251)
Backed out changeset 0113c698b44d (bug 1583251)
Backed out changeset 248ad59168dd (bug 1583251)
Backed out changeset 5d5e3dc17118 (bug 1583251)
Backed out changeset 9e9eaa78c436 (bug 1583251)
2019-10-18 17:59:20 +03:00
Geoff Brown
32490358c2 Bug 1585119 - Re-enable many more mochitests on Android; r=geckoview-reviewers,snorp
Most of these tests have been disabled for a long time; they run well
in the current test environment.
I intend to enable still more mochitests in a future patch.

Differential Revision: https://phabricator.services.mozilla.com/D49524

--HG--
extra : moz-landing-system : lando
2019-10-18 14:35:20 +00:00
Tom Tung
5ba65c0735 Bug 1583251 - P3 - Check if it is okay to allow shared memory while deserializing; r=nika,lth
Differential Revision: https://phabricator.services.mozilla.com/D48349

--HG--
extra : moz-landing-system : lando
2019-10-15 13:42:25 +00:00
Sebastian Streich
854f9b5f12 Bug 1585331 - Add nsIPrincipal::GetAboutModuleFlags r=ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D47775

--HG--
extra : moz-landing-system : lando
2019-10-17 13:54:41 +00:00
Simon Giesecke
ed63d87f12 Bug 1168606 - Fix code generation issue on Mac OS X. r=acreskey,ttung
As reported in https://bugzilla.mozilla.org/show_bug.cgi?id=1168606#c110,
some Mac OS X release build crashes with the original code, probably due
to some temporary string being destroyed prematurely. Assigning to a
named variable reportedly solves the issue.

Differential Revision: https://phabricator.services.mozilla.com/D49422

--HG--
extra : moz-landing-system : lando
2019-10-17 09:55:03 +00:00
Simon Giesecke
776d715465 Bug 1565224 - Added tests for Key::Set* and Key::CompareKeys. r=ttung,asuth
In addition to the tests added before, which test the decoding of encoded
keys, this adds test for other member functions of Key.

Differential Revision: https://phabricator.services.mozilla.com/D39005

--HG--
extra : moz-landing-system : lando
2019-10-14 14:46:55 +00:00
Simon Giesecke
624bd4d6a8 Bug 1565224 - Added some initial gtests for dom/indexedDB/Key. r=ttung,asuth
Differential Revision: https://phabricator.services.mozilla.com/D38360

--HG--
extra : moz-landing-system : lando
2019-10-14 14:47:18 +00:00
Simon Giesecke
49db1f8c5f Bug 1586189 - Provide useful assertion messages. r=ttung
Differential Revision: https://phabricator.services.mozilla.com/D48712

--HG--
extra : moz-landing-system : lando
2019-10-10 07:17:16 +00:00
Jan Varga
be1002620d Bug 1587263 - IDB: Use specialized directory locks for database maintenances; r=asuth
Differential Revision: https://phabricator.services.mozilla.com/D48658

--HG--
extra : moz-landing-system : lando
2019-10-11 03:03:01 +00:00
Simon Giesecke
7e3b8fe633 Bug 1558522 - Ensure that file actors created after the database was closed are expired. r=asuth
Differential Revision: https://phabricator.services.mozilla.com/D48046

--HG--
extra : moz-landing-system : lando
2019-10-09 03:21:22 +00:00
Simon Giesecke
840f75da74 Bug 1168606 - Replaced custom for loops by range-based for or STL algorithms. r=ttung
Differential Revision: https://phabricator.services.mozilla.com/D44988

--HG--
extra : moz-landing-system : lando
2019-10-03 07:56:57 +00:00
Simon Giesecke
cd0b6f05a1 Bug 1168606 - Use const where easily possible. r=ttung,asuth
Differential Revision: https://phabricator.services.mozilla.com/D43631

--HG--
extra : moz-landing-system : lando
2019-10-03 07:56:45 +00:00
Simon Giesecke
16d87d7487 Bug 1168606 - Avoid copying keys on cursor creation. r=ttung,asuth
Differential Revision: https://phabricator.services.mozilla.com/D43470

--HG--
extra : moz-landing-system : lando
2019-10-03 07:56:32 +00:00
Jan Varga
ae7651951f Bug 1584323 - Add more object properties to IndexedDBShutdownTimeout and LocalStorageShutdownTimeout crash annotations; r=asuth, dr=chutten
Differential Revision: https://phabricator.services.mozilla.com/D47341

--HG--
extra : moz-landing-system : lando
2019-10-02 04:28:23 +00:00
Oana Pop Rus
cb31d323be Backed out 5 changesets (bug 1168606) for xpcshell failures in dom/indexedDB/test/unit/test_temporary_storage.js on a CLOSED TREE
Backed out changeset fc5e1bee1332 (bug 1168606)
Backed out changeset 63cf0966cb41 (bug 1168606)
Backed out changeset f844afbebc6a (bug 1168606)
Backed out changeset 9e7a90dcc429 (bug 1168606)
Backed out changeset e493a6b5f125 (bug 1168606)
2019-10-02 02:28:15 +03:00
Simon Giesecke
3feb8e1ebe Bug 1168606 - Send two records with every ObjectStoreCursorResponse. r=ttung,asuth
Differential Revision: https://phabricator.services.mozilla.com/D43252

--HG--
extra : moz-landing-system : lando
2019-10-01 09:15:49 +00:00
Simon Giesecke
8b0c6aa21d Bug 1168606 - Replaced custom for loops by range-based for or STL algorithms. r=ttung
Differential Revision: https://phabricator.services.mozilla.com/D44988

--HG--
extra : moz-landing-system : lando
2019-10-01 09:14:21 +00:00
Simon Giesecke
a9cf10ae19 Bug 1168606 - Use const where easily possible. r=ttung,asuth
Differential Revision: https://phabricator.services.mozilla.com/D43631

--HG--
extra : moz-landing-system : lando
2019-10-01 09:14:04 +00:00
Simon Giesecke
0438fc4336 Bug 1168606 - Avoid copying keys on cursor creation. r=ttung,asuth
Differential Revision: https://phabricator.services.mozilla.com/D43470

--HG--
extra : moz-landing-system : lando
2019-10-01 08:56:37 +00:00
Gabriele Svelto
10d41866a5 Bug 1585156 - Remove useless inclusions of nsIDOMWindow.h and nsIDOMWindowUtils.h r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D47678

--HG--
extra : moz-landing-system : lando
2019-09-30 22:06:47 +00:00
Simon Giesecke
470b2174a1 Bug 1168606 - Allow current key to be provided with PBackgroundIDBCursor::Continue. r=ttung,asuth
The key is assumed to be unset for now.

Differential Revision: https://phabricator.services.mozilla.com/D43251

--HG--
extra : moz-landing-system : lando
2019-09-27 10:11:41 +00:00
Simon Giesecke
bd2e4939bc Bug 1168606 - Remove duplication in uses of IDB_LOG_MARK. r=ttung,asuth
Differential Revision: https://phabricator.services.mozilla.com/D46576

--HG--
extra : moz-landing-system : lando
2019-09-27 10:11:45 +00:00
Yaron Tausky
6214b585a0 Bug 1577107 - Avoid following the prototype chain r=janv
With this commit we no longer follow the value's prototype chain when
creating index updates in IndexedDB.

Differential Revision: https://phabricator.services.mozilla.com/D44438

--HG--
extra : moz-landing-system : lando
2019-09-27 13:36:25 +00:00
Simon Giesecke
a1dce92fcd Bug 1578453 - Correctly calculate response size in IndexGetKeyRequestOp::GetResponse and ObjectStoreGetKeyRequestOp::GetResponse r=ttung,asuth
Before this, the response size was always calculated as 0, since it used the swapped-out array.
In addition, make use of std::accumulate to increase idiomacy.

Differential Revision: https://phabricator.services.mozilla.com/D44806

--HG--
extra : moz-landing-system : lando
2019-09-26 21:49:54 +00:00
Brindusan Cristian
f892c56fa2 Backed out changeset e91773704fbd (bug 1577107) for wpt crashes/assertions on clone-before-keypath-eval.html. CLOSED TREE
--HG--
extra : histedit_source : 65f613208b85a94eef3de04365bc8e4e87585ac8
2019-09-26 20:11:03 +03:00
Yaron Tausky
b9add81961 Bug 1577107 - Avoid following the prototype chain r=janv
With this commit we no longer follow the value's prototype chain when
creating index updates in IndexedDB.

Differential Revision: https://phabricator.services.mozilla.com/D44438

--HG--
extra : moz-landing-system : lando
2019-09-13 09:35:09 +00:00
Sebastian Streich
88670a47e9 Bug 1580782 - Change Callsites to use nsIPrincipal->SchemeIs r=ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D45654

--HG--
extra : moz-landing-system : lando
2019-09-26 10:47:16 +00:00
Mihai Alexandru Michis
4e1448e7e6 Backed out 2 changesets (bug 1510226) for causing xpcshell crashes and xpcshell failures in test_TelemetrySession.js CLOSED TREE
Backed out changeset cb739de6606d (bug 1510226)
Backed out changeset b6f670610dc3 (bug 1510226)
2019-09-25 04:25:07 +03:00
Doug Thayer
65be2b22c1 Bug 1510226 - Remove vestigial references to cooperative scheduling r=froydnj
GetCurrentPhysicalThread and GetCurrentVirtualThread are, in practice,
identical, as the TLS override that GetCurrentVirtualThread depends on
is never actually set. This simply removes that and renames some things/
deletes some comments.

Differential Revision: https://phabricator.services.mozilla.com/D41247

--HG--
extra : moz-landing-system : lando
2019-08-20 18:03:11 +00:00
Ehsan Akhgari
021b9b9087 Bug 1552800 - Instead of assuming success, do proper error checking; r=asuth
Differential Revision: https://phabricator.services.mozilla.com/D46600

--HG--
extra : moz-landing-system : lando
2019-09-24 12:39:24 +00:00
Boris Zbarsky
e26682d684 Bug 1581173 part 1. Add a way to more easily throw TypeErrors and RangeErrors with custom message strings via ErrorResult. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D45932

--HG--
extra : moz-landing-system : lando
2019-09-20 02:19:18 +00:00
Simon Giesecke
89e37616c3 Bug 1168606 - Refactored tests, reduced duplicated code. r=ttung,asuth
Differential Revision: https://phabricator.services.mozilla.com/D43250

--HG--
extra : moz-landing-system : lando
2019-09-18 06:43:08 +00:00
Simon Giesecke
e6e5f01c36 Bug 1168606 - Apply renamings suggested for Cursor::*Key members and related identifiers. r=ytausky,asuth
Differential Revision: https://phabricator.services.mozilla.com/D43249

--HG--
extra : moz-landing-system : lando
2019-09-18 06:41:35 +00:00
Simon Giesecke
27297c9cf8 Bug 1168606 - Inline Key::Assert function to make effective use of MOZ_ASSERT diagnostics. r=ttung,asuth
Differential Revision: https://phabricator.services.mozilla.com/D43039

--HG--
extra : moz-landing-system : lando
2019-09-18 06:41:23 +00:00
Simon Giesecke
8158af97af Bug 1168606 - Make limit parameter a statement parameter. r=ytausky,asuth
Differential Revision: https://phabricator.services.mozilla.com/D43038

--HG--
extra : moz-landing-system : lando
2019-09-18 06:41:11 +00:00
Simon Giesecke
6d939ca292 Bug 1168606 - Refactored building of key range and direction clauses. r=ttung,asuth
To align with the coding style, GetBindingClauseForKeyRange should return its
result rather than by modifying an output parameter.

Differential Revision: https://phabricator.services.mozilla.com/D42853

--HG--
extra : moz-landing-system : lando
2019-09-18 06:40:53 +00:00
Simon Giesecke
433dbe0b8e Bug 1168606 - Remove code duplication in DatabaseOperationBase::BindKeyRangeToStatement overloads r=ttung,asuth
Differential Revision: https://phabricator.services.mozilla.com/D42852

--HG--
extra : moz-landing-system : lando
2019-09-18 06:40:40 +00:00
Simon Giesecke
19bf854bca Bug 1168606 - Move the functionality of OpenOp::GetKeyRangeInfo to Cursor::SetOptionalKeyRange r=ttung,asuth
Also avoid unnecessary copying of the non-locale-based key in case the locale-based is needed, and reduced code duplication and variable scoping. r=ttung

Differential Revision: https://phabricator.services.mozilla.com/D41404

--HG--
extra : moz-landing-system : lando
2019-09-18 06:40:28 +00:00
Simon Giesecke
f408d617b9 Bug 1580195 - Exclude calls of open(name, {}) and open(name) from telemetry. r=ttung,asuth
Differential Revision: https://phabricator.services.mozilla.com/D45812

--HG--
extra : moz-landing-system : lando
2019-09-13 16:55:13 +00:00
Simon Giesecke
2bb315d0cf Bug 1093064 - Repeat garbage collection until ref count becomes 0 r=janv
Differential Revision: https://phabricator.services.mozilla.com/D42609

--HG--
extra : moz-landing-system : lando
2019-09-13 14:02:20 +00:00
Boris Zbarsky
14c30e58d6 Bug 1578173 part 4. Switch event subclasses to constructor operations. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D45391

--HG--
extra : moz-landing-system : lando
2019-09-11 14:35:28 +00:00
Simon Giesecke
76e17f42d9 Bug 1168606 - Extract DatabaseConnection::ExecuteCachedStatement function. r=ytausky,asuth
Differential Revision: https://phabricator.services.mozilla.com/D41225

--HG--
extra : moz-landing-system : lando
2019-09-11 13:07:05 +00:00
Simon Giesecke
11c156d4b5 Bug 1168606 - Unified handling of literal strings using NS_LITERAL_(C)STRING and removed some duplications. r=ttung,asuth
Harmonized and provided a rationale for defining statement parameter names literally vs. by named constant,
and referencing them in binding calls by index vs. by name.

Differential Revision: https://phabricator.services.mozilla.com/D41026

--HG--
extra : moz-landing-system : lando
2019-09-11 13:02:38 +00:00
Simon Giesecke
8612ca8e4b Bug 1168606 - Extracted methods Cursor::OpenOp::PrepareKeyConditionClauses and PrepareIndexKeyConditionClause. r=ttung,asuth
Also reduced duplication within the extracted methods.

Differential Revision: https://phabricator.services.mozilla.com/D41025

--HG--
extra : moz-landing-system : lando
2019-09-11 11:51:35 +00:00
Simon Giesecke
95342c2fde Bug 1168606 - Reduce code duplication for different open cursor variants. r=ttung,asuth
Differential Revision: https://phabricator.services.mozilla.com/D40956

--HG--
extra : moz-landing-system : lando
2019-09-11 11:51:24 +00:00
Simon Giesecke
f4cb5f1dee Bug 1168606 - Change definition of OpenCursorParams subtypes to allow reducing duplicated code r=ttung,asuth
Differential Revision: https://phabricator.services.mozilla.com/D40955

--HG--
extra : moz-landing-system : lando
2019-09-11 11:51:26 +00:00
Simon Giesecke
abad982ec4 Bug 1168606 - Reduce the use of plain pointers, and use const for Cursor data members where possible. r=ttung
Differential Revision: https://phabricator.services.mozilla.com/D40954

--HG--
extra : moz-landing-system : lando
2019-09-11 11:51:28 +00:00
Simon Giesecke
860d44f9b4 Bug 1168606 - Added comments on almost-const data members r=ttung,asuth
Differential Revision: https://phabricator.services.mozilla.com/D42645

--HG--
extra : moz-landing-system : lando
2019-09-11 11:51:20 +00:00
Simon Giesecke
024bb0ac16 Bug 1168606 - Added documentation on Cursor data members. r=asuth
Differential Revision: https://phabricator.services.mozilla.com/D41403

--HG--
extra : moz-landing-system : lando
2019-09-11 11:51:22 +00:00