Commit Graph

27878 Commits

Author SHA1 Message Date
James Willcox
61ca9441b1 Bug 1525959 - Skip some mochitests tests under GeckoView r=geckoview-reviewers,esawin
There are few things that are either Fennec-specific or don't work
currently under GeckoView w/ e10s under TestRunnerActivity. Disable
these so we can get some testing going in automation.

This also replaces 'isFennec' with the more correct 'is_fennec'.

Differential Revision: https://phabricator.services.mozilla.com/D19016

--HG--
extra : moz-landing-system : lando
2019-02-27 15:01:43 +00:00
Oana Pop Rus
eda7a08ec6 Backed out changeset b63cae045a63 (bug 1462018) for geckoview failures 2019-02-27 14:42:59 +02:00
Emily Toop
c616a388d1 Bug 1462018 - Add API for taking screenshot of visible page. r=geckoview-reviewers,snorp
Invert screen pixels in `nsWindow`.

Update `RequestScreenPixels` in `nsWindow` to accept a `GeckoResult` as an argument and save as a `GlobalRef`.
Update `RecvScreenPixels` in `nsWindow` in order to invert the image before sending over JNI rather than requiring callers to invert the image themselves.
Complete the `GeckoResult` if there is one in `RecvScreenPixels` instead of making a callback to the compositor.

Remove `RecvScreenPixels` from `GeckoSession` and `GeckoSession.Compositor`.
Move `RecvScreenPixels` and `getPixels` to `GeckoDisplay`
Rename `getPixels` to `capturePixels`

Return Bitmap from `RecvScreenPixels`.

Return `GeckoResult` from `capturePixels`.

Add doc comments to new methods and classes.
Update FennecNativeDriver to use `GeckoView` and `GeckoResult`.

Update API docs and Changelog

Add tests

Differential Revision: https://phabricator.services.mozilla.com/D18944

--HG--
extra : moz-landing-system : lando
2019-02-26 10:51:02 +00:00
Makoto Kato
f6085c16d6 Bug 1524926 - Move some CSS files from mobile/android to toolkit. r=geckoview-reviewers,snorp
Although about.css, aboutMemory.css and aboutSupport.css are mobile-specific
style, these CSS files are used in toolkit, not mobile/android.
Since GeckoView doesn't has chrome.jar, these files are missing. So we should
move these CSS files to toolkit since we have mobile theme in toolkit.

Differential Revision: https://phabricator.services.mozilla.com/D20792

--HG--
rename : mobile/android/themes/core/about.css => toolkit/themes/mobile/global/about.css
rename : mobile/android/themes/core/aboutMemory.css => toolkit/themes/mobile/global/aboutMemory.css
rename : mobile/android/themes/core/aboutSupport.css => toolkit/themes/mobile/global/aboutSupport.css
extra : moz-landing-system : lando
2019-02-26 14:54:45 +00:00
Jan Henning
2a0386d4c6 Bug 1529367 - Part 2: Minor intent processing optimisation. r=snorp
The extension is only ever used for local files, so don't bother retrieving it
otherwise.

Differential Revision: https://phabricator.services.mozilla.com/D21049

--HG--
extra : moz-landing-system : lando
2019-02-26 14:54:27 +00:00
Jan Henning
8ff617cb88 Bug 1529367 - Part 1: Don't send MIME type when querying external apps for non-local HTML documents. r=geckoview-reviewers,snorp
Differential Revision: https://phabricator.services.mozilla.com/D20861

--HG--
extra : moz-landing-system : lando
2019-02-25 20:07:55 +00:00
Jan Henning
eb564828c4 Bug 1529258 - Part 2: Catch apps that register only generic HTTPS handlers, too. r=geckoview-reviewers,snorp
While it's not clear how many apps might still have a generic HTTP-only intent-
filter at this stage, we only collect that information once per session, so to
be on the safe side we still check both schemes separately and merge the data.

Differential Revision: https://phabricator.services.mozilla.com/D20860

--HG--
extra : moz-landing-system : lando
2019-02-25 19:46:28 +00:00
Jan Henning
c8ba1b3b0c Bug 1529258 - Part 1: Slightly modernise HelperApps.jsm r=geckoview-reviewers,agi
Use the more concise way of defining functions and more arrow functions.
Also use a class to define "App" objects.

Differential Revision: https://phabricator.services.mozilla.com/D20859

--HG--
extra : moz-landing-system : lando
2019-02-25 18:50:11 +00:00
Eitan Isaacson
f663d791e3 Bug 1524476 - Don't set the screen origin from synthesized MotionEvents. r=geckoview-reviewers,esawin
Differential Revision: https://phabricator.services.mozilla.com/D20702

--HG--
extra : moz-landing-system : lando
2019-02-22 14:11:32 +00:00
Petru Lingurar
5349aa6e59 Bug 1507531 - FilePicker will request WRITE_EXTERNAL_STORAGE; r=JanH
"Prior to Android 8.0 (API level 26), if an app requested a permission at
runtime and the permission was granted, the system would also incorrectly
grant the app the rest of the permissions that belonged to the same permission
group, and that were registered in the manifest.

For apps targeting Android 8.0, this behavior has been corrected. The app is
granted only the permissions it has explicitly requested. However, once the
user grants a permission to the app, all subsequent requests for permissions
in that permission group are automatically granted."
https://developer.android.com/about/versions/oreo/android-8.0-changes#rmp

Our FilePicker can delegate other applications to record media files
(photo/audio/video) which are then to be sent to websites. They must be saved
locally before the upload, scenario that wasn't possible anymore on Oreo+
because of the change in how Android handles runtime permissions.

As a way to get around this one could grant the "Storage" permission from
System Settings which would grant the app both READ and WRITE access.
But for actually being prepared to handle all situations our FilePicker must
ask for the WRITE_EXTERNAL_STORAGE permission at runtime.

Differential Revision: https://phabricator.services.mozilla.com/D20821

--HG--
extra : moz-landing-system : lando
2019-02-22 15:43:13 +00:00
Thomas Wisniewski
19cbb97ab8 Bug 1488845 - Add an about:compat page to the Webcompat GoFaster addon. r=denschub,kmag,Pike
Add an about:compat page to the Webcompat GoFaster addon.

Differential Revision: https://phabricator.services.mozilla.com/D18303

--HG--
extra : moz-landing-system : lando
2019-02-25 23:10:41 +00:00
Noemi Erli
7e23372938 Merge mozilla-central to autoland. a=merge CLOSED TREE
--HG--
extra : rebase_source : de8796d5d7d7079af1b895a2f537371885f8cc6c
2019-02-26 00:09:40 +02:00
Christoph Kerschbaumer
c8bb3d7749 Bug 1529869: Remove the 2 from speculate speculative(Anonymous)Connect2 within nsISpeculativeConnect.idl. r=valentin 2019-02-24 20:26:56 +01:00
Agi Sferro
ee86fd5efc Bug 1518841 - Allow embedders to load WebExtensions in GeckoView. r=snorp,esawin
Depends On D16913

Differential Revision: https://phabricator.services.mozilla.com/D16268

--HG--
extra : moz-landing-system : lando
2019-02-25 17:00:18 +00:00
Andreea Pavel
f49b3214e3 Backed out changeset 51467afba450 (bug 1518841) for failing eslint at GeckoViewWebExtension.jsm on a CLOSED TREE 2019-02-25 18:53:15 +02:00
Agi Sferro
9ccb6c983d Bug 1518841 - Allow embedders to load WebExtensions in GeckoView. r=snorp,esawin
Depends On D16913

Differential Revision: https://phabricator.services.mozilla.com/D16268

--HG--
extra : moz-landing-system : lando
2019-02-25 15:38:46 +00:00
Agi Sferro
d6b900089c Bug 1522137 - Make resource://android return a nsIJARURI. r=snorp,mayhemer,bzbarsky
resource://android URIs always point to a "jar:" URI so it doesn't make sense
that the returned URL object implements nsIFileURL.

This also makes it so extensions can be loaded from a resource://android URI.

Audited all places where we use `nsIJARURI` and check for places where we
assume it looks like `jar:`: the only (!) place where we do that is here:

https://searchfox.org/mozilla-central/rev/b36e97fc776635655e84f2048ff59f38fa8a4626/dom/xhr/XMLHttpRequestMainThread.cpp#1852

Where we have special handling for `jar:` URIs. It looks like we would have
less special handling for such a request to a `resource://android` and it could
be fixed by just checking for the interface instead, but that's what's already
happening today so it should work. That code is never reached for
`resource://android` URIs as `mIsMappedArrayBuffer` is false for those URIs
(see #2822). And the code is consistent in checking for the scheme instead of
the interface (the other check is here:
https://searchfox.org/mozilla-central/rev/b36e97fc776635655e84f2048ff59f38fa8a4626/dom/xhr/XMLHttpRequestMainThread.cpp#2822)

Audited all places where we do `EqualsLiteral("jar")`:
https://searchfox.org/mozilla-central/search?q=.EqualsLiteral%28%22jar%22%29&path=

`SubstituteRemoteChannel`: looks interesting, but uses
`nsISubstitutingProtocolHandler::ResolveURI` to first get the real URI (which
is a `jar:`) so it works for our case.

https://searchfox.org/mozilla-central/rev/b36e97fc776635655e84f2048ff59f38fa8a4626/netwerk/protocol/res/ExtensionProtocolHandler.cpp#414

`SubstitutingProtocolHandler.cpp`

This case is explicitly fixed by this change, making it account for both
`"jar"` and `"resource"`.

https://searchfox.org/mozilla-central/rev/b36e97fc776635655e84f2048ff59f38fa8a4626/netwerk/protocol/res/SubstitutingProtocolHandler.cpp#299

`ReadSourceFromFileName`: this also looks interesting, but uses the channel to
get the URI which returns the real `"jar"` URI and not the mapped `"resource"`.

https://searchfox.org/mozilla-central/rev/b36e97fc776635655e84f2048ff59f38fa8a4626/js/xpconnect/src/XPCJSRuntime.cpp#2837

`nsStringBundle.cpp`

Accounts for both `"jar"` and `"resource"`, so it should work the same.

https://searchfox.org/mozilla-central/rev/b36e97fc776635655e84f2048ff59f38fa8a4626/intl/strres/nsStringBundle.cpp#437

Audited all places where we use `nsINestedURI` to make sure they would work for
a `nsIJARURI` which does not implement `nsINestedURI`.

`BrowserContentHandler.jsm`

Uses `nsINestedURI` to figure out if a URI is local or not and then it checks
whether it's a `"file"`, `"resource"` or `"chrome"` URI, for a `nsIJARURI &
nsINestedURI` it would return a `"file"` which passes the test, for a
`nsIJARURI` alone it would return `"resource"` which is also considered local
by this code, so the result wouldn't change.

https://searchfox.org/mozilla-central/rev/b36e97fc776635655e84f2048ff59f38fa8a4626/browser/components/BrowserContentHandler.jsm#395-399

`nsScriptSecurityManager.cpp`

`GetOriginFromURI`: This is the reason why `SubstitutingJARURI` doesn't
implement `nsINestedURI`, the origin is computed starting from the innermost
URI, which in our case would be a file. The behavior in our case is that the
origin from a `resource://android` URI behaves like other `resource://` URIs,
which is what we expect.

https://searchfox.org/mozilla-central/rev/b36e97fc776635655e84f2048ff59f38fa8a4626/caps/nsScriptSecurityManager.cpp#169

`CheckLoadURIWithPrincipal`: for `nsIJARURI & nsINestedURI` this code will only
allow pages from the same jar to be in the same origin (which is correct), for
`nsIJARURI` this code is unreachable and it would allow every
`resource://android` to load every other `resource://android` URI (which is
essentially the same thing).

https://searchfox.org/mozilla-central/rev/b36e97fc776635655e84f2048ff59f38fa8a4626/caps/nsScriptSecurityManager.cpp#874-876

`nsDocShell.cpp`

`DisplayLoadError`: Just looping through the nested URI chain to build an error
message, no concerns here (it would just ignore the `jar:` part, which is
fine).

https://searchfox.org/mozilla-central/rev/b36e97fc776635655e84f2048ff59f38fa8a4626/docshell/base/nsDocShell.cpp#3986

`DoURILoad`: Looking for `view-source`, no concerns for `resource://android`.

https://searchfox.org/mozilla-central/rev/b36e97fc776635655e84f2048ff59f38fa8a4626/docshell/base/nsDocShell.cpp#9645

`nsObjectLoadingContent.cpp`

Also looking for `view-source`, no concerns.

https://searchfox.org/mozilla-central/rev/b36e97fc776635655e84f2048ff59f38fa8a4626/dom/base/nsObjectLoadingContent.cpp#2004

`nsIconURI.cpp`/`nsIconURI.h`

Exposing `nsINestedURI`. No concerns.

https://searchfox.org/mozilla-central/rev/b36e97fc776635655e84f2048ff59f38fa8a4626/image/decoders/icon/nsIconURI.cpp#58

`nsJARURI.cpp`/`nsJARURI.h`

Exposing `nsINestedURI`, the subject of this audit.

https://searchfox.org/mozilla-central/rev/b36e97fc776635655e84f2048ff59f38fa8a4626/modules/libjar/nsJARURI.cpp#45

`nsIOService.cpp`

`URIChainHasFlags`: This code looks at the chain of nested URIs to figure out
if the chain of protocols has a certain flags. for `nsIJARURI & nsINestedURI`
it would look at both `jar:` and `file:` protocols, while in `nsIJARURI` it
would only look at the `resource:` protocol, which is our intention, since we
want this URI to be treated like a `resource:` URI and nothing else. Note the
`resource:` URI is always local (enforced by `NewURI`), so this should be ok.

https://searchfox.org/mozilla-central/rev/b36e97fc776635655e84f2048ff59f38fa8a4626/netwerk/base/nsIOService.cpp#1494

`nsNetUtil.cpp`/`nsNetUtil.h`

Implementation of `NS_ImplGetInnermostURI`, which wouldn't work for `nsIJARURI`
alone, as expected.

https://searchfox.org/mozilla-central/rev/b36e97fc776635655e84f2048ff59f38fa8a4626/netwerk/base/nsNetUtil.h#704

`nsSimpleNestedURI.cpp`/`nsSimpleNestedURI.h`

Implementing `nsINestedURI` for `nsSimpleNestedURI`, no concerns.

https://searchfox.org/mozilla-central/rev/b36e97fc776635655e84f2048ff59f38fa8a4626/netwerk/base/nsSimpleNestedURI.cpp#19

`nsViewSourceHandler.cpp`

Looking at `view-source` inner URI to get the flags, no concerns.

https://searchfox.org/mozilla-central/rev/b36e97fc776635655e84f2048ff59f38fa8a4626/netwerk/protocol/viewsource/nsViewSourceHandler.cpp#49

`nsHtml5StreamParser.cpp`/`nsHtml5TreeOpExecutor.cpp`

More `view-source` handling code. No concerns.

https://searchfox.org/mozilla-central/rev/b36e97fc776635655e84f2048ff59f38fa8a4626/parser/html/nsHtml5StreamParser.cpp#310

https://searchfox.org/mozilla-central/rev/b36e97fc776635655e84f2048ff59f38fa8a4626/parser/html/nsHtml5TreeOpExecutor.cpp#884

`DownloadPlatform.cpp`

`IsURLPossiblyFromWeb`: This line is unreachable as the method would return
true because resource has `URI_IS_UI_RESOURCE`.

https://searchfox.org/mozilla-central/rev/b36e97fc776635655e84f2048ff59f38fa8a4626/toolkit/components/downloads/DownloadPlatform.cpp#314

`getAnonymizedPath`: This code looks a little scary, and it's the first one
that seems to conflate the fact that `jar: == nsINestedURI`.

On the android case (line 2130) this code manually replaces the
`resource://android` URI with a `jar:` URI, so it wouldn't matter whether
`resource://android` implements `nsINestedURI` or not.

Actually this code could be a lot easier by using
`nsISubstitutingURL::resolveURI`, maybe I should open a bug.

https://searchfox.org/mozilla-central/rev/b36e97fc776635655e84f2048ff59f38fa8a4626/toolkit/components/search/SearchService.jsm#2148

`getRemoteTypeForURIObject`: This also looks interesting. The switch at line
157 would go straight to line 218 for `resource:` URIs (irrespective of
`nsINestedURI`) and then for `nsINestedURI` we would look at the `jar:` URI
(and eventually the `file:` URI). While for not `nsINestedURI` we would call
straight to `validatedWebRemoteType`. This might return `WEB_REMOTE_TYPE`
instead of `FILE_REMOTE_TYPE`, but since it's already happening it should be ok
(`resource://android` maps _today_ to a `jar:` file that return
`WEB_RETURN_TYPE`)

https://searchfox.org/mozilla-central/rev/b36e97fc776635655e84f2048ff59f38fa8a4626/toolkit/modules/E10SUtils.jsm#150

`getURIHost`:

This is another piece of code that benefits from not implementing
`nsINestedURI` as the host would be correctly `"android"` instead of the apk
path.

https://searchfox.org/mozilla-central/rev/b36e97fc776635655e84f2048ff59f38fa8a4626/toolkit/mozapps/downloads/DownloadUtils.jsm#390

`initDialog`:

Download dialog would show the `resource://android` URI instead of the actual
`jar:` URI, kind of expected.

https://searchfox.org/mozilla-central/rev/b36e97fc776635655e84f2048ff59f38fa8a4626/toolkit/mozapps/downloads/HelperAppDlg.jsm#423

There are no places in the codebase where we do `== "jar"`. Looks like I've
already looked at all hits for "jar" too.

Checked for `"jar:` too and It looks like they are all from code that tries to
build a `jar:` URI manually which is fine for this change.

Audited all `schemeIs("jar")` occurrences:
https://searchfox.org/mozilla-central/search?q=schemeIs(%22jar%22)&path=

`browser-identity.js`

Uses the channel URI which is always resolved to `jar:`, so that works
regardless.  See also:
https://searchfox.org/mozilla-central/rev/b36e97fc776635655e84f2048ff59f38fa8a4626/netwerk/protocol/res/SubstitutingProtocolHandler.cpp#229

https://searchfox.org/mozilla-central/rev/b36e97fc776635655e84f2048ff59f38fa8a4626/browser/base/content/browser-siteIdentity.js#812

`tabbrowser.js`

Only for `scheme == "about"` URIs.

https://searchfox.org/mozilla-central/rev/b36e97fc776635655e84f2048ff59f38fa8a4626/browser/base/content/tabbrowser.js#789

`HelperAppDialog.js`

Treats "jar:" and "resource" the same way.

https://searchfox.org/mozilla-central/rev/dc0adc07db3df9431a0876156f50c65d580010cb/mobile/android/components/HelperAppDialog.js#63

`WebNavigationContent.js`

This code checks if the scheme is "jar" and if the original URI is "resource"
it will use that instead, so in our case it will use the "resource" URI either
way.

https://searchfox.org/mozilla-central/rev/dc0adc07db3df9431a0876156f50c65d580010cb/toolkit/modules/addons/WebNavigationContent.js#158

Depends on D18740

Differential Revision: https://phabricator.services.mozilla.com/D16913

--HG--
extra : moz-landing-system : lando
2019-02-25 15:38:33 +00:00
Agi Sferro
3ba359e0a9 Bug 1522137 - Move resource://android handler to C++. r=mayhemer
This is needed to make the handler to avoid race conditions where some code
tries to access a resource://android URI before the handler has been
registered.

Depends on D18739

Differential Revision: https://phabricator.services.mozilla.com/D18740

--HG--
extra : moz-landing-system : lando
2019-02-25 15:38:21 +00:00
Agi Sferro
31607a16bb Bug 1522137 - Fix HasSubstitution for special cases. r=bzbarsky
Before this change, HasSubstitution would return false for "gre" or "app" which
is incorrect, since these handlers exist.

Differential Revision: https://phabricator.services.mozilla.com/D18739

--HG--
extra : moz-landing-system : lando
2019-02-25 15:38:08 +00:00
Christoph Kerschbaumer
90e6dc3e93 Bug 1518454: Part 3, mobile changes, add CSP to loadURIOptions dictionary and pass CSP explicitly from frontend to docshell. r=snorp 2019-02-12 10:34:24 +01:00
Kartikaya Gupta
b3227123e2 Bug 1500941 - Add searchfox task for Android (ARMv7/API16). r=nalexander
The bulk of this is copy/pasted from a standard android-api-16 debug
build. The only changes are a few extra environment variables in the
taskcluster config, the subconfig file, and the mozconfig, as well as
the --enable-mozsearch-plugin flag in the mozconfig.

Depends on D20766

Differential Revision: https://phabricator.services.mozilla.com/D20767

--HG--
extra : moz-landing-system : lando
2019-02-22 11:31:58 +00:00
Matthew Noorenberghe
004fdc8088 Bug 1474143 - Switch earlyformsubmit pwmgr observers to DOMFormBeforeSubmit listeners. r=Felipe
Differential Revision: https://phabricator.services.mozilla.com/D16652

--HG--
extra : moz-landing-system : lando
2019-02-23 00:24:12 +00:00
James Willcox
6f4446a1d8 Bug 1529297 - Make GeckoWebExecutor.resolve() fail with UnknownHostException r=geckoview-reviewers,esawin
Also clean up some doc strings.

Differential Revision: https://phabricator.services.mozilla.com/D20498

--HG--
extra : moz-landing-system : lando
2019-02-22 14:23:37 +00:00
James Willcox
f2d0270ef5 Bug 1526327 - Add GeckoWebExecutor.FETCH_FLAGS_NO_REDIRECT r=geckoview-reviewers,droeh,esawin
Using this flag will cause GeckoWebExecutor.fetch() to not automatically
follow redirects, which is the default behavior if no flag is specified.

Differential Revision: https://phabricator.services.mozilla.com/D19523

--HG--
extra : moz-landing-system : lando
2019-02-22 21:46:14 +00:00
James Willcox
b90839887f Bug 1522705 - Add streaming response support to GeckoWebExecutor r=esawin,agi
Differential Revision: https://phabricator.services.mozilla.com/D19504

--HG--
extra : moz-landing-system : lando
2019-02-22 21:46:05 +00:00
James Willcox
58a8fb5571 Bug 1522705 - Add /data/<count> path to HttpBinHandler r=geckoview-reviewers,esawin
This simply lets you request 'count' random bytes. A SHA-256 digest is
included for verifying the integrity of the response.

Differential Revision: https://phabricator.services.mozilla.com/D19503

--HG--
extra : moz-landing-system : lando
2019-02-22 21:45:57 +00:00
Ciure Andrei
f7412ac1f2 Backed out 10 changesets (bug 1474143) for perma failing browser_markup_events_01.js CLOSED TREE
Backed out changeset 1b5d04866585 (bug 1474143)
Backed out changeset 78bfb4dd1f6a (bug 1474143)
Backed out changeset 85ec4f1f5f60 (bug 1474143)
Backed out changeset 5c112b77e489 (bug 1474143)
Backed out changeset 5d35599598bb (bug 1474143)
Backed out changeset 9fd0d7a7946f (bug 1474143)
Backed out changeset 1a83be7a75ca (bug 1474143)
Backed out changeset 2fc9b13171d0 (bug 1474143)
Backed out changeset 3983d7b6d9ad (bug 1474143)
Backed out changeset 9fe55dd58cd8 (bug 1474143)

--HG--
rename : browser/actors/FormValidationChild.jsm => browser/actors/FormSubmitChild.jsm
rename : toolkit/components/satchel/FormSubmitChild.jsm => toolkit/components/satchel/formSubmitListener.js
2019-02-22 21:16:49 +02:00
Matthew Noorenberghe
24787216b4 Bug 1474143 - Switch earlyformsubmit pwmgr observers to DOMFormBeforeSubmit listeners. r=Felipe
Differential Revision: https://phabricator.services.mozilla.com/D16652

--HG--
extra : moz-landing-system : lando
2019-02-22 15:12:48 +00:00
Matthew Noorenberghe
6a9cc09d37 Bug 1304001 - Stop passing the top window to LoginManagerContent. r=sfoster
It wasn't clear in callee code that the window was the top-window and it wasn't necessary in many cases. Relying on the top-window would also cause problems with Fission if the windows are in separate processes.

Differential Revision: https://phabricator.services.mozilla.com/D20395

--HG--
extra : moz-landing-system : lando
2019-02-22 15:41:35 +00:00
Jan Henning
e0451dd1a3 Bug 1528715 - Work around problems with forcing the autocomplete result's capitalisation. r=geckoview-reviewers,m_kato
Even though using text.replace() is supposed to keep the existing spans intact,
in practice the composition spans still get lost, even when the replacement text
is identical (because there was in fact no capitalisation difference between
user-entered text and autocomplete result).

One approach to fix this would be to manually save the composition spans and
subsequently restore them afterwards, like we already do this a few lines
further down below, in the other major code path through onAutocomplete().
However while trying to generalise that approach, the most natural approach for
the caller to specify which spans it wanted to save was to pass a Predicate
lambda to the state saving function, which for some reason led to strange
"Didn't find class" errors.

So instead, we just restart input for affected IMEs (i.e. Sony's keyboard) to
get them back into sync with the new contents of the EditText.

To avoid unnecessarily calling restartInput(), though, we only do this if the
user-entered text (which at this stage is known to correspond to the auto-
complete result when compared case-*insensitively*) actually differs from the
autocomplete result.

Differential Revision: https://phabricator.services.mozilla.com/D20487

--HG--
extra : moz-landing-system : lando
2019-02-22 13:11:32 +00:00
Agi Sferro
4b7a2d663a Bug 1529632 - Add links to CHANGELOG.md. r=geckoview-reviewers,esawin
Differential Revision: https://phabricator.services.mozilla.com/D20691

--HG--
extra : moz-landing-system : lando
2019-02-22 14:13:14 +00:00
Bogdan Tara
de6fb7d842 Backed out 5 changesets (bug 1304001) for dom/html/test/test_bug430351.html failures CLOSED TREE
Backed out changeset 275c3744e059 (bug 1304001)
Backed out changeset c9628639b5e1 (bug 1304001)
Backed out changeset 7d8f97779a35 (bug 1304001)
Backed out changeset a5644de3c2f5 (bug 1304001)
Backed out changeset e23ef4dbbc7f (bug 1304001)
2019-02-22 05:05:56 +02:00
Bogdan Tara
826f142a88 Backed out 3 changesets (bug 1526327, bug 1522705) for WebExecutorSupport.cpp caused Android build bustages CLOSED TREE
Backed out changeset 11f1c1b18d28 (bug 1526327)
Backed out changeset 194be6b55fc4 (bug 1522705)
Backed out changeset d116b3721569 (bug 1522705)
2019-02-22 01:56:07 +02:00
Matthew Noorenberghe
fc3ea21215 Bug 1304001 - Stop passing the top window to LoginManagerContent. r=sfoster
It wasn't clear in callee code that the window was the top-window and it wasn't necessary in many cases. Relying on the top-window would also cause problems with Fission if the windows are in separate processes.

Differential Revision: https://phabricator.services.mozilla.com/D20395

--HG--
extra : moz-landing-system : lando
2019-02-21 20:19:16 +00:00
James Willcox
0809c64d52 Bug 1526327 - Add GeckoWebExecutor.FETCH_FLAGS_NO_REDIRECT r=geckoview-reviewers,droeh,esawin
Using this flag will cause GeckoWebExecutor.fetch() to not automatically
follow redirects, which is the default behavior if no flag is specified.

Differential Revision: https://phabricator.services.mozilla.com/D19523

--HG--
extra : moz-landing-system : lando
2019-02-21 18:15:42 +00:00
James Willcox
f4c323650d Bug 1522705 - Add streaming response support to GeckoWebExecutor r=esawin,agi
Differential Revision: https://phabricator.services.mozilla.com/D19504

--HG--
extra : moz-landing-system : lando
2019-02-21 18:15:02 +00:00
James Willcox
b8f76d07c5 Bug 1522705 - Add /data/<count> path to HttpBinHandler r=geckoview-reviewers,esawin
This simply lets you request 'count' random bytes. A SHA-256 digest is
included for verifying the integrity of the response.

Differential Revision: https://phabricator.services.mozilla.com/D19503

--HG--
extra : moz-landing-system : lando
2019-02-21 18:14:53 +00:00
Eitan Isaacson
bf64f6d78e Bug 1525470 - Include description in accessible hints. r=yzen
Differential Revision: https://phabricator.services.mozilla.com/D19870

--HG--
extra : moz-landing-system : lando
2019-02-21 17:45:17 +00:00
Vlad Baicu
3753e60bbd Bug 1527648 - Uid deeplink nullpointer check. r=petru
Patch from bug 1519418 introduced a regression by removing line separators from
the uid parameter contained within deeplinks. However, not all deeplinks are
mandatory to contain the uid parameter. Added a null check before replacing the
line separators.

Differential Revision: https://phabricator.services.mozilla.com/D20367

--HG--
extra : moz-landing-system : lando
2019-02-19 16:59:07 +00:00
Cosmin Sabou
9f8b29287b Merge mozilla-central to autoland. 2019-02-21 05:43:34 +02:00
Cosmin Sabou
f3db52f4cf Merge mozilla-inbound to mozilla-central. a=merge 2019-02-21 05:42:03 +02:00
Eugen Sawin
1fc5f0ebdc Bug 1526981 - [2.4] Simplify JSM module logger initialization and ensure compatibility with ES6. r=geckoview-reviewers,agi
Differential Revision: https://phabricator.services.mozilla.com/D19580

--HG--
extra : moz-landing-system : lando
2019-02-20 16:11:57 +00:00
Eugen Sawin
01058ecf82 Bug 1526981 - [1.1] Remove obsolete module import. r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D19579

--HG--
extra : moz-landing-system : lando
2019-02-20 16:17:56 +00:00
Kartikaya Gupta
bab1ffc031 Bug 1428158 - Enable static analysis on Android. r=glandium
Differential Revision: https://phabricator.services.mozilla.com/D20402

--HG--
extra : moz-landing-system : lando
2019-02-20 20:03:52 +00:00
Noemi Erli
7c565dc045 Backed out 6 changesets (bug 1304001) for mochitest failures in test_bug430351.html CLOSED TREE
Backed out changeset 5fafa838de11 (bug 1304001)
Backed out changeset d75340a9a264 (bug 1304001)
Backed out changeset ed7ae6b877df (bug 1304001)
Backed out changeset 93bd4d634b14 (bug 1304001)
Backed out changeset e41015881591 (bug 1304001)
Backed out changeset 6346331d934d (bug 1304001)
2019-02-21 04:04:47 +02:00
Michael Kaply
918805dafb Bug 1522151 - Use correct region for regionOverrides. r=nalexander
Differential Revision: https://phabricator.services.mozilla.com/D17379

--HG--
extra : moz-landing-system : lando
2019-02-20 19:44:05 +00:00
Matthew Noorenberghe
e8404f39c5 Bug 1304001 - Stop passing the top window to LoginManagerContent. r=sfoster
It wasn't clear in callee code that the window was the top-window and it wasn't necessary in many cases. Relying on the top-window would also cause problems with Fission if the windows are in separate processes.

Differential Revision: https://phabricator.services.mozilla.com/D20395

--HG--
extra : moz-landing-system : lando
2019-02-20 17:59:59 +00:00
Agi Sferro
a5313e6c73 Bug 1512997 - Add GeckoSession.getDefaultUserAgent API. r=nalexander,rbarker
Differential Revision: https://phabricator.services.mozilla.com/D19813

--HG--
extra : moz-landing-system : lando
2019-02-20 18:11:27 +00:00
Agi Sferro
085d28afff Bug 1514374 - Remove workaround for accessibility-test-framework. r=nalexander,geckoview-reviewers,snorp
Looks like accessibility-test-framework was added to maven central so we can
remove this.

Differential Revision: https://phabricator.services.mozilla.com/D20365

--HG--
extra : moz-landing-system : lando
2019-02-20 17:44:23 +00:00
Geoff Brown
ac3c0e4b5d Bug 1501562 - Enable remote debugging in TRA;
Differential Revision: https://phabricator.services.mozilla.com/D20568

--HG--
extra : moz-landing-system : lando
2019-02-20 21:44:34 +00:00