Commit Graph

11 Commits

Author SHA1 Message Date
Sebastian Hengst
59aaffbcda Backed out changeset 9264d5789f76 (bug 1397849) for import failures, e.g. in mochitests and xpcshell tests. r=backout 2017-10-04 15:25:07 +02:00
Steve Armand
50c9b712c0 Bug 1397849 - Enable py2 and py3 linter on testing/mozbase. r=ahal
MozReview-Commit-ID: GnaVLhtO4un

--HG--
extra : rebase_source : 19f47b7f5854b7ee25d9779622ce4cd734ac15e5
2017-09-25 22:57:18 -04:00
Sebastian Hengst
73fac0091d Backed out changeset dbe60b600dc0 (bug 1397853) for failining linter py-compat at testing/mochitest/runtests.py:2236. r=backout 2017-09-28 14:58:36 +02:00
Steve Armand
f8318d16e8 Bug 1397853 - Enable py2 and py3 linter on testing/mochitest. r=ahal
MozReview-Commit-ID: EhkNhyFHDox

--HG--
extra : rebase_source : 5200a985034c7ca0a494bc7d02a4c842e85dec3a
2017-09-24 21:28:25 -04:00
ruby
af79c59e2a Bug 1397427 - Enable py2 linter on tools/tryselect, r=ahal
MozReview-Commit-ID: K12XisbVQGq

--HG--
extra : rebase_source : 6a97dda2be81fa45601c2f09486c4a187f177cf5
2017-09-13 11:57:47 +05:30
Steve Armand
5934392346 Bug 1397855 - Enable py2 and py3 linter on testing/xpcshell. r=ahal
MozReview-Commit-ID: CsfIcI1ma7J

--HG--
extra : rebase_source : 53658c33432927f72ddce0999f18c2b7df261f6d
2017-09-07 21:15:35 -04:00
Kris Maglione
e99cced382 Bug 1371065: Part 1 - Remove external references to the add-on SDK. r=Mossop,glandium
MozReview-Commit-ID: D5KyHcg8Ujk

--HG--
extra : rebase_source : 1a74ccb2963f2946a49c8bf720af595151b48fd1
2017-09-12 11:54:47 -07:00
Ionut Goldan
f3028165fe Bug 1396217 - resolve py2 and py3 lint errors r=jmaher
MozReview-Commit-ID: LG332HzJKcw

--HG--
extra : rebase_source : b82da0cceac18f310cadf945578464c2fb4704c4
2017-09-08 11:27:26 +03:00
Steve Armand
08d5fcd935 Bug 1397423 - Enable py2 linter on python/mozlint. r=ahal
MozReview-Commit-ID: 6QX7YCmfjdJ

--HG--
extra : rebase_source : 0610d67f376c462b0f103a6510f21459fc39f940
2017-09-06 22:52:46 -04:00
Dustin J. Mitchell
d7b6f0148a Bug 1397318: mozlint -l py2 for taskcluster/; r=ahal
MozReview-Commit-ID: 1ZUOrIfxQef

--HG--
extra : rebase_source : c398af2faa83812a70213679d5cb4ad0024d8f7d
2017-09-06 17:29:32 +00:00
Andrew Halberstadt
3411e8b3d4 Bug 1391019 - Add py2 and py3 compatability linters, r=gps
check_compat.py was adapted from gps' check-py3-compat.py in mercurial:
https://www.mercurial-scm.org/repo/hg/file/tip/contrib/check-py3-compat.py

The py3 linter simply runs ast.parse(f) for each file being linted. Any syntax errors
are formatted as mozlint results and dumped to stdout as json. I looked into also
importing the file (using 3.5+'s importlib.util.spec_from_file_location), but there
were too many problems:

1. Lots of false positives (e.g module not found)
2. Some files seemed to run indefinitely on import

I decided to punt on importing for now, we can always investigate in a follow-up.

The py2 linter runs ast.parse(f), and also checks that the file has:
from __future__ import absolute_import, print_function

Initially every python file in the tree is excluded from the py2 check, though
at least this makes it easy to find+fix, and new files in un-excluded
directories will automatically be linted.

MozReview-Commit-ID: ABtq9dnPo9T

--HG--
extra : rebase_source : 60762937284d498514cd020b90cbfd2ba23f0b70
2017-08-31 10:12:02 -04:00