Commit Graph

64853 Commits

Author SHA1 Message Date
Boris Zbarsky
fcb00cb36f Bug 1471095. Don't do extra work we don't need to in ReparentWrappersInSubtree. r=smaug 2018-06-28 23:36:46 -04:00
Noemi Erli
6477f0d03d Bug 1451808 - Disable border-radius/intersecting-clipping-1-refc.html on Windows for frequent failures. r=jmaher 2018-06-28 05:48:00 +03:00
sotaro
58705ea969 Bug 1405465 - Handle WR paint codepath with no frame r=kats 2018-06-29 08:32:26 +09:00
shindli
d288e9cae7 Merge inbound to mozilla-central. a=merge 2018-06-29 00:53:32 +03:00
Andrew Halberstadt
9435736ade Bug 1471620 - Skip python-tests locally that don't run with python 3 in CI r=davehunt
This will make sure that when running |mach python-test --python 3| locally,
we only run the tests that also run in CI with python 3 (and therefore pass
presumably).

MozReview-Commit-ID: 3OBr9yLSlSq

--HG--
extra : rebase_source : 456340d0ecdddf1078f2b5b4ebb1eddf3813b26a
2018-06-27 11:10:02 -04:00
Cosmin Sabou
a612a6fdf5 Merge mozilla-central to mozilla-inbound. a=merge 2018-06-28 13:13:46 +03:00
Cosmin Sabou
f4b3baf021 Merge mozilla-inbound to mozilla-central. a=merge 2018-06-28 13:04:23 +03:00
Jonathan Kew
b9bcc3ea6e Bug 1471664 - Remove redundant code for creating userData in SetupLineBreakerContext. r=xidorn 2018-06-28 09:37:55 +01:00
Samuel Thibault
01084d60d8 Bug 1376756 - gtk: while drawing nsTreeBodyFrame, fetch current row attributes for proper style rendering. r=karlt 2018-06-27 05:11:00 +03:00
Mihir Iyer
b3ebeebc31 Bug 1398483 - Implement column and row gap for flexbox. r=dholbert
MozReview-Commit-ID: 2EmaG3G0HRI

--HG--
extra : rebase_source : ce90f9a38c0f3a6634a95b0f4f97a2a3fbd48a57
2018-06-19 10:28:31 -07:00
Tiberius Oros
945c24abe5 Merge mozilla-central to autoland. a=merge CLOSED TREE 2018-06-28 01:12:18 +03:00
Tiberius Oros
705b995848 Merge inbound to mozilla-central. a=merge 2018-06-28 01:07:30 +03:00
Emilio Cobos Álvarez
8aaca6bf90 Bug 1464782: Allow logical aliases in the property database. r=me
MozReview-Commit-ID: 68WqG0OViPQ
2018-06-27 17:35:46 +02:00
Jonathan Kew
498696bbb5 Bug 1461573 - Mark various dynamicDirAuto-* tests as slightly fuzzy on Android due to painting inconsistency. r=mats 2018-06-27 16:12:41 +01:00
Dorel Luca
4e1a98da16 Merge mozilla-central to autland. CLOSED TREE
--HG--
extra : amend_source : f27ba81f58e12b4cf5286650b6910404748e7f95
2018-06-27 14:07:04 +03:00
Dorel Luca
d296624690 Backed out 5 changesets (bug 1340498) for build bustage due to conflicts with bug 1470325. a=backout
Backed out changeset 28bedb658af4 (bug 1340498)
Backed out changeset f950a2310e26 (bug 1340498)
Backed out changeset 5fcd31c65fe0 (bug 1340498)
Backed out changeset 515bb5e24dd7 (bug 1340498)
Backed out changeset 79a8619bd3e2 (bug 1340498)
2018-06-27 14:05:20 +03:00
Dorel Luca
bc2fbd0648 Merge mozilla-central to autoland
--HG--
extra : rebase_source : 0f5c3c308ce6ddd6fb9fcb49b83d4450a24d67dc
2018-06-27 13:33:04 +03:00
Dorel Luca
f51c4fa5d9 Merge mozilla-inbound to mozilla-central. a=merge 2018-06-27 13:26:49 +03:00
Cameron McCormack
674e812659 Bug 1471499 - Part 3: Replace remaining "see nsStyleConsts.h" comments with more useful references. r=xidorn
MozReview-Commit-ID: kO8uT9JZgK

--HG--
extra : rebase_source : 119ce72ccb1f2b79ec0e827325ed4ea6897a9e87
2018-06-27 16:45:56 +10:00
Cameron McCormack
73de67e798 Bug 1471499 - Part 2: Remove "see nsStyleConsts.h" comments for style struct members that are enum classes. r=xidorn
MozReview-Commit-ID: ISkGZ7FU8xR

--HG--
extra : rebase_source : 74e8b99a38e9d9fd94d1a93c2385fb91d66c12f4
2018-06-27 15:51:33 +10:00
Cameron McCormack
d5ad9f4ec6 Bug 1471499 - Part 1: Remove [reset] and [inherited] comments on style struct members. r=xidorn
MozReview-Commit-ID: 9dL51J2KqPS

--HG--
extra : rebase_source : 28cb17a14052db90b55a75d09ac190b85051624e
2018-06-27 15:44:58 +10:00
Xidorn Quan
4b65f18d5a Bug 1471114 part 7 - Scripts used to generated the previous patches. r=emilio
MozReview-Commit-ID: E9dB5l9AmeS

--HG--
extra : source : 960b212b998e728f90bbf564f5899a92f65c9e0e
2018-06-27 15:34:29 +10:00
Xidorn Quan
882b6f2f03 Bug 1471114 part 6 - Remove unused CSS keywords. r=emilio
This is done with the following script:
```python
#!/usr/bin/env python3

import re
import subprocess

LIST_FILE = "layout/style/nsCSSKeywordList.h"

RE_KEYWORD = re.compile(r"\beCSSKeyword_(\w+)")
rg_result = subprocess.check_output(["rg", r"eCSSKeyword_\w+"], encoding="UTF-8")
to_keep = set()
for item in rg_result.splitlines():
    file, line = item.split(':', 1)
    for m in RE_KEYWORD.finditer(line):
        to_keep.add(m.group(1))

remaining_lines = []
RE_ITEM = re.compile(r"CSS_KEY\(.+, (\w+)\)")
with open(LIST_FILE, "r") as f:
    for line in f:
        m = RE_ITEM.search(line)
        if m is not None and m.group(1) not in to_keep:
            print("Removing " + m.group(1))
            continue
        remaining_lines.append(line)
with open(LIST_FILE, "w", newline="") as f:
    f.writelines(remaining_lines)
```

MozReview-Commit-ID: upyTPc8984

--HG--
extra : source : 65a744682fe99d8f0de4fa4b7a478e10aba0349e
2018-06-27 15:34:29 +10:00
Xidorn Quan
a18ad3b214 Bug 1471114 part 5 - Remove unused keyword tables. r=emilio
This is done with the following script:
```python
#!/usr/bin/env python3

import re
import subprocess

from pathlib import Path

HEADER = Path("layout/style/nsCSSProps.h")
SOURCE = Path("layout/style/nsCSSProps.cpp")

RE_TABLE = re.compile(r"\b(k\w+KTable)")
rg_result = subprocess.check_output(["rg", r"\bk\w+KTable"], encoding="UTF-8")
to_keep = set()
all = set()
for item in rg_result.splitlines():
    file, line = item.split(':', 1)
    name = RE_TABLE.search(line).group(1)
    path = Path(file)
    if path != HEADER and path != SOURCE:
        to_keep.add(name)
    else:
        all.add(name)

to_remove = all - to_keep
remaining_lines = []
with HEADER.open() as f:
    for line in f:
        m = RE_TABLE.search(line)
        if m is not None and m.group(1) in to_remove:
            print("Removing " + m.group(1))
            continue
        remaining_lines.append(line)
with HEADER.open("w", newline="") as f:
    f.writelines(remaining_lines)

remaining_lines = []
removing = False
RE_DEF = re.compile(r"KTableEntry nsCSSProps::(k\w+KTable)\[\]")
with SOURCE.open() as f:
    for line in f:
        if removing:
            if line == "};\n":
                removing = False
            continue
        m = RE_DEF.search(line)
        if m is not None and m.group(1) in to_remove:
            if remaining_lines[-1] == "\n":
                remaining_lines.pop()
            removing = True
            continue
        remaining_lines.append(line)
with SOURCE.open("w", newline="") as f:
    f.writelines(remaining_lines)
```

MozReview-Commit-ID: FeDZRcBceqV

--HG--
extra : source : fe9369e5cef11a6c6eaac641c185844eb45554b1
2018-06-27 15:34:29 +10:00
Xidorn Quan
a01792b85b Bug 1471114 part 4 - Remove unused getter functions from nsComputedDOMStyle. r=emilio
This is done with the following script:
```python
#!/usr/bin/env python3

import re
import sys

from pathlib import Path

if len(sys.argv) != 2:
    print("Usage: {} objdir".format(sys.argv[0]))
    exit(1)

generated = Path(sys.argv[1]) / "layout" / "style"
generated = generated / "nsComputedDOMStyleGenerated.cpp"
RE_GENERATED = re.compile(r"DoGet\w+")
keeping = set()
with generated.open() as f:
    for line in f:
        m = RE_GENERATED.search(line)
        if m is not None:
            keeping.add(m.group(0))

HEADER = "layout/style/nsComputedDOMStyle.h"
SOURCE = "layout/style/nsComputedDOMStyle.cpp"

# We need to keep functions invoked by others
RE_DEF = re.compile(r"nsComputedDOMStyle::(DoGet\w+)\(\)")
RE_SRC = re.compile(r"\b(DoGet\w+)\(\)")
with open(SOURCE, "r") as f:
    for line in f:
        m = RE_DEF.search(line)
        if m is not None:
            continue
        m = RE_SRC.search(line)
        if m is not None:
            keeping.add(m.group(1))

removing = set()
remaining_lines = []
with open(HEADER, "r") as f:
    for line in f:
        m = RE_SRC.search(line)
        if m is not None:
            name = m.group(1)
            if name not in keeping:
                print("Removing " + name)
                removing.add(name)
                continue
        remaining_lines.append(line)

with open(HEADER, "w", newline="") as f:
    f.writelines(remaining_lines)

remaining_lines = []
is_removing = False
with open(SOURCE, "r") as f:
    for line in f:
        if is_removing:
            if line == "}\n":
                is_removing = False
            continue
        m = RE_DEF.search(line)
        if m is not None:
            name = m.group(1)
            if name in removing:
                remaining_lines.pop()
                if remaining_lines[-1] == "\n":
                    remaining_lines.pop()
                is_removing = True
                continue
        remaining_lines.append(line)

with open(SOURCE, "w", newline="") as f:
    f.writelines(remaining_lines)
```

MozReview-Commit-ID: ACewvZ9ztWp

--HG--
extra : source : 7f167f9affd954da907d1da307ebc82be4b85911
2018-06-27 15:34:29 +10:00
Xidorn Quan
cd114ec151 Bug 1471114 part 3 - Drop the reference to getter functions we don't call. r=emilio
MozReview-Commit-ID: IbBayOwsjNX

--HG--
extra : source : 82ce1f7b7fd21c406cf61726c78de5f120028e35
2018-06-27 15:34:29 +10:00
Xidorn Quan
dca9867a8f Bug 1471114 part 2 - Generate ComputedStyleMap entry list from property data. r=emilio
This changes the order of properties returned from gCS. The old order
doesn't make much sense, and other browsers don't agree on an identical
order either, so it should be trivial to change it. Also the spec isn't
super clear / useful in this case.

Several -moz-prefixed properties are excluded from the list due to their
being internal. I suspect they are never accessible anyway, so probably
nothing gets changed by this.

MozReview-Commit-ID: 9LfangjpJ3P

--HG--
extra : source : 879a7265c35f51c5954d8a44ccd374a606ecba0e
2018-06-27 15:34:29 +10:00
Xidorn Quan
d1caa962ed Bug 1471114 part 1 - Move CSSPropFlags prefix generation into GenerateServoCSSPropList.py. r=emilio
MozReview-Commit-ID: E5dl9V2B2dq

--HG--
extra : source : 6e2448ce3f4d9965749298a575795dfab926b9cb
2018-06-27 15:34:29 +10:00
Hiroyuki Ikezoe
048a8ca37c Bug 1471174 - Constify nsIFrame::IsScrolledOutOfView. r=birtles
The reason why const_cast is used for nsLayoutUtils::GetNearestScrollableFrame
is that if we changed the function as well, it ends up scattering const_cast
in most call sites of the function.  That's because GetNearestScrollableFrame
has a do_QueryFrame call for the given nsIFrame* and returns the queried frame,
so it will be like this;

 const nsIScrollableFrame* GetNearestScrollableFrame(const nsIFrame*, ..)

Most call sites of this function are then calls do_QueryFrame for the returned
nsIScrollableFrame*.

MozReview-Commit-ID: EwccKUITL89

--HG--
extra : rebase_source : f3b915fc78c096ca18d0922c764d15d73d552910
2018-06-27 09:08:36 +09:00
Hiroyuki Ikezoe
7cf6c6e8ac Bug 1471241 - Set dom.animations-api.core.enabled for 1343139-1.html. r=birtles
Since the test relies on missing keyframes handling.

MozReview-Commit-ID: IfbMvRhIeOh

--HG--
extra : rebase_source : 447bec6c7bc8d8a79f00bb738182e0647ee68ec5
2018-06-27 06:04:21 +09:00
Xidorn Quan
cca2036556 Bug 1471116 - Use nsCSSProps::kPropertyPrefTable for pref callback register of nsComputedDOMStyle. r=emilio
MozReview-Commit-ID: 7VvFGYi12te

--HG--
extra : rebase_source : de146bf00f8902ba01278cc70ddf231272fc5cee
2018-06-26 14:06:46 +10:00
Morgan Rae Reschenberg
41f649ace3 Bug 1471267 - Update some baseline-querying utility functions to bail on frames that have 'contain:size'. r=dholbert
MozReview-Commit-ID: Bk2P73tlRqG

--HG--
extra : rebase_source : f20c751b9dd902f295a2a2181a13453451327e2c
2018-06-26 15:34:15 -07:00
Emilio Cobos Álvarez
688e2c1d75 Bug 1464782: Put offset-* aliases behind a pref. r=xidorn
MozReview-Commit-ID: Hl6Muim3wVH
2018-06-27 16:12:04 +02:00
Emilio Cobos Álvarez
d73b4b0679 Bug 1464782: Rename offset-* logical properties to inset-*. r=xidorn
MozReview-Commit-ID: BW44sru99RF
2018-06-27 16:12:01 +02:00
Dorel Luca
48178c7559 Merge mozilla-central to mozilla-inbound. CLOSED TREE 2018-06-27 14:09:04 +03:00
Dorel Luca
fad3d6e777 Merge mozilla-central to mozilla-inbound
--HG--
extra : rebase_source : 66cecebb4b7699e57e8a3b73ae5664702dfeda78
2018-06-27 13:39:34 +03:00
Emilio Cobos Álvarez
0004f1c6ae No bug - Remove some useless intermediate variables. r=me
MozReview-Commit-ID: LFGpL7JImwK
2018-06-27 11:50:13 +02:00
Jeff Gilbert
5b753da289 Bug 1470325 - s/FooBinding/Foo_Binding/g - r=qdot
MozReview-Commit-ID: JtTcLL5OPF0
2018-06-26 17:05:01 -07:00
Tiberius Oros
eacc3eda3e Merge mozilla-central to inbound. a=merge CLOSED TREE 2018-06-28 01:15:41 +03:00
Stephen A Pohl
1f2e716a79 Bug 1466335: Automatically switch to the appropriate Firefox theme based on the macOS dark mode system preference. r=dao,mstange 2018-06-27 13:59:21 -04:00
Bas Schouten
43ddb842d7 Bug 1471437 - Part 2: Reset mPaintRect only when the new building rect is different, and update mPaintRectValid when it is. r=mattwoodrow
MozReview-Commit-ID: 5djSr7eNk8W
2018-06-27 16:47:55 +02:00
Bas Schouten
40d7ba26d3 Bug 1471437 - Part 1: Store the previous paint rect before occlusion culling. r=mattwoodrow
MozReview-Commit-ID: 8Bw9hsPcipZ
2018-06-27 16:47:54 +02:00
Ryan Hunt
6f29815288 Bug 1460753 - Remove TelemetryScrollProbe. r=smaug
The probe is expired and there's no clear owner here so let's remove this
for now.

--HG--
extra : rebase_source : 51c332a790ce5081ce4645633991c3b9213a5d21
extra : source : 98d141e6d651b804cf35040a5c20be74b6fb6c7a
2018-06-26 17:31:27 -05:00
Boris Zbarsky
faaf43f77b Bug 1471157. Fix null-deref crash when a drop event has no DataTransfer. r=nika
https://hg.mozilla.org/mozilla-central/rev/41d99ad7144f removed a null-check
that shouldn't have been removed: the datatransfer argument might actually be
null here.
2018-06-27 12:04:26 -04:00
Emilio Cobos Álvarez
4e021661e1 Bug 1469000: Fix image to layout transform for invalidation. r=aosmond
When computing image to layout transforms for invalidation, use the actual
intrinsic size of the source image, instead of the layout intrinsic size, which
may be scaled by ResponsiveImageSelector since bug 1149357.

I have absolutely no idea how to write a test for this, suggestions welcome.

MozReview-Commit-ID: LP6C9fSvMi2

--HG--
extra : rebase_source : c7c7b70dff3ba1c7514fceb58d0bb6f26374c8a8
2018-06-19 17:51:53 +02:00
Joel Maher
8bc0bcda97 Bug 1392106 - random-if more win7 reftest font rendering failures. r=RyanVM 2018-06-26 13:32:30 -04:00
Emilio Cobos Álvarez
c7d35aa526 Bug 1470930: Use enums for passing arguments for event dispatch. r=smaug
MozReview-Commit-ID: DsNuF7GAflJ
2018-06-26 18:22:06 +02:00
Doug Thayer
864c89631c Bug 1340498 - Fix unified sources build errors r=mrbkap
Adding the Places* files into unified sources pushed the
unified sources into a situation that exposed a strangely
large number of errors. This seems to be the minimum set of
changes I could make to resolve all of the issues.

MozReview-Commit-ID: C2H9ce8FmE4

--HG--
extra : rebase_source : 4f8dd2996d820fdb5a07afe544be5e2d6ca6a5c7
2018-04-13 11:04:47 -07:00
Doug Thayer
488eb2eb9c Bug 1340498 - Fix unified sources build errors r=mrbkap
Adding the Places* files into unified sources pushed the
unified sources into a situation that exposed a strangely
large number of errors. This seems to be the minimum set of
changes I could make to resolve all of the issues.

MozReview-Commit-ID: C2H9ce8FmE4

--HG--
extra : rebase_source : 61afc5481dc8ec34caba1886bd74200cf3659fb4
2018-04-13 11:04:47 -07:00
Emilio Cobos Álvarez
9e9546ecb2 Bug 1471045: Don't flush layout if the ready promise is not resolved yet. r=heycam
This prevents FOUC, and also matches the chromium logic:

  https://cs.chromium.org/chromium/src/third_party/blink/renderer/core/css/font_face_set_document.cc?l=105&rcl=e70e652d516c7d14d50e547aae2da1690c4ae54c

Differential Revision: https://phabricator.services.mozilla.com/D1827

MozReview-Commit-ID: A6m5fAMXhae
2018-06-26 15:32:03 +02:00