Commit Graph

832 Commits

Author SHA1 Message Date
Tom Schuster
d9047629b5 Bug 1876276 - Remove dead nsIDocShell allowPlugins code. r=emilio,sessionstore-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D199491
2024-01-31 13:23:52 +00:00
Makoto Kato
1e01e5fa87 Bug 1832627 - Popup should be closed. r=edgar
Differential Revision: https://phabricator.services.mozilla.com/D197067
2024-01-17 08:48:29 +00:00
Emilio Cobos Álvarez
71838e2f11 Bug 1850295 - Update :user-{valid,invalid} to follow the spec. r=smaug
(Modulo open spec issues linked in comments)

Differential Revision: https://phabricator.services.mozilla.com/D196986
2024-01-16 11:09:01 +00:00
Molly Howell
9b1bc951f4 Bug 1863583 - Add disablePictureInPicture attribute to HTMLVideoElement WebIDL. r=webidl,emilio,mconley
Differential Revision: https://phabricator.services.mozilla.com/D195466
2023-12-11 16:27:21 +00:00
Emilio Cobos Álvarez
6d78c0d72c Bug 1866984 - Don't artificially constrain select menupopup height. r=mconley
The test removed no longer holds on macOS because now more items show up
and the constraining logic kicks in, but that's the behavior of all
menulists (including e.g. the massive font name menulists in
about:preferences).

Differential Revision: https://phabricator.services.mozilla.com/D195488
2023-12-07 12:51:42 +00:00
Shane Hughes
4562817624 Bug 1858471 - Record an extra telemetry key when user opens PiP after seeing a PiP feature callout. r=omc-reviewers,mconley,jprickett
Differential Revision: https://phabricator.services.mozilla.com/D191140
2023-11-30 05:20:10 +00:00
CanadaHonk
b7cb7a41f5 Bug 1830909 - Implement <hr> in <select> r=hsivonen,emilio,geckoview-reviewers,desktop-theme-reviewers,Jamie,owlish
Updated HTML parser to allow <hr> in <select>.

Updated internal toolkit UI for <select> dropdown to create
menuseperators for hrs.

Updated WPT expectations:
 - HTML5Lib WebKit parsing for it now passes 100%

Also includes Android support, but Fenix does not support separators
in the menus used (single/multiple) yet so they are not rendered.

Differential Revision: https://phabricator.services.mozilla.com/D189065
2023-11-29 14:15:36 +00:00
Norisz Fay
be3e190621 Backed out changeset f56003f45cc6 (bug 1830909) for causing bc failures on browser_selectpopup_colors.js CLOSED TREE 2023-11-28 22:00:22 +02:00
CanadaHonk
a1eb267c1e Bug 1830909 - Implement <hr> in <select> r=hsivonen,emilio,geckoview-reviewers,desktop-theme-reviewers,Jamie,owlish
Updated HTML parser to allow <hr> in <select>.

Updated internal toolkit UI for <select> dropdown to create
menuseperators for hrs.

Updated WPT expectations:
 - HTML5Lib WebKit parsing for it now passes 100%

Also includes Android support, but Fenix does not support separators
in the menus used (single/multiple) yet so they are not rendered.

Differential Revision: https://phabricator.services.mozilla.com/D189065
2023-11-28 16:01:36 +00:00
Edgar Chen
fd9072b080 Bug 1866994 - Handle clipboard contextmenu in parent process; r=geckoview-reviewers,extension-reviewers,webidl,win-reviewers,saschanaz,robwu,nika,Gijs,m_kato,emilio
This patch makes the clipboard context menu trigger from the parent process rather
than the content process. A new method, `confirmUserPaste`, is added on `nsIPromptService`
to trigger frontend UI.

The behavior of handling multiple requests should remain unchanged, new tests are
added to ensure that.

Differential Revision: https://phabricator.services.mozilla.com/D190405
2023-11-28 15:38:01 +00:00
Jonathan Watt
15c1a58822 Bug 1866011 p2. Rename nsIDocShell.contentViewer. r=emilio,credential-management-reviewers,devtools-reviewers,sgalich
Differential Revision: https://phabricator.services.mozilla.com/D194370
2023-11-24 09:10:52 +00:00
Dana Keeler
70be8fb3b3 Bug 1862062 - remove defunct TLS_ERROR_REPORT_UI telemetry probe r=jschanck
Differential Revision: https://phabricator.services.mozilla.com/D192398
2023-11-08 21:37:54 +00:00
Cosmin Sabou
e6556f7d99 Backed out 5 changesets (bug 1862062) for causing xpcshell failures on test_content_signing.js. CLOSED TREE
Backed out changeset dcc224a798ba (bug 1862062)
Backed out changeset 8d2222109dd9 (bug 1862062)
Backed out changeset 13e730e6e684 (bug 1862062)
Backed out changeset 8c73f748ca55 (bug 1862062)
Backed out changeset 2a321dff5c82 (bug 1862062)
2023-11-02 23:22:42 +02:00
Dana Keeler
703ded5b0f Bug 1862062 - remove defunct TLS_ERROR_REPORT_UI telemetry probe r=jschanck
Differential Revision: https://phabricator.services.mozilla.com/D192398
2023-11-02 19:43:33 +00:00
Greg Tatum
f2ed6409bc Bug 1815339 - Restore the transfer attribute in JSWindowActor; r=ipc-reviewers,nika
This was removed in Bug 1580907, but the translations feature needs it
restored in order to transfer MessageChannel ports. A new test is added
as well.

Differential Revision: https://phabricator.services.mozilla.com/D190723
2023-10-25 22:15:11 +00:00
Sean Feng
d5f701c4b3 Bug 1848540 - Check general.autoscroll in AutoScrollChild for mouseup r=masayuki,dom-core
Although `_scrollable` will be cleared if `general.autoscroll` is set
to false, AutoScrollChild could receive the `mouseup` event before
it clears out, so we need to check `general.autoscroll` when `mouseup`
occurs.

Differential Revision: https://phabricator.services.mozilla.com/D186546
2023-08-28 18:43:16 +00:00
Masayuki Nakano
0f39d7eda7 Bug 1266437 - Drop "OS" modifier r=smaug,m_kato,karlt,Gijs
On Windows, Windows logo key was mapped to "OS" modifier, and on Linux,
it's same and the key is called "Super" and "Hyper".  That conformed to the
older UI Events spec.

However, UI Events declares that they should be mapped to "Meta" now and Chrome
handles it as the spec in Windows and Linux.  Therefore, we should align the
behavior to them.

Note that we've treated the legacy "Meta" modifier on Linux as DOM "Meta"
modifier state, and we'll keep this as-is because in Sun/Solaris keyboard
layout, they keys are mapped to the legacy "Meta".

Finally, the following check only `IsMeta()` but not `IsOS()`.  I think that
they should've checked `IsOS()` too.  Therefore, they will behave differently
in Windows and Linux.
* https://searchfox.org/mozilla-central/rev/9a4666e63199bd1bcfc9095f6efec3488c358458/dom/base/Element.cpp#3287-3288
* https://searchfox.org/mozilla-central/rev/9a4666e63199bd1bcfc9095f6efec3488c358458/dom/html/HTMLInputElement.cpp#3762-3764
* https://searchfox.org/mozilla-central/rev/9a4666e63199bd1bcfc9095f6efec3488c358458/dom/html/HTMLInputElement.cpp#3796-3806
* https://searchfox.org/mozilla-central/rev/9a4666e63199bd1bcfc9095f6efec3488c358458/dom/html/HTMLLabelElement.cpp#127-128
* https://searchfox.org/mozilla-central/rev/9a4666e63199bd1bcfc9095f6efec3488c358458/widget/gtk/nsGtkKeyUtils.cpp#1461-1462

Note that `KEY_NAME_INDEX_OS` will be removed in the patch for bug 1232918.

Differential Revision: https://phabricator.services.mozilla.com/D183480
2023-08-07 01:03:58 +00:00
Cristian Tuns
f5572b469f Backed out 2 changesets (bug 1266437, bug 1232918) for causing mochitest failures in test_autoplay_policy_key_blacklist.html CLOSED TREE
Backed out changeset 33e3c6593d4b (bug 1232918)
Backed out changeset 1b56e99dd221 (bug 1266437)
2023-08-03 23:29:52 -04:00
Masayuki Nakano
0664d98bce Bug 1266437 - Drop "OS" modifier r=smaug,m_kato,karlt,Gijs
On Windows, Windows logo key was mapped to "OS" modifier, and on Linux,
it's same and the key is called "Super" and "Hyper".  That conformed to the
older UI Events spec.

However, UI Events declares that they should be mapped to "Meta" now and Chrome
handles it as the spec in Windows and Linux.  Therefore, we should align the
behavior to them.

Note that we've treated the legacy "Meta" modifier on Linux as DOM "Meta"
modifier state, and we'll keep this as-is because in Sun/Solaris keyboard
layout, they keys are mapped to the legacy "Meta".

Finally, the following check only `IsMeta()` but not `IsOS()`.  I think that
they should've checked `IsOS()` too.  Therefore, they will behave differently
in Windows and Linux.
* https://searchfox.org/mozilla-central/rev/9a4666e63199bd1bcfc9095f6efec3488c358458/dom/base/Element.cpp#3287-3288
* https://searchfox.org/mozilla-central/rev/9a4666e63199bd1bcfc9095f6efec3488c358458/dom/html/HTMLInputElement.cpp#3762-3764
* https://searchfox.org/mozilla-central/rev/9a4666e63199bd1bcfc9095f6efec3488c358458/dom/html/HTMLInputElement.cpp#3796-3806
* https://searchfox.org/mozilla-central/rev/9a4666e63199bd1bcfc9095f6efec3488c358458/dom/html/HTMLLabelElement.cpp#127-128
* https://searchfox.org/mozilla-central/rev/9a4666e63199bd1bcfc9095f6efec3488c358458/widget/gtk/nsGtkKeyUtils.cpp#1461-1462

Note that `KEY_NAME_INDEX_OS` will be removed in the patch for bug 1232918.

Differential Revision: https://phabricator.services.mozilla.com/D183480
2023-08-04 00:10:11 +00:00
Gijs Kruitbosch
1627ed7f98 Bug 1844665 - rename RPMSetBoolPref so it's more obvious you can use it for int/char prefs, r=jhirsch
Differential Revision: https://phabricator.services.mozilla.com/D184742
2023-07-27 21:09:28 +00:00
Gregory Pappas
3eac12bbd7 Bug 1845311 - Use ChromeUtils.defineLazyGetter in more places r=arai,webdriver-reviewers,geckoview-reviewers,extension-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,anti-tracking-reviewers,sessionstore-reviewers,pbz,joschmidt,robwu,issammani,bytesized,owlish,dao
Differential Revision: https://phabricator.services.mozilla.com/D184481
2023-07-26 16:28:11 +00:00
Mathew Hodson
21cd613492 Bug 1564391 - Rename internal uses of mozInputSource. r=emilio,pip-reviewers,tabbrowser-reviewers,dao,kpatenio
This allows us to deprecate `mozInputSource` for the Web while
avoiding console warnings for internal uses, which now use the
ChromeOnly `inputSource` attribute.

Differential Revision: https://phabricator.services.mozilla.com/D183643
2023-07-26 09:27:45 +00:00
Gregory Pappas
ca2d7cbfc2 Bug 1845156 - Remove XPCOMUtils.defineLazyProxy r=arai,Gijs"
At this point, there's only one non-test use of this method in FindBarChild.sys.mjs which could be replaced with a simpler solution.

Removing this method seems to lower memory usage a bit.
https://treeherder.mozilla.org/perfherder/compare?originalProject=try&originalRevision=2dc498c7c81bd00c989cc3b69993ec1a53ff3032&newProject=try&newRevision=32669e95c9609cb07c258ca5fe964e9eb6411ade&page=1&framework=4

Differential Revision: https://phabricator.services.mozilla.com/D184403
2023-07-25 23:27:51 +00:00
Natalia Csoregi
a95bfa5f0c Backed out changeset 09c1addb65b6 (bug 1845156) for causing failures on browser_findbar.js. CLOSED TREE 2023-07-25 17:47:07 +03:00
Gregory Pappas
f88e1bfd16 Bug 1845156 - Remove XPCOMUtils.defineLazyProxy r=arai,Gijs"
At this point, there's only one non-test use of this method in FindBarChild.sys.mjs which could be replaced with a simpler solution.

Removing this method seems to lower memory usage a bit.
https://treeherder.mozilla.org/perfherder/compare?originalProject=try&originalRevision=2dc498c7c81bd00c989cc3b69993ec1a53ff3032&newProject=try&newRevision=32669e95c9609cb07c258ca5fe964e9eb6411ade&page=1&framework=4

Differential Revision: https://phabricator.services.mozilla.com/D184403
2023-07-25 12:49:00 +00:00
Sergey Galich
a6bf0f6d37 Bug 1091954 - showing autocomplete on connected elements only r=credential-management-reviewers,issammani,dimi
Differential Revision: https://phabricator.services.mozilla.com/D183947
2023-07-19 14:01:57 +00:00
Stanca Serban
5e0a341a67 Backed out 2 changesets (bug 1807618) for autocomplete related failures. CLOSED TREE
Backed out changeset 548365f1d102 (bug 1807618)
Backed out changeset 149b536f4fed (bug 1807618)
2023-07-06 01:27:55 +03:00
Neil Deakin
1c790e3235 Bug 1807618, check if autocomplete popup is open before sending close popup message, r=mak
This affects the test test_autocomplete_password_generation.html due to a timing issue. A password field is focused and closePopup ends up being called but the popup is already closed. By the time the parent receives the message, an attempt to open to popup has already occurred causing the popup to close again; the test fails as there aren't any items in the popup.

I'm not entirely convinced this fixes the test but I can rarely reproduce it only on Linux and cannot with this change.

Differential Revision: https://phabricator.services.mozilla.com/D182425
2023-07-05 19:24:40 +00:00
Tooru Fujisawa
09135083e3 Bug 1839276 - Update moz.build with Files() sections to use sys.mjs for already-migrated files. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D181426
2023-06-20 08:17:53 +00:00
Katherine Patenio
130ce23c4c Bug 1834831 - update imports of browser/modules JSMs r=webdriver-reviewers,perftest-reviewers,zeid,extension-reviewers,settings-reviewers,pip-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,sessionstore-reviewers,tabbrowser-reviewers,whimboo,mhowell,sgalich,robwu,sparky,Standard8,mconley,dao,sclements
Differential Revision: https://phabricator.services.mozilla.com/D179169
2023-06-19 18:44:48 +00:00
Cristian Tuns
110cfccc1f Backed out 2 changesets (bug 1834831) for causing node failures with checkBundles CLOSED TREE
Backed out changeset 58b351a155c8 (bug 1834831)
Backed out changeset 1acbb5231d14 (bug 1834831)
2023-06-19 13:22:35 -04:00
Katherine Patenio
a73f6ec769 Bug 1834831 - update imports of browser/modules JSMs r=webdriver-reviewers,perftest-reviewers,zeid,extension-reviewers,settings-reviewers,pip-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,sessionstore-reviewers,tabbrowser-reviewers,whimboo,mhowell,sgalich,robwu,sparky,Standard8,mconley,dao,sclements
Differential Revision: https://phabricator.services.mozilla.com/D179169
2023-06-19 16:46:18 +00:00
Niklas Baumgardner
f7058e9858 Bug 1580095 - Add audio scrubber to PiP. r=pip-reviewers,desktop-theme-reviewers,kpatenio,dao
Differential Revision: https://phabricator.services.mozilla.com/D179556
2023-06-17 17:01:58 +00:00
Norisz Fay
f890e5a1aa Backed out 3 changesets (bug 1580095) for causing bc failures on browser_mock_wrapper.js CLOSED TREE
Backed out changeset 047ac9aaa0f7 (bug 1580095)
Backed out changeset 22765b6eea1b (bug 1580095)
Backed out changeset 9372bbd6eb40 (bug 1580095)
2023-06-17 05:24:26 +03:00
Niklas Baumgardner
de7d493744 Bug 1580095 - Add audio scrubber to PiP. r=pip-reviewers,desktop-theme-reviewers,kpatenio,dao
Differential Revision: https://phabricator.services.mozilla.com/D179556
2023-06-16 21:57:23 +00:00
Stanca Serban
cf0c7e1d74 Backed out 3 changesets (bug 1580095) for causing mochitests failures in browser_audioScrubber.js. CLOSED TREE
Backed out changeset fa8f9b71e4db (bug 1580095)
Backed out changeset 2d042439b759 (bug 1580095)
Backed out changeset 66a695629d4b (bug 1580095)
2023-06-16 18:32:48 +03:00
Niklas Baumgardner
3ccac42558 Bug 1580095 - Add audio scrubber to PiP. r=pip-reviewers,desktop-theme-reviewers,kpatenio,dao
Differential Revision: https://phabricator.services.mozilla.com/D179556
2023-06-16 14:35:03 +00:00
Itiel
cf26dda371 Bug 1830679 - Convert element.setAttribute(data-l10n-{id,args}) uses in the codebase to document.l10n.setAttributes(element, id, args) r=eemeli,Gijs,willdurand,extension-reviewers,settings-reviewers,search-reviewers,devtools-reviewers,fxview-reviewers,mconley,Standard8,jdescottes,kcochrane,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D176791
2023-06-14 17:16:39 +00:00
Makoto Kato
2b44e638d8 Bug 1838137 - Convert GeckoViewAutocomplete to ESM. r=geckoview-reviewers,credential-management-reviewers,sgalich,ohall
Differential Revision: https://phabricator.services.mozilla.com/D180772
2023-06-14 12:58:08 +00:00
Iulian Moraru
1a03d0ff0d Backed out changeset 76c5afdda762 (bug 1830679) for causing xpcshell failures on test_VariablesView_filtering-without-controller.js. CLOSED TREE 2023-06-12 22:03:43 +03:00
Itiel
d6ff8a9975 Bug 1830679 - Convert element.setAttribute(data-l10n-{id,args}) uses in the codebase to document.l10n.setAttributes(element, id, args) r=eemeli,Gijs,willdurand,extension-reviewers,settings-reviewers,search-reviewers,devtools-reviewers,fxview-reviewers,mconley,Standard8,jdescottes,kcochrane,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D176791
2023-06-12 17:16:35 +00:00
Saira Abdulla
9691ab4a5f Bug 1824612 - Convert consumers of toolkit/components/extensions to ES modules. r=robwu,webcompat-reviewers,geckoview-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,cookie-reviewers,twisniewski,sgalich,valentin,nalexander,mconley,m_kato
Depends on D175553

Differential Revision: https://phabricator.services.mozilla.com/D176005
2023-05-31 15:27:03 +00:00
Iulian Moraru
90b739a400 Backed out 2 changesets (bug 1824612) for causing dt failures on browser_dbg-features-source-tree.js. CLOSED TREE
Backed out changeset c3f38adc818e (bug 1824612)
Backed out changeset 58ba8bb3398a (bug 1824612)
2023-05-31 17:28:16 +03:00
Saira Abdulla
2e8db5969a Bug 1824612 - Convert consumers of toolkit/components/extensions to ES modules. r=robwu,webcompat-reviewers,geckoview-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,cookie-reviewers,twisniewski,sgalich,valentin,nalexander,mconley,m_kato
Depends on D175553

Differential Revision: https://phabricator.services.mozilla.com/D176005
2023-05-31 10:21:37 +00:00
Valentin Gosu
304d922abb Bug 1818022 - Simplify the DoH native fallback warning detection and application r=acreskey,necko-reviewers,kershaw
This patch reverts the fallback warning behaviour when a canary heuristic
was tripped. Instead of enabling TRR and failing DNS resolves if skip reason
is a canary code, we now leave it disabled and instead fail DNS resolves
that would have otherwise used TRR if it had been enabled.

Differential Revision: https://phabricator.services.mozilla.com/D179057
2023-05-31 07:39:39 +00:00
Niklas Baumgardner
1c305eb10b Bug 1834554 - Update PiP telemetry. r=pip-reviewers,kpatenio
Depends on D175048

Differential Revision: https://phabricator.services.mozilla.com/D178864
2023-05-30 22:07:26 +00:00
Niklas Baumgardner
cc6b936914 Bug 1811321 - Create PiP panel for disablePiP. r=pip-reviewers,fluent-reviewers,desktop-theme-reviewers,flod,dao,kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D175048
2023-05-30 22:07:26 +00:00
Mark Banner
130a655906 Bug 1826062 - Automatic fixes for upgrading Prettier to 2.8.8. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,calu
Differential Revision: https://phabricator.services.mozilla.com/D177027
2023-05-20 12:26:53 +00:00
Mark Banner
8219a5c503 Bug 1826062 - Automatic fixes for Prettier 2.0.5 upgrade. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,owlish
Differential Revision: https://phabricator.services.mozilla.com/D177025
2023-05-20 12:26:49 +00:00
Iulian Moraru
170aaf5bb7 Backed out changeset bbb3bbd9b6af (bug 1830679) for causing dt failures on browser_storage_cache_delete.js. CLOSED TREE 2023-05-18 22:09:25 +03:00