A poorly thought fixup SQL condition was stripping "www." from the origin in any
case, but when the search string contained "www.".
This ended up stripping too often, for example when typing "w" and matching
against "www.mozilla.org".
Instead, the query should strip "www." from the origin only if it doesn't start
with the search string.
Differential Revision: https://phabricator.services.mozilla.com/D85006
This commit adds a new ecosystem client ID to `ClientID.jsm`. It's
handled the same way as a regular telemetry client ID, in that it's a
random UUID that's persisted to disk, and reset together with the
client ID. Unlike the main client ID, we don't cache it in prefs.
Additionally:
* `setClientID` has been renamed to `setCanaryClientIDs`, and
automatically sets the main and ecosystem client IDs to the canary
(known) ID. It's no longer possible to set either client ID to a
specific value, but only test code did this.
* `resetClientID` has been renamed to `removeClientIDs`, and clears
both client IDs. It no longer returns the new ID; instead, consumers
should call `getClientID` or `getEcosystemClientID` after.
* The ecosystem client ID is included in the `deletion-ping`.
Differential Revision: https://phabricator.services.mozilla.com/D84233
The base class retains the `popup` property, and now the `view` property is
entirely in the subclass. I defined some new methods so that the subclass can
easily customize behavior for a view that's not a popup. I used the name "view"
in these method names to refer to a generic view/panel. I didn't rename `popup`
`view` because the base class still assumes that `popup` is a `menupopup`.
We could/should probably get rid of the "compact" concept and instead specialize
the behavior even further in the subclass, but for simplicity's sake I left that
for now.
Depends on D84784
Differential Revision: https://phabricator.services.mozilla.com/D84785
This moves search-one-offs.js into a jsm without making any substantive changes,
adds a new subclass in UrlbarSearchOneOffs.jsm, and uses `UrlbarSearchOneOffs`
in `UrlbarView` instead of the base `SearchOneOffs` class. `UrlbarSearchOneOffs`
will be fleshed out in part 2.
Differential Revision: https://phabricator.services.mozilla.com/D84784
The base class retains the `popup` property, and now the `view` property is
entirely in the subclass. I defined some new methods so that the subclass can
easily customize behavior for a view that's not a popup. I used the name "view"
in these method names to refer to a generic view/panel. I didn't rename `popup`
`view` because the base class still assumes that `popup` is a `menupopup`.
We could/should probably get rid of the "compact" concept and instead specialize
the behavior even further in the subclass, but for simplicity's sake I left that
for now.
Depends on D84784
Differential Revision: https://phabricator.services.mozilla.com/D84785
This moves search-one-offs.js into a jsm without making any substantive changes,
adds a new subclass in UrlbarSearchOneOffs.jsm, and uses `UrlbarSearchOneOffs`
in `UrlbarView` instead of the base `SearchOneOffs` class. `UrlbarSearchOneOffs`
will be fleshed out in part 2.
Differential Revision: https://phabricator.services.mozilla.com/D84784
There's two issues being fixed here - the first is that no-unused-vars now reports against the last instance of the unused variable. The second is no-dupe-else-if is now on by default.
Depends on D84816
Differential Revision: https://phabricator.services.mozilla.com/D84818
This commit adds a new ecosystem client ID to `ClientID.jsm`. It's
handled the same way as a regular telemetry client ID, in that it's a
random UUID that's persisted to disk, and reset together with the
client ID. Unlike the main client ID, we don't cache it in prefs.
Additionally:
* `setClientID` has been renamed to `setCanaryClientIDs`, and
automatically sets the main and ecosystem client IDs to the canary
(known) ID. It's no longer possible to set either client ID to a
specific value, but only test code did this.
* `resetClientID` has been renamed to `removeClientIDs`, and clears
both client IDs. It no longer returns the new ID; instead, consumers
should call `getClientID` or `getEcosystemClientID` after.
* The ecosystem client ID is included in the `deletion-ping`.
Differential Revision: https://phabricator.services.mozilla.com/D84233
This gets the print UI into a tab modal but does so by abusing
SubDialog. This should be migrated to TabDialogBox in bug 1653317.
Differential Revision: https://phabricator.services.mozilla.com/D84244
The old query was picking a random bookmarked status out of the pages in an origin,
depending on the physical position of the origin rows in the table.
The new query uses window functions to partition the data by origin, so it can
query origins just once and sum www and non-www origin's frecency scores before
comparing to the autofill threshold.
Differential Revision: https://phabricator.services.mozilla.com/D84657
