Commit Graph

35 Commits

Author SHA1 Message Date
Ehsan Akhgari
5ce917a794 Bug 674558 - Implement the HTML5 selectionDirection property for text controls (input and textarea); r=bzbarsky 2011-07-28 13:51:22 -04:00
Ehsan Akhgari
15bb64e5e7 Bug 629878 - Part 2: Do not scroll the selection into view when restoring the selection offsets for a text control after a reframe; r=roc a=blocking-final+
Previously, we used to scroll the text control's selection into view after a
reframe.  This had two problems: it was not precise (in case the selection was
modified by the mouse, for example), and it lead to problems such as bug 629878
if the control's frame was reconstructed because of the control being moved
inside the DOM.

This patch disables that behavior by wrapping the selection scroll function
into nsITextControlFrame::ScrollSelectionIntoView, so that APIs such as
setSelectionRange on the text control's content node can still call it
explicitly (since they actually need this behavior), but other callers of
nsITextControlFrame::SetSelectionRange (such as the nsTextEditorState
object's selection offset restoring mechanism) don't get this behavior as
an undesired side-effect.
2011-02-04 19:29:29 -05:00
Ehsan Akhgari
6139ffb2b9 Bug 534785 - Move the ownership of editor and selection controller from the text frame to the content node; r=roc,jst sr=roc
(transplanted from 2437636244f39bbdc7d20b062e2c978b9d85c239)

--HG--
rename : layout/reftests/forms/placeholder/placeholder-14.html => layout/reftests/forms/placeholder/placeholder-18.html
extra : transplant_source : %247cbD%F3%9B%BD%C7%D2%0B%06.%2C%97%8B%9D%85%C29
2010-04-21 16:17:41 -04:00
Ehsan Akhgari
0bbd9e77c9 Bug 542919 - Refactor the plain text editor initialization to facilitate lazy initialization; r=bzbarsky sr=roc 2010-02-01 23:00:06 -05:00
Ehsan Akhgari
c51a6481a1 Back out the editor lazy inititialization patches (bug 221820) to try to solve the orange in bug 557689 2010-04-06 21:08:58 -04:00
Ehsan Akhgari
3776d4f9f8 Bug 542919 - Refactor the plain text editor initialization to facilitate lazy initialization; r=bzbarsky sr=roc
--HG--
extra : rebase_source : 9c043d3cb30420f061d543e11e3000a1f8e18e27
2010-02-01 23:00:06 -05:00
Ehsan Akhgari
c0c8581846 Backed out changeset e6cf06cfcef9 2010-02-18 19:03:28 -05:00
Ehsan Akhgari
c67120ed70 Bug 542919 - Refactor the plain text editor initialization to facilitate lazy initialization; r=bzbarsky sr=roc
--HG--
extra : rebase_source : 5c6baa16c4f3c91f8564cfdf394d70c8ea507861
2010-02-01 23:00:06 -05:00
Zack Weinberg
d47e0f433b Bug 497495 part 3: Add methods to every nsFrame subclass that expose the as-allocated identity of every frame object. Also some cleanups to the QueryFrame implementation. r=dbaron sr=roc 2009-09-12 17:49:24 +01:00
Robert O'Callahan
4453cced60 Backed out changeset e2927bb26412 2009-08-26 14:49:18 -07:00
Zack Weinberg
64f6d4d0dd Bug 497495 part 3a: rationalize the queryframe-implementation macro naming scheme, restructure the implementation to detect duplicate entries, and a couple fixes to the frame ID enumeration. r=dbaron sr=roc
Bug 497495 part 3b: update users of queryframe macros (strictly mechanical change). r=dbaron

--HG--
extra : rebase_source : ee672a17934227b408b83dc6b5cc4e4909652f72
2009-08-26 09:27:42 -07:00
Benjamin Smedberg
3498a5f86e Bug 396185 - Make nsIFrame derivatives and helper abstract classes use a different dynamic-cast system than nsISupports:
* we know all types frames may be cast to at compile time, so instead of extensible GUID IIDs, use a big enum (see nsQueryFrame::FrameIID)
* eliminate all vestiges of refcounting, since frames aren't refcounted

Some frames (SVG frames in particular) still implement nsISupports-derived interfaces, for example nsISVGValue. There is a FrameIID for nsISVGValue that lets you go from a frame to the XPCOM interface, but you can't query back.

r+sr=roc

nsITextControlFrame didn't have an IID the first time around, but this wasn't a compile error because nsITextControlFrame::kFrameIID inherited from nsIFormControlFrame::kFrameIID. I've added a static analysis pass to verify the correct behavior, since I can't figure out a way to make the compiler do it.

--HG--
extra : rebase_source : 4894a2ca0278e2ab92f27459db77165f8348cf41
2009-01-12 14:20:59 -05:00
Benjamin Smedberg
7a0477cfbf Bug 461186 - nsTextControlFrame should not implement nsIPhonetic: there's only one caller, and that caller can use nsITextControlFrame directly. This is one less frame that implements an nsISupports-derived interface. r+sr=roc 2008-10-27 20:27:55 -04:00
roc+%cs.cmu.edu
aac1b0d44f Bug 330305. Rename nsSelection to nsFrameSelection, and deCOMtaminate it, removing nsIFrameSelection. patch by Marc Liddell, r+sr=roc 2006-04-26 02:01:07 +00:00
sharparrow1%yahoo.com
aa0cb36648 Trivial; attempt to fix linux bustage 2006-02-21 01:27:11 +00:00
sharparrow1%yahoo.com
eb67fd0b3d Bug 327868: nsIFrameSelection cleanup. r+sr=roc 2006-02-21 00:49:04 +00:00
roc+%cs.cmu.edu
b65c655ed9 Bug 254755. deCOMtaminate nsIFormControlFrame. patch by jpl24, r+sr=roc 2005-12-12 23:53:06 +00:00
bsmedberg%covad.net
78f6d0683d Bug 313309 part 2 - change the NS_DEFINE_STATIC_IID_ACCESSOR macro to NS_DECLARE, and make a NS_DEFINE_ macro that's outside the class declaration, r=shaver 2005-11-11 14:36:26 +00:00
gerv%gerv.net
708b56cff4 Bug 236613: change to MPL/LGPL/GPL tri-license. 2004-04-18 14:30:37 +00:00
kyle.yuan%sun.com
0f97378c68 Bug 198542 missing #ifndef/#endif directives in nsITextControlFrame.h
r=jkeiser, sr=henry.jia
2003-04-02 08:34:33 +00:00
jkeiser%netscape.com
78b069a372 Change ns(I)GfxTextControlFrame(2) -> ns(I)TextControlFrame (bug 129909), r=rods
@netscape.com, sr=bzbarsky@mit.edu, a=asa
2002-07-26 20:57:24 +00:00
jkeiser%netscape.com
4d507d3aff Remove nsFormFrame forever. bug 125578, r=alexsavulov@netscape.com, sr=jst@netscape.com 2002-06-04 00:44:04 +00:00
jkeiser%netscape.com
79d7d4bffc Make textarea wrap="hard" not wrap text for restore/JS (only submit and edit). bug 74091, r=rods@netscape.com, sr=attinasi@netscape.com 2002-05-16 18:26:05 +00:00
dbaron%fas.harvard.edu
dc85afb6b7 Prevent input elements from adding frames back into the primary frame map during their destruction (and leaving the map with dangling pointers) by passing the frame to functions that will be called during frame destruction to avoid calls to GetPrimaryFrameFor that will repopulate the primary frame map. b=114220 r=jkeiser sr=jst 2001-12-11 05:39:36 +00:00
jkeiser%iname.com
67ebb1e3b4 Fix textboxes not showing up in Print and Print Preview (bug 109914). r=sicking@bigfoot.com;sr=jst@netscape.com 2001-11-16 02:38:10 +00:00
jst%netscape.com
6d64ded4f2 Checking in John Keiser's <jkeiser@iname.com> fix for *tons* of form submission and <select> related bugs, see tracking bug 34297 for details. r=rods@netscape.com, sr=jst@netscape.com 2001-11-02 07:40:01 +00:00
gerv%gerv.net
4e12e44b2f Relicensing Round 1, Take 2. Most C-like NPL files -> NPL/GPL/LGPL. Bug 98089. 2001-09-28 20:14:13 +00:00
mjudge%netscape.com
cf4580dd4d 53151 68396 sr=kin r= kin. removing some ifdefs of dead ender-lite code and fixing a mail news lockup in text traversal 2001-04-12 23:38:32 +00:00
akkana%netscape.com
481b7a5c02 38232 (nsbeta2+): Make line break character configurable in the
output system, and use \n (the DOM linebreak character) when getting
output from text controls.  Also fix some warnings.  r=kin.
2000-07-10 19:46:59 +00:00
mjudge%netscape.com
55912eddb8 changing way we access caret. use the selection controller whenever possible. because it will make the caret do the right thing even when we have multiple selections accessing same caret. 2000-05-11 04:25:43 +00:00
sfraser%netscape.com
e18fe941f0 Adding methods to allow control of the selection in text widgets. 2000-04-13 05:15:59 +00:00
tbogard%aol.net
9398e6b4f3 GetWebShell became GetDocShell to continue the conversion to talking in terms of DocShells instead of webShells. 2000-03-11 01:30:04 +00:00
hyatt%netscape.com
221920403a Patch that gets tabbing back into text fields. r=waterson 1999-12-21 19:35:13 +00:00
hyatt%netscape.com
d3e0848c19 Fixes for 3 PDT+ bugs (THAT'S RIGHT). Bugs 21895, 21832, and 21610. r=mjudge,
a=i'm leaving now for vacation, and i can't find anyone around, but i'm assuming that you
actually want them before January 3rd, so I'm checking them in.
1999-12-18 04:02:28 +00:00
buster%netscape.com
2c36996496 DOM extension for exposing text areas to XUL
bug 12022, r=rickg, vidur
1999-11-19 07:24:15 +00:00