Commit Graph

66718 Commits

Author SHA1 Message Date
Botond Ballo
647b04cbf1 Bug 1509552 - MobileViewportManager::UpdateResolution cleanup, part 3. r=kats
Adds an |UpdateType| parameter to UpdateResolution() to better separate the
pre-reflow and post-reflow logic.

Differential Revision: https://phabricator.services.mozilla.com/D13314

--HG--
extra : moz-landing-system : lando
2018-11-30 00:58:56 +00:00
Botond Ballo
51c7ddc4f7 Bug 1509552 - MobileViewportManager::UpdateResolution cleanup, part 2. r=kats
* Call SetResolutionAndScaleTo() in just one place
* Call UpdateVisualViewportSize() in UpdateResolution() rather than
  requiring the caller to do it (and on non-first paints, only call it
  if the resolution has actually changed)

Differential Revision: https://phabricator.services.mozilla.com/D13313

--HG--
extra : moz-landing-system : lando
2018-11-30 00:56:49 +00:00
Botond Ballo
3c27a3d1e2 Bug 1509552 - MobileViewportManager::UpdateResolution cleanup, part 1. r=kats
* Introduce helpers for converting between zoom and resolution
* Perform calculations in terms of zoom rather than resolution

Differential Revision: https://phabricator.services.mozilla.com/D13312

--HG--
extra : moz-landing-system : lando
2018-11-30 01:01:13 +00:00
Botond Ballo
10aa613485 Bug 1501342 - Add a reftest. r=mstange
Differential Revision: https://phabricator.services.mozilla.com/D13347

--HG--
extra : moz-landing-system : lando
2018-11-30 02:03:03 +00:00
Botond Ballo
5aba9815a4 Bug 1501342 - In ProcessDisplayItems(), handle the case where scrollMetadataASR and mContainerScrollMetadataASR are in different branches of the ASR tree. r=mstange
Differential Revision: https://phabricator.services.mozilla.com/D13346

--HG--
extra : moz-landing-system : lando
2018-11-30 02:02:48 +00:00
Masayuki Nakano
af36a869b3 Bug 1496288 - part 1: Make blacklist prefs for keypress event behavior changes ride the train r=smaug
Basically, we shouldn't have blacklist to disable web API.  However, the
keypress event behavior changes are not standardized things.  Therefore,
if some web developers realize that they need to change their apps when
it's too late for them, Firefox users need to use another browser for
such web apps for several weeks or more, and such things may make the users
switch their default browser.  For avoiding such worst scenario, we should
take the blacklists and if we get such compatibility reports, we should
add the domains into the blacklist even in release channel.

Differential Revision: https://phabricator.services.mozilla.com/D13374

--HG--
extra : moz-landing-system : lando
2018-11-29 15:04:18 +00:00
Miko Mynttinen
6e35b01f91 Bug 1509579 - Part 2: Do not call MarkNeedsDisplayItemRebuild(), when GetDependentFrame() == Frame() r=mattwoodrow
Depends on D13279

Differential Revision: https://phabricator.services.mozilla.com/D13280

--HG--
extra : moz-landing-system : lando
2018-11-29 20:40:58 +00:00
Miko Mynttinen
929f8a7027 Bug 1509579 - Part 1: Do not mark frames modified after the rebuild limit has been reached r=mattwoodrow
Differential Revision: https://phabricator.services.mozilla.com/D13279

--HG--
extra : moz-landing-system : lando
2018-11-29 05:19:36 +00:00
Emilio Cobos Álvarez
b39cd46f55 Bug 1510080 - Fix appending into a fragmented fieldset. r=TYLin
Differential Revision: https://phabricator.services.mozilla.com/D13079

--HG--
extra : moz-landing-system : lando
2018-11-29 21:54:57 +00:00
Daniel Holbert
5870eaf32d Bug 1337655 part 1: Move some prefixed gradient values to pref-controlled sections of property_database.js. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D13370

--HG--
extra : moz-landing-system : lando
2018-11-29 18:27:28 +00:00
Kartikaya Gupta
cca0a66cf0 Bug 1510639 - Add reftests for various scenarios involving sticky items inside scrollframes and transforms. r=kvark
Differential Revision: https://phabricator.services.mozilla.com/D13367

--HG--
extra : moz-landing-system : lando
2018-11-29 14:57:24 +00:00
Daniel Varga
d4b090ea42 Merge mozilla-central to autoland. a=merge on a CLOSED TREE
--HG--
extra : rebase_source : 81b5f62e48ccbe6c941a80b72a4eebe0ed942ccf
2018-11-29 11:59:02 +02:00
Coroiu Cristina
da4da94439 Merge mozilla-central to inbound a=merge 2018-11-29 06:39:53 +02:00
Coroiu Cristina
e92b0f1d7f Merge inbound to mozilla-central a=merge 2018-11-29 06:27:40 +02:00
Masayuki Nakano
83f155f075 Bug 1498816 - part 1: Make nsFrameSelection::CommonPageMove() emulate click in current selection limiter r=smaug
nsFrameSelection::CommonPageMove() is called only by
nsTextInputSelectionImpl::PageMove() and PresShell::PageMove().  So, this is
the only implementation of (Shift+) PageDown and (Shift+) PageUp.

This scrolls down/up the specific frame.  However, this allows to scroll
outside of selection limiter, for example, even when an editing host is
focused, its parent scrollable element may be scrolled.  This is same behavior
as Blink so that we should keep this behavior.

However, it also emulates to click same position after scroll and this behavior
is different from Blink.  At this time, it does not check selection limiter and
then, nsFrameSelection::HandleClick() may reset selection limiter the scrolled
frame is a parent frame of the limiter.

Therefore, this patch makes it check if the scrolled frame is a parent of the
limiter, and if so, use result of GetFrameToPageSelect() to emulate a click
instead.  The result won't be a parent of the limiter because it is used when
handling Shift + PageDown and Shift + PageUp which are always handled in the
limiter.

Differential Revision: https://phabricator.services.mozilla.com/D13202

--HG--
extra : moz-landing-system : lando
2018-11-29 06:16:15 +00:00
Masayuki Nakano
451e39f20d Bug 1498816 - part 0: Add automated tests of PageDown/PageUp key handling in an editing host r=smaug
Even if there is no scrollable element is in focused editing host, its parent
scrollable element should be scrolled.  However, focus shouldn't be moved and
selection ranges should be kept in the editing host.

Differential Revision: https://phabricator.services.mozilla.com/D13201

--HG--
extra : moz-landing-system : lando
2018-11-28 11:04:09 +00:00
Bogdan Tara
87661d5c7d Backed out changeset 30accf21bb0a (bug 1510214) perma failing org.mozilla.geckoview.test.AccessibilityTest.testScroll CLOSED TREE 2018-11-29 07:51:59 +02:00
Coroiu Cristina
3ba5c153be Merge mozilla-central to autoland a=merge 2018-11-29 06:38:18 +02:00
Hiroyuki Ikezoe
cb90e86a66 Bug 1510214 - Change the default minimum scale to match Chrome's. r=botond
The reftest in this commit fails without changing the default value.  The test
image is shrunk too much.

Differential Revision: https://phabricator.services.mozilla.com/D13172

--HG--
extra : moz-landing-system : lando
2018-11-29 02:51:18 +00:00
Gabriele Svelto
19e52bebd4 Bug 1510582 - Remove useless inclusions of Services.h r=erahm
Differential Revision: https://phabricator.services.mozilla.com/D13240

--HG--
extra : moz-landing-system : lando
2018-11-28 17:25:23 +00:00
Kartikaya Gupta
789591abf5 Bug 1503447 - Follow-up to fix reftest annotation. r=kvark CLOSED TREE
Reviewers: kvark

Bug #: 1503447

Differential Revision: https://phabricator.services.mozilla.com/D13307

--HG--
extra : rebase_source : bcacc6ee0377729c0e72fbd957891494e1b491be
extra : histedit_source : eccecf153af1a70663b2537edb7ae1b041c60fa4
2018-11-28 22:57:44 +02:00
Emilio Cobos Álvarez
9d8364e9b2 Bug 1498639 - Mark the reftest random-if since it passes sometimes.
CLOSED TREE
2018-11-28 21:25:21 +01:00
Mats Palmgren
e376f2d1c6 Bug 1509903 part 2 - Make the remaining nsTextFrame virtual methods 'final' unless they are overridden by nsContinuingTextFrame. r=emilio 2018-11-29 00:17:25 +01:00
Mats Palmgren
7cdfa1649e Bug 1509903 part 1 - Make nsTextFrame::IsFrameSelected() 'final' and inline nsIFrame::IsSelected() to de-virtualize the IsFrameSelected() call in some cases. r=emilio
In particular, in nsCharClipDisplayItem::IsSelected() we know that
the frame must be a nsTextFrame (or nsContinuingTextFrame) which
means nsTextFrame::IsFrameSelected() can be called directly now.
2018-11-29 00:17:25 +01:00
Emilio Cobos Álvarez
966d9cdd49 Bug 1498639 - Add a reftest (failing in WR). r=kats
Differential Revision: https://phabricator.services.mozilla.com/D12217

--HG--
extra : moz-landing-system : lando
2018-11-28 19:07:35 +00:00
Emilio Cobos Álvarez
448cf93a79 Bug 1498639 - Force the creation of APZ scroll data for the frames with perspective property, not just their children. r=kats
This fixes the assertion, though not the test-case, but now I can debug the
test-case and also land it as failing for now.

What was happening is that we had two ASRs (for the canvas and for the <body>),
and we were creating scroll data for the CompositorHitTestInfo of the <body>
(which obviously didn't have any ancestor transform) and for the
nsDisplayTransform in the backface for which HasPerspective returns true for,
but which already had an ancestor transform for the frame for which
ChildrenHavePerspective returns true.

It may be less risky to force it for both, but this doesn't make anything fail.

Differential Revision: https://phabricator.services.mozilla.com/D13242

--HG--
extra : moz-landing-system : lando
2018-11-28 15:56:58 +00:00
Dzmitry Malyshau
54ba2010c1 Bug 1503447 - Always use zero origin for WR reference frames and stacking contexts r=kats
Previously, WebRender was getting a rectangle for reference frames
and stacking contexts, and it had to carefully treat the origin of this rectange:
  - by offseting all the items in a stacking context
  - by negatively compensating the sticky frame scroll port according to the
parent reference frame origin

With this change, we stop providing any non-zero origins. Instead we accomplish
the same behavior using existing API primitives, such as reference frames:
  1. when a stacking context has an origin, we push another reference frame for it
  2. when computing the sticky frame scroll port, we take this origin into account

This slightly simplifies Gecko-WR API, but more importantly it would allow WR to
get rid of this logic (of handling origins), which in turn would allow to switch
the reference frames from push()/pop() model to just define(), like we do for
scroll/sticky frames already.

Differential Revision: https://phabricator.services.mozilla.com/D13081

--HG--
extra : moz-landing-system : lando
2018-11-28 15:32:41 +00:00
Narcis Beleuzu
32a0676730 Merge autoland to mozilla-central. a=merge 2018-11-28 11:48:31 +02:00
Cosmin Sabou
20c5475d6d Merge mozilla-central to autoland. 2018-11-28 06:11:15 +02:00
Cosmin Sabou
e1e8f2ea69 Merge mozilla-inbound to mozilla-central. a=merge 2018-11-28 06:08:19 +02:00
Kyle Machulis
c241567f0f Bug 1505601 - Turn nsIDocShell XPIDL const lists into cenums; r=bzbarsky
Turn all const lists and related attributes into cenums, to provide a
vague sense of type safety.

Depends on D11715

Differential Revision: https://phabricator.services.mozilla.com/D11716

--HG--
extra : moz-landing-system : lando
2018-11-28 03:30:56 +00:00
Hiroyuki Ikezoe
d745109dfb Bug 1504065 - Drop text in the child element inside background-color animated element to avoid fuzziness on Windows 7 GPU. r=birtles
Depends on D13002

Differential Revision: https://phabricator.services.mozilla.com/D13171

--HG--
extra : moz-landing-system : lando
2018-11-28 01:43:55 +00:00
Hiroyuki Ikezoe
218b4e7038 Bug 1504065 - Support background-color animations on the compositor for nsIDOMWindowUtils::GetOMTAValue. r=birtles
Depends on D13001

Differential Revision: https://phabricator.services.mozilla.com/D13002

--HG--
extra : moz-landing-system : lando
2018-11-28 00:59:15 +00:00
Hiroyuki Ikezoe
22056382c0 Bug 1504065 - Run background-color animations on the compositor. r=birtles
Changes for nsIDOMWindowUtils.getOMTAValue is in the next commit with come test
cases.

Differential Revision: https://phabricator.services.mozilla.com/D13001

--HG--
extra : moz-landing-system : lando
2018-11-28 00:58:46 +00:00
Victor Porof
6d5a049f43 Bug 1503824 - Migrate the treecols binding into a custom element. r=bgrins 2018-11-27 18:43:58 +01:00
Cosmin Sabou
0afa5aa670 Backed out 2 changesets (bug 1508472) for causing build bustages on JobScheduler_posix.cpp. CLOSED TREE
Backed out changeset af951294cf96 (bug 1508472)
Backed out changeset 2320933cb7bc (bug 1508472)
2018-11-28 00:08:11 +02:00
Sylvestre Ledru
9ea4a3d5c0 Bug 1508472 - Part 3: Third batch of comment fix-ups in preparation for the tree reformat (layout/) r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D13125

--HG--
extra : moz-landing-system : lando
2018-11-27 21:39:24 +00:00
Kartikaya Gupta
586636a517 Bug 1510026 - Send a sync IPC round-trip to the compositor after every crashtest. r=mattwoodrow
This sends a sync IPC message to the compositor after each crashtest, to
ensure that any stuff inflight in the compositor settles down. In
particular this should round-trip through all of the relevant compositor
threads (i.e. for WebRender it should ensure the scene builder, render
backend, and renderer threads all get flushed).

Differential Revision: https://phabricator.services.mozilla.com/D13033

--HG--
extra : moz-landing-system : lando
2018-11-27 19:46:23 +00:00
Rob Thijssen
d5df040c64 Bug 1509973 - move reftest from gecko-t-win10-64-hw to gecko-t-win10-64-gpu r=jmaher
Differential Revision: https://phabricator.services.mozilla.com/D12972

--HG--
extra : moz-landing-system : lando
2018-11-27 16:27:32 +00:00
Emilio Cobos Álvarez
a40dd78966 Bug 1509989 - Make sure the start container is safe to access in nsRange::InsertNode. r=mats
Depends on D13070

Differential Revision: https://phabricator.services.mozilla.com/D13071

--HG--
extra : moz-landing-system : lando
2018-11-27 16:56:26 +00:00
Razvan Maries
8965794e05 Merge mozilla-central to autoland. a=merge on a CLOSED TREE 2018-11-27 19:35:52 +02:00
Razvan Maries
99a5f987b3 Merge mozilla-inbound to mozilla-central a=merge 2018-11-27 19:32:31 +02:00
Andreea Pavel
f97b59258b Backed out 2 changesets (bug 1504065) for failing Win reftest at child-in-animating-element-display-none.html on a CLOSED TREE
Backed out changeset 129188370231 (bug 1504065)
Backed out changeset 359e81b35cfb (bug 1504065)
2018-11-27 15:33:29 +02:00
Razvan Maries
1a6559c239 Backed out 4 changesets (bug 1505887, bug 1509989) for failing crashtests on tests/layout/style/crashtests/1509989.html on a CLOSED TREE.
Backed out changeset dc6c022e9fe1 (bug 1509989)
Backed out changeset 490a99122a7f (bug 1505887)
Backed out changeset 7b9afff4ff11 (bug 1505887)
Backed out changeset 15da6e919d80 (bug 1505887)
2018-11-27 14:10:30 +02:00
Andreas Farre
3ccff85cdd Bug 1502330 - Create BrowsingContext with passed opener. r=qdot
By replacing nsWebBrowser's implementation of the
nsIBaseWindow.initWindow and nsIBaseWindow.create with a new static
nsWebBrowser::Create method we make it possible to pass arguments
directly when creating an nsWebBrowser, for example the opener
BrowsingContext. As a bonus we can do away with
nsWebBrowser::mInitInfo!

Differential Revision: https://phabricator.services.mozilla.com/D12634

--HG--
extra : moz-landing-system : lando
2018-11-27 09:59:44 +00:00
Hiroyuki Ikezoe
7943d48803 Bug 1504065 - Support background-color animations on the compositor for nsIDOMWindowUtils::GetOMTAValue. r=birtles
Depends on D13001

Differential Revision: https://phabricator.services.mozilla.com/D13002

--HG--
extra : moz-landing-system : lando
2018-11-27 09:27:22 +00:00
Hiroyuki Ikezoe
212fa4884a Bug 1504065 - Run background-color animations on the compositor. r=birtles
Changes for nsIDOMWindowUtils.getOMTAValue is in the next commit with come test
cases.

Differential Revision: https://phabricator.services.mozilla.com/D13001

--HG--
extra : moz-landing-system : lando
2018-11-27 09:26:51 +00:00
Daniel Holbert
3596daf87b Bug 1509972 part 5: Use UniquePtr (not nsAutoPtr) to store a few local vars in nsCSSFrameConstructor. r=TYLin
This patch also gives nsCSSFrameConstructor.h its own UniquePtr include (since
we have some UniquePtr usage there, but no include).  Presumably it's already
getting the include indirectly (via some other header) right now, but it should
really include it directly if it uses the type directly.

(This leaves one nsAutoPtr usage in nsCSSFrameConstructor, for 'mNode'. We can
probably convert that one without too much trouble, but I'm not doing so yet,
in part because we intentionally leak that variable in one spot and I haven't
fully worked out the ownership transfer for that case.)

Differential Revision: https://phabricator.services.mozilla.com/D12992

--HG--
extra : moz-landing-system : lando
2018-11-26 22:48:31 +00:00
Daniel Holbert
9f6e171c2f Bug 1509972 part 4: Use UniquePtr (not nsAutoPtr) to store nsDocumentViewer member mAutoBeforeAndAfterPrint. r=TYLin
Depends on D12995

Differential Revision: https://phabricator.services.mozilla.com/D12996

--HG--
extra : moz-landing-system : lando
2018-11-26 22:34:20 +00:00
Daniel Holbert
c9b8c15108 Bug 1509972 part 3: Use UniquePtr (not nsAutoPtr) for mNext pointers in StaticPresData's "LangGroupFontPrefs" list. r=TYLin
Depends on D12994

Differential Revision: https://phabricator.services.mozilla.com/D12995

--HG--
extra : moz-landing-system : lando
2018-11-26 22:24:36 +00:00