Add dependencies that weren't included in devtools-launchpad no more.
MozReview-Commit-ID: 39KkXvQsR7S
--HG--
extra : rebase_source : 3501a488774044cef2f4d9844b17123a40372a2a
We only label Object as being ArrayLike if they have consecutive, numeric indexes, starting at 0,
and that could contain only a non-numeric length property that matches the actual number of numeric
keys in the object.
A test is added to make sure we don't regress this.
Fix old console frontend tests which relied on the bad implementation of ArrayLike (and delete
test cases now covered by the server test).
MozReview-Commit-ID: ATF7WypNVhh
--HG--
extra : rebase_source : 5e6a0ef0da84cf89518164f518a257bd1f0d5fd8
This test was checking the HTTPinspector by directly calling a WebConsoleClient function
which is no longer used in console code.
MozReview-Commit-ID: LxjhhO2rB0W
--HG--
extra : rebase_source : 411c18a62ae97102907b35f5d5e26749b48047f5
When web-ext (the nodejs CLI tool which is often used to develop a WebExtension)
starts Firefox with the --start-debugger-server CLI parameter,
devtools/shims/devtools-startup.js creates a DebuggerServer instance in an
isolated separate module loader, marked invisible to the debugger so that
we can use it to debug the regular DebuggerServer instance (loaded internally
when the user is going to open one of the developer tools for the first time).
Right after this "debugger invisible" DebuggerServer instance is started,
web-ext connects to the debugger server and interacts with the RDP actors
(e.g. to list the addons actors, install the extensions temporarily, reload
the extensions etc.), and as a side-effect of connecting to the WebExtensions
RDP actor, the "devtools/server/child.js" module is going to be loaded,
and it will be loaded in the main process if the webextensions are not
configured to run in a separate extension child process
(on the contrary it would be loaded in a child process when the
the extensions are running in oop mode).
If the regular developer tools have been already opened by the user (e.g.
when --jsconsole has been passed to the Firefox command line, which
is what happens when web-ext is executed with the --bc command line option),
the DebuggerServer is initialized and the browser actors added to it,
on the contrary when the "devtools/server/child.js" module initializes
the DebuggerServer module for the first time, it doesn't add the browser actors
to it and so the DebuggerServer instance is going initialized but it will be
missing the createRootActor attribute (which is expected if the DebuggerServer
instance is initialized in a child process, but it is unexpected when the DebuggerServer
instance is the one that serves the main process).
MozReview-Commit-ID: GE51X14HfHJ
--HG--
extra : rebase_source : 65e3a0c02f8a419dc8588184dff56d3c07e430a9
In Bug 1404917, we introduced loading the
/devtools/client/netmonitor/test/shared-head.js
file in devtools/client/webconsole/new-console-output/test/mochitest/head.js.
But, the shared file is not declared in browser.ini,
which ends up making variabled from head.js inaccessible,
and some tests that relies on them to fail.
This was not picked up by TRY because the netmonitor tests
are ran before the console's one, which loads
devtools/client/netmonitor/test/shared-head.js .
MozReview-Commit-ID: 80OOUHwjnWL
--HG--
extra : rebase_source : 70a21db32ab3aee38946cc962bede9689a86045b
Switch some calls to addOneTimeListener from callback-style to Promise.
MozReview-Commit-ID: F9AlSvK0MAH
--HG--
extra : rebase_source : 076522e89004f8a4634b4f7732800a5ec14ce633
Once the test was migrated, it was failing because we did not show
error messages for invalid cd() calls.
There was a missing part in the evaluation result prepare message, which
this patch fixes. A stub and a mocha test were added to make sure we do
display those kind of messages.
MozReview-Commit-ID: FcTsP2pr3vD
--HG--
rename : devtools/client/webconsole/new-console-output/test/mochitest/test-bug-609872-cd-iframe-child.html => devtools/client/webconsole/new-console-output/test/mochitest/test-cd-iframe-child.html
rename : devtools/client/webconsole/new-console-output/test/mochitest/test-bug-609872-cd-iframe-parent.html => devtools/client/webconsole/new-console-output/test/mochitest/test-cd-iframe-parent.html
extra : rebase_source : 8fc82b71875cebfed0e318d1eba8b5332dc650c7
@Honza: Please wait for a green try before reviewing this.
MozReview-Commit-ID: 5KlOkYLnorj
--HG--
extra : rebase_source : 339c2dda1eb2afaf490e6bacb613addeece42d04
@nchevobbe: Please wait for a green try before reviewing this.
MozReview-Commit-ID: 9SLEHAq0IQQ
--HG--
extra : rebase_source : f3864d13d36802914171581f9f60351cf71aad2f
As you add more than 7 or so custom devices, the modal will eventually wrap to
a 4th column. Adding some more width allows that to happen without a horizontal
scroll bar.
This width looks natural without custom devices as well, and its not too large
for the most popular screen size (1366 x 768).
MozReview-Commit-ID: 5IErG8NX3xO
--HG--
extra : rebase_source : cbdb862597ef1774964bea135da6376e0cbb7650
@nchevobbe: Please wait for a green try before reviewing this.
MozReview-Commit-ID: 9SLEHAq0IQQ
--HG--
extra : rebase_source : b916d948f3712bf4f09e50436cbdd0cf0f12afb4
Response content should only be fetched whenever it is strictly needed
as it is the response body. A possibly very large string.
So, netmonitor UI should only retrieve it when users select the Response Panel
or do any other action that require having access to it (like "Copy response"
context menu).
MozReview-Commit-ID: CtpJ8PKsCsm
--HG--
extra : rebase_source : 4540f641e511b2199436ad5c2edccda8aff37634
Adding an HTML preview above the raw payload viewer on the developer
tools response tab caused browser_net_cyrillic-02.js to fail since
CodeMirror only renders visible lines to the DOM. The new HTML preview
shares space with the CodeMirror editor, so the resulting height became
shorter; enough to hide the line this test was looking for.
This solution uses CodeMirror.getValue() to retrieve the contents of all
lines stored in memory. Checking against that will allow the test to
pass since it contains the cyrillic text. One downside is that this
makes the test less reliable since it may not be guaranteed that what
CodeMirror has buffered to render will actually be what's inserted into
the DOM.
Two other solutions were explored before settling on the one above. The
first was simulating scroll events through EventUtils.sendWheelAndPaint.
const event = {
deltaMode: WheelEvent.DOM_DELTA_LINE,
deltaY: 20
}
yield new Promise(resolve => {
EventUtils.sendWheelAndPaint(
document.querySelector(".CodeMirror-scroll"),
10,
10,
event,
resolve,
monitor.panelWin
);
})
This did scroll the editor enough to render content and pass the test,
but caused additional errors since monitor.panelWin did not have a
.waitForAllPaintsFlushed() method that EventUtils.sendWheelAndPaint
expected.
The below alternative uses a hard-coded scroll amount and a
requestAnimationFrame as a rough estimate of when scrolling finished.
It worked in the ten or so runs I tested, but there's nothing guaranteed
about requestAnimationFrame that indicates when CodeMirror's rendering
has finished.
document.querySelector(".CodeMirror-scroll").scrollBy(0, 200);
yield new Promise(resolve => requestAnimationFrame(resolve));
MozReview-Commit-ID: H95HjR8UNpx
--HG--
extra : rebase_source : 03e4cd1e3a9042fa565373487c5cbb1118530917
Restoring the HTML preview in the response panel was requested by many
users who rely on it to debug erroring AJAX requests. Many web backend
frameworks display an HTML stacktrace helping users trace down the
problem.
The html-preview.js component was taken from a previous commit of the
source code before the preview panel was removed. A few modifications
with its name and CSS classname were made.
MozReview-Commit-ID: JFyF6cBMaNf
--HG--
extra : rebase_source : 7e358f5fb4336a15f549ecb6f7e24cc00429de8e
MozReview-Commit-ID: 5qWC97NFjKa
***
Bug 1409651- Fix security side panel color in netmonitor; r=gasolin
--HG--
extra : rebase_source : d1d91e737d0c6000d0431aa21eef8aa6a1704aa1
Taken from upstream commit: be179268c9b89390c13bdc9c4cca6000f6f583e5
Added skip-if true to some new debugger mochitests that still look intermittent.
MozReview-Commit-ID: EIcx5z9s7XF
--HG--
extra : rebase_source : 949356260ce38bba65166130d71438f443033137
These low level docs are getting out of date and causing confusion. Further,
they are of limited value at this stage anyway.
MozReview-Commit-ID: FSoNniNZjtj
--HG--
extra : rebase_source : fa5e02a771adcae9b0e53bd18c4eb10ebb5315ef
Bug 1345294 introduced nsPrefBranch::{get,set}StringPref(), which allowed the
getting of utf8 strings from prefs, which previously required using
nsISupportsString with {get,set}ComplexValue. That bug also converted most
uses.
This patch finishes the job.
- It removes the nsISupportsString support.
- It converts existing code that relied on the nsISupportsString.
- It removes the lint that was set up to detect such uses of nsISupportsString.
--HG--
extra : rebase_source : b885ee784704819e181430200af5ef762e269d14
This test verifies that WebExt messaging works as expected for both the
background page scripts and content scripts when RDM is used.
MozReview-Commit-ID: 3fODg3nYLr7
--HG--
extra : rebase_source : ad0051f6c377f15dbe27cf6cac5c3fd07af6fac7
WebExt messaging sends several new message types to content that should be
tunneled by RDM.
This change allows them to reach content as expected in RDM mode.
MozReview-Commit-ID: GKelgOGBUKI
--HG--
extra : rebase_source : 77288fc586efbaeb9b4c344a291c7c5f815e1a15
