Commit Graph

28529 Commits

Author SHA1 Message Date
Andrei Lazar
46f3d5ee22 Bug 1557661 java.lang.NullPointerException: at org.mozilla.gecko.home.TabMenuStripLayout.onPageSelected(TabMenuStripLayout.java) r=VladBaicu
Fixed an issue where we were trying to set some attributes on a null object due to the fact that
the view had not finished rendering.

Differential Revision: https://phabricator.services.mozilla.com/D35515

--HG--
extra : moz-landing-system : lando
2019-06-21 12:22:20 +00:00
Petru Lingurar
b49048f298 Bug 1551614 - Simpler way of restarting our app in a new process; r=VladBaicu
Our Restarter Service would have issues on Android Q:
It would run on a separate process that allowed it to kill the app's process
but when trying to restart the app it would fail because it would've been a
background Service and as such it would've been restricted from starting other
Android Application components.

To make it work on Android Q we would need to migrate it to a foreground
service or piggy-back the SYSTEM_ALERT_WINDOW permission given by the user for
the Tab Queue functionality.

The chosen solution is simpler and not affected by any of those limitations.

Depends on D35402

Differential Revision: https://phabricator.services.mozilla.com/D35403

--HG--
extra : moz-landing-system : lando
2019-06-20 18:53:44 +00:00
Petru Lingurar
94080c4b79 Bug 1551614 - Call BrowserApp's onCreate() before finish(); r=VladBaicu
Fix for the following scenario:
- "Don't keep activities" checked
- Change system language

Upon detecting a locale change in BrowserApp's onCreate() we would call
finish() and then return before calling super.onCreate().

This patch introdues the call to super.onCreate() before returning and ensures
that the app will die cleanly so that upon restarting Gecko can reinit add-ons
that touch the UI.

Differential Revision: https://phabricator.services.mozilla.com/D35402

--HG--
extra : moz-landing-system : lando
2019-06-21 06:24:43 +00:00
Nils Ohlmeier [:drno]
32b81368a2 Bug 1548679: disable future downloads of OpenH264 for Fennec. r=dminor
Differential Revision: https://phabricator.services.mozilla.com/D30939

--HG--
extra : moz-landing-system : lando
2019-06-21 01:00:05 +00:00
Cosmin Sabou
19d5f52e48 Backed out 2 changesets (bug 1551614) for Android checkstyle failures. CLOSED TREE
Backed out changeset 390ec5bd9da7 (bug 1551614)
Backed out changeset ab1822f92ad7 (bug 1551614)
2019-06-20 21:44:41 +03:00
Petru Lingurar
fea8493145 Bug 1555950 - Ignore lint error for drawables used for localized Top Sites; r=VladBaicu
Depends on D34681

Differential Revision: https://phabricator.services.mozilla.com/D35441

--HG--
extra : moz-landing-system : lando
2019-06-20 18:12:01 +00:00
Petru Lingurar
21dedc5b1f Bug 1555950 - Add/update Top Sites favicons; r=VladBaicu
Updated existing "suggestedsites_*" drawables to better match current websites
favicons.
Added new "suggestedsites_*" drawables that are to be used by the localized
Top Sites.
All images are added in density qualified drawable folders which based on my
testing need to range between 90x90px for mdpi to 360x360px for xxxhdpi.

Depends on D34680

Differential Revision: https://phabricator.services.mozilla.com/D34681

--HG--
extra : moz-landing-system : lando
2019-06-20 18:03:07 +00:00
Petru Lingurar
6b9de44c65 Bug 1555950 - Locale changing will rebuild suggested sites lookup map; r=VladBaicu
Differential Revision: https://phabricator.services.mozilla.com/D34680

--HG--
extra : moz-landing-system : lando
2019-06-20 18:02:18 +00:00
Petru Lingurar
471bc82aa0 Bug 1551614 - Simpler way of restarting our app in a new process; r=VladBaicu
Our Restarter Service would have issues on Android Q:
It would run on a separate process that allowed it to kill the app's process
but when trying to restart the app it would fail because it would've been a
background Service and as such it would've been restricted from starting other
Android Application components.

To make it work on Android Q we would need to migrate it to a foreground
service or piggy-back the SYSTEM_ALERT_WINDOW permission given by the user for
the Tab Queue functionality.

The chosen solution is simpler and not affected by any of those limitations.

Depends on D35402

Differential Revision: https://phabricator.services.mozilla.com/D35403

--HG--
extra : moz-landing-system : lando
2019-06-20 15:49:47 +00:00
Petru Lingurar
a75407dafb Bug 1551614 - Call BrowserApp's onCreate() before finish(); r=VladBaicu
Fix for the following scenario:
- "Don't keep activities" checked
- Change system language

Upon detecting a locale change in BrowserApp's onCreate() we would call
finish() and then return before calling super.onCreate().

This patch introdues the call to super.onCreate() before returning and ensures
that the app will die cleanly so that upon restarting Gecko can reinit add-ons
that touch the UI.

Differential Revision: https://phabricator.services.mozilla.com/D35402

--HG--
extra : moz-landing-system : lando
2019-06-20 15:41:10 +00:00
Bogdan Tara
d31a26f7f4 Backed out changeset 91dc017b27e8 (bug 1554189) for MediaDelegateTest.kt related bustages CLOSED TREE 2019-06-19 10:10:28 +03:00
Csoregi Natalia
844b2d3663 Bug 1554189 - Disabled org.mozilla.geckoview.test.MediaDelegateTest.testDeviceRecordingEventAudioAndVideo on debug builds. r=gbrown
Differential Revision: https://phabricator.services.mozilla.com/D35158

--HG--
extra : moz-landing-system : lando
2019-06-19 05:57:49 +00:00
Makoto Kato
1d7ac71577 Bug 1507997 - Use compositionupdate event to wait for composition text r=geckoview-reviewers,snorp
A lot of failures occurs in `org.mozilla.geckoview.test.TextInputDelegateTest.inputConnection` when getting composition string. This tests doesn't wait for `compositionupdate`, so we should listen this event to wait for updating composition string.

Differential Revision: https://phabricator.services.mozilla.com/D34812

--HG--
extra : moz-landing-system : lando
2019-06-17 05:23:17 +00:00
Boris Zbarsky
7add525d55 Bug 1558735 part 2. Stop using [array] in nsIX509Cert.getEmailAddresses. r=keeler
Differential Revision: https://phabricator.services.mozilla.com/D34671

--HG--
extra : moz-landing-system : lando
2019-06-15 03:51:58 +00:00
Dorel Luca
a589b46441 Backed out changeset c48327ec2874 (bug 1554014) for Browser-chrome failures in browser/components/newtab/test/browser/browser_asrouter_targeting.js. CLOSED TREE 2019-06-15 01:20:44 +03:00
Nick Alexander
e7c693693b Bug 1557805 - Support mach run {--app,--profile,--setenv} on Android. r=gbrown
This is just a small step on the path towards support for more
vehicles via the configuration files introduced by Bug 1552519.  It's
enough to invoke GeckoView example.

Differential Revision: https://phabricator.services.mozilla.com/D34952

--HG--
extra : moz-landing-system : lando
2019-06-14 20:14:23 +00:00
Petru Lingurar
cd2679f80d Bug 1557635 - Update the Sync Onboarding screen; r=VladBaicu
With this changes we must now support 3 Onboarding versions.

With this changes we must now support 3 Onboarding versions.

Latest Onboarding UX will use a new title for the "Sync screen", new subtext,
new image and new text for the signin button.
This will be presented only if all this new Strings are localized.

Refactored the existing OnboardingStringUtil to serve as a central point of
getting the right resources to be used and querying the Onboarding UX version
the app should offer.

Added to SyncPanel the missing logic to hide the space otherwise occupied by
the Onboarding screen message, when there is no message.
(now behaving the same as the other Onboarding screens.)

Applied a lossless compression for the new sync image which resulted in a 26.5%
size reduction.

Removed the lint suppression initially necessary for when first added the
updated Sync Strings which were not used at the moment.

Differential Revision: https://phabricator.services.mozilla.com/D35012

--HG--
rename : mobile/android/base/java/org/mozilla/gecko/util/OnboardingStringUtil.java => mobile/android/base/java/org/mozilla/gecko/util/OnboardingResources.java
extra : moz-landing-system : lando
2019-06-14 17:05:33 +00:00
Thomas Wisniewski
1f8762a90e Bug 1554014 - add a webcompat intervention for TinyMCE 3.0 thru 3.4.4 to overwrite tiny_mce.js and tiny_mce_src.js such that isGecko=false; r=bzbarsky,Gijs
add a webcompat intervention for TinyMCE 3.0 thru 3.4.4 to overwrite tiny_mce.js and tiny_mce_src.js such that isGecko=false

Differential Revision: https://phabricator.services.mozilla.com/D34776

--HG--
extra : moz-landing-system : lando
2019-06-13 23:36:29 +00:00
Andrew Creskey
ee27782e07 Bug 1547997 Increase android max connections from 20 to 40 r=mayhemer
The Android preferences limit network.http.max-connections to 20 (set ~7 years ago).
See https://searchfox.org/mozilla-central/rev/f8b11433159cbc9cc80500b3e579d767473fa539/mobile/android/app/mobile.js#102

By removing this preference the android builds will use the all.js android preference, now set to 40.

Differential Revision: https://phabricator.services.mozilla.com/D29368

--HG--
extra : rebase_source : 3c1f9749b549119329973dda6c5c3e48e79e911e
2019-06-14 14:13:32 -04:00
Gurzau Raul
4f7014872e Backed out changeset cc09b9a55c48 (bug 1557635) for lint failure at android_strings.dtd on a CLOSED TREE.
--HG--
rename : mobile/android/base/java/org/mozilla/gecko/util/OnboardingStringsUtil.java => mobile/android/base/java/org/mozilla/gecko/util/OnboardingStringUtil.java
2019-06-14 19:02:22 +03:00
Petru Lingurar
634b95f036 Bug 1557635 - Update the Sync Onboarding screen; r=VladBaicu
With this changes we must now support 3 Onboarding versions.

Latest Onboarding UX will use a new title for the "Sync screen", new subtext,
new image and new text for the signin button.
This will be presented only if all this new Strings are localized.

Refactored the existing OnboardingStringUtil to serve as a central point of
getting the right Strings to be used and querying the Onboarding UX version the
app should offer.

Applied a lossless compression for the new sync image which resulted in a 26.5%
size reduction.

Removed the lint suppression initially necessary for when first added the
updated Sync Strings which were not used at the moment.

Differential Revision: https://phabricator.services.mozilla.com/D35012

--HG--
rename : mobile/android/base/java/org/mozilla/gecko/util/OnboardingStringUtil.java => mobile/android/base/java/org/mozilla/gecko/util/OnboardingStringsUtil.java
extra : moz-landing-system : lando
2019-06-14 12:36:39 +00:00
Brad Arant
ec45022ea2 Bug 1268019 - Fix code violation of missing braces on if code block.;r=VladBaicu
Differential Revision: https://phabricator.services.mozilla.com/D34386

--HG--
extra : moz-landing-system : lando
2019-06-11 07:41:38 +00:00
Karan Sapolia
3cb0a39af4 Bug 1553237 - Simplify nsISearchService.addEngineWithDetails to one signature. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D34709

--HG--
extra : moz-landing-system : lando
2019-06-13 20:35:23 +00:00
Petru Lingurar
efebb8836e Bug 1550291 - Ensure we save CRASHED status to be able to restore previous tabs; r=AndreiLazar
Default app behavior for when a crash occurs involves starting an Activity that
lets users submit a crash report and maybe provide additional info.
In the event of a crash we want to restore for the user all previous tabs, this
Activity being the component that saves the CRASHED status that will trigger
the restore process.

On Android Q, when a crash notification is posted but ignored by the user, upon
starting the app would not know it crashed and it would not try restoring tabs.
Executing the "save CRASHED status" logic whenever a crash occurs, irrespective
of if we'll show the Activity or just post a notification ensures users will
always have their previous tabs restored.

Differential Revision: https://phabricator.services.mozilla.com/D34826

--HG--
extra : moz-landing-system : lando
2019-06-13 13:26:57 +00:00
Eugen Sawin
81dd9a3a64 Bug 1559084 - [1.0] Fix wrong nsIClearDataService constant name for clearing push notifications. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D34859

--HG--
extra : moz-landing-system : lando
2019-06-13 11:17:20 +00:00
Peter Van der Beken
8b00dd9ff2 Bug 1490044 - Move all prefs used in WebIDL to StaticPrefs. r=bzbarsky
Differential Revision: https://phabricator.services.mozilla.com/D33507

--HG--
extra : moz-landing-system : lando
2019-06-13 09:00:59 +00:00
Andrei Lazar
03013c9df0 Bug 1551458 Back button won't go back in history (Pixel 3 XL(Android 9)) r=VladBaicu
Created an exception in the key event suppression mechanism for the back button KEYCODE.

Differential Revision: https://phabricator.services.mozilla.com/D33950

--HG--
extra : moz-landing-system : lando
2019-06-12 10:36:01 +00:00
Ehsan Akhgari
caea64f895 Bug 1557872 - Add a new JS module for manipulating the Content Blocking allow list; r=nhnt11
Differential Revision: https://phabricator.services.mozilla.com/D34355

--HG--
extra : source : 832579daee7c9e328d220611ab8929a1a4cf150b
2019-06-11 22:28:31 +00:00
Dorel Luca
ddbbed33a8 Backed out changeset 832579daee7c (bug 1557872) for Browser-chrome failures in browser/components/contextualidentity/test/browser/browser_aboutURLs.js. CLOSED TREE 2019-06-12 10:06:21 +03:00
Ehsan Akhgari
19f96d0e2a Bug 1557872 - Add a new JS module for manipulating the Content Blocking allow list; r=nhnt11
Differential Revision: https://phabricator.services.mozilla.com/D34355

--HG--
extra : moz-landing-system : lando
2019-06-11 22:28:31 +00:00
Boris Zbarsky
9de72a3ac6 Bug 1557793 part 2. Stop using [array] in nsIStringBundle. r=Pike
Differential Revision: https://phabricator.services.mozilla.com/D34196

--HG--
extra : moz-landing-system : lando
2019-06-11 15:51:51 +00:00
Mihai Alexandru Michis
bbc8c51513 Backed out changeset 975fec3b327c (bug 1557872) for causing bc failures in browser_trackingUI_pbmode_exceptions.js CLOSED TREE 2019-06-11 19:43:07 +03:00
Ehsan Akhgari
2945c907d7 Bug 1557872 - Add a new JS module for manipulating the Content Blocking allow list; r=nhnt11
Differential Revision: https://phabricator.services.mozilla.com/D34355

--HG--
extra : moz-landing-system : lando
2019-06-11 14:42:58 +00:00
Jonathan Kingston
3dd41f32a1 Bug 1557035 - Changing android hardcoded system principal session to fix tests. r=JanH
Differential Revision: https://phabricator.services.mozilla.com/D33930

--HG--
extra : moz-landing-system : lando
2019-06-07 15:42:29 +00:00
Cosmin Sabou
22bf0df6b7 Bug 1535423 - Fix Android bustages. r=bustage-fix
--HG--
extra : rebase_source : 890c775f4e8081440c04113665d4318678e17f98
2019-06-11 01:52:01 +03:00
Andreea Pavel
9ba5553f62 Bug 1535423 - Disable PromptDelegateTest for frequent failures. r=gbrown
Differential Revision: https://phabricator.services.mozilla.com/D34348

--HG--
extra : moz-landing-system : lando
2019-06-10 22:15:38 +00:00
Agi Sferro
a641bc8da0 Bug 1554260 - Send WebExtension Page messages to GeckoSession. r=snorp
WebExtension pages introduce a case that was previously not possible: a script
with full WebExtension privileges that runs on a page with a GeckoSession
associated to it.

This breaks the assumption that all messages from a privileged context don't
have a GeckoSession associated to it. We fix this by checking if we can find an
eventDispatcher for the given window.

This also fixes the test which had the same wrong assumption.

Differential Revision: https://phabricator.services.mozilla.com/D32512

--HG--
extra : moz-landing-system : lando
2019-06-10 20:09:25 +00:00
Petru Lingurar
70755e0b8c Bug 1550291 - Android Q: Use the overlay permission or a foreground notification to start the crash handler; r=VladBaicu
Android Q doesn't allow starting Activities from background.
https://developer.android.com/preview/privacy/background-activity-starts

We can either piggy-back the SYSTEM_ALERT_WINDOW permission given by the user
for the Tab Queue functionality or use a foreground notification from where
users could start `CrashReporterActivity`.

Differential Revision: https://phabricator.services.mozilla.com/D33029

--HG--
extra : moz-landing-system : lando
2019-06-10 15:52:58 +00:00
Petru Lingurar
c9f1eb41c0 Bug 1550291 - Add new "Crash handler" notification channel; r=JanH
Differential Revision: https://phabricator.services.mozilla.com/D33028

--HG--
extra : moz-landing-system : lando
2019-06-07 08:01:46 +00:00
Boris Zbarsky
5eb248348f Bug 1557847. Stop using [array] in nsIClipboard. r=NeilDeakin
Differential Revision: https://phabricator.services.mozilla.com/D34243

--HG--
extra : moz-landing-system : lando
2019-06-09 01:06:39 +00:00
Cosmin Sabou
fc860d4bca Bug 1555662 - Follow-up: change 'l10n-registry.js' to 'l10n-registry.manifest'. r=John-Galt,gandalf
--HG--
extra : amend_source : 48cb36ee88ba34cf1ce0d137fe06a31e13035e36
2019-06-09 00:34:53 +03:00
Nicklas Boman
f293246462 Bug 1519365 - Update object property names that get passed to loadURIOptions to match the names in loadURIOptions r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D31729

--HG--
extra : moz-landing-system : lando
2019-06-08 11:04:27 +00:00
Zibi Braniecki
b4932e4709 Bug 1555662 - Register L10nRegistry sources using categories. r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D34227

--HG--
extra : moz-landing-system : lando
2019-06-08 04:37:31 +00:00
Andreea Pavel
ab7673faaa Backed out 2 changesets (bug 1555662) for multiple bc failures e.g browser_panelUINotifications_multiWindow.js on a CLOSED TREE
Backed out changeset 84c57f9dda5b (bug 1555662)
Backed out changeset ede8b931ee0d (bug 1555662)
2019-06-08 03:25:28 +03:00
Zibi Braniecki
6ca89e400f Bug 1555662 - Register L10nRegistry sources using categories. r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D34227

--HG--
extra : moz-landing-system : lando
2019-06-07 20:11:00 +00:00
Alvina Waseem
e40d11acc6 Bug 1533575 - Simplified GeckoSession.MediaSource.Source constants. r=droeh,geckoview-reviewers,snorp
Differential Revision: https://phabricator.services.mozilla.com/D34010

--HG--
extra : moz-landing-system : lando
2019-06-07 18:33:34 +00:00
Csoregi Natalia
f54d8331b9 Merge autoland to mozilla-central. a=merge 2019-06-07 00:51:26 +03:00
Csoregi Natalia
db63d343f2 Backed out changeset d637ee5ceb51 (bug 1552145) as per request. a=backout 2019-06-07 00:45:43 +03:00
shindli
3caa33a7ea Merge inbound to mozilla-central. a=merge 2019-06-06 12:57:52 +03:00
Andrei Teslovan
4d74397909 Bug 1556382 - Reset error message for "Find in page" after dismiss; r=VladBaicu
Differential Revision: https://phabricator.services.mozilla.com/D33934

--HG--
extra : moz-landing-system : lando
2019-06-06 11:57:23 +00:00