Commit Graph

8 Commits

Author SHA1 Message Date
Kris Maglione
e930b89c34 Bug 1514594: Part 3 - Change ChromeUtils.import API.
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8

This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:

  ChromeUtils.import("resource://gre/modules/Services.jsm");

is approximately the same as the following, in the new model:

  var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");

Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs

This was done using the followng script:

https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8

Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16750

--HG--
extra : rebase_source : 359574ee3064c90f33bf36c2ebe3159a24cc8895
extra : histedit_source : b93c8f42808b1599f9122d7842d2c0b3e656a594%2C64a3a4e3359dc889e2ab2b49461bab9e27fc10a7
2019-01-17 10:18:31 -08:00
Andrew McCreight
5dec0e0beb Bug 1432992, part 1 - Remove definitions of Ci, Cr, Cc, and Cu. r=florian
This patch was autogenerated by my decomponents.py

It covers almost every file with the extension js, jsm, html, py,
xhtml, or xul.

It removes blank lines after removed lines, when the removed lines are
preceded by either blank lines or the start of a new block. The "start
of a new block" is defined fairly hackily: either the line starts with
//, ends with */, ends with {, <![CDATA[, """ or '''. The first two
cover comments, the third one covers JS, the fourth covers JS embedded
in XUL, and the final two cover JS embedded in Python. This also
applies if the removed line was the first line of the file.

It covers the pattern matching cases like "var {classes: Cc,
interfaces: Ci, utils: Cu, results: Cr} = Components;". It'll remove
the entire thing if they are all either Ci, Cr, Cc or Cu, or it will
remove the appropriate ones and leave the residue behind. If there's
only one behind, then it will turn it into a normal, non-pattern
matching variable definition. (For instance, "const { classes: Cc,
Constructor: CC, interfaces: Ci, utils: Cu } = Components" becomes
"const CC = Components.Constructor".)

MozReview-Commit-ID: DeSHcClQ7cG

--HG--
extra : rebase_source : d9c41878036c1ef7766ef5e91a7005025bc1d72b
2018-02-06 09:36:57 -08:00
Kris Maglione
918ed6c474 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : source : 12fc4dee861c812fd2bd032c63ef17af61800c70
extra : intermediate-source : 34c999fa006bffe8705cf50c54708aa21a962e62
extra : histedit_source : b2be2c5e5d226e6c347312456a6ae339c1e634b0
2018-01-29 15:20:18 -08:00
Cosmin Sabou
9a65a40178 Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE
Backed out changeset a1eca62826a1 (bug 1431533)
Backed out changeset 34c999fa006b (bug 1431533)
Backed out changeset e2674287e57f (bug 1431533)
2018-01-30 07:17:48 +02:00
Kris Maglione
6476f95b13 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : source : 12fc4dee861c812fd2bd032c63ef17af61800c70
2018-01-29 15:20:18 -08:00
Brindusan Cristian
af8879d1eb Backed out 2 changesets (bug 1431533) for ESlint failures on a CLOSED TREE
Backed out changeset 6e56f4c8843e (bug 1431533)
Backed out changeset 12fc4dee861c (bug 1431533)
2018-01-30 02:32:43 +02:00
Kris Maglione
c276bb9375 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : rebase_source : c004a023389f1f6bf3d2f3efe93c13d423b23ccd
2018-01-29 15:20:18 -08:00
Andrea Marchesini
9b8df4a1d1 Bug 1270185 - create dom/url for URL API and its tests, r=ehsan
--HG--
rename : dom/base/URL.cpp => dom/url/URL.cpp
rename : dom/base/URL.h => dom/url/URL.h
rename : dom/base/URLSearchParams.cpp => dom/url/URLSearchParams.cpp
rename : dom/base/URLSearchParams.h => dom/url/URLSearchParams.h
rename : dom/base/test/file_url.jsm => dom/url/tests/file_url.jsm
rename : dom/workers/test/file_url.jsm => dom/url/tests/file_worker_url.jsm
rename : dom/workers/test/jsm_url_worker.js => dom/url/tests/jsm_url_worker.js
rename : dom/workers/test/test_bug883784.jsm => dom/url/tests/test_bug883784.jsm
rename : dom/workers/test/test_bug883784.xul => dom/url/tests/test_bug883784.xul
rename : dom/base/test/test_unknown_url_origin.html => dom/url/tests/test_unknown_url_origin.html
rename : dom/base/test/test_url.html => dom/url/tests/test_url.html
rename : dom/base/test/test_url.xul => dom/url/tests/test_url.xul
rename : dom/base/test/test_urlExceptions.html => dom/url/tests/test_urlExceptions.html
rename : dom/base/test/test_urlSearchParams.html => dom/url/tests/test_urlSearchParams.html
rename : dom/base/test/test_urlSearchParams_utf8.html => dom/url/tests/test_urlSearchParams_utf8.html
rename : dom/base/test/test_url_data.html => dom/url/tests/test_url_data.html
rename : dom/base/test/test_url_empty_port.html => dom/url/tests/test_url_empty_port.html
rename : dom/base/test/test_url_malformedHost.html => dom/url/tests/test_url_malformedHost.html
rename : dom/base/test/test_urlutils_stringify.html => dom/url/tests/test_urlutils_stringify.html
rename : dom/workers/test/test_url.html => dom/url/tests/test_worker_url.html
rename : dom/workers/test/test_url.xul => dom/url/tests/test_worker_url.xul
rename : dom/workers/test/test_urlApi.html => dom/url/tests/test_worker_urlApi.html
rename : dom/workers/test/test_urlSearchParams.html => dom/url/tests/test_worker_urlSearchParams.html
rename : dom/workers/test/test_url_exceptions.html => dom/url/tests/test_worker_url_exceptions.html
rename : dom/workers/test/urlApi_worker.js => dom/url/tests/urlApi_worker.js
rename : dom/workers/test/urlSearchParams_worker.js => dom/url/tests/urlSearchParams_worker.js
rename : dom/workers/test/url_exceptions_worker.js => dom/url/tests/url_exceptions_worker.js
rename : dom/workers/test/url_worker.js => dom/url/tests/url_worker.js
2016-06-29 07:44:18 +02:00