Commit Graph

791 Commits

Author SHA1 Message Date
Ehsan Akhgari
62312843c5 Bug 414526 - Backspace at the beginning of a contenteditable element or delete at the end of one should not affect the rest of the contenteditable elements on the page; r=roc
The main fix here involves the introduction of the nsHTMLEditor::IsNodeInActiveEditor
API.  This API returns true if the current selection in the document falls
inside the active editable section.  The patch adds a bunch of checks using
this API to various places in the code to make sure that editing operations do
not escape their editing host.

There are also some unrelated fixes to range promotion code which fix the
bugs that have existed in that code before, but because of the lack of this
check were not uncovered before.

This patch also removes the nsTextEditUtils::InBody API which only made sense
in designMode documents, and was insufficient for contenteditable elements.
2011-07-14 11:25:07 -04:00
Simon Montagu
41b695192a Undefine caret bidi level during reflow instead of on text entry. Bug 664087, r=roc 2011-07-05 08:42:32 +03:00
Jonas Sicking
a326e5c69f Bug 658714 Part 10: Remove nsIDOM3EventTarget/nsIDOMEventGroup. r=smaug 2011-06-23 19:18:02 -07:00
Jonas Sicking
0c346db2ed Bug 658714 Part 9: Don't use EventGroups for system-group. r=smaug 2011-06-23 19:18:02 -07:00
Jonas Sicking
cd52437ea7 Bug 658714 Part 6: Fixups after search'n'replace s/nsPIDOMEventTarget/nsIDOMEventTarget/. r=smaug 2011-06-23 19:18:01 -07:00
Jonas Sicking
07c1f0b90f Bug 658714 Part 5: Search'n'replace nsPIDOMEventTarget to nsIDOMEventTarget. r=smaug 2011-06-23 19:18:00 -07:00
Masayuki Nakano
b96a7b1afb Bug 664437 editor should use mozilla::Preferences r=ehsan 2011-06-17 09:59:29 +09:00
Masayuki Nakano
4a5030c91a Bug 660121 Remove all pref related methods from nsContentUtils r=roc 2011-05-29 08:42:57 +09:00
Ehsan Akhgari
9db2091376 Bug 634406 - Don't select past the trailing BR node in text fields when performing the SelectAll operation; r=roc 2011-05-25 16:30:14 -04:00
Masayuki Nakano
7b13fbd2d9 Bug 659536 part.2 Replace nsContentUtils::GetIntPref() with Preferences::GetInt() or Preferences::GetUint() r=roc 2011-05-25 15:32:00 +09:00
Ms2ger
95946ba581 Bug 657210 - Outparamdel nsEditor::GetPresShell; r=ehsan 2011-05-22 14:43:13 +02:00
Craig Topper
8a3f0ad8f7 Bug 658143 - Part 1: Changes nsCOMPtr<nsFrameSelection> to nsRefPtr. r=roc 2011-05-18 20:10:49 -07:00
Ms2ger
ebc1fff223 Bug 657160 - Remove NS_NewTextEditRules; r=ehsan 2011-05-15 12:16:45 +02:00
Ehsan Akhgari
e422c276a8 Bug 612129 - Set the initial selection range to the beginning of the text field in order to be more compatible with other browsers; r=roc 2011-05-12 09:52:38 -04:00
Masayuki Nakano
1ef49a007d Bug 655918 Clean up the composition string when whole characters of it are refused due to maxlength r=ehsan 2011-05-11 13:52:45 +09:00
Ed Morley
97cc9c4eea Bug 655756 - Remove final XP_MAC remnants; r=josh 2011-05-10 20:24:48 +02:00
Ehsan Akhgari
bc13895396 Bug 649797 - Rewrite the test for bug 600570 in a way that doesn't trigger the assertion which can never happen on the web; r=roc
--HG--
extra : rebase_source : 8f21974f360f1e9806a1b7cfefb7d1733513d22f
2011-04-21 10:25:34 -04:00
Ehsan Akhgari
2759ff18ea Bug 649012 - Fix some flaky mochitests which rely on non-zero timeout values; rs=ted 2011-04-16 19:39:34 -04:00
Ehsan Akhgari
135eb99ddb Backed out changeset d407ee4dabcc because it causes some tests to go orange 2011-04-16 23:47:06 -04:00
Ehsan Akhgari
d6e8bc6ecd Bug 649012 - Fix some flaky mochitests which rely on non-zero timeout values; rs=ted 2011-04-16 19:39:34 -04:00
Sebastian Kromp
d77753a5db Bug 633066: Remove nsICiter and make nsInternetCiter a static class. r=ehsan 2011-03-31 07:32:13 -04:00
Ehsan Akhgari
35dd938230 Bug 645914 - Do not eat the white-space when doing word selection if the eaten whitespace is a newline character and we have been instructed not to jump between lines; r=roc
This fixes a bug in selecting words at the end of lines in textarea's for Windows.
2011-03-30 11:56:48 -04:00
Ehsan Akhgari
389876ffaa Test case for bug 638596; r=roc 2011-03-04 13:44:25 -08:00
Ehsan Akhgari
c82a3bc6df Bug 641466 - Correct the array bounds checking so that the last surrogate pair in a textbox can be deleted correctly; r=roc 2011-03-16 15:34:29 -04:00
Ehsan Akhgari
a2c435fafa Bug 407127 - Part 6: Remove the presshell argument to nsIEditor::Init as it's no longer necessary; r=roc 2011-03-11 00:40:31 -05:00
Ehsan Akhgari
a991a93821 Bug 407127 - Part 4: Avoid using the presshell needlessly because it may not always be available; r=roc 2011-03-11 00:40:30 -05:00
Ehsan Akhgari
eabc4ca754 Bug 407127 - Part 2: Refactor the editor so that it only touches mSelConWeak in GetSelectionController, to make removing it for HTML editors easier; r=roc 2011-03-11 00:40:30 -05:00
Ehsan Akhgari
318a97fcfd Bug 407127 - Part 1: Refactor the editor so that it only touches mPresShellWeak in GetPresShell, to make removing it easier; r=roc 2011-03-11 00:40:30 -05:00
Ehsan Akhgari
76716122b8 Bug 636465 - Reset the spellchecking override status when detaching an editor object from the content node; r,a=roc 2011-03-01 15:04:42 -08:00
Ehsan Akhgari
612a38d5d6 Bug 636074 follow-up: move the assertion count adjustment because a test was added in between 2011-02-23 15:28:33 -08:00
Kyle Huey
c4c65578ef Bug 633709: Convert bogus assert into a warning. r+a=ehsan
--HG--
extra : rebase_source : 5928d5a4309bd98e0cf4cd3041f36ba64d992706
2011-02-19 17:49:23 -05:00
Peter Van der Beken
b6b7136d51 Fix for bug 633738 (quora.com bloats out of control (part 3)) - mark some known assertions caused by bug 439258. r=bz, a=jst. 2011-02-17 12:19:13 +01:00
Chris Leary
09f6be30b5 Merge tracemonkey to mozilla-central. (a=blockers) 2011-01-31 19:43:36 -08:00
Jonas Sicking
809bbcd2c3 Disallow content access to chrome functions without __exposedProps__ (bug 628410, r=gal). 2011-01-29 18:47:17 -08:00
Ehsan Akhgari
71ee52288f Bug 629172 - Fix the regression in switching the text input direction using Cmd/Ctrl+Shift+X; r=roc a=blocking-final+
--HG--
extra : rebase_source : 57471865db00c1efa07bb746df42de8278027b36
2011-01-27 00:26:33 -05:00
Ehsan Akhgari
170dc1627a Bug 626411 - Selecting a section of URL, then clicking "Delete" stays at refresh, instead of "go"; r=roc a=blocking-final+
--HG--
extra : rebase_source : 09c7a68d030c819afe7086fe22f2c83620e881eb
2011-01-19 19:25:03 -05:00
Ehsan Akhgari
3072499cd4 Bug 625452 - Make sure all plaintext editor commands generate trusted input events; r=roc a=blocking-final+ 2011-01-15 23:16:45 -05:00
Ehsan Akhgari
307930e087 Bug 527935 - Part 4: Make sure that the input event after paste operations; r=roc a=blocking-final+ 2010-12-17 14:47:11 -08:00
Ehsan Akhgari
5dece71b0e Bug 527935 - Fire the input event for text controls with the correct trusted-ness status; r=roc a=blocking-final+ 2010-12-07 01:30:05 -05:00
Masayuki Nakano
d96800b2f0 Bug 613810 - Undo(ctrl+z) does not work continuously after committing IME; r=ehsan a=blocking-final+ 2010-11-24 17:57:32 -05:00
Justin Dolske
156d2a0e18 Bug 613403 - Fix existing tests to work with tab-modal prompt changes. r=ehsan, a=testsonly 2010-11-19 15:15:27 -08:00
Ehsan Akhgari
b713ae82bc Bug 611182 - Part 6: Actually allow the bogus node to be deleted from the document, and check if the parent is modifiable when inserting an element to prevent a bogus node being inserted under a contenteditable="false" element; r=bzbarsky a=blocking-beta8+
This fixes a failure in layout/reftests/bugs/579985-1.html, and is tested by it.
2010-11-12 10:38:14 -05:00
Ehsan Akhgari
6965428458 Bug 611182 - Part 3: Handle dynamic changes to the editable documents and create/remove the bogus node if needed; r=bzbarsky a=blocking-beta8+ 2010-11-11 16:40:52 -05:00
Ehsan Akhgari
aaa5654ff3 Bug 551704 - Part 2: Don't replace newline characters with BR nodes in preformatted editable fields; r=roc a=blocking-betaN+ 2010-11-06 18:49:26 -04:00
Ms2ger
4194994721 Bug 606717 - Comparison between signed and unsigned integers in nsTextEditRules::CollapseSelectionToTrailingBRIfNeeded; r=ehsan a=bsmedberg 2010-11-04 16:45:39 -04:00
Ms2ger
83a3dc5087 Bug 605177 - Fix a number of build warnings in editor/; r=ehsan a=bsmedberg 2010-11-04 16:44:46 -04:00
Ehsan Akhgari
1191936178 Bug 606295 - Don't attempt to remove the edit action listener from nsPlaintextEditor's dtor; r,a=roc 2010-10-22 16:51:06 -04:00
Ehsan Akhgari
bb3084c79c Bug 604532 - Copying from the location bar doesn't copy the entire URL if some text has been appended to it; r=roc a=blocking-final+ 2010-10-18 13:58:55 -04:00
Ehsan Akhgari
5fd894c62c Bug 602130 - Always start with a clean transaction manager when re-initialing the editor; r=roc a=blocking-final+
--HG--
extra : rebase_source : ec386404eb6853a66406f1b441cc25f3a3417688
2010-10-14 19:53:43 -04:00
Ehsan Akhgari
b15b1bb4b3 Bug 603556 - pasting into text that is longer than maxlength of text control fails; r=roc a=blocking-final+ 2010-10-12 18:30:41 -04:00