Commit Graph

10274 Commits

Author SHA1 Message Date
Michael Layzell
6941e4ff9f servo: Merge #18643 - Remove unlanded TakeFrom methods from nsstring_vendor (from mystor:nsstring_vendor_untake); r=bholley
<!-- Please describe your changes on the following line: -->
This should fix the build failures which are happening on autoland right now (e.g. https://treeherder.mozilla.org/logviewer.html#?job_id=133381254&repo=autoland&lineNumber=29416)

I accidentally included changes from https://bugzilla.mozilla.org/show_bug.cgi?id=1377351 in the previous patch, despite those changes not landing in central yet. Oops.

r? @emilio

Source-Repo: https://github.com/servo/servo
Source-Revision: 68533ac46b48b2d9b61f04a4e86b9c6a4fd6af77

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 627467124ad1309e2a1a0538d1f958ea852150a6
2017-09-26 13:30:03 -05:00
Michael Layzell
9c98ebe759 servo: Merge #18642 - nsString bindings update (from mystor:nsstring_vendor_bump); r=emilio
<!-- Please describe your changes on the following line: -->
This fixes bugzilla bug [1403170](https://bugzilla.mozilla.org/show_bug.cgi?id=1403170).

We've missed a few updates of the nsstring bindings in servo compared to the changes in gecko, so we really ought to find a better solution than these manual updates. For example, recently the way flags in nsstring are implemented was completely redone, and this version wasn't updated. It happened to be that the representation of the new form was identical to the old one, so it wasn't a problem, but technically this was wrong.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build-geckolib` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix bugzilla bug [1403170](https://bugzilla.mozilla.org/show_bug.cgi?id=1403170)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because they are a dependency version bump.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: e68509b2e37983179a33c9f8cf4ad41c8a85d9a9

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : eb9e40bec9ced7f4972ac2fe276d0fcd52254436
2017-09-26 11:38:58 -05:00
Emilio Cobos Álvarez
e750cc6e4e servo: Merge #18640 - style: Really minor cleanups (from emilio:cleanup-as-you-go); r=nox
See commits for details.

Source-Repo: https://github.com/servo/servo
Source-Revision: 4450bbdb0c44637a3caa05bd14a6e2b9d867a74e

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : f97eac4495b2898422b8648f9dc4a3c15ddc9e76
2017-09-26 07:53:43 -05:00
Emilio Cobos Álvarez
975f7353ea servo: Merge #18638 - style: Lazily tweak the traversal root to account for sibling invalidations (from emilio:invalidation-lazy); r=heycam
Bug: 1403078
Reviewed-by: heycam
MozReview-Commit-ID: Ij3nMOKu5FO
Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>

Source-Repo: https://github.com/servo/servo
Source-Revision: 3dbb97922d75f7ba4c542cb67e9c30c28c7a0699

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : beada9b873383acc78c6f5365f68c34dd3e01f39
2017-09-26 06:58:04 -05:00
Nicholas Nethercote
a35d42324c servo: Merge #18637 - Two small tweaks related to MallocSizeOf (from nnethercote:rename-add_size_of_children); r=emilio
<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because tested on the Gecko side.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 81801ab8b4c76eb1fc69a6d31175c3a372dad93a

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 81c7ee7a5c7f6ea7cd13446c438bcfc6d760e7e6
2017-09-26 05:52:34 -05:00
Anthony Ramine
c10df37830 servo: Merge #18635 - Rename JS<T> to Dom<T>, Root<T> to DomRoot<T>, and other things (from servo:RENAME-ALL-THE-THINGS); r=emilio
Source-Repo: https://github.com/servo/servo
Source-Revision: 1282e0d8080ae15307ac8d35941754f9d60f0d76

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 7b291b334b5797291cac309f71232069534f53d2
2017-09-26 03:20:05 -05:00
Cameron McCormack
01d6fbf247 servo: Merge #18623 - style: Add support for -moz-font-smoothing-background-color (from heycam:smoothing-background); r=xidorn
From https://bugzilla.mozilla.org/show_bug.cgi?id=1399834 and reviewed there by Xidorn.

Source-Repo: https://github.com/servo/servo
Source-Revision: 2d24d2dd044a3850d048daf7734b3a1f533f95fe

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 1fd4ec3ece857a7506b950920c12f93fb954af7b
2017-09-26 02:16:46 -05:00
Glenn Watson
2da58727b1 servo: Merge #18636 - Update WR (handle translucent brightness, invert filters. Hit test API) (from glennw:update-wr-filter-hit); r=pcwalton
Source-Repo: https://github.com/servo/servo
Source-Revision: 92533ac2232e3511f4a4f742098765ce26ef5f95

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 455d8efbd1cba8b501fc837fb9b64042dc18b18f
2017-09-25 20:56:33 -05:00
Daniel Kolsoi
174f01216c servo: Merge #18617 - Removed integrity check and test for no-cors requests (from TheDan64:master); r=KiChjang
Removed Step 30.2 which raised a JS TypeError if the integrity metadata was not empty. I manually ran `new Request("", {"mode" : "no-cors", "integrity" : "not an empty string"});` in servo to validate that the exception no longer arose.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #18345
- [x] These changes do not require tests because according to the ticket "Unfortunately, there's no automated test available for this yet because we are having trouble updating our copy of the upstream tests. "

Source-Repo: https://github.com/servo/servo
Source-Revision: e6099b43646520a4d0076bfc50dcc65b1aa8eb6b

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : f28fc96a6fda0faca8cc43833f9b50058c2c9f6f
2017-09-25 19:15:26 -05:00
Josh Matthews
a21f1c19d8 servo: Merge #17056 - Make dictionaries and unions containing GC values safer (from jdm:heapdict); r=emilio
Problems:
* the Heap::new constructor is memory-unsafe with any value other than Undefined/Null
* this means that moving dictionaries containing Heap values (ie. any/object) is memory-unsafe
* unions containing GC pointers are similarly unsafe

Solutions:
- dictionaries containing GC pointers are now wrapped in RootedTraceableBox (even inside other dictionaries)
- instead of using Heap::new, dictionaries containing GC pointers are now initialized to a default value (by deriving Default) and mutated one field at a time
- dictionaries containing GC pointers are marked #[must_root]
- FromJSVal for dictionaries containing GC pointers now returns RootedTraceableBox<Dictionary>
- unions wrap their variants that require rooting in RootedTraceableBox

Rather than attempting to derive Default for all dictionaries, we only do so for the dictionaries that require it. Because some dictionaries that require it inherit from dictionaries that do not, we need to write manual implementations for those parent dictionaries. This is a better option than having to figure out a default value for types like `Root<T>`, which would be required for deriving Default for all dictionaries.

I would still like to come up with an automated test for this, but I figured I would get eyes on this first.

---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #16952
- [ ] There are tests for these changes

Source-Repo: https://github.com/servo/servo
Source-Revision: 532dee36c10b7dd5d33e560b55cf65c7243ef1d3

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : cb755f811ab9619a5711a1df38ddb440f2ce6a06
2017-09-25 16:07:47 -05:00
Kyle Machulis
e21decdbab servo: Merge #18629 - Update link to Windows Python Version in README (from qdot:update-windows-readme-python-version); r=jdm
<!-- Please describe your changes on the following line: -->

The README currently points to a 2 year old version python for windows (2.7.11). While this version works for servo development, builds also work with the current version (2.7.14), so the link can be updated.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because change is documentation update

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 86b926b4cf78ae3436b946e42caad8362b4841d1

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 437c95e2c38630fba6b765bec9c19cdd74ea5c40
2017-09-25 15:01:35 -05:00
Emilio Cobos Álvarez
752b15c1bd servo: Merge #18627 - style: paint-order serialization fixes (from emilio:paint-order); r=nox
See each commit for details.

Source-Repo: https://github.com/servo/servo
Source-Revision: bbb5c8436edb89235fe030e8dc965b9bef43c071

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 345c3f3c605e2142e97ebf737804f267db3eb3d3
2017-09-25 09:35:38 -05:00
Anthony Ramine
0473a2d652 servo: Merge #18626 - Decouple media load blockers from their resource URL (from servo:media); r=emilio
Source-Repo: https://github.com/servo/servo
Source-Revision: d9cec56d712a69bc78f918abe1774f9007a0ec9a

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 1c0015366eed2316411d37a025ba91a10c7113f0
2017-09-25 06:39:47 -05:00
Emilio Cobos Álvarez
5f2c775ed2 servo: Merge #18624 - style: Early return and skip duplicate assertion in matching.rs (from emilio:easier-is-better); r=nox
Source-Repo: https://github.com/servo/servo
Source-Revision: 30e007ba1a537c7721bb824f4ddf4d915804b087

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 8cf57b55b408aee8a22e7f195b2c9006c116f5b4
2017-09-25 05:29:48 -05:00
Anthony Ramine
b101503c9e servo: Merge #18582 - Improve HTMLMediaElement (from servo:media); r=emilio
Source-Repo: https://github.com/servo/servo
Source-Revision: f3214372bf7f754126e8b032225f81aea1cccb1b

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : fdeac7688ecf75fb1de3bfe78ff32bb36ee50b9d
2017-09-25 03:51:53 -05:00
Hiroyuki Ikezoe
b2c1d03b51 servo: Merge #18622 - Handle display property change from 'none' only if there is restyle hint for SMIL (from hiikezoe:display-none-by-cssom); r=birtles
<!-- Please describe your changes on the following line: -->
https://bugzilla.mozilla.org/show_bug.cgi?id=1401801

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

Source-Repo: https://github.com/servo/servo
Source-Revision: eba9b802ab7d1158a965923b44490a0d9b8b361a

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 92ba0c188b0801346d7e2807ddd01f4d9afde948
2017-09-25 00:21:18 -05:00
Emilio Cobos Álvarez
550a99e785 servo: Merge #18621 - selectors: Remove unused crate (from emilio:unused-crate); r=glennw
Source-Repo: https://github.com/servo/servo
Source-Revision: dd6aae9d52af1f7ff55826543e044e5a3f9dd5e6

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 3c9558fbf694d24589c77f8c8aa5a0141d6e8364
2017-09-24 21:05:49 -05:00
Emilio Cobos Álvarez
d24a63355a servo: Merge #18620 - style: Remove UnsafeNode (from emilio:bye-unsafe-node); r=glennw
No longer needed since a while ago.

Source-Repo: https://github.com/servo/servo
Source-Revision: 4628db14951667b7ffddb47bdcc0c5ed886cb3b1

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : bceb703e28667654cb67f7bdd04135503f9c8967
2017-09-24 20:04:58 -05:00
Glenn Watson
f23bf7a153 servo: Merge #18619 - Update WR (fast path text shadow fix, subpx text snapping improvements) (from glennw:update-wr-subpx-2); r=emilio
Source-Repo: https://github.com/servo/servo
Source-Revision: cc4dd589f739cbdff706f842b5531ae871f6508b

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 5ad013a2912bbba195526acc6ef6102d47749411
2017-09-24 19:03:00 -05:00
Glenn Watson
689d61c952 servo: Merge #18598 - Update WR (work around a mac GL driver bug) (from glennw:update-wr-driver-bug); r=emilio
Also includes updates to the mac core-* crates and friends.

Source-Repo: https://github.com/servo/servo
Source-Revision: 61f0fc199e243fdce5b31b24d416c6177770873b

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : b493db681e4080d636f9a8642a43a0fe7244aded
2017-09-24 16:13:47 -05:00
Manish Goregaokar
310d8a38cb servo: Merge #18609 - stylo: Animate font-size as NonNegativeLength (from Manishearth:fs-anim); r=emilio
Otherwise it doesn't clamp correctly and fails layout/style/test/test_transitions_per_property.html

Source-Repo: https://github.com/servo/servo
Source-Revision: 216f64e4e1033dd179d3657f300bfc9be58ed3f1

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 7a418f57d09e6377f46966866a3a60e34e990237
2017-09-24 02:48:12 -05:00
tigercosmos
4a335e9c9f servo: Merge #18603 - fix #18594: Unnecessarily allocating an error string (from tigercosmos:allocating); r=KiChjang
<!-- Please describe your changes on the following line: -->
r? @asajeffrey

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #18594 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 35aad086191c7c4561067a1f774b3ae2d69bc375

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 50ce2afd344fbaeb4e453929b4bba0e22ab4b027
2017-09-23 17:11:51 -05:00
Manish Goregaokar
78e3a25f72 servo: Merge #18607 - stylo: Move font computation data into nsStyleFont and computed value of font-size (from Manishearth:stylo-font-nsstylefont); r=emilio
r=emilio https://bugzilla.mozilla.org/show_bug.cgi?id=1399228

Source-Repo: https://github.com/servo/servo
Source-Revision: 3db1776326619be91db4ae15005b52eefc289e8a

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 26a368e1878b165a04d4455592bdf601ee7f644d
2017-09-23 13:26:02 -05:00
Emilio Cobos Álvarez
8ca796bf7a servo: Merge #18602 - style: Make sure to not run any style invalidation in an unstyled children only traversal (from emilio:invalidation-unstyled-only); r=bholley
Bug: 1402472
Reviewed-by: bholley
MozReview-Commit-ID: IFPA7LJpvsZ
Source-Repo: https://github.com/servo/servo
Source-Revision: 5a6b90b14ff709eab41493a05c8235c522d35250

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 15e1c869a5b3495e08cb403527539c54d2f6756d
2017-09-22 21:16:43 -05:00
Matt Brubeck
b2e957402f servo: Merge #18601 - Remove unused 'untagged_unions' feature gate (from mbrubeck:features); r=KiChjang
CC #5286

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes do not require tests because _____

Source-Repo: https://github.com/servo/servo
Source-Revision: 352b129dc5b237757ade67448cc42f327780417e

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 0162983ceffbaeb3221c38f8b7319033694eaaef
2017-09-22 14:39:25 -05:00
Alan Jeffrey
322859253d servo: Merge #18514 - Remove sources of panic when laying out an iframe without a nested browsing context (from asajeffrey:layout-dont-panic-if-no-iframe-bc); r=emilio
<!-- Please describe your changes on the following line: -->

At the moment, layout panics if it discovers an iframe without a nested browsing context. Under normal circumstances, this is reasonable, but it requires very tight synchronization between script, layout, the constellation and the compositor. In particular, if a layout is in progress when an iframe's browsing context is discarded, this can trigger panic.

This PR fixes this in two ways:

1. Making the pipeline and browsing context ids optional in layout's representation of an iframe.
2. Shutting down layout before discarding a browsing context, rather than after.

This is belt and braces.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #17482 and #18477
- [X] These changes do not require tests because the PR is fixing a panic caused by a race condition

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: c48ef50b7260df7f2e781e15bba37b08f0970062

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : d2bff55daaa2c40d23ef05e75b61f4979ae2cbe2
2017-09-22 09:34:12 -05:00
Anthony Ramine
656ba29569 servo: Merge #18600 - Improve Promise (from servo:promises); r=<try>
The elephant 🐘 (not PHP's) still remains in the room: `Rc<Promise>` shouldn't require `#⁠[allow(unrooted_must_root)]`.

Source-Repo: https://github.com/servo/servo
Source-Revision: 4af0d9acb3f5724cac9f40a46ee03ab364a053bc

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : ca27ceeeebb0b9743e110e94793cae1a6cd85e84
2017-09-22 07:36:38 -05:00
Michael Droettboom
ef7217bd69 servo: Merge #18553 - Make tidy aware of Rust multiline strings (from mdboom:tidy-support-multiline-strings); r=wafflespeanut
<!-- Please describe your changes on the following line: -->
This makes the internal tidy script properly ignore the contents of Rust multiline strings.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #18551 (github issue number if applicable).

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: a8a25dac5226a12916c8fe17155d1dbb3b6cb565

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : ec337ad33ec9033a2d3819f0fbc9a9778b23c073
2017-09-21 23:38:29 -05:00
Bobby Holley
5f78e33b00 servo: Merge #18595 - Implement an nth-index cache (from bholley:nth_index_cache); r=emilio
https://bugzilla.mozilla.org/show_bug.cgi?id=1334730

Source-Repo: https://github.com/servo/servo
Source-Revision: be9c8ec07a0ca745adf1b412d32b3b32adec122c

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 3a03da9ae7e549b53b72306c7ec5f87365461470
2017-09-21 18:10:05 -05:00
J. Ryan Stinnett
d5e79945ae servo: Merge #18593 - Update inherited prop state for animation (from jryans:stylo-anim-inherit-context); r=heycam
https://bugzilla.mozilla.org/show_bug.cgi?id=1401256

Source-Repo: https://github.com/servo/servo
Source-Revision: 83705a8fa8992a974b32acc6635c7dfeed1afa50

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 08724f2f81fd5297eee8da5bbb3e12a16957e828
2017-09-21 16:43:37 -05:00
Matt Brubeck
c965d8f708 servo: Merge #18579 - Remove unused feature gates (from mbrubeck:features); r=KiChjang
CC #5286.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes do not require tests because no code changes

Source-Repo: https://github.com/servo/servo
Source-Revision: 29517d553e6c2fddc7e3cf0c0abef58c6d0f34aa

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : c2e8b88135a03d5d56b950e5ee25123e7403c31c
2017-09-21 15:08:04 -05:00
sendilkumarn
27e6d68edf servo: Merge #18059 - Using OnceCell<T> from Mitochondria (from sendilkumarn:mito); r=nox
<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #13402  (github issue number if applicable).

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 5c797d194346d5be3c55da51d82bfcd1031a51f5

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 6936fce573771660b0e310ebccadd5c2fa542602
2017-09-21 13:20:29 -05:00
Hiroyuki Ikezoe
e7db2e5d36 servo: Merge #18590 - Use Atom::from(nsIAtom) to increment reference count in case of dynam… (from hiikezoe:increment-ref-count-for-will-change); r=xidorn
…ic atom for will-change.

If we don't increment the reference count for the Atom in servo side, it's
possible to try to release the Atom in servo side even if we have already
released in gecko side.  When it happens, nsIAtom::mKind is no longer reliable.

https://bugzilla.mozilla.org/show_bug.cgi?id=1401809

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

Source-Repo: https://github.com/servo/servo
Source-Revision: 581f0bf09a8ec35dadd5de207777f79138255e1a

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : b8daadff800d3af1378b2d93707e6a222533bdb7
2017-09-21 04:18:28 -05:00
Jeremy Chen
aa61267643 servo: Merge #18591 - stylo: do not handle the fallback discrete animation inside the Animate trait (from chenpighead:stylo-singular-matrix-animation); r=BorisChiou
At present, we do the fallback discrete animation for non-invertible matrices in
ComputedMatrix.animate(). However, according to the spec, we should fallback to
discrete animation for cases like:

1. animation between transform with single non-invertible matrix
2. animation between transform with matched transform functions that have at least
   one non-invertible matrix
2. animation between transform with mismatched transform functions that have at
   least one non-invertible matrix.

The current implementation only handles the first case.

Moreover, we already have fallback discrete animation procedures in CSS Animation
and Web Animation, so we should be able to not doing any fallback inside the
Animate trait.

In this patch, we let the animation between non-invertible matrices to return Err().
So, we can propagate the Err() to the callers, and let the fallback discrete
animation procedure stay at the Servo_MatrixTransform_Operate, which is ouside
the Animate trait.

Gecko bug: [Bug 1394284](https://bugzilla.mozilla.org/show_bug.cgi?id=1394284)

---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix [Bug 1394284](https://bugzilla.mozilla.org/show_bug.cgi?id=1394284)
- [X] There are wpt tests for these changes, and thet will be landed in [Bug 1394284](https://bugzilla.mozilla.org/show_bug.cgi?id=1394284)

Source-Repo: https://github.com/servo/servo
Source-Revision: ce7cee75e4c0c8357b489be42589d96348870627

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 830ee041c599c8dee799d36732e16f7e8b2fcd34
2017-09-21 03:16:58 -05:00
Bobby Holley
af9981dd55 servo: Merge #18589 - Plumbing for the nth-index cache (from bholley:nth_index_plumbing); r=emilio
https://bugzilla.mozilla.org/show_bug.cgi?id=1334730

Source-Repo: https://github.com/servo/servo
Source-Revision: 39f8fce453f0a34751abb82485442429f06324bf

--HG--
rename : servo/components/style/cache.rs => servo/components/lru_cache/lib.rs
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : b0b2eb5c94f5c9ea2e6903cf5274840a5c561952
2017-09-21 01:24:01 -05:00
Glenn Watson
6a68d52db6 servo: Merge #18586 - Update WR (font variations, runtime dp ratio changes) (from glennw:update-wr-font-vars); r=metajack
Source-Repo: https://github.com/servo/servo
Source-Revision: 5afb1b7dd280b988c6d4bb302d6b9ef77d79de35

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 8982a5a4a9a2f70ba2c5db505a68ea92afdbb264
2017-09-21 00:11:15 -05:00
Hiroyuki Ikezoe
dd4c8b760b servo: Merge #18584 - Drop RulesChanged (from hiikezoe:drop-rule-changed); r=emilio
It's no longer used.

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Either: -->
- [X] These changes do not require tests because this just drops unused code.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 7ce78164bff629395020dd4a25ea66d7dcc58e53

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 756b98406636a61afda3da9043f68f09911ceb82
2017-09-20 23:12:56 -05:00
Imanol Fernandez
02939c27b3 servo: Merge #18575 - Improve Webrender<->WebGL synchronization (from MortimerGoro:webgl_flickering); r=glennw
<!-- Please describe your changes on the following line: -->

 Webrender<->WebGL synchronization is not perfect yet, and it has some flickering specially when adding more elements on the page than a single full-screen canvas.

This PR improves the synchronization by using the WR thread to perform the fence wait. All the flickering with multiple elements on the page is gone thanks to this change.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #14235 (github issue number if applicable).

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 941757bafebecd8327fff66e0369c3c5f42d1366

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 2644bb5199128f8554c183cfcf77c3326e045eff
2017-09-20 22:08:17 -05:00
Xidorn Quan
76244c86a8 servo: Merge #18588 - Use array instead of linked list for -moz-border-*-colors (from upsuper:moz-border-colors-array); r=heycam
This is the Servo side change of [bug 1400438](https://bugzilla.mozilla.org/show_bug.cgi?id=1400438). (take 3)

Source-Repo: https://github.com/servo/servo
Source-Revision: 8bc21d799f1a02b72ecac3994faf1d3e1c6d0397

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 0966834cd2519054903169147f653deb655ecab5
2017-09-20 21:02:06 -05:00
Nicholas Nethercote
516e2b5d7c servo: Merge #18583 - Fix MallocSizeOf for TypedSize2D (from nnethercote:fix-TypedSize2D); r=mbrubeck
TypedSize2D's MallocSizeOf impl has two problems.

- It measures `width` twice, and `height` not at all.

- It erroneously asserts that `width` and `height` are scalars. This
  seems reasonable at first blush, but Stylo uses
  `BorderRadius<LengthAndPercentage>` which contains a
  `TypedSize2D<LengthAndPercentage, UnknownUnit>`, and
  `LengthAndPercentage` is non-scalar.

This patch fixes both of these problems, and also removes a low-value
`use` statement.

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix https://bugzilla.mozilla.org/show_bug.cgi?id=1401692

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because tested on the Gecko side.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: dfb80f07539298d5972c8ca108dda5f83d8e009f

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 0706aaa344d99e8a575c79c57438b77e1d632ac6
2017-09-20 18:38:51 -05:00
Alan Jeffrey
a4f95fc4f9 servo: Merge #18578 - Window should own Location, Document shouldn't (from asajeffrey:script-window-owns-location); r=KiChjang
<!-- Please describe your changes on the following line: -->

Document shouldn't own location, Window should.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #18438
- [X] These changes do not require tests because it's an intermittent

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 6a791cd7f26b42a6688099bea203c21fb3c9cc12

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 275ce0ac177aff6c59f8b4959f79259031dbbdde
2017-09-20 14:38:31 -05:00
Hiroyuki Ikezoe
824e1b0103 servo: Merge #18572 - Handle !important in keyframe (from hiikezoe:immportant-in-keyframe); r=emilio
<!-- Please describe your changes on the following line: -->
https://bugzilla.mozilla.org/show_bug.cgi?id=1400926

---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

Source-Repo: https://github.com/servo/servo
Source-Revision: 46ae11b5d03a4935f5a8594269ea14ae2594c2c2

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : e949cf5aa256f95cd502bbcae9c59ad8c8c6bbe0
2017-09-20 13:40:12 -05:00
Sebastian Hengst
cf3edd7dd1 Backed out changeset 5b56ebe80e22 (bug 1400438) for heap write hazard. r=backout 2017-09-20 16:53:11 +02:00
Simon Sapin
b5383eadfb servo: Merge #18576 - Update some dependencies to fix some warnings (from servo:warn); r=nox
"`#[must_use]` on methods is experimental" and "trait bounds are not (yet) enforced in type definitions" are shown despite Cargo using `--cap-lints=allow` for dependencies.

Source-Repo: https://github.com/servo/servo
Source-Revision: 98e3bb3cddb1c2e91b1f265269668e11843758fa

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : b1eefcf731743f295070bba26fd1988ce0a06e21
2017-09-20 07:49:42 -05:00
Xidorn Quan
2d38252072 servo: Merge #18574 - Use array instead of linked list for -moz-border-*-colors (from upsuper:moz-border-colors-array); r=heycam
This is the Servo side change of [bug 1400438](https://bugzilla.mozilla.org/show_bug.cgi?id=1400438). (take 2)

Source-Repo: https://github.com/servo/servo
Source-Revision: b49fe47b7d1be7ea8ef32d1f57952f926b5f828b

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : b9b1358c8399ea4011ee310f17a0de874eeb4657
2017-09-20 06:40:48 -05:00
Anthony Ramine
3875b3dac8 servo: Merge #18573 - Introduce TaskOnce (from servo:TASKS); r=SimonSapin
Source-Repo: https://github.com/servo/servo
Source-Revision: 44c6bd9fa9594e7fd2a6576a4eab501a5838d113

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 8814df2f1a210ddeba69a81774f35853fcc018fd
2017-09-20 05:17:12 -05:00
Bobby Holley
cff6e00bcf servo: Merge #18571 - Add a geckolib API to check for primary style reuse (from bholley:primary_reuse_api); r=emilio
https://bugzilla.mozilla.org/show_bug.cgi?id=1401317

Source-Repo: https://github.com/servo/servo
Source-Revision: 3cea16e18f125e3839af4dd3f064b4194fde4953

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : d3e71cc94e07434947e7950699d2486e9c32fd9f
2017-09-20 02:05:57 -05:00
Blake Kaplan
10a0ad44d5 servo: Merge #18569 - Bug 1398393 - Add a way to initialize a cooperative thread in servo (from mrbkap:1398393-cooperative-thread-tagging); r=emilio
<!-- Please describe your changes on the following line: -->

Over in [bug 1398393](https://bugzilla.mozilla.org/show_bug.cgi?id=1398393), I found that when we turn Quantum DOM's cooperative threads on, we hit a Servo panic because we assume that we've set some state in the TLD. The cooperative threads currently have no way of doing this without also re-initializing the log module and some other static data. This small patch gives the cooperative threads a way of informing Servo about themselves.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Either: -->
- [X] These changes do not require tests because they will be tested on Gecko's tinderbox once we get cooperative threading working.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 8000efac75c96f87a5e242be84b246f98a1b61e5

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 3ca761684490cbf23ea4c5fc7cb74df51ce36cbf
2017-09-20 00:59:35 -05:00
Glenn Watson
284ba5cb95 servo: Merge #18567 - Update WR (quality improvements for subpx text and blur) (from glennw:update-wr-subpx-blur); r=wafflespeanut
Source-Repo: https://github.com/servo/servo
Source-Revision: 2a97b2cd7cb7e2e52ea48f857d1687b8dcee6604

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 05b033a6d8e8800c39f70ac7949f055043a55cf9
2017-09-19 23:42:33 -05:00
Nicholas Nethercote
98925075f9 servo: Merge #18568 - Measure the UA cache (from nnethercote:bug-1400078); r=emilio
This is the Servo PR for https://bugzilla.mozilla.org/show_bug.cgi?id=1400078

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix https://bugzilla.mozilla.org/show_bug.cgi?id=1400078

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because tested on Gecko side.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: ad4f50270d12564da471489c703119fc4a57fa15

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : d87d573c871173bfeda5421da84a8e8a1af41a84
2017-09-19 18:46:49 -05:00