Commit Graph

3358 Commits

Author SHA1 Message Date
Jared Wein
43bac26d30 Bug 1331661 - Enable the 'quotes' rule for eslint and fix most of the errors with --fix. r=Gijs
MozReview-Commit-ID: 6tv0Z06CO4a

--HG--
extra : rebase_source : 014c0b04d8538dc5f15bc6dd4ed6bd220c55c5d4
2017-01-17 09:48:17 -06:00
Florian Quèze
85611a7b6d Bug 1331081 - script generated patch to omit addEventListener/removeEventListener's third parameter when it's false, r=jaws.
--HG--
extra : rebase_source : a22344ee1569f58f1f0a01017bfe0d46a6a14602
2017-01-17 11:50:25 +01:00
Wes Kocher
f8a62a9ce6 Merge m-c to inbound, a=merge
MozReview-Commit-ID: ASajzspkOe1
2017-01-13 15:48:34 -08:00
Florian Quèze
22d9b71466 Bug 1330464 - make the no-useless-parameters eslint rule detect misuses of the Services.prefs APIs, r=jaws. 2017-01-13 20:21:55 +01:00
Florian Quèze
1e42cad36c Bug 1330464 - script-generated removal of additional parameters that don't exist in the interface, r=jaws. 2017-01-13 20:21:53 +01:00
Jared Wein
9a0aefca79 Bug 1330014 - Remove extra lines that eslint --fix adds for no-useless-return. r=standard8
MozReview-Commit-ID: Be36laqLQQ2

--HG--
extra : rebase_source : 48f6fc7a832e51035c04ea825f77a38cb08a7151
2017-01-10 12:08:32 -05:00
Jared Wein
65605f286e Bug 1330014 - Add .eslintrc.js file to /services and run eslint --fix to automatically fix most of the errors. --fix brings the error count down from 4083 to 321 errors. r=markh,standard8
MozReview-Commit-ID: EjyAssqiQk8

--HG--
extra : rebase_source : cbfc8d4474b6c3d46eb21374e33fd3341403444f
2017-01-10 12:09:02 -05:00
Iris Hsiao
55313b4bc9 Backed out changeset 7e0a0bd74199 (bug 1330014) 2017-01-13 11:06:43 +08:00
Iris Hsiao
303147b9fa Backed out changeset afe70927277c (bug 1330014) for xpcshell test_storage_manager.js failures 2017-01-13 11:06:38 +08:00
Jared Wein
dd7ec3a99b Bug 1330014 - Remove extra lines that eslint --fix adds for no-useless-return. r=standard8
MozReview-Commit-ID: Be36laqLQQ2

--HG--
extra : rebase_source : 05c863e038aa1a6571500f4178c325b1b9913af9
2017-01-10 12:08:32 -05:00
Jared Wein
81cb5e57b9 Bug 1330014 - Add .eslintrc.js file to /services and run eslint --fix to automatically fix most of the errors. --fix brings the error count down from 4083 to 321 errors. r=markh,standard8
MozReview-Commit-ID: EjyAssqiQk8

--HG--
extra : rebase_source : d783829bc7fced3044d0d076c4786a6957d29bb6
2017-01-10 12:09:02 -05:00
Ethan Glasser-Camp
90c9daf114 Bug 1320324: deleted values are not handled correctly on sync, r=markh
No tests existed for this functionality either, so add some.

MozReview-Commit-ID: FkHV0GBTHov

--HG--
extra : rebase_source : 3784eca629db62cc1f92a87622afe0f3da091501
2016-12-22 13:37:12 -05:00
Kit Cambridge
08ec8494fb No bug - Log tracker contents in test_telemetry.js to diagnose intermittent failures. a=testonly
MozReview-Commit-ID: 2qUNV7Cz7pd

--HG--
extra : rebase_source : b9c6e4c6adc506f05ef7ec5982444aebdba32fc4
2017-01-11 15:30:25 -07:00
Mark Banner
582fcb8090 Bug 1329614 - [eslint] Catch more cases of importing globals from 'var foo = Cu.import('...');'. r=jaws
MozReview-Commit-ID: 5NKHHb70YA6

--HG--
extra : rebase_source : 4551e56f56065349fb9ddc8d90e67f9dc84c1701
2017-01-09 10:12:26 +00:00
Florian Quèze
fc6379e827 Bug 1329182 - remove trailing newURI null parameters in the rest of the tree, r=jaws. 2017-01-09 20:27:26 +01:00
Mark Hammond
5f7905c8f3 Bug 1289536 (part 2) - Add a unique flowID GUID to each command sent via the clients collection. r=rnewman
MozReview-Commit-ID: 4eTFDq4Yr7S

--HG--
extra : rebase_source : faa5cb3ddd41e107b898412b0c9c5899df91c335
2016-11-04 12:46:57 +11:00
Mark Hammond
85c80336b8 Bug 1289536 (part 1) - Add events to Sync ping. r=gfritzsche
MozReview-Commit-ID: 184fIhelOa6

--HG--
extra : rebase_source : bf7c96a473b92a42411fe5c94ac6802d42ff57d5
2016-11-04 17:57:09 +11:00
Thom Chiovoloni
1330224f6a Bug 1301389 - Only include the uid and device ID once in the sync ping. r=markh
Previously this was included for each sync. In addition to being less efficient,
this makes certain info that's planned to be added in the future more difficult.

MozReview-Commit-ID: fjOvAJJVI6

--HG--
extra : rebase_source : edb9a60a101c1110560c1ceb61a927248bed06e9
2016-11-21 16:34:46 -05:00
Kit Cambridge
1897a70d72 Bug 1325523 - Clean up after tests that modify tracker contents. r=markh
MozReview-Commit-ID: 45g4n4UipTW

--HG--
extra : rebase_source : 1be78706cab9b42d0c6c949243b9a835351486fa
2016-12-29 18:18:38 -07:00
David Keeler
104c38c723 bug 1324071 - add nsIPK11Token.hasPassword to replace unnecessary uses of nsIPKCS11Slot.status r=Cykesiopka,gps,MattN,sebastian
MozReview-Commit-ID: C2jwQHPEDC0

--HG--
extra : rebase_source : 16271e70ef32da8657cdc4f8df41b7822430e3bf
2016-12-02 15:09:35 -08:00
Kit Cambridge
4797a3b6cd Bug 1319175 - Switch to JSONFile for tracker persistence. r=markh
MozReview-Commit-ID: 6nhGe9aHSk3

--HG--
extra : rebase_source : 43449f689a47287e034b80d3cbdd2fd5fbba44ab
2016-12-20 12:25:27 -07:00
Kris Maglione
22eba76d86 Bug 987512: Part 5 - Remove manual AddonManager promise wrappers. r=rhelmer
MozReview-Commit-ID: LrEiGbQGrt6

--HG--
extra : rebase_source : 38971f7242261e5d8b11d586f6eb033b6364c6cf
extra : histedit_source : 0b9403a97d3f3092b8991e8e6af5095b898dd8c3
2016-12-15 12:03:24 -10:00
Kit Cambridge
8558928fe7 Bug 1322954 - Fix incorrect instanceof negations. r=markh
MozReview-Commit-ID: PgQmAu9hbQ

--HG--
extra : rebase_source : 376b83af517442cc05bc46ff7ca36e6ac46b06e2
2016-12-12 13:50:10 -08:00
Wes Kocher
b5de71ec44 Merge m-c to autoland, a=merge 2016-12-01 15:46:49 -08:00
Kit Cambridge
666a52df0a Bug 1319037 - Disable trace logging and increase timeout factor for test_bookmark_tracker.js. a=testonly
MozReview-Commit-ID: EmSdy92cYzc

--HG--
extra : rebase_source : 8e15718c657cbd7fd1ecae0bf4a4c86c51a70b8c
2016-11-29 13:21:56 -07:00
Kit Cambridge
52ddf2d3d0 Bug 1319328 - Wait for pending statements before checking annos in test_mobile_query. a=testonly
MozReview-Commit-ID: BW5b0FgvwMD

--HG--
extra : rebase_source : 6af0f95c3aca4e434533bc496f1b695b8c74100d
2016-11-29 13:13:20 -07:00
André Bargull
82ed270fce Bug 1319937 - Remove String generics uses in services/sync. r=markh 2016-11-24 13:17:08 -08:00
Thom Chiovoloni
39c3163cf7 Bug 1321396 - Skip oversized records without aborting the sync by default in sync engines. r=markh
MozReview-Commit-ID: 7hgzyKb2UxY

--HG--
extra : rebase_source : 7c7f238a8e46b0776afe83798061d1539b07f76c
2016-11-30 17:28:52 -05:00
Mark Hammond
632c46235a Bug 1317216 - consistently use the Sync client GUID as the basis for the device ID in the sync ping. r=tcsc
MozReview-Commit-ID: BDTqnM7de6n

--HG--
extra : rebase_source : 169b3ad54dd19b5ef319d1e09684c0fd474e695b
2016-11-10 19:12:55 +11:00
Mark Hammond
40140fc9de Bug 1319323 (part 2) - improve sync unit tests; SyncTestingInfrastructure now uses the FxA identity provider. r=tcsc
MozReview-Commit-ID: 2zpZMpvbAy

--HG--
extra : rebase_source : a33b15a3ef8acf39a7a423694093a690ca519c88
2016-11-22 15:03:47 +11:00
Mark Hammond
f3312b9b72 Bug 1319323 (part 1) - improve sync unit tests; remove many ensureLegacyIdentityManager calls. r=tcsc
MozReview-Commit-ID: CV6cpo2Tp5O

--HG--
extra : rebase_source : 03f8fb39e69065bf7263b8bc20e4b2641a247b01
2016-11-21 12:22:24 +11:00
Kit Cambridge
73fba410f4 Bug 1173359 - Exclude hidden pages and framed links from syncing. r=markh
MozReview-Commit-ID: 8I4Sulyr0H7

--HG--
extra : rebase_source : 55fb1ff567c0a2916bc0153a09c41b03d396cfeb
2016-11-22 12:52:09 -07:00
Kit Cambridge
ce8909d3fb Bug 1173359 - Convert the history tracker tests to use async functions. r=markh
MozReview-Commit-ID: CFNLQkRa7Qb

--HG--
extra : rebase_source : 086dbe074f6979428e826aa1faa7ab75100a0dad
2016-11-22 12:34:02 -07:00
Mark Hammond
682d81fa5d Bug 1316500 - remove use of tasks and promise.jsm promises from Sync tests. r=tcsc
MozReview-Commit-ID: 5itPSLBKguc

--HG--
extra : rebase_source : 2b16f697902736ef39cded96c1bd98b547136263
2016-11-10 14:34:38 +11:00
Thom Chiovoloni
15acd98009 Bug 1273342 - Don't retry skippable records that fail to sync due to being too large. r=markh
MozReview-Commit-ID: HjzL1crTVDB

--HG--
extra : rebase_source : 887c3364bf0dec05353c2ea7e7c23d6393158fa3
2016-11-21 15:37:35 -05:00
Kit Cambridge
8c2abe0611 Bug 1318414 - Default to empty strings for titles and parent titles if not set. r=rnewman,tcsc
MozReview-Commit-ID: DppxJuVrbAM

--HG--
extra : rebase_source : a214d54fda7d25798039fc9844c34cabd3165a27
2016-11-19 08:29:26 -08:00
Kit Cambridge
ccee4d37f5 Bug 1258127 - Add migration logic for old synced bookmarks. r=markh,rnewman
MozReview-Commit-ID: Gye30bYZejy

--HG--
extra : rebase_source : 882c4769d28ad4b56829e5b6037f74c04028f03a
2016-11-18 14:00:56 -08:00
Kit Cambridge
4c26a7b758 Bug 1258127 - Move bookmark deletion logic into PlacesSyncUtils.bookmarks.remove. r=tcsc
This patch moves most of `BookmarksStore::deletePending` and
`BookmarksStore::_shouldReviveRemotelyDeletedRecord` into
`PlacesSyncUtils.bookmarks.remove` and `touch`, respectively. Both
methods use the same approach as `PlacesSyncUtils.bookmarks.dedupe` to
amend the `_modified` changeset with new change records.

We use the new `SYNC_REPARENT_REMOVED_FOLDER_CHILDREN` change source to
bump the change counters for the reparented items and their new
parents, without bumping the score and triggering extra syncs.

MozReview-Commit-ID: 1SZvygWNkgL

--HG--
extra : rebase_source : 97fdac6ccb0d0326a3da7e42259dc6a961994ac3
2016-11-17 15:07:14 -08:00
Kit Cambridge
69350f8b7b Bug 1258127 - Move bookmark de-duping logic into PlacesSyncUtils.bookmarks.dedupe. r=markh
This patch moves the logic from `BookmarksEngine::_switchItemToDupe`
into `PlacesSyncUtils.bookmarks.dedupe`, and updates it to work with
the new tracker. `dedupe` returns an object containing new change
records, which the bookmarks engine merges into the initial changeset
from `PlacesSyncUtils.bookmarks.pullChanges`.

This patch also removes `changeItemID` and
`PlacesSyncUtils.bookmarks.changeGuid`, since `dedupe` subsumes them.

MozReview-Commit-ID: Iw3YRxWuZnK

--HG--
extra : rebase_source : 6fd80c64b160103e1090b87a300ed74b8ef85eed
2016-11-17 15:04:19 -08:00
Kit Cambridge
ccf45973d0 Bug 1258127 - Update the bookmarks engine to pull changes from Places. r=markh
MozReview-Commit-ID: 4YESuxP2rRf

--HG--
extra : rebase_source : 9c2f5830d10ba280e45c30076f19f498e6913fd0
2016-11-17 15:39:15 -08:00
Sebastian Hengst
0849ed2bea Backed out changeset c644b01be649 (bug 1318414) for failing xpcshell test test_bookmark_store.js. r=backout 2016-11-19 09:35:02 +01:00
Kit Cambridge
96702bd1f2 Bug 1318414 - Default to empty strings for titles and parent titles if not set. r=rnewman,tcsc
MozReview-Commit-ID: DppxJuVrbAM

--HG--
extra : rebase_source : 649bc0b945c8a2dd69dade682bf80c874053bc92
2016-11-17 10:42:32 -08:00
Phil Ringnalda
1583627c71 Backed out changeset ca02f30bc3a0 (bug 1316500) for eslint failures 2016-11-16 19:32:10 -08:00
Mark Hammond
a5e2bb0e72 Bug 1317589 - store the most recent hashed UID so we can still report it on transient errors renewing tokens. r=tcsc
MozReview-Commit-ID: 4qCFBltcPi1

--HG--
extra : rebase_source : 4ee6b0725729e8db2ba8d18d06dce7816a5e1da3
2016-11-15 16:03:41 +11:00
Mark Hammond
e35c5ab29f Bug 1316500 - remove use of tasks and promise.jsm promises from Sync tests. r=tcsc
MozReview-Commit-ID: 5itPSLBKguc

--HG--
extra : rebase_source : 9c0ee4387d4b3d7df56c1e9ccda0ec39cd5b11e2
2016-11-10 14:34:38 +11:00
Mark Hammond
9c1b1b298b Bug 1317587 - don't start scheduled sync after shutdown. r=rnewman
MozReview-Commit-ID: GSyWAUa1qyr

--HG--
extra : rebase_source : 45d0dfd5c686803f017230ab6152d0204a3d4c8e
2016-11-15 15:28:52 +11:00
Mark Hammond
e6302fe87d Bug 1317592 - don't try syncing other engines after one fails with a shutdown error. r=rnewman
MozReview-Commit-ID: LZ72JbOtpm4

--HG--
extra : rebase_source : 00493ea6d24470e5b45a2d42e8b64468427f89d3
2016-11-15 16:15:03 +11:00
Mark Hammond
136eb80ff1 Bug 1303831 - have _buildGUIDMap yield to the event loop and have it abort on shutdown. r=rnewman,tcsc
MozReview-Commit-ID: Ff8mq9eHBsQ

--HG--
extra : rebase_source : ab891da610a03791d6c13ea35fc5cd44d305a175
2016-11-15 17:01:22 +11:00
Kit Cambridge
6cd5db91d6 Bug 1303679 - Remove Places roots, reading list items, and pinned sites from the Sync server. r=markh
MozReview-Commit-ID: AhOBOnXsTYi

--HG--
extra : rebase_source : 1f39b406b1a9215ca04ff4602cc8fac54163916f
2016-11-09 14:23:54 -08:00
ffxbld
d07aca95ba Update configs. IGNORE BROKEN CHANGESETS CLOSED TREE NO BUG a=release ba=release 2016-11-14 13:29:32 +01:00