Commit Graph

3215 Commits

Author SHA1 Message Date
Jared Wein
ce7a61e0dc Bug 1643673 - Guard against a null default application. r=tkikuchi
Differential Revision: https://phabricator.services.mozilla.com/D78551
2020-06-05 18:19:12 +00:00
Mark Striemer
3e55277036 Bug 1632277 - Part 1: Launch PDFs in app mode when default r=jaws,tkikuchi
Differential Revision: https://phabricator.services.mozilla.com/D73774
2020-06-03 18:21:32 +00:00
Gijs Kruitbosch
6c6ab1223a Bug 1606797 - restrict opening the 'open external protocol' dialog, r=johannh,fluent-reviewers,flod
This patch adds the following constraints:

- close the dialog when the originating context navigates;
- close the dialog when the originating context closes / goes away;
- do not allow more than 1 dialog at a time;

Differential Revision: https://phabricator.services.mozilla.com/D77029
2020-06-02 17:12:09 +00:00
Gijs Kruitbosch
a64a69eb7d Bug 1606797 - do not allow navigating to external URIs in cross-origin disjoint browsing contexts, r=johannh,smaug
Differential Revision: https://phabricator.services.mozilla.com/D77028
2020-06-01 21:21:32 +00:00
Gijs Kruitbosch
728702a673 Bug 1606797 - pass the triggering principal when opening external URIs, r=ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D77027
2020-05-27 12:46:34 +00:00
Matt Woodrow
7adf95e964 Bug 1620679 - Don't fire load event from within Stop(). r=smaug
This matches what the spec says, and what blink does.

Differential Revision: https://phabricator.services.mozilla.com/D73994
2020-05-30 17:19:54 +00:00
Emilio Cobos Álvarez
2f5607b8d0 Bug 1642221 - Rename SheetLoadData::mLoaderPrincipal to mTriggeringPrincipal. r=jwatt
I'm about to introduce the concept of "Loader principal" (as in "the
principal of the CSS loader"), and SheetLoadData already has an
mLoaderPrincipal.

However SheetLoadData's principal is just the triggering principal (the
principal that initiated the load). So name it that with consistency
with SheetInfo::mTriggeringPrincipal etc.

Differential Revision: https://phabricator.services.mozilla.com/D77613
2020-05-31 17:11:57 +00:00
Jared Wein
fd5b93e11e Bug 1640589 - Update the mimeInfo when a download is handled internally. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D77144
2020-05-28 16:48:48 +00:00
Gijs Kruitbosch
f163447d48 Bug 1366645 - overwrite image file extensions when initializing file info, r=mak
Differential Revision: https://phabricator.services.mozilla.com/D75640
2020-05-27 16:30:43 +00:00
Gijs Kruitbosch
865098cc8b Bug 1366645 - check builtin extra entries for mimetype information before falling back to the extension, r=mak
Differential Revision: https://phabricator.services.mozilla.com/D75639
2020-05-28 13:49:34 +00:00
Valentin Gosu
243b953e9d Bug 1586630 - Add check to GetURIDirectory r=mayhemer
Differential Revision: https://phabricator.services.mozilla.com/D76125
2020-05-27 11:48:07 +00:00
Emilio Cobos Álvarez
54fd961a29 Bug 1641245 - Make string comparators not virtual. r=froydnj,necko-reviewers,geckoview-reviewers,jgilbert,agi,valentin
There's no use case for stateful comparators, so they can be just plain
function pointers.

This is used in some hot places like CSS selector matching.

Differential Revision: https://phabricator.services.mozilla.com/D77084
2020-05-27 18:11:12 +00:00
Dorel Luca
99ddf6cdc5 Backed out 2 changesets (bug 1366645) for Browser-chrome failures in uriloader/exthandler/tests/mochitest/browser_download_open_with_internal_handler.js. CLOSED TREE
Backed out changeset cdfedc4707bd (bug 1366645)
Backed out changeset 666659de5856 (bug 1366645)
2020-05-27 19:25:57 +03:00
Gijs Kruitbosch
d4bceb69bb Bug 1366645 - overwrite image file extensions when initializing file info, r=mak
Differential Revision: https://phabricator.services.mozilla.com/D75640
2020-05-27 14:14:26 +00:00
Gijs Kruitbosch
d5b5be8f99 Bug 1366645 - check builtin extra entries for mimetype information before falling back to the extension, r=mak
Differential Revision: https://phabricator.services.mozilla.com/D75639
2020-05-22 08:34:17 +00:00
Matt Woodrow
38ffa87e05 Bug 1640160 - Serialize mRequestContextId with BrowsingContext's IPCInitializer to ensure that we don't try to create a request context with an id of 0. r=nika
This was a bit of pain to track down, because some code was allowing an ID of 0, and creating a request context to match, but other code was treating 0 as invalid.

Differential Revision: https://phabricator.services.mozilla.com/D76652
2020-05-26 21:14:27 +00:00
Butkovits Atila
1d2238af48 Backed out 2 changesets (bug 1620679) for perma Reftest failure. CLOSED TREE
Backed out changeset 8190c67514cc (bug 1620679)
Backed out changeset 4ca2912d7421 (bug 1620679)
2020-05-26 10:58:42 +03:00
Matt Woodrow
d347ab0ef5 Bug 1620679 - Don't fire load event from within Stop(). r=smaug
This matches what the spec says, and what blink does.

Differential Revision: https://phabricator.services.mozilla.com/D73994
2020-05-26 03:08:40 +00:00
Honza Bambas
0057c96229 Bug 1637039 - Make synchronous open errors of a fetch preloading channel be notified to link preload tags, r=kershaw
Differential Revision: https://phabricator.services.mozilla.com/D76367
2020-05-25 18:40:07 +00:00
Honza Bambas
b10e870a54 Bug 1637039 - Adjust PreloaderBase::NotifyStart to read channel tainting also for non-opened preloads, r=edgar
Differential Revision: https://phabricator.services.mozilla.com/D76362
2020-05-25 18:38:36 +00:00
Jared Wein
c686b5d561 Bug 1639606 - Downloads that are set to launchWhenSucceeded with an external application should not get handled internally, unless an attempt has already been made to launch externally. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D76243
2020-05-23 16:21:16 +00:00
Mihai Alexandru Michis
9afe3180db Backed out changeset 2708f3e553cb (bug 1639606) for causing xpcshell failures in toolkit/components/downloads
CLOSED TREE
2020-05-23 00:26:32 +03:00
Jared Wein
1b3310643d Bug 1639606 - Downloads that are set to launchWhenSucceeded with an external application should not get handled internally, unless an attempt has already been made to launch externally. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D76243
2020-05-22 17:43:57 +00:00
Bogdan Tara
404a84e0a6 Backed out changeset ee9c7714e513 (bug 1639606) for browser_download_open_with_internal_handler.js failures CLOSED TREE
DONTBUILD
2020-05-22 07:04:45 +03:00
Jared Wein
c9919e67e4 Bug 1639606 - Downloads that are set to launchWhenSucceeded with an external application should not get handled internally, unless an attempt has already been made to launch externally. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D76243
2020-05-22 02:09:45 +00:00
Matt Woodrow
b7105cc963 Bug 1627533 - Create LoadGroups for docshells using the BrowsingContext's request context id. r=dragana,necko-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D75885
2020-05-21 03:38:37 +00:00
Emilio Cobos Álvarez
c3b7227771 Bug 1639392 - Merge nsIStyleSheetLinkingElement and nsStyleLinkElement, and call it LinkStyle. r=jwatt
Which is the spec term. nsIStyleSheetLinkingElement is even more
confusing since it may not be an element at all (see: processing
instructions).

Differential Revision: https://phabricator.services.mozilla.com/D76071
2020-05-21 03:07:16 +00:00
Noemi Erli
3adaaeb800 Backed out 3 changesets (bug 1627533) for causing assertions in RequestContextService.cpp CLOSED TREE
Backed out changeset 3b35a1852a60 (bug 1627533)
Backed out changeset 70fa5e075269 (bug 1627533)
Backed out changeset 0d1046670534 (bug 1627533)
2020-05-21 04:16:21 +03:00
Matt Woodrow
f8b14e22ba Bug 1627533 - Create LoadGroups for docshells using the BrowsingContext's request context id. r=dragana,necko-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D75885
2020-05-20 23:41:36 +00:00
Jared Wein
f5e23e91eb Bug 1638683 - When opening a PDF internally, the new tab should appear adjacent to the opening tab. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D75818
2020-05-20 14:28:04 +00:00
Honza Bambas
d88ed92c5f Bug 1618548 - Make Link: rel=preload response header work with preload-as-speculative-load, r=dragana
Differential Revision: https://phabricator.services.mozilla.com/D75133
2020-05-18 17:33:57 +00:00
Gijs Kruitbosch
34a6029cd6 Bug 1633270 - don't default to saveToDisk if we are supposed to handle internally, r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D75581
2020-05-16 13:22:01 +00:00
Honza Bambas
7a64bc8d9b Bug 1618543 - Let fetch() use "fetch" preloads, r=baku
Differential Revision: https://phabricator.services.mozilla.com/D74899
2020-05-18 12:18:14 +00:00
Mihai Alexandru Michis
19a4744fcc Backed out 2 changesets (bug 1620679) for causing failures in nsDocShell.cpp
CLOSED TREE

Backed out changeset 2957142243c5 (bug 1620679)
Backed out changeset 60df74b03f34 (bug 1620679)
2020-05-18 14:47:37 +03:00
Matt Woodrow
2f95a6ac80 Bug 1620679 - Don't fire load event from within Stop(). r=smaug
This matches what the spec says, and what blink does.

Differential Revision: https://phabricator.services.mozilla.com/D73994
2020-05-18 07:30:14 +00:00
Gijs Kruitbosch
72186b2199 Bug 1638092 - do not require a browsingcontext to call the external protocol service's loadURI method, r=mattwoodrow
Differential Revision: https://phabricator.services.mozilla.com/D75543
2020-05-17 22:54:30 +00:00
Narcis Beleuzu
da3bd17056 Backed out 2 changesets (bug 1633270) for mochitest failure on test_allowContentRetargeting.html
Backed out changeset 77d5aff05a0e (bug 1633270)
Backed out changeset cb53eac110d1 (bug 1633270)
2020-05-16 16:16:57 +03:00
Gijs Kruitbosch
7331d81a95 Bug 1633270 - don't default to saveToDisk if we are supposed to handle internally, r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D75581
2020-05-15 18:20:53 +00:00
Jared Wein
2c619e2a98 Bug 773942 - Create a new init method in nsITransfer that accepts a BrowsingContext and if the download should be handled internally for backwards-compat. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D75186
2020-05-16 06:00:08 +00:00
Jared Wein
f370299b89 Bug 773942 - Add tests that cover the generic PDF description and the 'open with (internal handler)' option of the Unknown Content Type dialog. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D73537
2020-05-16 06:00:03 +00:00
Jared Wein
9b0a889740 Bug 773942 - Hide the 'Open with Firefox' option if the download is started from the download button in pdf.js. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D72779
2020-05-16 05:59:55 +00:00
Jared Wein
3ab25176e5 Bug 773942 - Use the browsingContext to open the new tab with correct userContextId, private-ness, and ownerTab. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D72778
2020-05-16 05:59:53 +00:00
Jared Wein
e2e5ff74a3 Bug 773942 - Use a generic string for the PDF description since it is not necessarily tied to the default handler. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D72777
2020-05-16 05:59:50 +00:00
Jared Wein
3074d7ebb9 Bug 773942 - Open PDFs using pdf.js in a new tab when the Preview option is selected from the Unknown Content Type dialog. r=Gijs
This is currently preffed off behind the "browser.helperApps.showOpenOptionForPdfJS" pref.

Differential Revision: https://phabricator.services.mozilla.com/D72776
2020-05-16 05:59:43 +00:00
Narcis Beleuzu
35b6e759f7 Backed out 9 changesets (bug 773942) for xpcshell failure on test_getMIMEInfo_pdf.js
Backed out changeset 6fb0f25b2f5d (bug 773942)
Backed out changeset 27e9fe03a549 (bug 773942)
Backed out changeset ee0ecad5e90a (bug 773942)
Backed out changeset df062e14287b (bug 773942)
Backed out changeset 7da06239ccfb (bug 773942)
Backed out changeset dfedbeeaec66 (bug 773942)
Backed out changeset 286e1be9dc46 (bug 773942)
Backed out changeset f4df0a553bc0 (bug 773942)
Backed out changeset 97f3b96b6be0 (bug 773942)
2020-05-16 08:37:53 +03:00
Jared Wein
788718620f Bug 773942 - Create a new init method in nsITransfer that accepts a BrowsingContext and if the download should be handled internally for backwards-compat. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D75186
2020-05-16 04:26:12 +00:00
Jared Wein
6db46926a5 Bug 773942 - Add tests that cover the generic PDF description and the 'open with (internal handler)' option of the Unknown Content Type dialog. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D73537
2020-05-16 04:25:18 +00:00
Jared Wein
b804d9a64f Bug 773942 - Hide the 'Open with Firefox' option if the download is started from the download button in pdf.js. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D72779
2020-05-16 04:25:06 +00:00
Jared Wein
58822bff64 Bug 773942 - Use the browsingContext to open the new tab with correct userContextId, private-ness, and ownerTab. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D72778
2020-05-16 04:25:03 +00:00
Jared Wein
fbedeb01f3 Bug 773942 - Use a generic string for the PDF description since it is not necessarily tied to the default handler. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D72777
2020-05-16 04:24:59 +00:00