Commit Graph

10038 Commits

Author SHA1 Message Date
Morgan Rae Reschenberg
c2cd0ee189 Bug 1787274: Use mCachedFields viewport cache for determining offscreen state r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D155903
2022-09-06 21:00:29 +00:00
Morgan Rae Reschenberg
ec1c2a165e Bug 1787282: [Part 2] Cache LINKS_TO relation information r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D156138
2022-09-06 19:27:17 +00:00
Morgan Rae Reschenberg
c8469d0ad8 Bug 1787282: [Part 1] Modify relations caching infrastructure for rels with no implicit partner r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D156126
2022-09-06 19:27:16 +00:00
James Teh
41073adfb6 Bug 1787692: Partially support ISimpleDOMNode::nodeInfo for cached RemoteAccessibles. r=morgan
JAWS won't expose MathML without this.
We can't fully support it; we don't cache info about namespaces, for example.
However, this implementation is enough to get MathML working with JAWS.

Differential Revision: https://phabricator.services.mozilla.com/D156150
2022-09-05 04:30:44 +00:00
Morgan Rae Reschenberg
956c373882 Bug 1788597: Null check acc before creating cache update r=nlapre
Differential Revision: https://phabricator.services.mozilla.com/D156230
2022-09-02 16:53:47 +00:00
Eitan Isaacson
3774262195 Bug 1788132 - Introduce TextLeafPoint::IsParagraphStart. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D156025
2022-08-31 20:52:46 +00:00
Eitan Isaacson
96c72183cc Bug 1788116 - Introduce TextLeafRange iterator. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D156003
2022-08-31 20:34:18 +00:00
Nathan LaPre
982410361d Bug 1732280 - Implement mappings for sub, sup elements and subscript, superscript roles, r=Jamie
This commit adds mappings for HTML sub and sup elements, as well as ARIA
role mappings for subscript, superscript roles, with the goal of properly
exposing this information to the accessibility tree. This commit also updates
text attribute code to account for the attributes implied by those roles.
Finally, this commit updates tests to verify that the role and attribute
information is working properly.

Differential Revision: https://phabricator.services.mozilla.com/D155523
2022-08-31 16:48:56 +00:00
Morgan Rae Reschenberg
45fe2a97f1 Bug 1786086: [Part 3] Queue table cache update on table acc in PruneOrInsertSubtree r=Jamie
Depends on D155132

Differential Revision: https://phabricator.services.mozilla.com/D155133
2022-08-30 23:12:20 +00:00
Morgan Rae Reschenberg
70e8d2d0be Bug 1786086: [Part 2] Queue table cache update when TableLayoutGuessMaybeChanged is called r=Jamie
Depends on D155131

Differential Revision: https://phabricator.services.mozilla.com/D155132
2022-08-30 23:12:20 +00:00
Morgan Rae Reschenberg
b30a39e89d Bug 1786086: [Part 1] Add test to verify changing border style changes layout status r=Jamie
Depends on D154011

Differential Revision: https://phabricator.services.mozilla.com/D155131
2022-08-30 23:12:19 +00:00
Morgan Rae Reschenberg
6d134e1ab6 Bug 1726124: [Part 2] Only fire TABLE_STYLING_CHANGED events on tables, not table parts r=Jamie
Depends on D155276

Differential Revision: https://phabricator.services.mozilla.com/D154011
2022-08-30 23:12:19 +00:00
Morgan Rae Reschenberg
c6c9f2d743 Bug 1726124: [Part 1] Generalise nsAccUtils::TableFor for table parts r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D155276
2022-08-30 23:12:18 +00:00
Eitan Isaacson
ebe08f86d0 Bug 1786519 - Null check BrowserParent's element and its owner doc. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D155729
2022-08-30 23:04:14 +00:00
James Teh
0787850ef9 Bug 1759971: Support MathML on a cached RemoteAccessible for Windows a11y clients. r=morgan
Windows a11y clients retrieve MathML markup using ISimpleDOMNode::innerHTML.
We cache innerHTML to support this, but only on math elements and only on Windows.
sdnAccessible had to be modified to support RemoteAccessible and to use the cache for this method.

Differential Revision: https://phabricator.services.mozilla.com/D155806
2022-08-30 02:29:17 +00:00
James Teh
551e1f9ba8 Bug 1787686: Expose the URL of a link as its value, as well as the value of text/image leaf descendants. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D155810
2022-08-30 02:26:02 +00:00
Cosmin Sabou
3840d81095 Backed out 5 changesets (bug 1726124, bug 1786086) for failures on browser_table.js. CLOSED TREE
Backed out changeset 169c9576cb7b (bug 1786086)
Backed out changeset 76dd155c66b8 (bug 1786086)
Backed out changeset 25a5c81eded3 (bug 1786086)
Backed out changeset 1c5f2f67382b (bug 1726124)
Backed out changeset 8c82b5407ff3 (bug 1726124)
2022-08-29 21:22:27 +03:00
Morgan Rae Reschenberg
9c668d29f9 Bug 1786086: [Part 3] Queue table cache update on table acc in PruneOrInsertSubtree r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D155133
2022-08-29 17:18:34 +00:00
Morgan Rae Reschenberg
f8da65f648 Bug 1786086: [Part 2] Queue table cache update when TableLayoutGuessMaybeChanged is called r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D155132
2022-08-29 17:18:33 +00:00
Morgan Rae Reschenberg
0a22a5d265 Bug 1786086: [Part 1] Add test to verify changing border style changes layout status r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D155131
2022-08-29 17:18:33 +00:00
Morgan Rae Reschenberg
8fe73fc09a Bug 1726124: [Part 2] Only fire TABLE_STYLING_CHANGED events on tables, not table parts r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D154011
2022-08-29 17:18:32 +00:00
Morgan Rae Reschenberg
77f810cf5c Bug 1726124: [Part 1] Generalise nsAccUtils::TableFor for table parts r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D155276
2022-08-29 17:18:32 +00:00
Eitan Isaacson
c039e2a85b Bug 1785930 - Introduce aStopInEditable argument in TextLeafPoint::FindBoundary. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D155030
2022-08-26 16:26:31 +00:00
Mark Banner
8fd5aae050 Bug 1786197 - Turn on ESLint rule for prefer-boolean-length-check for accessible. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D155166
2022-08-26 13:39:34 +00:00
James Teh
08d6b123a8 Bug 1787101: HyperTextAccessibleBase::OffsetAtPoint: Transform the offset before returning it. r=morgan
Otherwise, the returned offset is incorrect if the point is in a child other than the first.

Differential Revision: https://phabricator.services.mozilla.com/D155571
2022-08-26 07:25:12 +00:00
James Teh
fff8d45634 Bug 1787105: HyperTextAccessibleBase::OffsetAtPoint: Don't try to move forward if the end point moves before the start point. r=morgan
This can happen in a container containing no actual characters.
Previously, we would end up in an infinite loop in this case.

Differential Revision: https://phabricator.services.mozilla.com/D155570
2022-08-26 07:25:11 +00:00
Eitan Isaacson
23fc627ed6 Bug 1787291 - Modify mac popup test to wait for cache updates. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D155617
2022-08-25 23:22:53 +00:00
Morgan Rae Reschenberg
da8ff39165 Bug 1785958: Set offscreen state based on BrowsingContext::IsActive r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D155528
2022-08-25 21:00:34 +00:00
Daniel Holbert
c6ad0aa8e2 Bug 1472024 part 2: Add curly braces around if-controlled statements in HTMLTableAccessible.cpp. r=eeejay
This patch doesn't impact behavior.

This changes the code to align with this Mozilla coding style rule:
"Always brace controlled statements, even a single-line consequent [...]"
https://firefox-source-docs.mozilla.org/code-quality/coding-style/coding_style_cpp.html#control-structures

Depends on D155123

Differential Revision: https://phabricator.services.mozilla.com/D155143
2022-08-25 20:31:17 +00:00
Kagami Sascha Rosylight
102bd338be Bug 1695435 - Part 2: Add more words to the chrome script heuristic in use-isInstance r=preferences-reviewers,Gijs,webdriver-reviewers,whimboo,sgalich
Differential Revision: https://phabricator.services.mozilla.com/D110932
2022-08-24 22:47:42 +00:00
Eitan Isaacson
ab16248fa6 Bug 1786963 - Make cached TextBounds return rect of whole input if it is empty. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D155513
2022-08-24 22:00:47 +00:00
Eitan Isaacson
7faa334970 Bug 1786649 - Await for untilCacheOk to resolve in browser position test. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D155434
2022-08-24 16:32:12 +00:00
Morgan Rae Reschenberg
2d7344edbe Bug 1786638: Return early if we can't fetch an internal obj when computing ATK relations r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D155426
2022-08-24 04:44:38 +00:00
James Teh
a15f3cb0ce Bug 1781169: Ensure that the cached start/end containers contain characters before returning them in DocAccessibleParent::SelectionRanges. r=eeejay
In bug 1772170, I added code to ensure that the cached offsets are valid.
However, this didn't account for the possibility that one of the containers contained 0 characters.
In that case, offset 0 is itself invalid.
If there were also no children, this might in GetChildAtOffset being called and returning null, causing a crash when retrieving selection.

Differential Revision: https://phabricator.services.mozilla.com/D154964
2022-08-24 02:40:55 +00:00
Eitan Isaacson
8130d7e4dc Bug 1783733 - Return null if registered accessible is defunct. r=Jamie
Assert if we reach that condition, since the accessible failed to
unregister.

Differential Revision: https://phabricator.services.mozilla.com/D155086
2022-08-23 21:46:09 +00:00
Daniel Holbert
90e860f7bd Bug 1472024 part 1: Check for & gracefully handle failure return values from HTMLTableCellAccessible::GetCellIndexes. r=eeejay
HTMLTableCellAccessible::GetCellIndexes can fail via its NS_ENSURE_STATE macro,
and this patch updates its callsites to account for that possibility.  In each
case, I've just copied the existing graceful-fallback behavior that the
surrounding code uses for other unexpected conditions.

Note that I'm intentionally not using NS_ENSURE_SUCCESS in my error-handling
here, to avoid redundant warning-spam.  (In the failure scenario,
GetCellIndexes will already have spammed a warning, via its own aforementioned
NS_ENSURE_STATE call; it's usually not useful to repeat the warning in the
caller.)

Differential Revision: https://phabricator.services.mozilla.com/D155123
2022-08-23 17:30:19 +00:00
Nathan LaPre
7bda7f2c18 Bug 1785182 - prune children of progressbar elements from the acc tree, r=Jamie
Per the ARIA spec, children of progressbar elements are purely
presentational. So, we should prune their children from the
accessibility tree. This commit adds some logic to nsAccUtils::MustPrune
to forcibly prune these children, ultimately unbreaking the experience
for screen reader users who would otherwise not be told about some ARIA
progressbars.

Differential Revision: https://phabricator.services.mozilla.com/D155307
2022-08-23 16:54:54 +00:00
Morgan Rae Reschenberg
5e8dfcb2e3 Bug 1234121: Unify FocusedChild() in Accessible base class r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D154949
2022-08-19 02:42:30 +00:00
Morgan Rae Reschenberg
498f9328f9 Bug 1234121: Add GetFrom method to DocAccessibleParent r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D153997
2022-08-19 02:42:29 +00:00
Eitan Isaacson
baa3f51d6b Bug 1776907 - Detect line breaks with inputs correctly. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D150492
2022-08-18 17:10:43 +00:00
Nathan LaPre
936dba8ae0 Bug 1779252 - implicitly map address element to role=group, r=Jamie
This commit remaps the HTML address element such that it is implicitly
mapped to the group role rather than being a generic element. It also
updates a test to reflect the new role.

Differential Revision: https://phabricator.services.mozilla.com/D154910
2022-08-18 15:18:02 +00:00
James Teh
fff810fb26 Bug 1784841: Use unified OffsetAtPoint in platform specific code. r=morgan
Most importantly, this means OffsetAtPoint is now supported for cached RemoteAccessible on Windows.
I also included a drive-by fix to make ATK use the unified CharacterCount method instead of the old unnecessary conditional local/remote paths.

Differential Revision: https://phabricator.services.mozilla.com/D154628
2022-08-17 04:59:12 +00:00
Andreas Farre
e6bdbb5f03 Bug 1595491 - Part 2: Adapt test files to <embed> and <object> behaving more like <iframe>. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D148118
2022-08-16 16:42:59 +00:00
Morgan Rae Reschenberg
83e97e1c04 Bug 1782172: [Part 3] Support RelationType::CONTAINING_TAB_PANE in RemoteAccessibleBase r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D153797
2022-08-15 20:43:55 +00:00
Morgan Rae Reschenberg
9b717bd77e Bug 1782172: [Part 2] Support RelationType::EMBEDS in RootAccessible r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D153796
2022-08-15 20:43:55 +00:00
Morgan Rae Reschenberg
439d408a9e Bug 1782172: [Part 1] Support creating a Relation with a RemoteAccessible r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D153795
2022-08-15 20:43:54 +00:00
Morgan Rae Reschenberg
fbec461253 Bug 1783549: Null check mContent before attempting to process CacheDomain::Relations r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D154174
2022-08-15 18:22:29 +00:00
Morgan Rae Reschenberg
b6665e6e70 Bug 1783095: Add relation caching test for input wrapped in <label> r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D154010
2022-08-10 19:45:48 +00:00
Morgan Rae Reschenberg
2469d25ec9 Bug 1783096: Attempt to fetch tag from aFields if TagName() is null r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D153798
2022-08-10 19:45:48 +00:00
James Teh
01e1aa0df7 Bug 1783133: Don't report unexpected test passes when CTW is enabled for bugs that CTW fixes. r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D153718
2022-08-08 23:41:41 +00:00