Commit Graph

2248 Commits

Author SHA1 Message Date
jake%acutex.net
9a8e390762 Checking in the cleaner version of the fix for "No Available Products". This was attached to bug 65311.
Patch by Dave Miller <justdave@syndicomm.com>
r= jake@acutex.net
2001-06-14 20:02:31 +00:00
jake%acutex.net
c2f223f052 Backing out previous changes as there was a better patch already attached to a different bug 2001-06-14 20:00:03 +00:00
jake%acutex.net
22c2912d66 Bugzilla shouldn't display empty header in the New: email notifications (bug 85734)
r=timeless
2001-06-14 14:16:27 +00:00
justdave%syndicomm.com
45bd565c70 Fix for bug 84596: Syncshadowdb wasn't using the db_user and db_pass from localconfig, which meant that it previously wouldn't run unless it was running under a user that had access to the bugs and shadowbugs dbs and didn't have a password. It now looks for db_user and db_pass and specifies them on the command line to mysqldump and mysql if they're in use.
r= tara
2001-06-10 17:38:15 +00:00
justdave%syndicomm.com
6fe1144587 Re-fix for bug 21253: fix calling conventions for syncshadowdb so that a phony parameter to get past the multi-param system() test in tinderbox actually works.
r= tara
2001-06-10 17:15:56 +00:00
jake%acutex.net
9e4a6d0caf Give a logical error message if no products are available to a user for bug entry (bug 84285).
Patch by Paul Thomas <paul.thomas@sse.ie>
r= jake@acutex.net
2001-06-08 13:12:13 +00:00
justdave%syndicomm.com
7ca1d33f14 Hopefully the fix for bug 77778: component lists, etc stuttering due to corruption in data/versioncache.
Patch design by Terry Weissman <terry@mozilla.org>
Patch implemented by Dave Miller <justdave@syndicomm.com>
r= tara@tequilarista.org
2001-06-07 21:26:49 +00:00
justdave%syndicomm.com
3b98736d18 Fix for bug 15980: Password is no longer shown in the location bar on the first page you load after logging in.
Patch by Dave Miller <justdave@syndicomm.com>
r= jake@acutex.net
2001-06-07 20:26:40 +00:00
justdave%syndicomm.com
78dceec13b fix typo 2001-06-07 01:31:51 +00:00
justdave%syndicomm.com
e28badd576 Fix "used only once" error, per tinderbox build log. 2001-06-06 23:09:54 +00:00
justdave%syndicomm.com
336d245aa5 Fix for bug 21253: removing all single-parameter system() calls from Bugzilla
Patch by Dave Miller <justdave@syndicomm.com>
r= tara@tequilarista.org
2001-06-06 21:17:42 +00:00
justdave%syndicomm.com
d92a5f89ec Fix for bug 83872: Bugzilla no longer requires the Mysql Perl module, but the DBD::mysql Perl module, and has been this way for a while. Fixing the version checks in checksetup.pl to check the correct module. Also eliminates a DBD::mysql-specific database function call that is depricated in the current version of DBD_mysql.
Patch by Dave Miller <justdave@syndicomm.com>
r= jake@acutex.net, tara@tequilarista.org
2001-06-06 21:10:47 +00:00
jake%acutex.net
53dba83bd9 Users should only be able to view attachments if they can view the bug that the file is attached to (bug 70189)
r=tara
2001-06-06 18:36:25 +00:00
jake%acutex.net
2c20a3ead5 Fixing typo. Attachments isn't spelled 'Attachemnts' (bug 84295). 2001-06-06 14:25:18 +00:00
justdave%syndicomm.com
4273abfb58 Fix for bug 39557: doeditvotes.cgi will no longer create a vote record for a nonexistant bug if the HTML is tampered with or other bugs cause bad bug numbers in the submitted form.
Patch by Myk Melez <myk@mozilla.org>
r= justdave@syndicomm.com
2001-06-06 04:51:55 +00:00
justdave%syndicomm.com
4fe1f1c9c3 Fix for bug 82781: describecomponents.cgi now checks viewing permissions to make sure you can see a product
Patch by Myk Melez <myk@mozilla.org>
r= tara@tequilarista.org
2001-06-06 04:32:45 +00:00
justdave%syndicomm.com
7f393c1d85 Fix for bug 28458: "NEW" bugs were not getting CC or QA Contact information displayed.
Patch by Jake Steenhagen <jake@acutex.net>
r= justdave@syndicomm.com
2001-06-06 04:28:52 +00:00
justdave%syndicomm.com
450514d585 Fix for bug 75482: adding the capability to deactivate a group without deleting it (prevent new bugs from being placed into that group, but don't remove the group restriction from bugs already in it).
Patch by Myk Melez <myk@mozilla.org>
r= justdave@syndicomm.com
2001-06-06 03:16:52 +00:00
ian%hixie.ch
86e3bcd2ae * Improved the helpfulness of the extremely verbose debugging information of PLIF.pm by quoting embedded variables
* Implemented MagicCollectingArray, which acts like MagicPipingArray except that the result is collected into one big array instead of multiple arrayrefs
* Added the relevant getCollecting*List methods to the Controller class
* Added DESTROY methods to the magic array to prevent DESTROY method calls from being propagated
* Made the debug.dumpVars string more robust when the data hash includes one of the three magic characters '(', '.' or ')'
* Implemented sanitation in COSES so that any keys in the data hash containing one of the three magic characters '(', '.' or ')' will have them transliterated to '[', ':' and ']' respectively (sanitation is optional and can be bypassed)
* Changed the API of the generic output module's 'output' method to take the optional $session argument last, thus simplifying the call sites a lot
* Implemented the 'dispatcher.output' service in several classes to return strings that must be support in variants (required for a good UI in the COSES editor)
* Renamed the Login module's strings so that they use the dot-notation separating significant parts
2001-06-04 06:13:22 +00:00
ian%hixie.ch
a6faa21a5f Stub implementation of a COSES editor component, plus added 'component.nameOfComponent' to the list of services provided by the other two components 2001-06-03 23:06:09 +00:00
ian%hixie.ch
15b9f89cde Moved AdminCommands.pm and Login.pm to a Component directory 2001-06-03 22:45:37 +00:00
ian%hixie.ch
407f43e493 Minor bug fixes required to make the code run without crashing... 2001-06-03 16:14:41 +00:00
ian%hixie.ch
02d609eb82 Some more minor corrections to get it to run as well as compile... (removes some XXX comments and adds some error checking) 2001-06-03 15:27:16 +00:00
ian%hixie.ch
5dd8af9c83 Fixing a gazillion syntax, logic and XML errors and adding some debug code. It compiles! 2001-06-03 14:49:41 +00:00
ian%hixie.ch
7daa595cd4 * Added some comments (including some XXX comments where I realised we had missing code)
* Added implicit data to the hash passed to the string expander from the generic output service
* To support the implicit data, added a |hash| stub method to the Session.pm module (and changed the already implemented version in the descendant user service to take this into account)
* To support the implicit data, added |hash| and |getArguments| methods to the Input.pm module (and implemented |getArguments| in the Arguments.pm module)
* To support the implicit data, made the Program.pm module keep track of the executing command
* To support the implicit data, added |hash| and |name| methods to the Program.pm module (actually, |name| was already assumed to exist in other parts of the codebase)
* Corrected trivial semantic mistake in Program.pm's |verifyInput| method
* Added a way to get a user not by username but by a specific address (modifies the user service and the user data source and it's MySQL implementation)
* Implemented GenericOutputs.pm, an implementation of 'dispatcher.output.generic' and 'dataSource.strings.default' for some strings used by other parts of PLIF (currently only supports 'stdout' and 'http' protocols, and minimally at that)
* Implemented Login.pm, a helper module that implements user authentication, user creation and the sending of a new password if it is forgotten, a utility method |hasRight| to ensure that the authenticated user has a particular right (resulting in a message if not), and various routines to support all this.
2001-06-03 10:11:58 +00:00
tara%tequilarista.org
eda44f5b9f Landing Myk's patch for bug #71767 2001-06-02 22:02:02 +00:00
jake%acutex.net
dd724b762d sanitycheck.cgi was able to be run by anybody - even people without Bugzilla accounts. It is now restricted to only people with the editbugs permission (bug 54556).
Patch by Myk Melez <myk@mozilla.org>
r= jake@acutex.net
2001-06-02 14:24:45 +00:00
justdave%syndicomm.com
770e473d23 Fix for bug 65190: add comparison type "all words as substrings" and "any words as substrings" to the text fields in query.cgi
Patch by Andreas Franke <afranke@ags.uni-sb.de>
r= justdave@syndicomm.com
2001-06-02 04:02:13 +00:00
justdave%syndicomm.com
46f339c5a5 Fix for bug 78407: extra safeguard against overpopping the email list when pruning people who aren't supposed to get mail.
Patch by Jake Steenhagen <jake@acutex.net>
r= justdave@syndicomm.com
2001-06-02 03:19:26 +00:00
justdave%syndicomm.com
6e09c91524 Fix for bug 83596: optional dependency on XML::Parser now checked in checksetup.pl
Patch by Dave Miller <justdave@syndicomm.com>
r= jake@acutex.net
2001-06-02 01:57:22 +00:00
justdave%syndicomm.com
988054fcd5 Fix for bug 83618: checksetup.pl crashes if DBI module isn't already installed.
Patch by Dave Miller <justdave@syndicomm.com>
r= jake@acutex.net
2001-06-02 01:53:01 +00:00
jake%acutex.net
d92f61970d More leak pluggin. This one fixes bug 39526.
Patch by Myk Melez <myk@mozilla.org>
r= jake@acutex.net
2001-06-01 13:38:01 +00:00
justdave%syndicomm.com
a490c6a17a Fix for bug 83633: perl warnings in 5.6
r= Hixie
2001-06-01 10:03:52 +00:00
justdave%syndicomm.com
b2c86ed7e1 Fix for bug 73249: perl warnings under 5.6.0.
Patch by Chris Yeh <Chris.Yeh@nokia.com>
r= justdave@syndicomm.com
2001-06-01 08:34:45 +00:00
justdave%syndicomm.com
d3e70e89ba Fix for bug 79317: dependency on CGI::Carp not caught by checksetup.pl
Patch by Dave Miller <justdave@syndicomm.com>
r= jake@acutex.net
2001-06-01 03:13:28 +00:00
justdave%syndicomm.com
8ab8f92481 backing out previous fix to importxml.pl. It fixed it on Perl 5.6 and broke it on Perl 5.005. Will need to investigate. 2001-06-01 02:27:52 +00:00
justdave%syndicomm.com
bb1c25a4d0 Fix for bug 72862: fixes more Perl warnings in RelationSet.pm and globals.pl 2001-06-01 02:14:23 +00:00
justdave%syndicomm.com
ed939131dc Fix for bug 57848, perl warnings in several files.
Patch by Nick Hibma <n_hibma@qubesoft.com>
r= justdave@syndicomm.com
2001-06-01 02:07:28 +00:00
ian%hixie.ch
07b4d3d583 * fixing some syntactic errors
* added addUserGroup and removeUserGroup to the data source interface for users
* added some comments
* changed many double quotes |"| to single quotes |'| where double quotes were not needed
* implemented the remaining methods for the MySQL implementation of the user data source
* added a mode flag to user fields (idea from MattyT) so that fields can be disabled, hidden, etc
2001-06-01 00:32:35 +00:00
jake%acutex.net
d520cdb669 Bugzilla was leaking information about bugs marked secure (using bug groups). This checkin fixes bugs 39524, 39527, 39531, and 39533.
Patches by Myk Melez <myk@mozilla.org>.
r= jake@acutex.net
2001-05-31 15:52:25 +00:00
jake%acutex.net
7da1a248bc Bug 80388 - cvsblame shouldn't require layers for popups
r=baloo
2001-05-30 22:13:03 +00:00
jake%acutex.net
8cbb7741ca Fix for bug 45164 - New users created by the admin were not subject to the userregexp for groupsets.
Patch by Joe Robins <jmrobins@tgix.com>
r= jake@acutex.net
2001-05-30 15:47:30 +00:00
justdave%syndicomm.com
17dff3efe0 Dummy commit so I can put the attributions I forgot in the previous one.
Patch from bug 65290 was by Jake Steenhagen <jake@acutex.net>
r= justdave@syndicomm.com
2001-05-29 21:27:12 +00:00
justdave%syndicomm.com
8f363f7f6e Fix for bug 65290: can now edit user-regexps for system groups 2001-05-29 21:25:02 +00:00
ian%hixie.ch
76d1f38fb9 Change the semantics of address changing, making it faster, smaller, simpler, and better. Aaah... :-) In the new system, instead of cloning the current $session object to pass it back to the output code, you pass the real $session object to the output code, just making sure that the relevant field has been warned to return a different address than found in the database. 2001-05-29 20:34:12 +00:00
justdave%syndicomm.com
de23e17707 Fix for bug 65399: Can't use string ("") as an ARRAY ref while "strict refs" in use at query.cgi due to no components defined in a product.
Patch by Matthias Radestock <matthias@sorted.org>
r= justdave@syndicomm.com
2001-05-29 20:30:51 +00:00
justdave%syndicomm.com
3aaea9ad25 Additional cleanup for bug 73191. newquip.html is no longer needed. 2001-05-29 18:44:00 +00:00
ian%hixie.ch
1b89023d7a Adding some XXX comments regarding a known bug (when the user is changing their address, fields try to update the database before the new address has been authenticated) 2001-05-29 09:11:33 +00:00
ian%hixie.ch
2411ff6005 * Fixing a minor bug in the MySQL implementation of the string data source
* Started implementing the MySQL version of the user data source (completed so far: database creation and a few of the SELECT calls)
* Changed the user property 'disabled' to 'mode' to enable extensibility
* Fix a potential bug with changing addresses (make sure the fake session object doesn't update the database -- this is an incomplete solution so far, fields still have the bug)
2001-05-29 09:07:10 +00:00
justdave%syndicomm.com
c2cf48b4bd Fix for bug 78045: change references to README in error messages to point to the Bugzilla Guide instead.
Patch by Matthew Tuck <matty@chariot.net.au>
r= justdave@syndicomm.com
2001-05-29 08:10:28 +00:00