Commit Graph

69460 Commits

Author SHA1 Message Date
Coroiu Cristina
6a915c899d Merge mozilla-central to inbound a=merge 2019-02-22 18:41:16 +02:00
Coroiu Cristina
4a72e9cc9a Merge inbound to mozilla-central a=merge 2019-02-22 18:30:44 +02:00
Paul Bone
5d3d1e589f Bug 1528867 - Add a new version of the GC_NURSERY_BYTES telemetry histogram r=chutten
Differential Revision: https://phabricator.services.mozilla.com/D20248

--HG--
extra : moz-landing-system : lando
2019-02-22 04:00:24 +00:00
Bogdan Tara
72e4a39f71 Backed out 2 changesets (bug 1528409) for ParseNode.cpp caused Linux bustages CLOSED TREE
Backed out changeset 49ade2dbfd2b (bug 1528409)
Backed out changeset 76f2dc553878 (bug 1528409)
2019-02-22 07:08:52 +02:00
Luke Wagner
4cf59eac86 Bug 1529349 - Baldr: detect invalid section before code section during streaming compilation (r=bbouvier)
--HG--
extra : rebase_source : f960764027ba5e3d3f891560b30ad16af3d5c219
2019-02-22 09:35:19 -06:00
Brian Hackett
95d63e80b2 Bug 1528320 - Ensure correct record/replay progress flag after XDR-decoding a script, r=tcampbell.
--HG--
extra : rebase_source : 8c89ccde2627022a2d9d6becc66586d2a106b34d
2019-02-21 17:32:59 -10:00
Jeff Walden
15186f6a95 Bug 1529298 - Initialize all ArrayBuffers that store their data inline using a single function. r=sfink 2019-02-18 23:06:28 -08:00
Jeff Walden
d2da599780 Bug 1529298 - Add BufferKind::NO_DATA for ArrayBuffers that have no data (whether because byteLength is zero or because the ArrayBuffer is detached), for which the value of |ownsData()| is irrelevant. r=sfink 2019-02-18 22:53:37 -08:00
Jeff Walden
6308d87577 Bug 1529298 - Remove ArrayBufferOffset::offsetOfFlags as unused. r=sfink 2019-02-18 22:52:42 -08:00
Jeff Walden
ba59f4ed50 Bug 1529298 - Add BufferContents::createFoo functions for every kind so that the templaty, harder-to-search-for create function can be removed. r=sfink 2019-02-18 22:52:42 -08:00
Jeff Walden
adf8ccf080 Bug 1529298 - Consistently use "ArrayBuffer" instead of the vaguer "array buffer" in ArrayBuffer-related JSAPI descriptions. r=sfink 2019-02-18 22:52:42 -08:00
Jeff Walden
2c3a26a56b Bug 1529298 - Simplify ArrayBufferObject::createForContents some now that it's only ever passed non-null contents. r=sfink 2019-02-18 22:52:42 -08:00
Jeff Walden
75b3991d95 Bug 1529298 - Only pass BufferContents containing a non-null pointer to |ArrayBufferObject::createForContents|. r=sfink 2019-02-18 22:52:42 -08:00
Jeff Walden
3f664260f6 Bug 1529298 - Make AllocateArrayBufferContents return uint8_t*, and make its callers consistently not redundantly report OOMs. r=sfink 2019-02-18 22:52:42 -08:00
Jeff Walden
cf48c9f262 Bug 1529298 - Remove trailing arguments to ArrayBufferObject::createForContents that are identical for every caller. r=sfink 2019-02-18 22:52:42 -08:00
Jeff Walden
0b28f92bdc Bug 1529298 - Rename the two ArrayBufferObject::create overloads to ArrayBufferObject::create{Zeroed,WithContents}, and inline a simplified form of the more-complex ArrayBufferObject::create into the new createZeroed function. r=sfink 2019-02-18 22:52:41 -08:00
Jeff Walden
770a4748b4 Bug 1529298 - Remove ArrayBufferObject::hasData and perform its operation in its sole caller in a more straightforward manner. r=sfink 2019-02-18 22:52:41 -08:00
Jeff Walden
7be1e6c028 Bug 1529298 - Remove JS_ExternalizeArrayBufferContents because it has no users except in tests, implements complicated ownership semantics, and is definite implementation complexity. r=sfink 2019-02-18 22:52:41 -08:00
Jeff Walden
851c01dd7e Bug 1529298 - Move most of JS_ExternalizeArrayBufferContents into a static member function on ArrayBufferObject so that internals-observing code isn't smeared across two functions. r=sfink 2019-02-18 22:52:41 -08:00
Jeff Walden
06f85a7986 Bug 1529298 - Split PLAIN into INLINE_DATA/MALLOCED for ArrayBuffer kinds. r=sfink 2019-02-18 22:52:25 -08:00
Jeff Walden
ed29a8a408 Bug 1529298 - Rename JS_NewArrayBufferWithExternalContents to JS_NewArrayBufferWithUserOwnedContents to better accord with the USER_OWNED ArrayBufferKind name, and to avoid namespace overload with the semantically distinct JS_NewExternalArrayBuffer and JS_ExternalizeArrayBufferContents functions. r=sfink
--HG--
rename : js/src/jsapi-tests/testExternalArrayBuffer.cpp => js/src/jsapi-tests/testArrayBufferWithUserOwnedContents.cpp
2019-02-18 22:48:06 -08:00
Jeff Walden
b0059a00fb Bug 1529294 - Add a test for ArrayBuffers with external contents not being serializable. r=sfink 2019-02-18 22:45:17 -08:00
Csoregi Natalia
c80b2680b6 Backed out 16 changesets (bug 1529298, bug 1529294) for spidermonkey bustages on testAtomicOperations.cpp. CLOSED TREE
Backed out changeset d80b681a68e6 (bug 1529298)
Backed out changeset 086849ef0dd5 (bug 1529298)
Backed out changeset 6f66e6c059df (bug 1529298)
Backed out changeset 6cc3cd982953 (bug 1529298)
Backed out changeset d80ce47bba52 (bug 1529298)
Backed out changeset deaa41ca96da (bug 1529298)
Backed out changeset e7fad41d68e0 (bug 1529298)
Backed out changeset b3e668a95d32 (bug 1529298)
Backed out changeset c9f62f10eeb5 (bug 1529298)
Backed out changeset 1477b8eb5442 (bug 1529298)
Backed out changeset 5be8cb19ad3d (bug 1529298)
Backed out changeset 432b2e88c651 (bug 1529298)
Backed out changeset 3512de18097c (bug 1529298)
Backed out changeset 9294b0d54597 (bug 1529298)
Backed out changeset c5a391fd808f (bug 1529298)
Backed out changeset 086f0ad27487 (bug 1529294)

--HG--
rename : js/src/jsapi-tests/testArrayBufferWithUserOwnedContents.cpp => js/src/jsapi-tests/testExternalArrayBuffer.cpp
2019-02-22 05:43:19 +02:00
Jeff Walden
c898e8fff9 Bug 1529298 - Initialize all ArrayBuffers that store their data inline using a single function. r=sfink
--HG--
extra : rebase_source : c265c87b4337f84390622aa788007a0f68b42899
2019-02-18 23:06:28 -08:00
Jeff Walden
c4eba44b33 Bug 1529298 - Add BufferKind::NO_DATA for ArrayBuffers that have no data (whether because byteLength is zero or because the ArrayBuffer is detached), for which the value of |ownsData()| is irrelevant. r=sfink
--HG--
extra : rebase_source : 53bd958bf767f0defb862540308adccde7052af1
2019-02-18 22:53:37 -08:00
Jeff Walden
70cfd5d3a3 Bug 1529298 - Remove ArrayBufferOffset::offsetOfFlags as unused. r=sfink
--HG--
extra : rebase_source : d024d174423cf5b3cc929727017594eb77292f72
2019-02-18 22:52:42 -08:00
Jeff Walden
774a720d27 Bug 1529298 - Add BufferContents::createFoo functions for every kind so that the templaty, harder-to-search-for create function can be removed. r=sfink
--HG--
extra : rebase_source : 9c37a7ffa93331c2b34907edd0ad3011c2332689
2019-02-18 22:52:42 -08:00
Jeff Walden
31d9bc5a55 Bug 1529298 - Consistently use "ArrayBuffer" instead of the vaguer "array buffer" in ArrayBuffer-related JSAPI descriptions. r=sfink
--HG--
extra : rebase_source : e6e6d33d8117935417100521c35f3bd299eba5ef
2019-02-18 22:52:42 -08:00
Jeff Walden
3bbd76241d Bug 1529298 - Simplify ArrayBufferObject::createForContents some now that it's only ever passed non-null contents. r=sfink
--HG--
extra : rebase_source : 8ace1062a7f81cc826c06f0d6f7cadb45a33b1a5
2019-02-18 22:52:42 -08:00
Jeff Walden
d2f26b7737 Bug 1529298 - Only pass BufferContents containing a non-null pointer to |ArrayBufferObject::createForContents|. r=sfink
--HG--
extra : rebase_source : 9546122ddfcbe343dd074b2ca983207589aae1c3
2019-02-18 22:52:42 -08:00
Jeff Walden
bcd8ee657f Bug 1529298 - Make AllocateArrayBufferContents return uint8_t*, and make its callers consistently not redundantly report OOMs. r=sfink
--HG--
extra : rebase_source : 8761b22d2635f5b3cda530d3b2ddfbf116280a36
2019-02-18 22:52:42 -08:00
Jeff Walden
fce4e5a543 Bug 1529298 - Remove trailing arguments to ArrayBufferObject::createForContents that are identical for every caller. r=sfink
--HG--
extra : rebase_source : 610f1507e3e6f152e1baf44d87965c036255017a
2019-02-18 22:52:42 -08:00
Jeff Walden
226f5338b6 Bug 1529298 - Rename the two ArrayBufferObject::create overloads to ArrayBufferObject::create{Zeroed,WithContents}, and inline a simplified form of the more-complex ArrayBufferObject::create into the new createZeroed function. r=sfink
--HG--
extra : rebase_source : 0cc09680ee0e4b7b0cb616aac1157c59b05de5e6
2019-02-18 22:52:41 -08:00
Jeff Walden
9900998369 Bug 1529298 - Remove ArrayBufferObject::hasData and perform its operation in its sole caller in a more straightforward manner. r=sfink
--HG--
extra : rebase_source : 187a9a479a3401c36377e27bf137404c519ed610
2019-02-18 22:52:41 -08:00
Jeff Walden
1563e3e9c8 Bug 1529298 - Remove JS_ExternalizeArrayBufferContents because it has no users except in tests, implements complicated ownership semantics, and is definite implementation complexity. r=sfink
--HG--
extra : rebase_source : da77c4c8ab2089337d74c8fda5823515d4e32d01
2019-02-18 22:52:41 -08:00
Jeff Walden
eeca9137a2 Bug 1529298 - Move most of JS_ExternalizeArrayBufferContents into a static member function on ArrayBufferObject so that internals-observing code isn't smeared across two functions. r=sfink
--HG--
extra : rebase_source : b888ab64b7b8222f00925277b6551a1b4ded266d
2019-02-18 22:52:41 -08:00
Jeff Walden
d5c95a54dc Bug 1529298 - Split PLAIN into INLINE_DATA/MALLOCED for ArrayBuffer kinds. r=sfink
--HG--
extra : rebase_source : 20a657a5ec97ae63f09b8e0e083b969e4fe990a1
2019-02-18 22:52:25 -08:00
Jeff Walden
498b9d3a76 Bug 1529298 - Rename JS_NewArrayBufferWithExternalContents to JS_NewArrayBufferWithUserOwnedContents to better accord with the USER_OWNED ArrayBufferKind name, and to avoid namespace overload with the semantically distinct JS_NewExternalArrayBuffer and JS_ExternalizeArrayBufferContents functions. r=sfink
--HG--
rename : js/src/jsapi-tests/testExternalArrayBuffer.cpp => js/src/jsapi-tests/testArrayBufferWithUserOwnedContents.cpp
extra : rebase_source : ff6c403009297e7a26d54a2dabac59e71bbe5512
2019-02-18 22:48:06 -08:00
Jeff Walden
9348aa838a Bug 1529294 - Add a test for ArrayBuffers with external contents not being serializable. r=sfink
--HG--
extra : rebase_source : f55dc685bfca639dd2793b02eda9d9480d3d14c5
2019-02-18 22:45:17 -08:00
Narcis Beleuzu
1cc1d33847 Merge mozilla-central to inbound. a=merge CLOSED TREE 2019-02-21 18:11:40 +02:00
Narcis Beleuzu
9a26332ec2 Merge autoland to mozilla-central. a=merge 2019-02-21 17:59:30 +02:00
shindli
e8f10d178c Backed out changeset 386a2afe9189 (bug 1508559) for failing raptor tests in /home/cltbld/tasks/task_1550758926/build/raptor.json CLOSED TREE 2019-02-21 17:10:40 +02:00
Nicolas B. Pierron
49a5ea07d9 Bug 1528829 - Restrict ExtractLinearSum to monotonous operation in infinite math space. r=jandem,sunfish
Thanks to Bruno Keith & Niklas Baumstark from the phoenhex team for finding this
issue and reporting it with a proper analysis.

Differential Revision: https://phabricator.services.mozilla.com/D20343
2019-02-21 15:58:55 +01:00
Oana Pop Rus
e3f2246ee8 Merge mozilla-central to autoland. a=merge CLOSED TREE 2019-02-21 11:42:10 +02:00
Oana Pop Rus
b36e97fc77 Merge inbound to mozilla-central. a=merge 2019-02-21 11:31:00 +02:00
Julian Seward
309a7bfa90 Bug 1518785 - wasm-via-Ion: incorrect logic to decide on whether to omit a stack overflow check. r=luke.
MacroAssembler::wasmReserveStackChecked takes a parameter |amount|, which
appears to be the number of bytes pushed by the prologue, not including for
the wasm::Frame, up to this point.  If this value is zero, the stack overflow
check is omitted.

I believe this logic is incorrect and that the stack overflow check should
never be omitted.  There's no way any non-leaf call could really use zero
bytes of stack in total, since there would be no place to store the return
address.

I believe this code worked by accident, for the following reason: |amount| is
never zero.  That happens because, currently, wasm::Frame is 3 words (except
on ARM64).  That's 12 bytes or 24 bytes, depending on word size.  At some
point I imagine that |amount| is rounded upwards, prior to the call to
MacroAssembler::wasmReserveStackChecked, so that |amount| +
sizeof(wasm::Frame) is 0 % 16.

If amount was originally zero, then it will be adjusted upwards to 4 (16-12)
on a 32-bit system and to 8 (32-24) on a 64-bit system.  The end effect is
that |amount| can never be zero here.

The fix is simply to remove the early exit.
2019-02-21 06:25:42 +01:00
Jan de Mooij
d245692106 Bug 1529265 - Don't include scheduled zones we can't collect in zoneStats.collectedZoneCount. r=sfink
Differential Revision: https://phabricator.services.mozilla.com/D20516

--HG--
extra : moz-landing-system : lando
2019-02-21 03:30:57 +00:00
Noemi Erli
47496561f4 Backed out changeset fb6c0d850fa3 (bug 1527862) for bustage in job-queue-04.js CLOSED TREE 2019-02-21 06:58:12 +02:00
Jim Blandy
99c8e0c2ea Bug 1527862: Use proper initialization condition in AutoDebuggerJobQueueInterruption destructor. r=arai
The AutoDebuggerJobQueueInterruption destructor asserts that the Debugger has
properly managed its hooks' asynchronous jobs. But this assertion clearly only
applies when the AutoDebuggerJobQueueInterruption is properly initialized;
otherwise, the debuggee's job queue is still in place.

Unfortunately, the destructor was using the wrong test to determine whether the
debuggee's queue had been saved. This patch makes it uses the `initialized`
method, rather that checking the `cx` field, which is always initialized.

Differential Revision: https://phabricator.services.mozilla.com/D20575

--HG--
extra : moz-landing-system : lando
2019-02-21 01:58:12 +00:00
Cosmin Sabou
9f8b29287b Merge mozilla-central to autoland. 2019-02-21 05:43:34 +02:00