9460 Commits

Author SHA1 Message Date
Emilio Cobos Álvarez
6f97dba672 servo: Merge #17431 - style: Cleanup after #17427, and remove extra-optimistic optimization added in #17429 (from emilio:restyle-hints-xbl); r=emilio
This just addresses my review comments in #17427, and removes a wrong optimization I added in #17429 thinking it was correct.

Source-Repo: https://github.com/servo/servo
Source-Revision: b50cf33efd67fe319aaccb94b476d473901c79d8

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 568e029333d18171751eaa1ca7079ed47ab2c11f
2017-06-20 08:13:05 -07:00
Anthony Ramine
565433f368 servo: Merge #17402 - Use generics for the filter property (from servo:derive-all-the-things); r=emilio
Source-Repo: https://github.com/servo/servo
Source-Revision: fc2c5b7ef4bd7f36b6aa4e0540adc5b8ef3882c0

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : ffccb6f72d2ac1e74cb406e00a940f07c204100f
2017-06-20 06:23:17 -07:00
cku
f503d82ff7 servo: Merge #17427 - Stylo: Correct style match for element instances under a use-element … (from CJKu:cku-master); r=emilio
<!-- Please describe your changes on the following line: -->
This patch is the last one of bug 265894.
It fixes two things:
1. Do not cross shadow tree boundary while matching rules.
2. Change display value to 'inline' while cloning a root symbol element instance.

Bugzilla link:
https://bugzilla.mozilla.org/show_bug.cgi?id=265894
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: b2549bb6c4e512f3fcad9c450908616a1a8d1b5b

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 79ca133437e7bfa7537503691c17b9acc418ca6f
2017-06-20 05:17:45 -07:00
Emilio Cobos Álvarez
83dbe4dfca servo: Merge #17429 - style: Get restyle hints right in presence of XBL (from emilio:restyle-hints-xbl); r=heycam
Fixes bug 1371130.

Source-Repo: https://github.com/servo/servo
Source-Revision: f5a61684f4d357e9259cd42d7b626f73cb32faaf

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 91587d2f9afed039199863fa7dd66af00b1fcb76
2017-06-20 04:15:57 -07:00
Jonathan Chan
e814ff480a servo: Merge #17414 - style: Have OneOrMoreSeparated replace OneOrMoreCommaSeparated (from jyc:space-separator); r=nox
**NOTE** The alternative for me is just to duplicate the ToCss code, which is not bad and is less code changed! Don't know what others would think, though. Looking for feedback!

A future patch series has some values that should be separated by spaces. This
allows us to re-use the code for serialization, but the types do get a little
clunky. The separator is now indicated with an associated type.

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because they shoudl be tested by existing serialization code

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 40a3826dd6ec6908f9fd145ba79985d3b4b8636e

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : ef1200b662d7ccf9c7f03b6fb421434b2de836ab
2017-06-20 03:08:11 -07:00
Ting-Yu Lin
4c8856f6c7 servo: Merge #17426 - stylo: Fix has_author_specified_rules() for rules in XBL stylesheets (from aethanyc:fix-has-author-specified-rules-xbl); r=heycam
This change is reviewed in https://bugzilla.mozilla.org/show_bug.cgi?id=1372062

Source-Repo: https://github.com/servo/servo
Source-Revision: a7ac9214f2b3e6c5a2b9786aebf9073ce4531bc4

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : d3dcde327caf92964da7283466ca01cc3a645769
2017-06-20 02:05:08 -07:00
Glenn Watson
b3c118e299 servo: Merge #17420 - Update WR (optimizations, local clip rect) (from glennw:update-wr-pbo); r=jdm
* PBO optimization for GPU cache updates.
* Alpha rectangle optimizations.
* Local clip rect improvements.

Source-Repo: https://github.com/servo/servo
Source-Revision: c04a29b6e92e5503cb367cb026eb4546aab2fecd

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 54619f7356355e2c21475328e80eda8a8f588655
2017-06-20 00:39:18 -07:00
Boris Chiou
dcbd6ed429 servo: Merge #17422 - stylo: Bug 1369625 - Make stop-color, flood-color, lighting-color animatable (from BorisChiou:stylo/animation/stop_flood_lighting_colors); r=hiro
This is an interdependent patch of Bug 1369625. We make stop-color, flood-color, and lighting-color animatable by using IntermediateRGBA as the animation value type, just like 'color'
attribute. On the Gecko-side, we enable/add the reftest of them and update WPT expectations for these properties.

---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix [Bug 1369625](https://bugzilla.mozilla.org/show_bug.cgi?id=1369625).
- [X] These changes do not require tests because we have tests already in Gekco.

Source-Repo: https://github.com/servo/servo
Source-Revision: 4d997f0d0c87fbce1808d4a97a6c13a68a3c6fdb

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 8ed6ca8c3fe6e3488be86c69e4feeb1abd2c2e1b
2017-06-19 23:12:19 -07:00
Hiroyuki Ikezoe
caab4777af servo: Merge #17400 - Don't run normal traversal for animation only restyle element (from hiikezoe:dont-do-normal-traversal-for-animation-only-restyle-element); r=heycam
<!-- Please describe your changes on the following line: -->
https://bugzilla.mozilla.org/show_bug.cgi?id=1356141

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

Source-Repo: https://github.com/servo/servo
Source-Revision: 546c9db7a7bb762659d1a6d8188eae7bc69902dd

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : a0366f843c5f3b3c3534c7a50eee80eb65fa7fd6
2017-06-19 20:19:16 -07:00
Boris Zbarsky
3b61cf8d3e servo: Merge #17418 - Add pseudo-classes to match on the state of the "dir" attribute (from bzbarsky:dir-pseudo-classes); r=emilio
Fixes the servo parts of Gecko bug 1373798 <https://bugzilla.mozilla.org/show_bug.cgi?id=1373798>

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix https://bugzilla.mozilla.org/show_bug.cgi?id=1373798
<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 27add56298c3f38ae6e7ee2b7242bef947aabf7c

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : df03c2c19911c0169cdf953ac05d22e142256471
2017-06-19 19:25:45 -07:00
est31
711e440a3b servo: Merge #17413 - Update clipboard to 0.4 (from est31:master); r=cbrewster
Fixes #17271
Fixes #16459

Source-Repo: https://github.com/servo/servo
Source-Revision: 154186f420f96897e926fa0a7c4a653cd0185e34

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : d3bc167eb8cf04c1576b683861389b8090aea2fb
2017-06-19 18:22:25 -07:00
Wes Kocher
aed65e6ce7 servo: Merge #17415 - Revert "Add pseudo-classes to match on the state of the "dir" attribute." for preventing me from backing out a gecko-side patch (from KWierso:backout17409); r=jdm
The gecko patches in bug 1373798 broke some gecko-side tests, but they also fixed a stylo build failure that started when this commit merged from servo to autoland, so this needs to get reverted so I can cleanly back out those gecko patches.

This reverts commit e4660c2b5b62779e25432e5acf9d091ce6f04ddc.

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: fa72cd04d98c76b4edb924bc27d8d6a95c646621

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 9958b3f1848573629120cf95c48c364e5eb85ec8
2017-06-19 17:21:29 -07:00
Brian Lewis
3bb211dfa3 servo: Merge #17404 - Shrink rulenode (from zuwow:shrink-rulenode); r=bholley
This shrinks rulenode by one word by removing the Option wrapper around the StyleSource and adding None to StyleSource as an additional variant. The issue mentions shrinking by two words but the free_count one was taken care of in #17368.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #17280

Also tested with `./mach test-unit` and `./mach test-stylo` with no errors reported from either.

<!-- Either: -->
- [X] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

r? @bholley

Source-Repo: https://github.com/servo/servo
Source-Revision: d700a301d3a34c898e1b32b18595f1e9a8000ab6

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : e614566a740d74d69290a142d320684514e14072
2017-06-19 15:30:21 -07:00
Alan Jeffrey
412f60331c servo: Merge #17410 - Support nested requestAnimationFrame in the presence of reftest-wait (from asajeffrey:compositor-nested-rAF-with-reftest-wait); r=jdm
<!-- Please describe your changes on the following line: -->

Currently, nested rAF callbacks don't get called in the presence of reftest-wait. This PR fixes that.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #17408
- [X] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 5f10a25ead8bae973ed9d5f6104f84b8dc1b8a16

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 2867317a41dfdad424d3e2e4093b562144b54442
2017-06-19 13:25:36 -07:00
Boris Zbarsky
df823bd9cf servo: Merge #17409 - Add pseudo-classes to match on the state of the "dir" attribute (from bzbarsky:dir-pseudo-classes); r=emilio
Fixes the servo parts of Gecko bug 1373798 <https://bugzilla.mozilla.org/show_bug.cgi?id=1373798>

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix https://bugzilla.mozilla.org/show_bug.cgi?id=1373798

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 4ecddb0622dcb6fdb7a7bd5025dd12be293b30e1

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : a2a3e880935b9f278d2ae88bc973d431f533cae4
2017-06-19 11:46:52 -07:00
Mantaroh Yoshinaga
0cda7f5772 servo: Merge #17288 - Make filter property animatable (from mantaroh:filter); r=hiro
<!-- Please describe your changes on the following line: -->
This is a PR for https://bugzilla.mozilla.org/show_bug.cgi?id=1362897

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Either: -->
There are tests for these changes, a test case will be landed in web-platform-tests in https://bugzilla.mozilla.org/show_bug.cgi?id=1362897

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: e41b7d06b473544755902be2c1334a7622c84940

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 2262798313c19fcbff756b6b1aa95482b547ad1d
2017-06-18 20:28:16 -07:00
Cameron McCormack
43e2d655f4 servo: Merge #17397 - style: Make checks for attribute/state dependencies take stylist dirty state into account (from heycam:might-have-attr-state-fixes); r=emilio
This is a follow-up Servo-side change for https://bugzilla.mozilla.org/show_bug.cgi?id=1352306
which caused some test failures on landing.

Source-Repo: https://github.com/servo/servo
Source-Revision: 3a4bd245495ab389490602e9a7d458c1e5169b43

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : cf379e0d80937febe3162193ae02d9e84e8d2112
2017-06-18 18:34:05 -07:00
Josh Matthews
62c25ef8e2 servo: Merge #17393 - Don't report the charade package as an error (from servo:jdm-patch-9); r=emilio
DependencyCI does not like that the charade package has been removed from PyPi. This is really not something we care about, though. It's an upstream part of html5lib which is used in the web-platform-tests, and I've filed https://github.com/w3c/web-platform-tests/issues/6269 about replacing it.

Source-Repo: https://github.com/servo/servo
Source-Revision: 8c58736989bcb520413cfbbd0aa07e28043ae0cc

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 2e5ef25d72a6046ad4c55afe202ffe3c8ca4bbb6
2017-06-18 13:21:43 -07:00
Alexis Beingessner
41ef937667 servo: Merge #17389 - Update WR (unrevert border snapping code) (from glennw:revert); r=jdm
Source-Repo: https://github.com/servo/servo
Source-Revision: 348c28240760560eef44bc1443673e0cf6fd501c

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 2f0bfd81d375754ba8176a36a992b27331478c21
2017-06-18 09:07:35 -07:00
Simon Sapin
f2e4fa0a56 servo: Merge #17390 - Untry (from servo:untry); r=nox
Source-Repo: https://github.com/servo/servo
Source-Revision: 568ab550053fddf346806ed6cc2d3bfe37f3e1d0

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 2d258d6f281ff628b88311d2f4523bed29e60ff3
2017-06-18 05:55:11 -07:00
Boris Zbarsky
2d205eed24 servo: Merge #17386 - :-moz-locale-dir shouldn't be a revalidation selector (from bzbarsky:locale-dir-not-revalidation); r=emilio
Fixes Gecko bug 1374019 <https://bugzilla.mozilla.org/show_bug.cgi?id=1374019>

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix https://bugzilla.mozilla.org/show_bug.cgi?id=1374019

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 4c5f7bfaa3bfa57b92b1a30f86e4d5e4031d78db

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 0b72e43e6db84e8db0d34410dd0273f9c7590ff3
2017-06-18 02:14:22 -07:00
Emilio Cobos Álvarez
264b5bdf0b servo: Merge #17384 - style: Clean up some stylist code and make it slightly more efficient (from emilio:stylist-attr-dep); r=nox
Source-Repo: https://github.com/servo/servo
Source-Revision: c5433277b44467ccbfd00024000ded5769157e3c

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 8990e102de45adea1db5ad9421374d6692167c81
2017-06-17 06:20:45 -07:00
Anthony Ramine
d4071af462 servo: Merge #17382 - Derive more ToCss impls (from servo:derive-all-the-things); r=emilio
Source-Repo: https://github.com/servo/servo
Source-Revision: effd6f2f877e767352b45fc35c8066a56c1612b7

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 0f268b10eec3e35c9df66632f82858dde2b6d7a0
2017-06-17 04:53:32 -07:00
Nikhil Shagrithaya
a03ae92655 servo: Merge #17037 - Added Async HTML Tokenizer (from cynicaldevil:impl-Sink); r=nox
Design: I realized having two different parsers for sync and async was wrong, because the API for both was fundamentally the same. All I needed to do was create another Tokenizer, because `ParseNode` ( representation for nodes which are yet to be created) is used by the TreeBuilder and the Sink, and the `Tokenizer` is the 'lowermost' type concerned with these two types.

Therefore, I created one and placed it in `async_html.rs`, and also created a new Sink which deals with `ParseNode`s. I changed the methods in ServoParser to take an `async` argument too, which decides which Tokenizer will be used. The Tokenizer isn't exactly *async* for now, but this PR separates action creation from execution, which allows the async behaviour to be implemented later. Right now, all actions are executed soon after they are created.

The Sink consists of two Hashmaps, `nodes`, which contains the actual nodes, with the key being their corresponding `ParseNode`'s id, and `parse_node_data`, which contains metadata about the nodes.

It's still a bit rough, (I can't figure out how to deal with `complete_script` and `is_mathml_annotation_xml_integration_point`, along with some other parts I wrote in a hurry), but I believe the overall design is sound. I'd like to hear what you think about it.

Source-Repo: https://github.com/servo/servo
Source-Revision: 9c2dffdf72efe4274bb514407edc552b14fc0a4d

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 706e41f53fd00305d695faa3c78757c6771cf6c9
2017-06-17 02:21:19 -07:00
Imanol Fernandez
6b28baff7b servo: Merge #17380 - Fix over-alignment assert crash on Android (from MortimerGoro:over_alignment); r=bholley
<!-- Please describe your changes on the following line: -->

See https://github.com/servo/servo/issues/17320

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #17320 (github issue number if applicable).

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: f56d19227641a2ffeadd30a9673a13cd9a192841

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : d7ff3d05bf70efef5ebfac63a6af62da3105116e
2017-06-16 19:34:23 -07:00
Sadman Kazi
62a0f00c68 servo: Merge #17312 - Fix parsing of shell.homepage (from sadmansk:fix/broken_windows_build); r=paulrouget
<!-- Please describe your changes on the following line: -->
This should fix the nightly builds crashing, although I don't know how to verify whether my fixes worked since I don't know how to test packaging. Any pointers on how to do that would be highly appreciated.

@paulrouget Please let me know if there are any problems with these changes.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #17290
<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 91bdc50e10bdb08fab4dbd3ee3b7997e34168d3a

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 37f02060847b6588e9c609a0433205db0cc7e7e5
2017-06-16 18:36:11 -07:00
Josh Matthews
c4e3d38722 servo: Merge #17360 - Hold stderr lock when using stdout through Console APIs (from servo:stderr); r=emilio
This addresses a longstanding source of intermittent test failures where the stderr and stdout outputs get interleaved and the test harness becomes confused.

---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #12797
- [X] There are tests for these changes

Source-Repo: https://github.com/servo/servo
Source-Revision: d388dc94fc849055e1ae908c77c2e8e5f70a52ca

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : b517b363d3266595f21577163c0055977d091f22
2017-06-16 17:37:26 -07:00
Anthony Ramine
af4107474f servo: Merge #17356 - Minor improvements to #[derive(ToCss)] (from servo:derive-all-the-things); r=SimonSapin
Source-Repo: https://github.com/servo/servo
Source-Revision: 2b02a444ea57448fb30408cba5297101bf9b310d

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 498fd46cf0f3381863bc61e95db74492f96ff134
2017-06-16 15:46:12 -07:00
Bobby Holley
49d6c9f1bf servo: Merge #17368 - Rule tree gc never runs until teardown (from bholley:rule_tree_gc); r=emilio
https://bugzilla.mozilla.org/show_bug.cgi?id=1373725

Source-Repo: https://github.com/servo/servo
Source-Revision: 2a856edf57dcad7e65861ffe12f5aae16db3aa9c

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 53920fd4c3e7a5a2921718f0085c22f28629d037
2017-06-16 14:13:38 -07:00
Jonathan Chan
58409ce69a servo: Merge #17284 - Propagate changes in custom properties' computed values to descendants (from jyc:custom-properties-cascade); r=emilio
If ComputedValues.custom_properties differs between the old and new
ComputedValues, indicate that we have to propogate changes to
descendants by setting child_cascade_requirement to
MustCascadeDescendants in cascade_primary.

style::matching::TElement::cascade_primary already calls
accumulate_damage, which eventually calls
ServoRestyleDamage::compute_style_difference in order to check if other
properties' computed values changed. If any of those change, we signal
that we need to propogate changes for inherited properties.

With Properties & Values, some custom properties will not be inherited,
and we will need to revisit this.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #17283

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 81275234aa225d1011bad7eca126af800ff0d4fc

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 4bf31d42c75dfd84f06e4545bbac6df70739e356
2017-06-16 11:04:51 -07:00
UK992
57a332bfa6 servo: Merge #16395 - Bootstrap: Fix cmake version parsing (from UK992:msvc2017); r=metajack
Fixes https://github.com/servo/servo/issues/16387

Source-Repo: https://github.com/servo/servo
Source-Revision: ffdb27ae3380e6271a01279cb3ba35df6b6c8da9

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 2202d927251ba1fe1b24974fd5fc4904bf2e95aa
2017-06-16 09:00:43 -07:00
Simon Sapin
58442c5f01 servo: Merge #17345 - Upgrade cssparser to 0.15 (from servo:cssparserup); r=<try>
Depends on https://github.com/servo/rust-cssparser/pull/159

Source-Repo: https://github.com/servo/servo
Source-Revision: 75876a0e2220b7b95541feef4393288b195b090e

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 3adf5873dad10451b7d57cc1a5feec40cabeb7d7
2017-06-16 06:09:52 -07:00
Simon Sapin
817c7746be servo: Merge #17355 - Bump serde to 1.0 (from servo:serdeup); r=nox
This is a rebase of #17325 with `[replace]` entries removed, a bunch more dependencies updated, and some more compile fixes. Original work by @Eijebong, thanks a lot!

Source-Repo: https://github.com/servo/servo
Source-Revision: 66c130d55aa0d7af1104c00e93a5bf950f23a383

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 323361580a540d8b296f6f7d77f20d46cbdc5c73
2017-06-16 05:03:18 -07:00
Glenn Watson
2865a9e008 servo: Merge #17352 - Update WR (CPU text optimizations, image format renames) (from glennw:update-wr-faster-text); r=emilio
Source-Repo: https://github.com/servo/servo
Source-Revision: e1bce241291683ee61abab042d0c808ae5396e91

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 38f0d8ec39b0377ce568d0877e0939fafe27d0d1
2017-06-16 01:21:05 -07:00
Xidorn Quan
2a93f79eda servo: Merge #17353 - Make counter style 'disc' not overridable (from upsuper:counter-style-disc); r=dbaron
This is the Servo side change for [bug 1372488](https://bugzilla.mozilla.org/show_bug.cgi?id=1372488).

Source-Repo: https://github.com/servo/servo
Source-Revision: 32f82959f89ccd0d6f92058f22f11f2cc7d21d52

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 64ef1f0cba8d44b9451874cd5aec2a851fb1fdfd
2017-06-15 23:51:16 -07:00
Cameron McCormack
0d10d88134 servo: Merge #17351 - style: Tweak an import (from heycam:nit); r=emilio
Source-Repo: https://github.com/servo/servo
Source-Revision: 4d54f2c9bbc700f06cfef7d85df5f43bdbcf085d

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : a69a806c6044e0f60cba1c08ab446dcf42230471
2017-06-15 22:50:53 -07:00
Connor Brewster
e1ae5b07a2 servo: Merge #17224 - WebIDL HTMLConstructor support (from cbrewster:html_constructor); r=jdm
<!-- Please describe your changes on the following line: -->
spec: https://html.spec.whatwg.org/multipage/#htmlconstructor

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #17194 (github issue number if applicable).

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: c58bcc23ea5c4b5f83944e111ce9a2d0ec2b5400

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 2ee613be5c136e0376b935ff4d5de918731cb44b
2017-06-15 21:47:16 -07:00
Emilio Cobos Álvarez
7a567b8052 servo: Merge #17348 - style: Inline RestyleData (from emilio:bup); r=bholley
Bug: 1368236
MozReview-Commit-ID: 49s3SO0PMHf
Source-Repo: https://github.com/servo/servo
Source-Revision: 33766b2714443399808c950e5bb74b1f124f2bc4

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 690c18bca1352a15a9f9f891faeb1aae94563de0
2017-06-15 20:28:56 -07:00
Cameron McCormack
90a4e723f9 servo: Merge #17350 - style: Adjust display:contents to display:inline for NAC (including ::before/::after) (from heycam:gencon-contents); r=emilio
From https://bugzilla.mozilla.org/show_bug.cgi?id=1354879.

Source-Repo: https://github.com/servo/servo
Source-Revision: e3a52536b650f4aeb951b474936a0b67821f112e

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 49f06023911a61699087b6e04863cb3e6cb12afd
2017-06-15 18:58:01 -07:00
Ellen Marie Dash
aa43c98d84 servo: Merge #17347 - Fix setting img src before window.onload causing panic (from duckinator:fix-issue-17319); r=mbrubeck
<!-- Please describe your changes on the following line: -->

Setting an image source asynchronously (e.g. using `setTimeout` or in the callback of an `XMLHttpRequest`) before `window.onload` fired would cause a panic due to a preexisting load blocker not being terminated before assigning a new one.

This PR fixes that and adds a test for it.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #17319.

<!-- Either: -->
- [x] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 04935de3ea8db953415a87bb4107cd48555503de

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 433c35c6dd15b15df8815bd93d3502d8f0de784a
2017-06-15 16:58:20 -07:00
hinaria
ea177608e2 servo: Merge #17340 - windows: fix line height handling (from hinaria:master); r=jdm
hi there!

on windows, this change properly scales a font's line height by its size.

previously, line height was not scaled to the font's size at all, which meant line heights become worse and worse the further you scaled away from the font's design size (in either direction, larger or smaller).

this change makes the `line_gap` ratio and size scale with the font size. i've hand checked that the new computed `line_gap` matches the effective heights in chrome and firefox when `line-height = normal` for a bunch of system fonts. (servo's rendering quality on windows is a different story, though).

![demonstration](https://user-images.githubusercontent.com/975570/27185401-8e27023a-5228-11e7-8475-9e4223730d25.png)

i believe this also solves #16476.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors

Source-Repo: https://github.com/servo/servo
Source-Revision: 8fd7dc80c40440b88f42b8f1036ef67483dd93f0

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 391981353adad7566e4a59ca8d296e4062355ea0
2017-06-15 15:42:38 -07:00
Anthony Ramine
74279dfc9b servo: Merge #17338 - Derive ToCss for computed LengthOrPercentage types (from servo:derive-all-the-things); r=emilio,waffles
Source-Repo: https://github.com/servo/servo
Source-Revision: 0142d193a3fde057718612028d9c1676e046b816

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : dbf86c0ae37ccd730b2a38035b192e8b36b5a36c
2017-06-15 13:37:04 -07:00
budaim
3d6af99f59 servo: Merge #17323 - Avoid panic when reloading a page with mouse event handlers (from ibmandura:issue16057); r=jdm
This PR fixes issue #16057, by nullifying `topmost_mouse_over_target` inside of the `handle_exit_pipeline_msg` method, in case owner document is the same as the pipeline document that is being destroyed.

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors

Testing was done manually, by running `./mach run (-r|-d) "http://localhost:8000/minimal.html" `, where `minimal.html` contains `<div onmouseover="location.reload()" onmouseout="this.clientLeft">hi there</div>`.

r?@jdm

Source-Repo: https://github.com/servo/servo
Source-Revision: 0c53ba318aaccf9b4a8b233496ed7bfe929c02ce

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 192f635ae711f875b1f4b711efac1436d5f91918
2017-06-15 12:36:19 -07:00
Emilio Cobos Álvarez
bc95f926c6 servo: Merge #17341 - style: Bindgen bump (from emilio:bup); r=bholley
To grab https://github.com/servo/rust-bindgen/pull/752.

Source-Repo: https://github.com/servo/servo
Source-Revision: d903bd883ee064b295944af28a76a6223f2bc56d

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 2dd2e8eff9d2f5ccff4fae4441ef6b32cc97b94b
2017-06-15 11:34:12 -07:00
Bobby Holley
ced56a8161 servo: Merge #17334 - Make the traversal work better with the style sharing cache (from bholley:breadth_first_traversal); r=emilio
https://bugzilla.mozilla.org/show_bug.cgi?id=1365692

Source-Repo: https://github.com/servo/servo
Source-Revision: 6ec95ecb9f5159eafa8d3051c259d566d518f29d

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : b8b74ce57dbeb6d85958a4c903095fefc4569443
2017-06-15 10:34:49 -07:00
Anthony Ramine
98940e5acb servo: Merge #17337 - Use CustomIdent in more properties (from servo:derive-all-the-things); r=emilio
Source-Repo: https://github.com/servo/servo
Source-Revision: 4b633c8637ec8bf5da7538a04506941325807701

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 68d19e6b1133667d4599fdc0299014c0d86d3454
2017-06-15 05:24:17 -07:00
Fernando Jiménez Moreno
2c72d1419f servo: Merge #17324 - stylo: set location for NestedRuleParser during prelude parsing (from ferjm:bug1371393.column); r=SimonSapin
From https://bugzilla.mozilla.org/show_bug.cgi?id=1371393

Source-Repo: https://github.com/servo/servo
Source-Revision: b0392dbf39d36f19cd16ec06e29b6aca6e6135e2

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 2d9901d5de8634c9656453b7755a0d42f5b75e28
2017-06-15 01:36:22 -07:00
Brian Birtles
066d307211 servo: Merge #17331 - Support animation of the display property (from birtles:animate-display); r=hiro
These are the Servo-side changes of [Mozilla bug 1371518](https://bugzilla.mozilla.org/show_bug.cgi?id=1371518).

These changes have been reviewed by @hiikezoe.

Source-Repo: https://github.com/servo/servo
Source-Revision: 09b8f124f59f98d83e4fe72a3fe4d506e912cdb6

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : c1d1941bcbf78d38a7ec6c1201d1df4061dbc18a
2017-06-14 20:17:47 -07:00
Bobby Holley
c98302df9c servo: Merge #17332 - Bump rayon to 0.8 (from bholley:bump_rayon_0_8); r=glennw
Source-Repo: https://github.com/servo/servo
Source-Revision: e0820c8654489a226e3f1348c1e134e890cb84c3

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 25e4f805202f3d0389a3d3f8e36046ffc9c97d34
2017-06-14 19:12:30 -07:00
Emilio Cobos Álvarez
a346686966 servo: Merge #17330 - style: Avoid some branches in common RuleIterator::next cases (from emilio:rules-iter-perf); r=heycam
I saw this function appear in the profiles at #17329.

It was under set_device, which isn't a Stylo path, but probably worth there
anyway.

This reduces the reported overhead of RulesIterator::next in perf from ~8% to
0.46%

Source-Repo: https://github.com/servo/servo
Source-Revision: bb36553c1965fdc0ffefff530e8a264275efe2ba

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : bd915f2f6e1d022d00118f9daa2e5693129729d2
2017-06-14 18:19:21 -07:00