Commit Graph

20 Commits

Author SHA1 Message Date
Jean-Yves Avenard
11ac9e9cf8 Bug 1540581 - P6. Tidy some C++ declarations in gfx/. r=gerald,jrmuizel
* Remove redundant virtual keywords
* Mark all destructors of inheriting classes as virtual for clarity
* Mark all classes without virtual destructor as final (exposed errors)
* Make destructor virtual where it needed to be (some were missing)
* Replace empty ({}) code declaration in header with = default
* Remove virtual unused methods

I probably missed some, it quickly became a rabbit hole.

Differential Revision: https://phabricator.services.mozilla.com/D26060

--HG--
extra : moz-landing-system : lando
2019-04-11 12:36:51 +00:00
Sylvestre Ledru
265e672179 Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format
# ignore-this-changeset

--HG--
extra : amend_source : 4d301d3b0b8711c4692392aa76088ba7fd7d1022
2018-11-30 11:46:48 +01:00
Ehsan Akhgari
2febd96e7e Bug 1508472 - Part 2: Second batch of comment fix-ups in preparation for the tree reformat r=sylvestre
This is a best effort attempt at ensuring that the adverse impact of
reformatting the entire tree over the comments would be minimal.  I've used a
combination of strategies including disabling of formatting, some manual
formatting and some changes to formatting to work around some clang-format
limitations.

Differential Revision: https://phabricator.services.mozilla.com/D13073

--HG--
extra : moz-landing-system : lando
2018-11-28 00:54:56 +00:00
Cosmin Sabou
0afa5aa670 Backed out 2 changesets (bug 1508472) for causing build bustages on JobScheduler_posix.cpp. CLOSED TREE
Backed out changeset af951294cf96 (bug 1508472)
Backed out changeset 2320933cb7bc (bug 1508472)
2018-11-28 00:08:11 +02:00
Ehsan Akhgari
7c937c2747 Bug 1508472 - Part 2: Second batch of comment fix-ups in preparation for the tree reformat r=sylvestre
This is a best effort attempt at ensuring that the adverse impact of
reformatting the entire tree over the comments would be minimal.  I've used a
combination of strategies including disabling of formatting, some manual
formatting and some changes to formatting to work around some clang-format
limitations.

Differential Revision: https://phabricator.services.mozilla.com/D13073

--HG--
extra : moz-landing-system : lando
2018-11-27 21:36:18 +00:00
Andreea Pavel
945463d394 Backed out changeset 11d6688b953f (bug 1508472) for build bustages on a CLOSED TREE 2018-11-27 18:28:30 +02:00
Ehsan Akhgari
d0a3a76106 Bug 1508472 - Part 2: Second batch of comment fix-ups in preparation for the tree reformat r=sylvestre
This is a best effort attempt at ensuring that the adverse impact of
reformatting the entire tree over the comments would be minimal.  I've used a
combination of strategies including disabling of formatting, some manual
formatting and some changes to formatting to work around some clang-format
limitations.

Differential Revision: https://phabricator.services.mozilla.com/D13073

--HG--
extra : moz-landing-system : lando
2018-11-27 15:18:32 +00:00
Sebastian Hengst
0819f35e51 Backed out 4 changesets (bug 525063) on request from Andi. a=backout
Backed out changeset 516c4fb1e4b8 (bug 525063)
Backed out changeset 6ff8aaef2866 (bug 525063)
Backed out changeset bf13e4103150 (bug 525063)
Backed out changeset d7d2f08e051c (bug 525063)
2018-04-13 16:01:28 +03:00
Tristan Bourvon
a3a77c0312 Bug 525063 - Initialize uninitialized class attributes in m-c. r=ehsan 2018-04-10 21:11:02 +02:00
Daniel Holbert
126bd9e1a4 Bug 1412427 part 8: (automated patch) Switch a bunch of C++ files in gfx to use our standard mode lines. r=jrmuizel
This patch was generated automatically by the "modeline.py" script, available
here: https://github.com/amccreight/moz-source-tools/blob/master/modeline.py

For every file that is modified in this patch, the changes are as follows:
 (1) The patch changes the file to use the exact C++ mode lines from the
     Mozilla coding style guide, available here:
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Coding_Style#Mode_Line

 (2) The patch deletes any blank lines between the mode line & the MPL
     boilerplate comment.

 (3) If the file previously had the mode lines and MPL boilerplate in a
     single contiguous C++ comment, then the patch splits them into
     separate C++ comments, to match the boilerplate in the coding style.

MozReview-Commit-ID: 77D61xpSmIl

--HG--
extra : rebase_source : c6162fa3cf539a07177a19838324bf368faa162b
2017-10-27 16:10:06 -07:00
Andi-Bogdan Postelnicu
98ef2aa49c Bug 1317637 - Use C++11's override and remove virtual where applicable in gfx/. r=jrmuizel
MozReview-Commit-ID: 2nzBWEAu2wt

--HG--
extra : rebase_source : 0fffd208a79f8d72bc36d77600ba925cbe254a7c
2016-11-15 11:16:29 +02:00
Andi-Bogdan Postelnicu
eb85517996 Bug 1317637 - Replace default bodies of special member functions with = default; in gfx/. r=jrmuizel
MozReview-Commit-ID: EWUpBvj5i6Z

--HG--
extra : rebase_source : 9639ddfbd21183870fe48bc946a6164a2d5ec530
2016-11-15 11:04:18 +02:00
Nicolas Silva
f06dc39683 Bug 1233743 - Remove the Mutex typedef from gfx/2d. r=vlad 2016-03-21 15:34:50 +01:00
Nicolas Silva
b7f00c6f5b Bug 1209039 - Temporarily disable thread names in Moz2D to work around a static check failure CLOSED TREE. r=me 2015-09-28 15:27:16 +02:00
Nicolas Silva
120cce1d84 Bug 1083101 - Win32 implementation of the JobScheduler. r=jrmuizel 2015-09-28 13:49:52 +02:00
Nicolas Silva
850e06aa00 Bug 1083101 - Add a task scheduler to Moz2D. r=jrmuizel 2015-09-28 13:49:43 +02:00
Wes Kocher
d28eb4d8c9 Backed out bug 1083101 for build bustage CLOSED TREE
changesets backed out:
e39dfd9e05cb, cd54e93993b4, 61db1a51a7c4, c20fd7506bb7, b5e97b0facb7, cdf356cb817e, b058a918f443, d421e79326a2, 34a0be9af3f3, bba6f89ab775, 2fd5cfcea4e5

--HG--
extra : amend_source : 9dd084c69c78fd2248dfb1b9ba562b8a396ba205
extra : histedit_source : 7dc833e4d0e1656ed98f560b0bd8fec9e0aee3ef%2C1df84fdd3e0adae06356f9ffbafc49538ffb8729
2015-09-24 11:14:50 -07:00
Nicolas Silva
5c994c47a4 Bug 1083101 - Back 5 patches out due to windows build issues, CLOSED TREE. 2015-09-24 19:47:20 +02:00
Nicolas Silva
0819b3e7d5 Bug 1083101 - Win32 implementation of the JobScheduler. r=jrmuizel 2015-09-24 17:35:30 +02:00
Nicolas Silva
dbac937791 Bug 1083101 - Add a task scheduler to Moz2D. r=jrmuizel 2015-09-24 17:35:10 +02:00