Commit Graph

159 Commits

Author SHA1 Message Date
Paul Adenot
6e6f676da0 Bug 1403041 - Don't re-enter libcubeb from the audio thread. r=kinetik
This delays initializing the channel count until actually initializing the
cubeb stream for an AudioCallbackDriver.

The constructor of an AudioCallbackDriver is usually called from the previous
driver's thread (be it a system thread or the audio callback, the exception
being when it's the first time a GraphDriver is being created), while the
AudioCallbackDriver::Init method is always called from a special thread that is
specially created to run potentially long and blocking operations, such as
creating an audio stream.

MozReview-Commit-ID: GFx85N8PlKX
2017-09-28 16:57:46 +02:00
Paul Adenot
ec46b8ffb1 Bug 1403041 - Fix typo in AudioCallbackDriver member. r=kinetik
s/mOuputChannelCount/mOutputChannelCount/

MozReview-Commit-ID: Kv03aSKnfQa
2017-09-26 12:05:01 +02:00
Andreas Pehrson
3e7a54981e Bug 1360334 - Improve error handling. r=padenot
MozReview-Commit-ID: 5tIXzzisg0V

--HG--
extra : source : 0dc85355af3d166038ccf6e0fd161bd614b0ead2
2017-09-08 16:41:36 +02:00
Sebastian Hengst
3a76476175 Backed out changeset a3eabb355005 (bug 1360334) for build bustaget at dom/media/GraphDriver.cpp:200: cannot pass non-trivial object of type 'RefPtr<mozilla::GraphDriver>' to variadic function. r=backout on a CLOSED TREE 2017-09-09 18:00:49 +02:00
Andreas Pehrson
0bdbb7d2aa Bug 1360334 - Improve error handling. r=padenot 2017-09-08 16:41:36 +02:00
Alex Chronopoulos
087f9c1689 Bug 1392837 - Support multichannel audio input on gUM. r=padenot
MozReview-Commit-ID: FKCIAo4a8jy

--HG--
extra : rebase_source : 2f72331514909f418580e3c7c8bcc445e74167c8
2017-09-04 17:26:03 +03:00
Alex Chronopoulos
eb4205d7a8 Bug 1395195 - Restrict min number of channels on AudioCallbackDriver's helper buffers. r=padenot
MozReview-Commit-ID: 5eAhN4x6U4q

--HG--
extra : rebase_source : 0445dc820222ae51b74e277995baf423190cff7e
2017-08-31 16:43:01 +03:00
Chun-Min Chang
b0e140e2a2 Bug 1392930 - part 3: Make AudioCallbackDriver inherit from DeviceChangeListener; r=padenot
--HG--
extra : rebase_source : a6d87257004fe4954044c0ccd70ca4b4f597099a
2017-08-29 17:45:44 +08:00
Alex Chronopoulos
c9d4805a3f Bug 1378070 - Implement multichannel WebAudio. r=padenot
* * *
[mq]: rebase

MozReview-Commit-ID: KJwH3ZeJn55

--HG--
extra : rebase_source : 0e9866c8dc5ccb98a9654c1e18b0bcef1ef5afa8
2017-08-28 17:16:20 +03:00
Paul Adenot
a202254933 Bug 1388243 - r=jesup
MozReview-Commit-ID: Jexghw0QFrB

--HG--
extra : amend_source : 624073ea6dc7c13728945a0feebf10f891c33174
2017-08-21 11:56:13 +01:00
Matthew Gregan
2f8cc7804c Bug 1388236 - Remove B2G-only AudioChannel code from MSG. r=padenot 2017-08-10 13:00:08 +12:00
Matthew Gregan
f4d992a821 Bug 1388229 - Remove B2G-only audio stream type handling. r=kamidphish 2017-08-10 13:00:07 +12:00
Eric Rahm
01f545fea7 Bug 1386825 - Part 1: Remove MOZ_B2G from dom. r=bkelly
MozReview-Commit-ID: 1zzP2r01B7U
2017-08-08 14:41:05 -07:00
Paul Adenot
4029e408c3 Bug 1378067 - Label more runnables in dom/media (GraphDriver.cpp, CubebUtils.cpp, DOMMediaStream.cpp). r=jesup
MozReview-Commit-ID: EQzR1AfzvzE

--HG--
extra : rebase_source : 9950d07eb1e8e9b1d07f94c10d7c5cf0008a8141
2017-07-18 11:26:58 +02:00
Sebastian Hengst
cb2227a5c7 Backed out changeset 6dc016256eba (bug 1378067) for bustage at dom/media/webaudio/WebAudioUtils.cpp:107. r=backout on a CLOSED TREE 2017-07-18 11:51:22 +02:00
Paul Adenot
ac12821115 Bug 1378067 - Label more runnables in dom/media (GraphDriver.cpp, CubebUtils.cpp, DOMMediaStream.cpp). r=jesup
MozReview-Commit-ID: EQzR1AfzvzE
2017-07-18 11:26:58 +02:00
Paul Adenot
67c95cdcdf Bug 1312623 - Don't attempt to shutdown a thread in the dtor of a GraphDriver, since it might be called during stable state. r=smaug
MozReview-Commit-ID: HA67HQQrfow

--HG--
extra : rebase_source : d9301c6f5687eb1e1c3a7c4049e48ceaf74fa529
2017-07-04 09:21:23 +02:00
Alex Chronopoulos
48c9b10048 Bug 1380233 - New signature for cubeb_get_min_latency. r=kinetik
MozReview-Commit-ID: 4vh6atnnRpS

--HG--
extra : rebase_source : bee0a7d0a10b0eaf9cedb6286a1b1aa492457a94
2017-07-13 13:06:02 +03:00
Carsten "Tomcat" Book
daa67cc9e3 merge mozilla-inbound to mozilla-central a=merge 2017-06-30 12:59:45 +02:00
Paul Adenot
e55c008768 Bug 1372247 - Make the AudioOutputObserver a member of the MediaEngineWebRTCMicrophoneSource so it's not a global singleton anymore. r=jesup
MozReview-Commit-ID: 3yC1PvG3sW7

--HG--
extra : rebase_source : 950c1633d127ee0b6670b112bb31637a8851a583
2017-06-12 17:14:26 +02:00
Alex Chronopoulos
41737dc1af Bug 1213414 - Implement channelCount audio constraint. r=jib,padenot
MozReview-Commit-ID: K95iBYOE1nR

--HG--
extra : rebase_source : 5c73eea4902933faec75e37d90e42a2f38c51b81
2017-06-29 21:01:17 -07:00
Bill McCloskey
f115503a0b Bug 1372405 - Provide names for all runnables in the tree (r=froydnj)
MozReview-Commit-ID: DKR6ROiHRS7
2017-06-26 14:19:58 -07:00
Carsten "Tomcat" Book
8a1350b5a6 Backed out changeset 4f6302a98ae4 (bug 1372405)
--HG--
extra : rebase_source : 41632f3158e88e692809731394a683d065a73dfb
2017-06-21 13:59:26 +02:00
Bill McCloskey
6b3e84ed5f Bug 1372405 - Provide names for all runnables in the tree (r=froydnj)
MozReview-Commit-ID: DKR6ROiHRS7
2017-06-20 21:44:11 -07:00
Carsten "Tomcat" Book
ea1b86680c Backed out changeset 9846de3bd954 (bug 1372405)
--HG--
extra : rebase_source : 5d4a48e8ec394c329994689d938d2a6e9b2752b0
2017-06-20 08:27:02 +02:00
Bill McCloskey
4592152411 Bug 1372405 - Provide names for all runnables in the tree (r=froydnj)
MozReview-Commit-ID: DKR6ROiHRS7
2017-06-19 22:25:47 -07:00
Bill McCloskey
d6affd5261 Bug 1365098 - Convert NS_GetCurrentThread uses in dom/media (r=cpearce)
MozReview-Commit-ID: DUPt6xj49zz
2017-06-12 20:20:08 -07:00
Alex Chronopoulos
b62929dc13 Bug 1368448 - After full duplex AEC info can be found in MSG. r=padenot
MozReview-Commit-ID: Atfjf1iu48k

--HG--
extra : rebase_source : 18704da62dd2428f85bd430b551b4567424cfdc6
2017-06-06 12:26:39 +03:00
Alex Chronopoulos
a88c8ec84a Bug 971528 - Allow stereo capture in AudioCallbackDriver. r=padenot
* * *
[mq]: graph-driver-comments

MozReview-Commit-ID: JnU3opk8X5K
* * *
[mq]: tmp

MozReview-Commit-ID: 73CtZw4CRG

--HG--
extra : rebase_source : eda1c9429de289dff1b1c235d8c505828a4b3ed2
2017-06-02 09:11:56 +03:00
Sebastian Hengst
c3adb686ab Backed out changeset 4481be95f232 (bug 971528) for build bustage in MediaEngineWebRTC.h (at least on OS X). r=backout 2017-06-01 18:26:17 +02:00
Alex Chronopoulos
fa245fd24c Bug 971528 - Allow stereo capture in AudioCallbackDriver. r=padenot
* * *
[mq]: graph-driver-comments

MozReview-Commit-ID: JnU3opk8X5K
* * *
[mq]: tmp

MozReview-Commit-ID: 73CtZw4CRG

--HG--
extra : rebase_source : cf6942aeaf4c2831fce4d92de0c5eeaaba7c0cd6
2017-05-29 13:26:27 +03:00
Carsten "Tomcat" Book
eff0fbf63b Backed out changeset e0bab3ab79ff (bug 971528) for asan mda failures on a CLOSED TREE 2017-04-27 13:02:47 +02:00
Alex Chronopoulos
e79da75180 Bug 971528 - Allow stereo capture in AudioCallbackDriver. r=padenot
* * *
[mq]: graph-driver-comments

MozReview-Commit-ID: JnU3opk8X5K
* * *
[mq]: tmp

MozReview-Commit-ID: 73CtZw4CRG

--HG--
extra : rebase_source : bca0932ccffc6348260039fc7ec829245a9b2236
2017-04-27 10:24:25 +03:00
Sebastian Hengst
48d0fe2217 Backed out changeset cce59c2a2baa (bug 971528) for crashing in mda tests, e.g. dom/media/tests/mochitest/identity/test_peerConnection_asymmetricIsolation.html. r=backout 2017-04-24 19:11:46 +02:00
Alex Chronopoulos
c8b9a5a3df Bug 971528 - Allow stereo capture in AudioCallbackDriver. r=padenot
* * *
[mq]: graph-driver-comments

MozReview-Commit-ID: JnU3opk8X5K
* * *
[mq]: tmp

MozReview-Commit-ID: 73CtZw4CRG

--HG--
extra : rebase_source : 1fc6ebb1265514cfbb9c8e969ae7e3b269ba9527
2017-04-24 19:05:24 +03:00
JW Wang
79d42d9703 Bug 1350202 - use shorter names for logging macros in MediaDecoder.cpp. r=kaku
MozReview-Commit-ID: E2OnbXb82Zb

--HG--
extra : rebase_source : d1de2002a7bb446b10aaeb4e03a56ce3a63f6ae4
2017-03-24 11:17:17 +08:00
Paul Adenot
76e574e1c0 Bug 1340718 - When the cubeb stream errors out while driving a MediaStreamGraph, fall back to a SystemClockDriver. r=jesup
MozReview-Commit-ID: Co1UIuU7bCu

--HG--
extra : rebase_source : 7436e871e6ece2da7e44b3a2d242c012d57bfe97
2017-02-24 16:42:20 +01:00
Paul Adenot
36370e3c12 Bug 1336945 - Modernize MSG/GraphDriver logging. r=jesup
MozReview-Commit-ID: 5Redgg5uaQG
2017-02-06 16:22:36 +01:00
Jean-Yves Avenard
b7844bd5c3 Bug 1319987: P9. More coding style fixes. r=gerald
MozReview-Commit-ID: DhFRqkWQZny

--HG--
extra : rebase_source : 03ed44efc83fe9cab7fc975229ac4e5746aff96b
2017-01-27 13:20:37 +01:00
Paul Adenot
f012888dd8 Bug 1332905 - For mono or stereo in AudioStream.cpp until the rest of the code is multichannel-aware. r=achronop a=tomcat
MozReview-Commit-ID: 5eqBlPnHVk2
2017-01-23 11:36:58 +01:00
Alex Chronopoulos
bad8dea079 Bug 1331869 - Initialize new field of cubeb_stream_params. r=kinetik,padenot
MozReview-Commit-ID: KZ08mckJX44

--HG--
extra : rebase_source : 6789db291ace421114055063efa37481cfc524ef
2017-01-20 16:54:00 +02:00
Ralph Giles
d5608e0a47 Bug 1277037 - Make AudioCallbackDriver::StartStream fallible. r=jesup
Avoid crashing in the case that cubeb stream start fails and report
an error instead.

MozReview-Commit-ID: 75M392POyHo

--HG--
extra : rebase_source : 2c083cf129f12ad1e18d9065152cfee13987b071
2017-01-11 11:51:23 -08:00
Markus Stange
942cdc08a8 Bug 1323100 - Stop double-registering the MediaStreamGraph thread with the profiler. r=froydnj
MozReview-Commit-ID: 7WxNLZpBWL4

--HG--
extra : rebase_source : 6dee759440f94e63a82c43ec295b9a6e9c020d21
2016-12-21 23:06:45 +01:00
Alex Chronopoulos
1bb3f66458 Bug 1221574 - [02] Fix build erros with the new backend. r=jesup
MozReview-Commit-ID: n27saMBWfw
2016-11-18 18:00:48 +02:00
Randell Jesup
4875bcdbf9 Bug 1300818: bustage fix rs=kwierso on a CLOSED TREE 2016-10-14 15:13:30 -04:00
Paul Adenot
0fea3fd083 Bug 1300818 - Cap latency at 512 frames for some mac models. r=jesup
MozReview-Commit-ID: B40Tu7r8GG2
2016-10-14 18:35:35 +02:00
Paul Adenot
cb690a7e56 Bug 1301648 - Add a pref to be able to control the AudioCallbackDriver requested latency. r=kinetik
MozReview-Commit-ID: 19BZUjyXFlq

--HG--
extra : rebase_source : 96df59a9b5c9f8bd7e5f8211a09b854d65833b3b
2016-09-09 15:21:50 +02:00
Matthew Gregan
0ebace12e5 Bug 1302348 - Report cubeb context init failures via telemetry. r=padenot 2016-09-16 12:54:24 +12:00
Gerald Squelart
6e6bb23cf3 Bug 1300446 - Check return value from GetCubebContext - r=kinetik
MozReview-Commit-ID: Y9b5Aq2RZE

--HG--
extra : rebase_source : 11422dc401d95cd91329b33b082b29bd193b16da
2016-08-30 17:20:10 -07:00
Nicholas Nethercote
b71747b2ac Bug 1299727 - Rename NS_WARN_IF_FALSE as NS_WARNING_ASSERTION. r=erahm.
The new name makes the sense of the condition much clearer. E.g. compare:

  NS_WARN_IF_FALSE(!rv.Failed());

with:

  NS_WARNING_ASSERTION(!rv.Failed());

The new name also makes it clearer that it only has effect in debug builds,
because that's standard for assertions.

--HG--
extra : rebase_source : 886e57a9e433e0cb6ed635cc075b34b7ebf81853
2016-09-01 15:01:16 +10:00