When the autoclose bracket addon is enabled, quotes and ] are automatically
inserted, but that wasn't taken into account in the function that is in charge
of setting the input value when the user accept the autocompletion.
This patch should fix this, and add a few tests to makes sure we don't regress.
Differential Revision: https://phabricator.services.mozilla.com/D79126
The console editor uses the codeMirror autoclose bracket addon,
which when the user types a closing bracket and the next char
in the input is the same char, won't insert a new char, but will
only move the cursor.
In such case, the JsTerm code wasn't capturing this key event, and
it could happen that the autocomplete would still be displayed,
which would then lead to some weirdness when the user hits Enter.
In order to fix that, we listen for the keyHandled event, which
is fired one a keypress was handled, and that appear that be fired
for the case I exposed, and isn't triggered when the character is
simply inserted.
A test case is added in one of our test to make sure this works as
expected.
Differential Revision: https://phabricator.services.mozilla.com/D78935
When there are multiple runtime.onMessage listeners in the same context, if
the first one sends a response, but the second one throws, the exception wins
the race because we convert all responses into async promises.
Converting the sync exception into an async promise rejection ensures we process
them in the original order.
Differential Revision: https://phabricator.services.mozilla.com/D79006
Instead of linking to a page in MDN which links back to firefox-source-doc, this change links it directly to "Building Firefox On Windows"
Differential Revision: https://phabricator.services.mozilla.com/D79302
My patch from bug 1599160 changed timing in a way that makes this bug a
perma fail and I'd rather not get it backed out :)
Differential Revision: https://phabricator.services.mozilla.com/D79316
To avoid sending identifying information, common absolute paths are patched with placeholder values. For example, devs
may place their Firefox repository within their home dir, so absolute paths are doctored to be prefixed with
"<topsrcdir"> instead.
Additionally, any paths including the user's home directory are patched to instead be a relate path from "~".
Differential Revision: https://phabricator.services.mozilla.com/D78962
This supports the fact that devtools, which is hosted in an "about:" page,
does not use inline styles. They are prevented from working by the CSP defined
at devtools/client/framework/toolbox.xhtml. This patch moves The styles that
are added by the MozPanel.initialize method into the popup.css files for each
theme, where the other .panel-arrowcontent class selectors live.
Differential Revision: https://phabricator.services.mozilla.com/D78832
...and be still super safe by adding null checks.
Some existing tests crash if we just add the assertions and the rest of the patch
fixes those.
Differential Revision: https://phabricator.services.mozilla.com/D79269
This patch adds a prefix field to the mozperftest perfherder data. This is a non-standard data field so the performance-artifact-schema.json file isn't modified to include it.
Differential Revision: https://phabricator.services.mozilla.com/D79296
Update existing tests to run with `SharedArrayBuffer` and `ArrayBuffer`.
Also add new tests for cases which weren't previously possible (detached
buffers and TypedArrays using inline storage).
Differential Revision: https://phabricator.services.mozilla.com/D76322
We no longer need to guard against non-shared TypedArrays when inlining
`Atomics` functions.
The `MemoryBarrierRequirement` changes for `M(Load|Store)UnboxedScalar` were
made to keep at least some users for `TypedArraySharedness`. In practice this
code won't be used anyway, because `TemporaryTypeSet::getTypedArraySharedness`
always returns `UnknownSharedness`. Also see bug 1225025.
Differential Revision: https://phabricator.services.mozilla.com/D76320
The TypedArray data extraction had to be moved from `AtomicAccess` into the
actual operation to account for the case when a TypedArray using inline data
is moved by the GC due to side-effects triggered by type conversions within
the operation. Part 4 contains tests to cover this case.
Because the TypedArray data is no longer passed to the operation, we can't use
it anymore to determine the data type from the `SharedMem<T>` parameter. Instead
pass an `ArrayOps<T>` instance to the operation, so we can determine `T` within
the lambda function. (Templated lambda functions are only available starting
with C++20!) The compiler should be able to optimise away the stack allocation
for this instance, so this won't incur any performance costs.
Differential Revision: https://phabricator.services.mozilla.com/D76319
These days, FunctionBox can be created without a JSFunction which is also
suitable for the asm.js dummyFunction case. Remove the function and pass name
and flags directly to the FunctionBox.
We set flags to INTERPRETED_NORMAL since that is only type of function
allowed at this point in the asm.js context.
Differential Revision: https://phabricator.services.mozilla.com/D78802
