Commit Graph

746312 Commits

Author SHA1 Message Date
Simon Giesecke
eb291e55de Bug 1693541 - Improve uses of nsBaseHashtable and descendants by using Contains instead of Get in image. r=tnikkel
Differential Revision: https://phabricator.services.mozilla.com/D106106
2021-02-24 12:49:57 +00:00
Simon Giesecke
03bd728532 Bug 1693541 - Improve uses of nsBaseHashtable and descendants by using Contains instead of Get in dom/gamepad. r=handyman
Differential Revision: https://phabricator.services.mozilla.com/D106101
2021-02-24 12:49:56 +00:00
Simon Giesecke
022bf00650 Bug 1693541 - Improve uses of nsBaseHashtable and descendants by using Contains instead of Get in toolkit/components/url-classifier. r=gcp
Differential Revision: https://phabricator.services.mozilla.com/D106110
2021-02-24 12:49:56 +00:00
Simon Giesecke
700d52dc1a Bug 1693541 - Improve uses of nsBaseHashtable and descendants by using Contains instead of Get in storage. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D106098
2021-02-24 12:49:55 +00:00
Simon Giesecke
eeedc67ff4 Bug 1693002 - Remove redundant nullptr checks of return value of infallible new in dom/media. r=bryce
Depends on D105290

Differential Revision: https://phabricator.services.mozilla.com/D105291
2021-02-24 12:44:08 +00:00
Emilio Cobos Álvarez
1076a90e6d Bug 1694616 - Don't use FunctionRef in MutationObservers. r=smaug
FunctionRef is so easily inlineable, looking at the comments in D95354.
This also removes some duplication, so it's win-win.

I fixed the assertion to restore the original meaning, since it seems it
was accidentally changed in that revision.

Also added some comments on why the different ordering for removals and
non-removals.

Differential Revision: https://phabricator.services.mozilla.com/D106265
2021-02-24 11:50:30 +00:00
Emilio Cobos Álvarez
02f55d8bdf Bug 1694616 - Document doesn't need to inherit from nsStubMutationObserver. r=smaug
We don't override any of the methods. I wonder when this stopped being
useful, it seemed useless before bug 1420547 already, and the comment
oes back to bug 342062...

Differential Revision: https://phabricator.services.mozilla.com/D106268
2021-02-24 11:48:57 +00:00
Butkovits Atila
ac34595c78 Backed out changeset 1ff45a9b57fe (bug 1690845) for causing failure at reftest.list. CLOSED TREE 2021-02-24 12:44:07 +02:00
Nicolas Silva
a14439cf73 Bug 1692250 - Begin refactoring the how pictures refer to their textured content. r=gw
This patch only erases some of the differences between how pictures and other primitves resolve their render tasks. There is a lot more to do there but I quite haven't figured out the incremental next step towards decoupling the picture primitive its content. After this patch we may be close to a good place to start extracting composite modes out into their own primitives.

Differential Revision: https://phabricator.services.mozilla.com/D106142
2021-02-24 10:32:25 +00:00
Nicolas Silva
94ed405587 Bug 1692250 - Remove ImageSourceHandle. r=gw
Replaced with RenderTaskId or Option<RenderTaskId> depending on context.

Differential Revision: https://phabricator.services.mozilla.com/D105984
2021-02-24 10:32:25 +00:00
Nicolas Silva
0e6dc9d100 Bug 1692250 - Make RenderTaskId smaller. r=gw
65k render tasks is a lot more than what we need, and RenderTaskId will soon be stored in more places where size affects performance.

Differential Revision: https://phabricator.services.mozilla.com/D105986
2021-02-24 10:32:24 +00:00
Nicolas Silva
64d2e19380 Bug 1692250 - Get the gpu cache in a valid state in frame graph tests. r=gw
The test render tasks used to dodge the gpu cache interactions. Rather than maintain special cases, make it so the gpu cache is usable during these tests (which mainly means having a valid frame stamp to not trigger some assertions).

Differential Revision: https://phabricator.services.mozilla.com/D105985
2021-02-24 10:32:24 +00:00
Nicolas Silva
beb3f1412b Bug 1692250 - Refer to cached render tasks with a render task ID. r=gw
This is the last important change of this render task refactoring. Cached render tasks now create nodes in the frame graph so that they can be referenced via a render task ID. With this it is now possible to refer to almost any textured content via a render task ID, regardless of how it was produced and whether it is cached. It also allows any render task to read from a cached one (before, only primitives and clip sources could).
This obsoletes ImageSourceHandle which will be remvoed in a subsequent patch.

Differential Revision: https://phabricator.services.mozilla.com/D105952
2021-02-24 10:32:23 +00:00
Sebastian Zartner
3fcc126250 Bug 1651649 - Use toggle button for switching between raw and formatted response view. r=Honza,bomsy
The accordion widget inside the response view of the Network Monitor got replaced by a simple headline with a toggle button at the end.

Differential Revision: https://phabricator.services.mozilla.com/D103839
2021-02-24 10:09:36 +00:00
Timothy Nikkel
a17ef11404 Bug 1690845. Don't ask Windows for the icon of an empty file extension because it returns the c: drive icon, which is not what we want. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D105736
2021-02-24 09:56:16 +00:00
Edmund Wong
6aa9734887 Bug 1675676 - Add --with-crashreporter-url for ac_add_options to allow specifying alternative crash-stats server url. r=glandium,gsvelto
Differential Revision: https://phabricator.services.mozilla.com/D96322
2021-02-24 09:46:59 +00:00
Andreea Pavel
4d15e7e3f1 Backed out changeset 45b36995cfd6 (bug 1690216) for build bustages at rules.mk on a CLOSED TREE 2021-02-24 12:03:14 +02:00
Lee Salzman
e746523892 Bug 1690216 - Report whether to redraw on invalidation to WR. r=mattwoodrow
This requires us to plumb CompositorCapabilities to support the extra field.
This is complicated by the fact that since it is a Rust struct, it has no
default constructor that can pass through to C++ via bindings, so every
one of our RenderCompositors was forced to manually initialize fields. To
get around this brittle footgun, instead the structure is initialized on
the Rust side, and RenderCompositor's are encouraged to only change fields
that actually diverge from the defaults as passed in via pointer.

Finally, we can then do what we need to do, which is just to send the
ForceRedraw message that needs to happen based on what we know about
CompositorCapabilities.

Differential Revision: https://phabricator.services.mozilla.com/D106246
2021-02-24 09:18:33 +00:00
Itiel
0bb647b6f6 Bug 1692773 - Fix about:certificate tabs' outline when focused r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D105223
2021-02-24 08:38:15 +00:00
Eden Chuang
00ad03a9c3 Bug 1684139 - Adding mozilla specific wpt for timer nesting level in workers r=dom-worker-reviewers,asuth
This patch is developed from D104136#3396152.

This patch creates WorkerTestUtils.webidl under dom/webidl for testing workers with internal APIs. These APIs are exposed to workers only and controlled by dom.workers.testing.enabled pref.

This patch creates a Mozilla-specific web-platform test, testing/web-platform/mozilla/test/workers/worker_timer_nesting_level.html, to test the timer nesting level implementation for workers.

To simplify the test implementation, this patch does not implement the webidl under dom/chrome-webidl/ suggested by D104136#3396152.

Depends on D104136

Differential Revision: https://phabricator.services.mozilla.com/D105332
2021-02-24 08:14:39 +00:00
Eden Chuang
aed62c9971 Bug 1684139 - Implement timer nesting level for workers r=dom-worker-reviewers,asuth
This patch implements the timer nesting level for workers according to https://html.spec.whatwg.org/#timer-initialisation-steps.

If the timer's nesting level is larger than 5 and the interval time is less than 4, the timer should be clamped to 4.

Differential Revision: https://phabricator.services.mozilla.com/D104136
2021-02-24 08:14:39 +00:00
Frederik Braun
fe5b17c259 Bug 1664485 - update WPT for optional sanitize arguments r=ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D105954
2021-02-24 08:01:01 +00:00
Frederik Braun
85f139b0d2 Bug 1664485 - make sanitize/sanitizeToString param's non-optional r=ckerschb,emilio
Differential Revision: https://phabricator.services.mozilla.com/D105953
2021-02-24 08:01:01 +00:00
Masayuki Nakano
b60a352c71 Bug 1661132 - Make test_bug596600.xhtml wait proper event after syntheisizing native mousemove event r=smaug
The test assumes that mousemove events are fired with waiting a tick
after synthesizing native mousemove event.  However, it's wrong since
synthesizing native mousemove event may run after a tick for waiting
safe time to synthesize a native event.

Differential Revision: https://phabricator.services.mozilla.com/D106136
2021-02-24 07:01:16 +00:00
Tooru Fujisawa
36a819f0cc Bug 1694364 - Remove CompilationStencil constructor with CompilationInput parameter. r=tcampbell
Differential Revision: https://phabricator.services.mozilla.com/D106128
2021-02-24 04:22:38 +00:00
Tooru Fujisawa
8bf21e07a7 Bug 1692577 - Part 16: Remove unnecessary and redundant ExtensibleCompilationStencil::finish from reflect_parse. r=tcampbell
reflect_parse wasn't using CompilationStencil, but uses
ExtensibleCompilationStencil in CompilationState.

Differential Revision: https://phabricator.services.mozilla.com/D105908
2021-02-24 04:22:38 +00:00
Tooru Fujisawa
265f679178 Bug 1692577 - Part 15: Use frontend::CompileGlobalScriptToExtensibleStencil in DumpStencil. r=tcampbell
Differential Revision: https://phabricator.services.mozilla.com/D105907
2021-02-24 04:22:37 +00:00
Tooru Fujisawa
a40c3d117c Bug 1692577 - Part 14: Use frontend::CompileGlobalScriptToExtensibleStencil in CompileStencilXDR. r=tcampbell
Differential Revision: https://phabricator.services.mozilla.com/D105906
2021-02-24 04:22:37 +00:00
Tooru Fujisawa
6486950bdd Bug 1692577 - Part 13: Use frontend::CompileGlobalScriptToExtensibleStencil in CompileSourceBufferAndStartIncrementalEncoding. r=tcampbell
Differential Revision: https://phabricator.services.mozilla.com/D105905
2021-02-24 04:22:36 +00:00
Tooru Fujisawa
264b455882 Bug 1692577 - Part 12: Add frontend::CompileLazyFunction. r=tcampbell
Differential Revision: https://phabricator.services.mozilla.com/D105904
2021-02-24 04:22:36 +00:00
Tooru Fujisawa
bfac577ab5 Bug 1692577 - Part 11: Use ExtensibleCompilationStencil in off-thread module compilation task r=tcampbell
Differential Revision: https://phabricator.services.mozilla.com/D105903
2021-02-24 04:22:36 +00:00
Tooru Fujisawa
90598b2bf4 Bug 1692577 - Part 10: Add ParseModuleToStencilAndMaybeInstantiate. r=tcampbell
Differential Revision: https://phabricator.services.mozilla.com/D105902
2021-02-24 04:22:35 +00:00
Tooru Fujisawa
7ac8a44635 Bug 1692577 - Part 9: Use ExtensibleCompilationStencil in off-thread script compilation task. r=tcampbell
Differential Revision: https://phabricator.services.mozilla.com/D105901
2021-02-24 04:22:35 +00:00
Tooru Fujisawa
f8bcc0524c Bug 1692577 - Part 8: Add ExtensibleCompilationStencil::{sizeOfExcludingThis,sizeOfIncludingThis}. r=tcampbell
Differential Revision: https://phabricator.services.mozilla.com/D105900
2021-02-24 04:22:34 +00:00
Tooru Fujisawa
e9ad0d01c7 Bug 1692577 - Part 7: Cleanup JSRuntime::initSelfHosting. r=tcampbell
Stop reusing already-initialized CompilationInput from decode to compile.

Differential Revision: https://phabricator.services.mozilla.com/D105899
2021-02-24 04:22:34 +00:00
Tooru Fujisawa
5cc10c73ab Bug 1692577 - Part 6: Add frontend::CompileGlobalScriptToExtensibleStencil. r=tcampbell
For the case the consumer needs heap-allocated ExtensibleCompilationStencil,
make CompileGlobalScriptToStencilAndMaybeInstantiate possible to also return
ExtensibleCompilationStencil.

Differential Revision: https://phabricator.services.mozilla.com/D105898
2021-02-24 04:22:34 +00:00
Tooru Fujisawa
b77a51c09c Bug 1692577 - Part 5: Add CompileGlobalScriptToStencilAndMaybeInstantiate. r=tcampbell
To support instantiating without heap-allocate CompilationStencil, modify
CompileGlobalScriptToStencil to receive either CompilationStencil pointer or
CompilationGCOutput pointer, and if CompilationGCOutput pointer is passed,
instantiate it internally.

Differential Revision: https://phabricator.services.mozilla.com/D105897
2021-02-24 04:22:33 +00:00
Tooru Fujisawa
fd545742b8 Bug 1692577 - Part 4: Unify Compiler class interface. r=tcampbell
Make all classes to follow init() + compile() + stencil().
stencil() returns a reference to ExtensibleCompilationStencil, and consumer
can either use BorrowingCompilationStencil to create temporary
CompilationStencil from it, or use ExtensibleCompilationStencil::finish to
get non-temporary CompilationStencil.

Differential Revision: https://phabricator.services.mozilla.com/D105896
2021-02-24 04:22:33 +00:00
Tooru Fujisawa
e399685ee4 Bug 1692577 - Part 3: Make more CompilationStencil& parameter const. r=tcampbell
Differential Revision: https://phabricator.services.mozilla.com/D105895
2021-02-24 04:22:32 +00:00
Tooru Fujisawa
8aacd24949 Bug 1692577 - Part 2: Move finish to ExtensibleCompilationStencil. r=tcampbell
Differential Revision: https://phabricator.services.mozilla.com/D105894
2021-02-24 04:22:32 +00:00
Tooru Fujisawa
180bfe382b Bug 1692577 - Part 1: Add BorrowingCompilationStencil. r=tcampbell
BorrowingCompilationStencil provides a CompilationStencil instance that
borrows all ExtensibleCompilationStencil data,

Differential Revision: https://phabricator.services.mozilla.com/D105893
2021-02-24 04:22:32 +00:00
Tooru Fujisawa
f6ee9a2a00 Bug 1693433 - Part 5: Add ref-counted StencilAsmJSContainer. r=tcampbell
To borrow ExtensibleCompilationStencil.asmJS from CompilationStencil.asmJS.

Differential Revision: https://phabricator.services.mozilla.com/D105892
2021-02-24 04:22:31 +00:00
Tooru Fujisawa
21f7c222fc Bug 1693433 - Part 4: Make StencilModuleMetadata ref-counted. r=tcampbell
To borrow ExtensibleCompilationStencil.moduleMetadata from CompilationStencil.moduleMetadata.

Differential Revision: https://phabricator.services.mozilla.com/D105891
2021-02-24 04:22:31 +00:00
Tooru Fujisawa
cb0853be4b Bug 1693433 - Part 3: Add borrow variant to SharedDataContainer. r=tcampbell
To borrow ExtensibleCompilationStencil.sharedData from CompilationStencil.sharedData.

Differential Revision: https://phabricator.services.mozilla.com/D105890
2021-02-24 04:22:30 +00:00
Tooru Fujisawa
930010f263 Bug 1693433 - Part 2: Add {CompilationStencil,ExtensibleCompilationStencil}::assertNoExternalDependency. r=tcampbell
Differential Revision: https://phabricator.services.mozilla.com/D105799
2021-02-24 04:22:30 +00:00
Tooru Fujisawa
441c738f4f Bug 1693433 - Part 1: Add CompilationStencil.hasExternalDependency field. r=tcampbell
For now, the field is set to true only when decoding from XDR.

Differential Revision: https://phabricator.services.mozilla.com/D105621
2021-02-24 04:22:30 +00:00
Tooru Fujisawa
2c1de41799 Bug 1692648 - Part 5: Accumulate all data into CompilationState, and copy/move to CompilationStencil in CompilationState::finish. r=tcampbell
Instead of directly storing into CompilationStencil, store all data into
CompilationState, from Parser and BytecodeEmitter.

Differential Revision: https://phabricator.services.mozilla.com/D105145
2021-02-24 04:22:29 +00:00
Tooru Fujisawa
0bbe9def38 Bug 1692648 - Part 4: Add ExtensibleCompilationStencil and move stencil-related fields from CompilationState, and make CompilationState subclass of it. r=tcampbell
Differential Revision: https://phabricator.services.mozilla.com/D105720
2021-02-24 04:22:29 +00:00
Tooru Fujisawa
23690adb54 Bug 1692648 - Part 3: Move CompilationState definition after CompilationStencil. r=tcampbell
Differential Revision: https://phabricator.services.mozilla.com/D105143
2021-02-24 04:22:28 +00:00
Tooru Fujisawa
87f2f509f0 Bug 1692648 - Part 2: Pass LifoAlloc to ScopeStencil::createFor*. r=tcampbell
Differential Revision: https://phabricator.services.mozilla.com/D105141
2021-02-24 04:22:28 +00:00