Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-12 04:45:45 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
318,098 Commits 615 Branches 98 Tags 6 GiB
6f4e72b203
Commit Graph

347 Commits

Author SHA1 Message Date
Birunthan Mohanathas
6f4e72b203 Bug 888548 - Part 3: Add enum support to mozilla::Atomic<T>. r=froydnj 
Due to a bug in GCC, the compareExchange function is not available with enum types.
 2013-07-31 21:15:25 -04:00
Birunthan Mohanathas
19404c8ec4 Bug 888548 - Part 2: Refactor and cleanup mozilla::Atomic<T> implementation. r=froydnj 
This moves the increment and decrement operators from detail::AtomicBase to
detail::AtomicBaseIncDec and moves the implementation of the assignment
operator into detail::AtomicBase. Additionally, this changes the integral
implementation to use mozilla::EnableIf for its specialization.
 2013-07-31 21:15:25 -04:00
Birunthan Mohanathas
1ee96e1d2b Bug 888548 - Part 1: Add mozilla::IsEnum to TypeTraits.h. r=froydnj 2013-07-31 21:15:25 -04:00
Ehsan Akhgari
d344af7264 Bug 895322 - Part 5: Stop #defining MOZ_STATIC_ASSERT in C++ code; r=Waldo 
--HG--
extra : rebase_source : 463c9918228e3f46c909cc7cad45c9d2913b0152
 2013-07-18 14:39:20 -04:00
Ehsan Akhgari
2824b29025 Bug 895322 - Part 1: Replace the usages of MOZ_STATIC_ASSERT with C++11 static_assert; r=Waldo 
This patch was mostly generated by running the following scripts on the codebase, with some
manual changes made afterwards:

# static_assert.sh
#!/bin/bash
# Command to convert an NSPR integer type to the equivalent standard integer type

function convert() {
echo "Converting $1 to $2..."
find . ! -wholename "*nsprpub*" \
       ! -wholename "*security/nss*" \
       ! -wholename "*/.hg*" \
       ! -wholename "obj-ff-dbg*" \
       ! -name nsXPCOMCID.h \
       ! -name prtypes.h \
         -type f \
      \( -iname "*.cpp" \
         -o -iname "*.h" \
         -o -iname "*.cc" \
         -o -iname "*.mm" \) | \
    xargs -n 1 `dirname $0`/assert_replacer.py #sed -i -e "s/\b$1\b/$2/g"
}

convert MOZ_STATIC_ASSERT static_assert
hg rev --no-backup mfbt/Assertions.h \
                   media/webrtc/signaling/src/sipcc/core/includes/ccapi.h \
                   modules/libmar/src/mar_private.h \
                   modules/libmar/src/mar.h


# assert_replacer.py
#!/usr/bin/python

import sys
import re

pattern = re.compile(r"\bMOZ_STATIC_ASSERT\b")

def replaceInPlace(fname):
  print fname
  f = open(fname, "rw+")
  lines = f.readlines()
  for i in range(0, len(lines)):
    while True:
      index = re.search(pattern, lines[i])
      if index != None:
        index = index.start()
        lines[i] = lines[i][0:index] + "static_assert" + lines[i][index+len("MOZ_STATIC_ASSERT"):]
        for j in range(i + 1, len(lines)):
          if lines[j].find("                 ", index) == index:
            lines[j] = lines[j][0:index] + lines[j][index+4:]
          else:
            break
      else:
        break
  f.seek(0, 0)
  f.truncate()
  f.write("".join(lines))
  f.close()

argc = len(sys.argv)
for i in range(1, argc):
  replaceInPlace(sys.argv[i])

--HG--
extra : rebase_source : 4b4a4047d82f2c205b9fad8d56dfc3f1afc0b045
 2013-07-18 13:59:53 -04:00
Nathan Froyd
86df43c75a Bug 898491 - use the four argument form of compare_exchange_strong in Atomics.h; r=Waldo 
The C++ standard (29.6p20-22 in N3337) specifies limitations on the failure ordering
for atomic compare-and-exchange.  Specifically, you can't pass memory_order_acq_rel or
memory_order_release.  For the (T&, T, std::memory_order) version, which we use, the
standard specifies that the provided argument should be "lowered" to comply with the
above restrictions on the failure ordering (29.6p21).

However, it seems that some versions of GCC's <atomic> header don't follow the spec
for the generic versions of std::atomic<>, though they do follow the spec with the
appropriate specializations (bool, integer, and pointer) of std::atomic<>.  This
results in mysterious failures when using atomic enums, as bug 888548 purports to
do, and ReleaseAcquire ordering.

Happily, we can work around this by using the more explicit version of
compare-and-exchange.  I've chosen to add another member to AtomicOrderConstraints,
even though it'd be the same as LoadOrder.  I feel explicitness is to be preferred
here.
 2013-07-26 12:31:19 -04:00
Ehsan Akhgari
8a2e6c774e Bug 872127 - Part 3: Remove MSStdInt.h; r=Waldo 2013-07-30 10:25:42 -04:00
Ehsan Akhgari
ef4b479714 Bug 872127 - Part 2: Replace mozilla/StandardInteger.h with stdint.h; r=Waldo,ted 2013-07-30 10:25:31 -04:00
Jeff Walden
cea309af82 Bug 895792 - Fix RoundUpPow2's required precondition to not be wrong. r=terrence 
--HG--
extra : rebase_source : e42420628dad8b8e9fe37287fa8e08eb262fe615
 2013-07-25 20:01:45 -07:00
Jeff Walden
9dddd7b506 Add #include <new> to mfbt/Vector.h so that placement-new actually works when that header hasn't been bootlegged. No bug, r=too-long-spent-debugging-this 
--HG--
extra : rebase_source : b4b3a5a10757d01d1c5957736210ed09e3c2b157
 2013-07-25 20:01:42 -07:00
Birunthan Mohanathas
9e65e2904f Bug 784739 - Switch from NULL to nullptr in mfbt/. r=jwalden 
--HG--
extra : rebase_source : 090706fa9d97854fe3071adf037a09d914a0854f
 2013-07-25 16:31:48 -07:00
Ryan VanderMeulen
c5cf7535b6 Backed out 3 changesets (bug 896124, bug 784739, bug 894026) for Windows checktest orange on a CLOSED TREE. 
Backed out changeset 631b3d5d54f4 (bug 896124)
Backed out changeset 5e1dd28ede5d (bug 894026)
Backed out changeset c10c0a6270ec (bug 784739)
 2013-07-26 00:08:51 -04:00
Birunthan Mohanathas
0c642c695d Bug 784739 - Switch from NULL to nullptr in mfbt/. r=jwalden 2013-07-25 16:31:48 -07:00
Nicholas Nethercote
199d172e78 Bug 892806 - Clean up InflateUTF8String() and related functions. r=terrence. 
--HG--
extra : rebase_source : df901e9900fbd01f1adbe430b9ac52428499681f
 2013-07-09 23:17:32 -07:00
Ms2ger
51f391870b Bug 896341 - Update include guards and modelines in MFBT; r=Waldo 2013-07-24 09:41:39 +02:00
Ms2ger
10d5739f7a Bug 888643 - Part b: Move CPP_UNIT_TESTS definitions into moz.build files; r=gps 2013-07-24 09:23:06 +02:00
Jeff Walden
25c4d5d841 Bug 896842 - Implement mozilla::DoublesAreIdentical. r=luke 2013-06-18 15:35:03 -07:00
Jeff Walden
65803582cf Bug 895727 - Fix obvious typo breaking Win64 builds. r=lumpy 2013-07-18 19:30:06 -07:00
Jeff Walden
64982b30df Bug 891177 - Implement mozilla/Vector.h, and make js/Vector.h implement js::Vector using mozilla::Vector's implementation of the functionality. r=terrence 
--HG--
rename : js/public/Vector.h => mfbt/Vector.h
extra : rebase_source : d5f87a48485e3f2241228a4b003e80974c86fd5f
 2013-07-09 16:33:29 -07:00
Jeff Walden
7c8d6dea3e Bug 891177 - Remove Vector.h's js/TemplateLib.h dependency by introducing mfbt/TemplateLib.h with the necessary bits. r=terrence 
--HG--
extra : rebase_source : e84231171d6bd6c1e2de8201b8c9563375723d01
 2013-07-08 12:42:13 -07:00
Jeff Walden
9248a5e743 Bug 891177 - Move leading/trailing-zero-bit counting functions, ceiling/floor log2 functions, and round-up-pow2 functions into MathAlgorithms.h. r=terrence 
--HG--
extra : rebase_source : 8cfbd68b8cd4a0e21185dd864c7e827ccfa6b751
 2013-07-03 15:46:51 -07:00
Jeff Walden
8bad2a44e0 Bug 891437 - Implement mozilla/Array.h, a class suitable for use where a C array would be used, with additional debug bounds-checking. r=Ms2ger 
--HG--
extra : rebase_source : 314232d817e67d9a26dfa215b5c897e0dd0be353
 2013-02-07 15:32:20 -08:00
Jeff Walden
8a8e1ffd26 Bug 891177 - Add an explanatory comment by the const_cast<> in the Move(const T&) overload. r=luke 
--HG--
extra : rebase_source : 37a91bf2bdfe2b2f96ddebf276ad532d4419c42b
 2013-07-13 12:54:18 -07:00
Justin Lebar
fc156c847f Bug 892839 - Fix buggy example code in Move.h. r=luke DONTBUILD 2013-07-15 10:40:30 -07:00
Xavier Fung
4ba1624cef Bug 888159 - Fix Decimap.cpp building on VS2013. r=Waldo 2013-07-11 10:13:29 +09:00
Jeff Walden
90a0f4dfea Bug 891177 - Move js::Swap to mozilla::Swap. r=terrence 
--HG--
extra : rebase_source : 925bccd4fa3f95e1aa4e17d94ad5a443fc7a63aa
 2013-07-03 15:57:33 -07:00
Jeff Walden
7a5c915ff2 Bug 891177 - Add ReentrancyGuard.h as a helper class for asserting that use of a class is non-reentrant. r=terrence 
--HG--
extra : rebase_source : 3751e523c0b0315697cb6e005dfd8ee625f6dd58
 2013-07-02 17:47:08 -07:00
Jeff Walden
3bc19b56c2 Bug 891177 - Implement Move.h to define a move-construction interface. r=terrence 
--HG--
extra : rebase_source : 45f9bb87fc0ee96ea35005ca0dcb263aa11745b8
 2013-07-02 17:25:13 -07:00
Jeff Walden
791a4e2b4e Bug 891177 - Add AllocPolicy.h to define an implementation policy concept for use in mfbt. r=terrence 
--HG--
extra : rebase_source : f6336b5ba3298bbf9c5418b4e9d993b9173f7926
 2013-07-02 17:16:07 -07:00
Trevor Saunders
c9c3f11e7c bug 888493 - add MOZ_CONSTEXPR_VAR r=waldo 2013-06-28 17:34:51 -04:00
Phil Ringnalda
7dd50910d4 Backed out changeset 454706720bbc (bug 888493) for build bustage 
CLOSED TREE
 2013-07-04 13:06:07 -07:00
Trevor Saunders
7e27dbafc9 bug 888493 - add MOZ_CONSTEXPR_VAR r=waldo 2013-06-28 17:34:51 -04:00
Justin Lebar
3da6ed220e Bug 820686 - Follow-up: s/MOZ_ASSUME_NOT_REACHED/MOZ_ASSUME_UNREACHABLE/. rs=waldo 
I'd meant to do this, but I only got as far as the comment in mfbt.  Oops!

--HG--
extra : rebase_source : 3cfe3ef1bf401eb7d9a10fcabcfb39008e9553a4
 2013-06-28 19:20:12 -07:00
Justin Lebar
674bdae8dc Bug 820686 - Rename MOZ_NOT_REACHED() and JS_NOT_REACHED() to MOZ_ASSUME_NOT_REACHED(). r=waldo 
This includes a mechanical renaming of MOZ_NOT_REACHED to MOZ_ASSUME_NOT_REACHED in JS.  Later patches in this queue clean up whitespace errors and so on.
 2013-06-28 18:38:31 -07:00
Justin Lebar
051c5b560a Bug 802686 - s/MOZ_NOT_REACHED/MOZ_CRASH/ in Gecko. r=(see below) 
r=tbsaunde for accessible
r=jmuizelaar for gfx
r=roc for layout
r=glandium for mozglue
r=jduell for netwerk
r=khuey for everything else

This is a mechanical change made with sed.  Later patches in this queue
clean up the whitespace errors and so on.
 2013-06-28 18:38:30 -07:00
Justin Lebar
c144581d22 Bug 763070 - Give MOZ_CRASH() an optional string argument. r=waldo 2013-06-28 18:38:30 -07:00
Jeff Walden
13aed03de7 Style fixes and proper-numeric-type usage in mfbt/tests/TestEndian.cpp. No bug, r=trivial 
--HG--
extra : rebase_source : 54a658a6baf78852a3f8839b2cbb98700a7c91e7
 2013-06-13 19:27:11 -07:00
Emanuel Hoogeveen
66b88396c7 Bug 887465 - Rewrite double-conversion's assertions in terms of the MOZ_* assertions, and keep wtf (Yarr) from redefining them. r=jwalden 
--HG--
extra : rebase_source : 3cdadf85f6bc471f065d570cb03d2441886d3738
 2013-06-27 16:25:42 -07:00
Emanuel Hoogeveen
34bc4c281c Bug 878925 - Update double-conversion to latest git revision. r=jwalden 
--HG--
extra : rebase_source : 01275cc88cfb119f231ba83cfec0579bc11edfe1
 2013-06-27 16:25:32 -07:00
Masatoshi Kimura
2b3b31ec7e Bug 839998 - Replace thisDuringConstruction() with MOZ_THIS_IN_INITIALIZER_LIST(). r=waldo 2013-06-27 00:15:53 +09:00
Masatoshi Kimura
f7d20e1769 Bug 839998 - Introduce MOZ_THIS_IN_INITIALIZER_LIST macro. r=waldo 2013-06-27 00:15:52 +09:00
Emanuel Hoogeveen
c1374919d0 Bug 886128 - Fix various clang warnings and some potential bugs in nonstandard configurations. r=nnethercote,terrence. 
--HG--
extra : rebase_source : 0d833ecc9879f5d9fd0a28f9b4eca7793d01aa40
 2013-06-24 21:32:05 -07:00
Catalin Iacob
0990f16fa9 Bug 798914 (part 1) - Introduce mozilla::MallocSizeOf in mfbt. r=Waldo. 
--HG--
extra : rebase_source : 45cb28264b1aa3fe9adc9bdc9ed73bead4332af6
 2013-06-23 12:57:47 +02:00
Brian O'Keefe
11bcc1cd9e Bug 875934 - Move LIBRARY_NAME to moz.build (batch #1); r=mshal 
--HG--
extra : rebase_source : 385d3fd65475ffc18ee44ae088753649470e214b
 2013-06-17 15:21:01 -04:00
Jeff Gilbert
3049ca7c76 Bug 881980 - Allow casting CheckedInts to other CheckedInt types. - r=bjacob,waldo 2013-06-14 15:19:40 -07:00
Jeff Gilbert
75ab2ff473 Bug 874764 - Add CheckedInt support for operator%. - r=bjacob,waldo 2013-06-14 15:19:30 -07:00
Justin Lebar
532a674922 No bug - Fix typo in comment in mfbt/HashFunctions.h. DONTBUILD 2013-06-14 11:17:01 -07:00
Jeff Walden
3e42b95bec Bug 798179 - Rewrite ToIntWidth to more simply act upon the actual bits of the IEEE-754 representation. r=froydnj 
--HG--
extra : rebase_source : fb2da4e55b258b6b62c1c9449447fccff8c2012d
 2013-06-07 13:22:45 -07:00
Jeff Walden
d4e61d152b Rename a method from 'check' to 'checkBounds' to avoid colliding with a 'check' macro in an OS X system header. (No, really.) Noticed while tryservering patches for bug 798179, r=rage 
--HG--
extra : rebase_source : 3f9323afa6e80962ede30d1b953b95f3d363ccd0
 2013-06-10 15:31:37 -07:00
Jeff Walden
6249325181 Bug 798179 - Implement mozilla::MakeUnsigned. r=froydnj 
--HG--
extra : rebase_source : fdd1fe8841d1bc42c1758cd4d477969b3f382b30
 2013-03-05 15:44:02 -08:00