Commit Graph

339 Commits

Author SHA1 Message Date
Ting-Yu Lin
80fee1a237 Bug 1418224 Part 3 - Add shape-outside: <image> support to style system. r=heycam
Some Gecko style system files are modified to prevent assertions and
crashing, and to keep test failures on stylo disabled builds to minimum.

MozReview-Commit-ID: GuxAeCTz0xx

--HG--
extra : rebase_source : 2342085d13a50535836be46d75a731641d0fc49e
2017-11-17 16:34:37 +08:00
dluca
627438bf3c Backed out 4 changesets (bug 1418224) for build bustages r=backout on a CLOSED TREE
Backed out changeset 3ef8715cb8d7 (bug 1418224)
Backed out changeset 0d58d9fed90d (bug 1418224)
Backed out changeset faad7f275749 (bug 1418224)
Backed out changeset 1e86ff6b95ae (bug 1418224)
2017-11-27 07:42:50 +02:00
Ting-Yu Lin
0a432576a1 Bug 1418224 Part 3 - Add shape-outside: <image> support to style system. r=heycam
Some Gecko style system files are modified to prevent assertions and
crashing, and to keep test failures on stylo disabled builds to minimum.

MozReview-Commit-ID: GuxAeCTz0xx

--HG--
extra : rebase_source : 97c8b3900e4492ac03158a38aa03f7c044b71e0f
2017-11-17 16:34:37 +08:00
Cameron McCormack
630cd9c74f Bug 1418899 - Part 3: Use a single image layer array filling function. r=cjku
We were accidentally using the background one for the mask layers list anyway,
and I don't think the overhead of filling the arrays for the two properties
mask layers don't use is a problem.

MozReview-Commit-ID: 7LDiYGrnUd5

--HG--
extra : rebase_source : 573d70e0e8c4d110ca6da2846e6fd2887b1fded2
2017-11-20 13:44:22 +08:00
Cameron McCormack
99c87da38a Bug 1418217 - Move visited links pref to StylePrefs. r=TYLin
On a CLOSED TREE to fix Servo bustage.

MozReview-Commit-ID: HLukaX0EFFv
2017-11-17 14:08:22 +01:00
Emilio Cobos Álvarez
79635409a0 Bug 1410624: Add a Document::elements_with_id API. r=xidorn
MozReview-Commit-ID: BNtbJp0RI68
2017-11-04 12:36:22 +01:00
Emilio Cobos Álvarez
2d5df88155 Bug 1410624: Add some declarations and bindings so the build isn't busted when servo-vcs-sync goes back alive. r=me,heycam
https://github.com/servo/servo/pull/18988 has merged a while ago in servo, but
since the sync service is down, I haven't been able to land the relevant patches
today.

This at least ensures that the build isn't busted when servo-vcs-sync goes back
up.

MozReview-Commit-ID: 9ohgwcnMc5T
2017-10-23 22:46:02 +02:00
Xidorn Quan
e175680895 Bug 1397644 part 1 - Implement XUL tree pseudo style resolution for stylo. r=emilio
MozReview-Commit-ID: 5JqvLv3tt5m

--HG--
extra : source : 23a7db4b7938b095947abeb41edb0cb6375f95da
2017-10-20 21:31:13 +11:00
Bobby Holley
7c241c0f84 Bug 1407080 - Add an API to annotate crash reports from stylo. r=Manishearth
MozReview-Commit-ID: KuD4SbVrdYH
2017-10-10 13:30:57 -07:00
Hiroyuki Ikezoe
5e34bc1f57 Bug 1329169 - Use atom for animation-name property. r=xidorn
MozReview-Commit-ID: 9yVWXVi1oXf

--HG--
extra : rebase_source : f0d8a731c3e6caaf248a0b0e25ef96370af3ecd8
2017-10-10 17:00:28 +09:00
Nicholas Nethercote
d225f7151b Bug 1400460 - Rename nsIAtom as nsAtom. r=hiro.
(Path is actually r=froydnj.)

Bug 1400459 devirtualized nsIAtom so that it is no longer a subclass of
nsISupports. This means that nsAtom is now a better name for it than nsIAtom.

MozReview-Commit-ID: 91U22X2NydP

--HG--
rename : xpcom/ds/nsIAtom.h => xpcom/ds/nsAtom.h
extra : rebase_source : ac3e904a21b8b48e74534fff964f1623ee937c67
2017-10-03 09:05:19 +11:00
Bobby Holley
a519863205 Bug 1406220 - Add canary and journaling. r=Manishearth,r=dmajor
MozReview-Commit-ID: 582ZiTmcvgs
2017-10-07 12:35:24 -07:00
Cameron McCormack
0b7960f23a Bug 1397626 - Part 3: Use SharedFontList to store font-family specified and computed values. r=xidorn
MozReview-Commit-ID: J3MNO2un2ov

--HG--
extra : rebase_source : 737943aea3d383669a7103d4e23f109889c09034
2017-10-03 12:27:45 +08:00
Bobby Holley
cb4c93bfd6 Bug 1403397 - Revert: Round hashglobe allocations up to the nearest page size. r=bholley
This reverts commit a4aba77facc8ceab1e0d7f7d796075a6606b15c6.

MozReview-Commit-ID: 7quMDoDmqxL
2017-10-03 14:07:05 -07:00
Bobby Holley
ce4c83e27d Bug 1403397 - Revert: Protect the hashmaps outside of rebuilds. r=bholley
This reverts commit 80a3d080ad6f6ae8641443ba08e11a6e9eed260a.
2017-10-03 14:05:57 -07:00
Ting-Yu Lin
d944131798 Bug 1404243 Part 3 - Remove refcount for StyleBasicShape, and use UniquePtr to hold it. r=heycam
After StyleBasicShape is set to StyleShapeSource, it's life cycle never go
beyond StyleShapeSource, so I make StyleBasicShape hold by a UniquePtr in
StyleShapeSource.

Also, replace all raw pointers to StyleBasicShape by UniquePtr in all APIs.

MozReview-Commit-ID: 1MfIFjP8TsQ

--HG--
extra : rebase_source : bdbbd47de57e0bc610e37913752ab8413f62588a
2017-09-25 18:50:24 +08:00
Bobby Holley
9163763885 Bug 1403397 - Protect the hashmaps outside of rebuilds. r=Manishearth,r=dmajor,r=ehoogeveen
MozReview-Commit-ID: KACmfw4pZY2
2017-09-28 18:23:13 -07:00
Bobby Holley
55e810d2cf Bug 1403397 - Round hashglobe allocations up to the nearest page size. r=Manishearth,r=dmajor
MozReview-Commit-ID: 34KFtcwCkBB
2017-09-28 18:23:11 -07:00
Emilio Cobos Álvarez
371f0cc42f Bug 1396073: Simplify and remove some more code. r=xidorn
MozReview-Commit-ID: Ec9pfQw7U6W
Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
2017-09-28 12:26:44 +02:00
Xidorn Quan
c5b7f94e1c Bug 1400438 - Use array instead of linked list for -moz-border-*-colors. r=heycam,mattwoodrow
MozReview-Commit-ID: LPl1Rlg5gRn

--HG--
extra : rebase_source : c9df383e14523bb534cac5018333178b7c17167a
2017-09-18 13:38:39 +10:00
Sebastian Hengst
cbf485433e Backed out changeset 61a277705d59 (bug 1400438) for heap write hazard. r=backout 2017-09-20 16:52:02 +02:00
Xidorn Quan
4599882448 Bug 1400438 - Use array instead of linked list for -moz-border-*-colors. r=heycam,mattwoodrow
MozReview-Commit-ID: LPl1Rlg5gRn

--HG--
extra : source : 418288301c994faded0993a1cd3d73fc3b6521be
extra : amend_source : 7cba1fc0ca13b86782aa05ab4dae4cdc7eb9fbf6
2017-09-20 22:52:20 +10:00
Sebastian Hengst
107a8b1f39 Backed out changeset df9036657f25 (bug 1400438) for crashing chrome test mobile/android/components/extensions/test/mochitest/test_ext_options_ui.html on Android. r=backout on a CLOSED TREE 2017-09-19 16:33:05 +02:00
Xidorn Quan
60d4fdfcc7 Bug 1400438 - Use array instead of linked list for -moz-border-*-colors. r=heycam,mattwoodrow
MozReview-Commit-ID: LPl1Rlg5gRn

--HG--
extra : rebase_source : 3742eefec0a9957847aac23a6070729eaafa8034
2017-09-18 13:38:39 +10:00
Nicholas Nethercote
6217edda82 Bug 1399758 - Measure ImageValue objects. r=heycam.
We have about 11,500 of these when loading gmail in a Stylo-enabled build, from
SpecifiedUrls; the objects themselves account for about 1.3 MiB of memory, and
the strings within them about 2.9 MiB.

We also have a very small number of them on the Gecko side.
2017-09-14 18:48:19 +10:00
Emilio Cobos Álvarez
39a846c6f3 Bug 1399546: Remove unused binding function. r=me
MozReview-Commit-ID: 9FN3j5zNHQe
2017-09-17 19:39:51 +02:00
Emilio Cobos Álvarez
4c6d499f97 Bug 1399546: Add an API to know if an element is it's document body element. r=heycam
MozReview-Commit-ID: 8mtd4CsoSlU
2017-09-16 02:39:09 +02:00
Josh Matthews
a323bdfe53 Bug 1397971 - Share strings in URLDataValue with Rust. r=heycam
--HG--
extra : amend_source : 7946c76a40240baac44db6c1c6c7b0117ced4219
2017-09-15 13:11:37 -07:00
Sebastian Hengst
627dd1e633 Backed out changeset 1536fa69bad4 (bug 1399758) for Hazard failures. r=backout 2017-09-15 10:00:52 +02:00
Nicholas Nethercote
beeb6cb150 Bug 1399758 - Measure ImageValue objects. r=heycam.
We have about 11,500 of these when loading gmail in a Stylo-enabled build, from
SpecifiedUrls; the objects themselves account for about 1.3 MiB of memory, and the
strings within them about 2.9 MiB.

We also have a very small number of them on the Gecko side.

MozReview-Commit-ID: AduCIaDIzGG

--HG--
extra : rebase_source : ee2a20921a17b9091b60a5d9e389a6c6f2fa192b
2017-09-14 18:48:19 +10:00
Boris Chiou
07f634028f Bug 1392161 - Part 1: Update Servo binding functions for CSSPixelLength. r=emilio
MozReview-Commit-ID: 2x4Y9py4Pfv

--HG--
extra : rebase_source : 347e46b6a92794e8d12273ed963e54dbb2da1c8e
2017-09-13 14:27:25 +08:00
Emilio Cobos Álvarez
8fee8e03c1 Bug 1395227: Stop the cascade when only reset structs change. r=heycam
MozReview-Commit-ID: JCZJl2fmtJ9
Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
2017-09-06 16:58:46 +02:00
Nazım Can Altınova
39c02b31f3 Bug 1394551 - stylo: Dont unnecessarily construct gfxFontFeatureValueSet r=xidorn
If there is no font feature values inside document we should avoid creating
unnecessary objects.

MozReview-Commit-ID: HJKMzQvQAPR

--HG--
extra : rebase_source : 06dc792d2c4848c4c8ca49b9eb98630d5d475006
2017-08-30 17:08:50 -07:00
Emilio Cobos Álvarez
3bbd915f86 Bug 1394935: Add a special case for marking something as dirty from invalidation code. r=bholley
Not sure about the name, or whether making it a static or not (a static seemed
slightly clearer, but nbd, feel free to bikeshed about it).

MozReview-Commit-ID: FHGmcoprN2Q

--HG--
extra : rebase_source : 2f68a55ee861d9eacc56004cb98470a518574626
2017-08-31 09:42:26 +02:00
Xidorn Quan
f3c33019da Bug 1393189 part 5 - Rewrite CounterStyleOrNone::from_gecko_value to use fewer binding functions. r=heycam
MozReview-Commit-ID: 3EsExs0DzQr

--HG--
extra : rebase_source : b97cfeb82dcaf80eb91635e9094c55a264678865
2017-08-29 17:11:13 +10:00
Nazım Can Altınova
b2b88364dd Bug 1355721 - stylo: Implement font feature values lookup r=emilio,xidorn
MozReview-Commit-ID: 7wgQ1NCn7vL

--HG--
extra : rebase_source : 6c774e87b8bd3f30d819302aba5a73a50047981a
2017-08-23 18:05:53 -07:00
Gregory Szorc
2a5e786286 Backed out changesets b749fc196a50, 2791eac8d760 (bug 1355721) for build bustage
CLOSED TREE

--HG--
extra : amend_source : 7618f27e1cf71347f12384935374d303d5c1ab23
extra : histedit_source : 1143d226673ace563bb5d9ff3c420ded33439791%2C9746a30097304bd2214a0072773dc00c767d31cd
2017-08-24 20:30:17 -07:00
Nazım Can Altınova
00f1cc4565 Bug 1355721 - stylo: Implement font feature values lookup r=emilio,xidorn
MozReview-Commit-ID: 7wgQ1NCn7vL

--HG--
extra : rebase_source : c104c2b09ebfbf5cdb98bc5638473cac1bfc40c9
2017-08-23 18:05:53 -07:00
Emilio Cobos Álvarez
977a701ae1 Bug 1392093: Remove dead code to get the old style context. r=heycam
Unused since https://github.com/servo/servo/pull/18153.

MozReview-Commit-ID: DtQdm3ONS5E

--HG--
extra : rebase_source : 8a781dfdd4963b73c0f6a0c5bc2de8041bcc0db9
2017-08-20 18:01:25 +02:00
Bobby Holley
a0a0196602 Bug 1375911 - Avoid creating a stylo thread pool in e10s parent processes. r=xidorn
MozReview-Commit-ID: LW92yNDKZf4
2017-08-17 19:15:20 -07:00
Emilio Cobos Álvarez
af1bc71c5d Bug 1390650: stylo: Remove some unused FFI functions. r=bholley,xidorn
MozReview-Commit-ID: K9fXGRmgkr4

--HG--
extra : rebase_source : 2428cd915b9d7f4b75b23df99e9d532034ff63a7
2017-08-15 23:21:30 +02:00
J. Ryan Stinnett
bdb91a3c76 Bug 1390691 - Fix up Gecko_CalcStyleDifference for Linux 32-bit ABI. r=manishearth
Bindgen bitfield enums don't work as return values with the Linux 32-bit ABI at
the moment because they wrap the value in a struct.

This causes the Rust side to believe the callee expects space for the struct
return value, while C++ believes it's just an integer value.

MozReview-Commit-ID: FRBqlZuMiAR

--HG--
extra : rebase_source : d1b2af4b965c000a5bd8e1792ae166cba5e152a9
2017-08-14 20:02:01 -05:00
Bobby Holley
3e308bd38d Bug 1389385 - Rearrange dirty noting to operate on the element rather than the parent. r=emilio
This will allow us to scope restyle roots more tightly.

MozReview-Commit-ID: 2t2lp5sKBHH
2017-08-11 18:18:22 -07:00
Bobby Holley
7a9898d81a Bug 1389385 - Do all descendant bit propagation from Gecko over FFI. r=emilio
Deduplicating code is nice, and it will help us when we make the bit
propagation more complicated in upcoming patches.

MozReview-Commit-ID: KIQnNJVayrM
2017-08-11 18:18:19 -07:00
Xidorn Quan
b97e3aed9b Bug 1388255 - Make nsStylePosition::mGridTemplate{Columns,Rows} a UniquePtr. r=canaltinova,dholbert
MozReview-Commit-ID: 8SOE6sAavCX

--HG--
extra : rebase_source : 666c95221e059da9b1a729eea3584e2060968582
2017-08-09 11:30:25 +10:00
Daisuke Akatsuka
26b36b660d Bug 1382137 - Part 2: make list-style-type animatable. r=hiro
MozReview-Commit-ID: BT4SX6SxIYi
2017-08-08 10:12:57 +09:00
Daisuke Akatsuka
e77e436ab7 Bug 1382137 - Part 1: implement conversion method from Gecko CounterStylePtr to CounterStyleOrNone. r=hiro
In this path, implement conversion method from CounterStylePtr to CounterStyleOrNone since we need this to implement clone_list_style_type method.

MozReview-Commit-ID: Fmyc50WQU4C
2017-08-08 10:12:54 +09:00
Manish Goregaokar
efbe3a9af8 Bug 1386887 - Clean up FFI lifetimes to work on nightly; r=emilio
MozReview-Commit-ID: 5WAIVd6p2du
2017-08-03 15:49:25 -07:00
Emilio Cobos Álvarez
938400aeaa Bug 1385896: Move nsStyleContext::mParent to GeckoStyleContext. r=heycam
Unfortunately this means that we lose the NS_STYLE_INHERIT_BIT optimization to
avoid posting changes if we had not requested the struct. In practice, I'm not
sure this optimization matters much, though, and we already compare all the
structs anyway.

We _could_ keep a weak parent pointer from the text style if needed, given we're
going to keep alive the text style at least until the parent style context goes
away, so should be safe, but I don't think the extra churn is worth it, to be
honest. Happy to do so as part of bug 1368290 if you think it's worth it.

MozReview-Commit-ID: ka6tNwf4Ke

--HG--
extra : rebase_source : dd6e98cf5743a8dd2e959ca09ed9a17e52b201e9
2017-07-31 16:21:40 +02:00
Nicholas Nethercote
cc91deea30 Bug 1383977 - stylo: Measure Elements and ComputedValues. r=manishearth.
The patch provides FFI access to Gecko's SeenPtrs type from Rust, in order to
record what has already been measured when measuring Arcs. (The SeenPtrs must
be initialized on the Gecko side because the same table is reused for measuring
all Elements within a window, because Elements can share ComputedValues.) I
have confirmed with DMD that this is working correctly.

The patch also introduces MallocSizeOfRepeats, which is like MallocSizeOf but
takes a SizeOfState, which holds a SeenPtrs table.

MozReview-Commit-ID: DHS8zvCsEdQ

--HG--
extra : rebase_source : acf4d7909abf6ceb1719331ccf2e33137eb6dc91
2017-07-19 10:30:53 +10:00