Commit Graph

29006 Commits

Author SHA1 Message Date
Nicolas Chevobbe
d406d5f0db Bug 1931507 - [devtools] Adapt toolbox border in High Contrast Mode. r=devtools-reviewers,ochameau.
Make sure the border between the content and the toolbox adapts when Firefox
is in High Contrast Mode.

Differential Revision: https://phabricator.services.mozilla.com/D229115
2024-11-20 14:43:56 +00:00
Emilio Cobos Álvarez
8f4f441cae Bug 1388910 - Remove -moz-user-modify property. r=dshin
We successfully unshipped it in bug 1920118.

Differential Revision: https://phabricator.services.mozilla.com/D229530
2024-11-19 19:35:35 +00:00
Sebastian Hengst
197fea4f23 Bug 1922355 - macOS 14.70: adjust expectations for mochitests and xpcshell tests. r=jmaher,necko-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D228118
2024-11-19 17:19:24 +00:00
Nicolas Chevobbe
7737ef1ef0 Bug 1931502 - [devtools] Adapt Split Console border in High Contrast Mode. r=devtools-reviewers,ochameau.
Differential Revision: https://phabricator.services.mozilla.com/D229116
2024-11-19 14:14:56 +00:00
Nicolas Chevobbe
8b59fb40c9 Bug 1931499 - [devtools] Only re-set forced-color-adjust if forced colors is enabled. r=devtools-reviewers,ochameau
Differential Revision: https://phabricator.services.mozilla.com/D229106
2024-11-18 09:08:28 +00:00
Nicolas Chevobbe
70b6d9a3d7 Bug 1916688 - [devtools] Add color for markup node in High Contrast Mode. r=ochameau,accessibility-frontend-reviewers,nlapre.
We're using system color for the tagname (and pseudo element name),
and HCM-compliant colors for attribute value (blue) and comment nodes (green).
For non-visible nodes, we set them in GrayText so they're visually different
from visible ones.

Differential Revision: https://phabricator.services.mozilla.com/D227924
2024-11-18 08:30:12 +00:00
Julian Descottes
d169cee642 Bug 1931530 - [DevTools Release Tasks - Cycle 134] Update MDN compat data r=devtools-reviewers,bomsy
Differential Revision: https://phabricator.services.mozilla.com/D229124
2024-11-15 16:47:36 +00:00
Nicolas Chevobbe
9ded41f6d6 Bug 1916608 - [devtools] Fix interactive badge colors in High Contrast Mode and tweak style. r=ochameau.
In High Contrast Mode, non-interactive badges looked like buttons, so this patch fixes the colors.
We tweak the padding and the border radius to help makde badges nicer.

Differential Revision: https://phabricator.services.mozilla.com/D228774
2024-11-15 08:03:22 +00:00
Nicolas Chevobbe
33a38f39d9 Bug 1916608 - [devtools] Fix markup tree badges borders in High Contrast Mode. r=devtools-reviewers,ochameau.
Differential Revision: https://phabricator.services.mozilla.com/D228773
2024-11-15 08:03:22 +00:00
Alexandre Poirot
b1731033db Bug 1929390 - [devtools] Import objectInspector without going through Reps. r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D228994
2024-11-14 21:43:34 +00:00
Alexandre Poirot
6448d4d797 Bug 1929388 - [devtools] Move JSONViewer to absolute URLs. r=devtools-reviewers,nchevobbe
This also required to migrate external dependencies to absolute URLs.

Differential Revision: https://phabricator.services.mozilla.com/D228993
2024-11-14 21:43:33 +00:00
Alexandre Poirot
1379d6fb1e Bug 1929388 - [devtools] Use absolute URLs for require statements in Reps. r=devtools-reviewers,nchevobbe
This is one (small) step forward using ES Modules.

Differential Revision: https://phabricator.services.mozilla.com/D228100
2024-11-14 21:43:33 +00:00
Nicolas Chevobbe
51c72e06cc Bug 1930956 - [devtools] Adapt Callstack panel to High Contrast Mode. r=bomsy.
Use --theme-selection-color instead of white.
Don't lower opacity on frames and use dedicated variable instead.
Tweak some selectors to make sure the panel looks good in all situations.

Differential Revision: https://phabricator.services.mozilla.com/D228841
2024-11-14 12:52:45 +00:00
Nicolas Chevobbe
bd6b5e75f4 Bug 1916346 - [devtools] Adapt Jump to definition button in High Contrast Mode. r=devtools-reviewers,bomsy.
Increment the width of the button so the icon has enough room to be displayed comfortably.

Differential Revision: https://phabricator.services.mozilla.com/D228151
2024-11-14 08:05:34 +00:00
Nicolas Chevobbe
849bd37d2f Bug 1916617 - [devtools] Adapt scroll badges in High Contrast Mode. r=devtools-reviewers,ochameau
Differential Revision: https://phabricator.services.mozilla.com/D228632
2024-11-13 22:29:21 +00:00
Nicolas Chevobbe
bcffdd6b42 Bug 1916358 - [devtools] Make network resume button use context-fill color. r=devtools-reviewers,bomsy.
Differential Revision: https://phabricator.services.mozilla.com/D227941
2024-11-13 22:28:43 +00:00
Nicolas Chevobbe
6b19d1953b Bug 1916358 - [devtools] Set aria-pressed attribute on pause/resume network recording button. r=devtools-reviewers,bomsy.
This allows the state of the button to be announced to screen readers,
as well as make it follow the styling we have for such buttons.
We can now rely on the state of the attribute to change the icon.

Differential Revision: https://phabricator.services.mozilla.com/D227940
2024-11-13 22:28:43 +00:00
Nicolas Chevobbe
b257bda79f Bug 1916700 - [devtools] Adapt pressed devtools-button in High Contrast Mode. r=devtools-reviewers,ochameau
The pressed style was reusing --toolbarbutton-hover-background, instead of using the more
semantically appropriate --toolbarbutton-checked-background.
The latter was having a very distinct style (blue background), which didn't match the
style we wanted. But, I don't think the style as used anywhere and seemed more like
a relic of a previous design, so I updated the variable to mimic what we currently
have in regular themes, and adapted the colors for High Contrast.

This way we can extract some selectors into their own rules so we have a more fine-grained
way to style those.

We take this as an opportunity to remove the --toolbarbutton-focus* variables and
the declarations using them as we now have proper focus indicator on the buttons.

Differential Revision: https://phabricator.services.mozilla.com/D227840
2024-11-13 22:28:42 +00:00
Nicolas Chevobbe
7839d1a7d1 Bug 1916700 - [devtools] Don't use --toolbarbutton-checked-(background|color) on non-button elements. r=devtools-reviewers,bomsy.
Differential Revision: https://phabricator.services.mozilla.com/D227839
2024-11-13 22:28:42 +00:00
Nicolas Chevobbe
d541afa8e2 Bug 1916700 - [devtools] Cleanup toolbarbutton.css. r=devtools-reviewers,bomsy.
No element with the `devtools-toolbarbutton` class can have a label or a checked attribute,
or can have `.toolbarbutton-text` items, so we can remove some selectors and rules from the stylesheet.

We take this as an opportunity to refactor the stylesheet with CSS nesting.

Depends on D221945

Differential Revision: https://phabricator.services.mozilla.com/D227838
2024-11-13 22:28:42 +00:00
Nicolas Chevobbe
26fc6223dc Bug 1916335 - [devtools] Adapt toolbox tool tabs to High Contrast Mode. r=devtools-reviewers,ochameau.
This only tweaks the colors of the tabs for the different states (hover, selected, reordering),
to make it consistent with the changes made in the previous commit.

Differential Revision: https://phabricator.services.mozilla.com/D221945
2024-11-13 16:37:46 +00:00
Nicolas Chevobbe
617a2c16d4 Bug 1916372 - [devtools] Adapt Tabs component to High Contrast Mode. r=devtools-reviewers,ochameau.
In HCM, we change the background color when it's selected, whereas in regular mode,
we only change the text color (and add a thin line on top).
On hover, in HCM we want to change the text color, and in regular mode only the
background color.
To handle those more easily, we introduce new variables so that we can easily
define them for HCM too.

Differential Revision: https://phabricator.services.mozilla.com/D228638
2024-11-13 16:37:45 +00:00
Alexandre Poirot
e495a2afea Bug 1930687 - [devtools] Fix the restoring of pause on caught exception when opening DevTools. r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D228686
2024-11-13 09:49:32 +00:00
AR
4ee25421cb Bug 1826381 - Titles now link to respective pages. r=firefox-source-docs-reviewers,devtools-reviewers,sylvestre,ahal,nchevobbe DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D228556
2024-11-13 07:51:58 +00:00
Alexandre Lissy
ae13d95188 Bug 1929104 - Add SandboxProfiler feature to enable/disable r=canaltinova,profiler-reviewers,aabh
Differential Revision: https://phabricator.services.mozilla.com/D227962
2024-11-13 07:03:22 +00:00
Sandor Molnar
a5a8061097 Bug 1833502 - Remove a11y_check annotation on browser_dbg-editor-scroll.js.r=devtools-reviewers,bomsy DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D228476
2024-11-13 05:53:24 +00:00
Norisz Fay
5dd128abb4 Backed out changeset 76200f16a497 (bug 1644983) for causing Bug 1930798, Bug 1930799, Bug 1930791 and other CacheFileIOManager related crashes CLOSED TREE 2024-11-13 06:23:51 +02:00
Valentin Gosu
5d3e7ab00e Bug 1644983 - Make CacheIOThread a regular XPCOM thread and register thread with profiler r=necko-reviewers,dragana,profiler-reviewers,julienw,kershaw
I had big issues with this patch as it was causing random crashes
when run with MOZ_PROFILER_STARTUP=1 and breaking browser_xpcom_graph_wait.js
which does the same.
I tried to get around that by avoiding the IOInterposer registration
in CacheIOThread, but that was also problematic.

Eventually it seems there's no longer a good reason to keep calling
PR_CreateThread manually instead of NS_NewNamedThread, so I switched
to that and all of the previous issues are gone.

The stack is now twice as big, but hopefully that's not a major issue.
All other behaviour should stay the same.

Differential Revision: https://phabricator.services.mozilla.com/D132381
2024-11-12 19:12:43 +00:00
Cristina Horotan
1e75cbdee2 Backed out changeset 11c6eadee766 (bug 1929104) for causing bc failures at browser_sandbox_profiler.js CLOSED TREE 2024-11-12 22:00:04 +02:00
Alexandre Lissy
77c7fde899 Bug 1929104 - Add SandboxProfiler feature to enable/disable r=canaltinova,profiler-reviewers,aabh
Differential Revision: https://phabricator.services.mozilla.com/D227962
2024-11-12 18:35:27 +00:00
Julian Descottes
d39ba891c4 Bug 1911521 - [devtools] Wait for no pseudo rule to be displayed in browser_rules_pseudo-element_01.js r=nchevobbe,devtools-reviewers
The initial check for nb == 0 should not be needed now that we test that the expected number of elements are displayed. The initial version of the patch was only using `some` and there it made sense to special case nb == 0, but we ended up improving this before landing.

Differential Revision: https://phabricator.services.mozilla.com/D228660
2024-11-12 15:29:40 +00:00
Sean
4223f4d19e Bug 1915717 - [network markers] Expose http protocol version for a request in the profiler network tab r=acreskey,necko-reviewers,profiler-reviewers,devtools-reviewers,kershaw,aabh,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D227064
2024-11-12 14:02:02 +00:00
Nicolas Chevobbe
9d8ebf646c Bug 1852762 - [devtools] Remove unused rule in accessibility.css. r=devtools-reviewers,bomsy
The beta class isn't set anywhere.

Differential Revision: https://phabricator.services.mozilla.com/D228627
2024-11-12 08:51:07 +00:00
Nicolas Chevobbe
c929c7e952 Bug 1930185 - [devtools] Remove color transitions. r=devtools-reviewers,bomsy.
Firefox UI don't have such transition, and they need to not be applied
in High Contrast Mode/reduced motion, so we can remove them all together.

Differential Revision: https://phabricator.services.mozilla.com/D228464
2024-11-12 06:33:07 +00:00
Nicolas Chevobbe
fd103eccc3 Bug 1929508 - [devtools] Use --theme-selection-color instead of white in Tree.css. r=devtools-reviewers,bomsy.
Differential Revision: https://phabricator.services.mozilla.com/D228153
2024-11-08 16:57:56 +00:00
Nicolas Chevobbe
f5bcd8d4e9 Bug 1929006 - [devtools] Delete unused devtools/client/accessibility/components/Button.js. r=devtools-reviewers,bomsy.
The components weren't used anywhere. We can also remove selectors and rules that were targetting
classes only used in this file.

Differential Revision: https://phabricator.services.mozilla.com/D227837
2024-11-08 16:57:55 +00:00
Nicolas Chevobbe
017c39770e Bug 1928134 - [devtools] Wait for the right resource in browser_inspector_fission_frame_navigation.js. r=devtools-reviewers,bomsy.
Differential Revision: https://phabricator.services.mozilla.com/D228407
2024-11-08 14:36:29 +00:00
Nicolas Chevobbe
8d06bad117 Bug 1916669 - [devtools] Adapt Accordion headers in High Contrast Mode. r=devtools-reviewers,ochameau.
Adapt the color of the text and arrow, especially on hover.
This covers accordion in the rules view, the layout panel and the debugger.

Differential Revision: https://phabricator.services.mozilla.com/D228149
2024-11-08 14:30:26 +00:00
Nicolas Chevobbe
65c193fd36 Bug 1916669 - [devtools] Don't use --theme-accordion-header-background on elements that are not accordion headers. r=devtools-reviewers,ochameau.
This adds a new variable with the same colors than the variable one that we can use as a drop-in replacement.
For some cases, we could reuse the existing --theme-body-emphasized-background.
The Debugger ResultList style could be simplified as it should always have either 'small' or 'big' class, which
were both setting a background color for selected item, overriding the declaration that was using --theme-accordion-header-background.

Differential Revision: https://phabricator.services.mozilla.com/D228148
2024-11-08 14:30:26 +00:00
Nicolas Chevobbe
7582c38052 Bug 1930099 - [devtools] Use --theme-icon-disabled-color for disabled debugger command bar button instead of tweaking opacity. r=devtools-reviewers,bomsy.
Differential Revision: https://phabricator.services.mozilla.com/D228415
2024-11-08 14:02:56 +00:00
Florian Quèze
afae43d44a Bug 1927093 - Remove scalar helpers from devtools/client/shared/telemetry.js, r=chutten,devtools-reviewers,nchevobbe.
Depends on D228159

Differential Revision: https://phabricator.services.mozilla.com/D228160
2024-11-07 20:42:05 +00:00
Florian Quèze
7ef193e2e0 Bug 1927093 - Migrate scalars to use Glean APIs in devtools/client/inspector, r=chutten,devtools-reviewers,nchevobbe.
Differential Revision: https://phabricator.services.mozilla.com/D228159
2024-11-07 20:42:05 +00:00
Florian Quèze
a97d36031e Bug 1927093 - Migrate scalars to use Glean APIs in devtools/client/shared/telemetry.js, r=chutten.
Depends on D228157

Differential Revision: https://phabricator.services.mozilla.com/D228158
2024-11-07 20:42:04 +00:00
Florian Quèze
37d88b8fac Bug 1927093 - Migrate scalars to use Glean APIs in devtools/client/framework, r=chutten.
Depends on D228156

Differential Revision: https://phabricator.services.mozilla.com/D228157
2024-11-07 20:42:04 +00:00
Florian Quèze
b83ebbd304 Bug 1927093 - Migrate scalars to use Glean APIs for devtools.responsive.*, r=chutten.
Depends on D228155

Differential Revision: https://phabricator.services.mozilla.com/D228156
2024-11-07 20:42:03 +00:00
Florian Quèze
2af147c9f6 Bug 1927093 - Migrate scalars to use Glean APIs in devtools/client/accessibility, r=chutten.
Differential Revision: https://phabricator.services.mozilla.com/D228155
2024-11-07 20:42:03 +00:00
Nicolas Chevobbe
9183fd6097 Bug 1929594 - [devtools] Use --theme-text-color-inactive for disabled menu items instead of tweaking the opacity. r=devtools-reviewers,ochameau.
This makes the element nicely adapt to High Contrast Mode.

Differential Revision: https://phabricator.services.mozilla.com/D228191
2024-11-07 16:01:43 +00:00
Alexandre Poirot
049093be6b Bug 1929007 - [devtools] Collect console API calls when tracing from DevTools. r=dthayer
Because the tracer actor runs in the content process, the preference toggling logic
has to be done in some code running in the parent process: TargetConfiguration.

Differential Revision: https://phabricator.services.mozilla.com/D227833
2024-11-07 15:52:03 +00:00
Alexandre Poirot
868a58edfe Bug 1929004 - [devtools] Record DOM Mutation when tracing from DevTools. r=dthayer
For now, use a custom DOM Marker. But it would be nice to show them from the stack chart.

Differential Revision: https://phabricator.services.mozilla.com/D227832
2024-11-07 15:52:03 +00:00
Alexandre Poirot
a66046ef90 Bug 1929003 - [devtools] Use native profiler to collect JS Traces from DevTools. r=dthayer
Stop manually crafting the profiler data by using SpiderMonkey hooks.
Instead, use the profiler native pipeline to do the collection.

This still relies on JSTracer class in order to trigger the record on next interaction or page load.
One caveat is that it starts the profiler from the content process, which prevents recording screenshots correctly.

Differential Revision: https://phabricator.services.mozilla.com/D227831
2024-11-07 15:52:02 +00:00