Commit Graph

546 Commits

Author SHA1 Message Date
Zibi Braniecki
70e0d2b8e8 Bug 1398390 - Only react to mousedown if it is a left-click. r=Gijs
MozReview-Commit-ID: Ie2Xgasg2eN

--HG--
extra : rebase_source : 5e58c418f91a1802328c4128dffd2c1ab9aa067f
2017-09-09 22:17:19 -07:00
Sebastian Hengst
a4b102b6d9 Backed out changeset 1a8147d55b02 (bug 1398390) for failing browser-chrome's browser_overflow_anchor.js at least on macOS and Windows. r=backout 2017-09-10 09:37:30 +02:00
Zibi Braniecki
923420c64a Bug 1398390 - Only react to mousedown if it is a left-click. r=Gijs
MozReview-Commit-ID: Ie2Xgasg2eN

--HG--
extra : rebase_source : 9aeed150b6106210bbe06e8a98ae602e5471851b
2017-09-09 22:17:19 -07:00
Sebastian Hengst
8eb249afcc merge mozilla-inbound to mozilla-central. r=merge a=merge
MozReview-Commit-ID: JSRVc5yW6Kx
2017-09-07 12:39:12 +02:00
Paolo Amadini
fe96089fe4 Bug 1387416 - Place the search bar in the customization palette for new profiles. r=Gijs
MozReview-Commit-ID: Tq8YrZWG6P

--HG--
extra : rebase_source : 2e02e0a809d08ff26291a027b73a54668d6d5f9d
2017-09-06 13:09:27 +01:00
Zibi Braniecki
0e1ced7d71 Bug 1395871 - Open toolbar menus on mousedown, rather than oncommand.
MozReview-Commit-ID: A3P4QBBgcB8

--HG--
extra : rebase_source : 2a1b660f6489c5aece8f8b25935ad5799779629d
2017-09-01 01:54:34 -07:00
Mike de Boer
d9febd9d56 Bug 1354532 - Part 2 - To facilitate the DownloadsSubview, add a 'LimitedHistoryDownloadsData' and 'LimitedPrivateHistoryDownloadData' dataview. r=Paolo
MozReview-Commit-ID: Jkyj2SQ7F00

--HG--
extra : rebase_source : 00650aacdab727e612648127cb5a0d5ce995b662
2017-09-06 17:16:02 +02:00
Mike de Boer
0fcde6db9c Bug 1354532 - Part 1 - Implement a new Downloads view as part of the Library widget. r=Paolo
MozReview-Commit-ID: AqH8Zj8XCQl

--HG--
extra : rebase_source : a78764e9ab25af06c5652d13065e3f8944998025
2017-09-06 16:23:00 +02:00
Sebastian Hengst
c3dc29271d Backed out changeset f1d18c741b2c (bug 1354532) for eslint failure at browser/components/downloads/DownloadsCommon.jsm:671: Expected property shorthand. r=backout 2017-09-06 16:48:00 +02:00
Sebastian Hengst
f807d2849c Backed out changeset 63909748b3ce (bug 1354532) 2017-09-06 16:47:12 +02:00
Mike de Boer
330e35542c Bug 1354532 - Part 2 - To facilitate the DownloadsSubview, add a 'LimitedHistoryDownloadsData' and 'LimitedPrivateHistoryDownloadData' dataview. r=Paolo
MozReview-Commit-ID: Jkyj2SQ7F00

--HG--
extra : rebase_source : 6342507ccd83187fc1e6690f8ba1a59c26d4c589
2017-09-06 16:23:06 +02:00
Mike de Boer
bfdabc36cf Bug 1354532 - Part 1 - Implement a new Downloads view as part of the Library widget. r=Paolo
MozReview-Commit-ID: AqH8Zj8XCQl

--HG--
extra : rebase_source : a78764e9ab25af06c5652d13065e3f8944998025
2017-09-06 16:23:00 +02:00
Wes Kocher
7ea5ed6e6a Merge m-c to autoland, a=merge
MozReview-Commit-ID: LEKykpTAKjv
2017-08-25 17:32:33 -07:00
Johann Hofmann
b5ba1bbb3c Bug 1139913 - Downloads with partial data should still keep the placeholder on disk. r=mak
This prevents naming conflicts if a paused or blocked download is retried from the original page.

MozReview-Commit-ID: 4rFZ5rP8saJ

--HG--
extra : rebase_source : 82dd14f0eb2f43c2404dff6e78aa564d07ba06d7
extra : source : d2a4fa2a4005db6c39aece63208059a86c5e35a5
2017-08-25 16:42:45 +01:00
Gijs Kruitbosch
e47e6f071c Back out changeset 97f7f5175b2f (bug 1371765) because we're changing the plan for the downloads button, rs=backout,firebot,paolo
MozReview-Commit-ID: FTvFDV5nuG6

--HG--
extra : rebase_source : af8ed6b6da9adc1badbdc5016aacb877511875f0
2017-08-25 13:32:47 +01:00
Blake Winton
fff59923b4 Bug 1384692 - Update the download doorhanger style. ui-r=amylee, r=Paolo.
MozReview-Commit-ID: 4pY9JxnLNYk

--HG--
extra : rebase_source : a6573e33298e84fca2fc8de92c932f770dcc53b2
2017-08-01 09:18:11 -04:00
Paolo Amadini
e9f7da41fa Bug 1393418 - Fix initialization of the Downloads Indicator on startup. r=mak
MozReview-Commit-ID: GEQZoak5MFl

--HG--
extra : rebase_source : d06fdd9e0a07e70cf3d3143c3ecefd0e3365a350
2017-08-24 13:34:08 +01:00
Gijs Kruitbosch
ace9ca19d1 Bug 1371765 - make downloads button non-customizable, r=jaws,Paolo
MozReview-Commit-ID: E9izQpa4fFZ

--HG--
extra : rebase_source : f2c8a292c5bddb2dfde656b0f37fe2abee371ea0
2017-08-16 15:54:36 +01:00
Paolo Amadini
f19bdfadcf Bug 1296554 - Show a static progress bar for downloads of unknown size. r=jaws
MozReview-Commit-ID: HgRl7vlTp3Z

--HG--
extra : rebase_source : 629e19cccc4c15aae0e244488cf3fe2e8008b449
2017-08-21 14:52:33 +01:00
Sam Foster
cb750380af Bug 1388183 - Queue and play the last download notification instead of truncating/aborting it. r=Paolo
* Maintain a _nextNotificationType LIFO "queue" of one, to play overlapping events in series
* _showNotification assumes everything could have changed since it was last called
* Signature of showEventNotification is unchanged, but most of its work is now done in _showNotification

MozReview-Commit-ID: 8sv4DZoZU65

--HG--
extra : rebase_source : 6c7fe7fd3b1d0401247d964d378c6829b04e2b93
2017-08-11 16:06:02 -07:00
Sebastian Hengst
549eba284b Backed out changeset bf522e33426e (bug 1388183) for eslint failure browser/components/downloads/content/indicator.js. r=backout on a CLOSED TREE 2017-08-17 22:04:54 +02:00
Sam Foster
c01a1898f4 Bug 1388183 - Queue and play the last download notification instead of truncating/aborting it. r=Paolo
* Maintain a _nextNotificationType LIFO "queue" of one, to play overlapping events in series
* _showNotification assumes everything could have changed since it was last called
* Signature of showEventNotification is unchanged, but most of its work is now done in _showNotification

MozReview-Commit-ID: 8sv4DZoZU65

--HG--
extra : rebase_source : 9d6a0fc905b42e8843693f6c5fe8cd1444d08868
2017-08-11 16:06:02 -07:00
Andrew Halberstadt
d2109610fb Bug 1385352 - Enable 'mozilla/no-arbitrary-setTimeout' eslint rule on browser-chrome tests, r=standard8
MozReview-Commit-ID: 5lO0uAjHMsw

--HG--
extra : rebase_source : 8607b3964da207a6076c79b6f1d75b40503cdd7d
2017-08-10 14:48:21 -04:00
Phil Ringnalda
0ff5a4285d Backed out changeset 6896f93a2327 (bug 1385352) for not making it to m-c before the next violation of its new linting rule merged to autoland
MozReview-Commit-ID: 3HDE2C3wSU0
2017-08-10 20:21:19 -07:00
Wes Kocher
cff9e9b197 Merge m-c to autoland, a=merge
MozReview-Commit-ID: 2YvHbITn9w3
2017-08-10 18:25:34 -07:00
Kris Maglione
0ecfcbc93e Bug 1388215: Part 3 - Use JIT-friendly defineLazy*Getters methods when defining many lazy imports. r=florian
MozReview-Commit-ID: APoFwUhDFdj

--HG--
extra : rebase_source : 15761873b91efaf1d338b6361bf7168ab4348e0d
2017-08-09 13:03:36 -07:00
Andrew Halberstadt
f625fd5c37 Bug 1385352 - Enable 'mozilla/no-arbitrary-setTimeout' eslint rule on browser-chrome tests, r=standard8
MozReview-Commit-ID: 5lO0uAjHMsw

--HG--
extra : rebase_source : d72a88962ec8d843e7be99e25f710887f01b6e1a
2017-08-10 14:48:21 -04:00
Jared Wein
76f886b972 Bug 1385913 - Remove MOZ_PHOTON_ANIMATIONS ifdef. r=Gijs
MozReview-Commit-ID: 40TP43EKPCU

--HG--
extra : rebase_source : 203f7449e8345ed5c779dfc4fd5e9bd515b89da8
2017-08-07 12:37:34 -04:00
Masatoshi Kimura
ca088e461c Bug 389565 - Remove nsIExternalProtocolService::LoadUrl. r=Paolo
MozReview-Commit-ID: lMq06cPWYB

--HG--
extra : rebase_source : 5c48597cbe4491fff93d3e757efa5ecad0f7fc22
2017-08-06 11:25:42 +09:00
Paolo Amadini
a0fc00495b Bug 1381411 - Implement the DownloadHistoryList object. r=mak
This also changes the Library window to use the newly added back-end object. The only user-visible change should be how the selection behaves when retrying downloads.

MozReview-Commit-ID: 7CQr1m21rcB

--HG--
extra : rebase_source : e36faf63dadeba0c897b769cb7e14a2d01d0f628
extra : amend_source : 2c7a88b6e3d6de50b37c34a5579b3ab6fb0c10dd
2017-08-04 14:48:53 +01:00
Sam Foster
6130972950 Bug 1376519 - Photon download notifications. r=Paolo
* Filmstrip style svg animation for start download notification, vertically centered to allow for variable-height toolbar buttons
* Simultaneous identifer "dip" animation on the icon for download start
* Identifier icon bounce animation for download finish (no notification animation in the #downloads-animation-container)
* Always measure the anchor element as toolbarheight may change in a session (e.g. switching to compact mode)
* Conditionally include the start/finish pngs for non-Photon builds
* Have #downloads-notification-anchor hidden by default, and show it before measuring for placement. This avoids the interference with scrolling/APZ when the notifier element is tall enough to overlap the tabbrowser element

MozReview-Commit-ID: LJF6iV9HiJi

--HG--
extra : rebase_source : 80238cf0240c32943667ee4c141c756813b2728e
2017-07-31 09:36:27 -07:00
Paolo Amadini
54a5e2c5a7 Bug 830415 - Part 2 - Move the front-end code that stores download metadata in history to the DownloadHistory module. r=mak
Regression tests will be added in bug 1381411 when methods to retrieve the metadata will be available.

MozReview-Commit-ID: I3MgwM0EOty

--HG--
extra : source : 6b7ffdcb3f99be007e88c685fd54a8132d844101
2017-07-26 16:12:57 +01:00
Marco Bonardo
12415f39f7 Bug 1275878 - Part 1: move back clear history operations to History.clear(). r=adw
MozReview-Commit-ID: DbEJgKbTxd7

--HG--
extra : rebase_source : f257f99aff6eebc44fac46d0e2d2579dae50ace2
2016-05-17 09:35:45 +02:00
Florian Quèze
b5647ed1c0 Bug 1381853 - lazy load downloads scripts into the browser window, r=mconley. 2017-07-23 00:18:00 +02:00
Paolo Amadini
073b04818f Bug 1354568 - Show the final file size in the Downloads Panel. r=mak
MozReview-Commit-ID: I9D2yaYpwHD

--HG--
extra : rebase_source : 445bc80d50dd3401175c1be639715679bb42d6b4
2017-07-18 15:00:19 +01:00
Paolo Amadini
137d61ddbb Bug 1381409 - Part 3 - Use DownloadList notifications directly in front-end download views. r=mak
The DownloadList object now provides batch notifications directly, in preparation for linking front-end views to other types of download lists without having to use the DownloadsData indirection.

MozReview-Commit-ID: FOTz1YwGRE1

--HG--
extra : rebase_source : df2d50d50c45a98e257caaa6efa9d0da2fa79237
extra : source : 278858e3d78b5e371f865adac043d07b770f1d3f
2017-07-17 12:05:12 +01:00
Paolo Amadini
64bb3feb3b Bug 1381409 - Part 2 - Let each view keep the state of downloads relevant to it. r=mak
The front-end download views now maintain the old download state themselves, instead of relying on the DownloadsData object dispatching the onDownloadStateChanged notification.

This allows each view to keep only the state relevant to it, for example the Downloads Panel already keeps the state only for the visible items. This also makes it possible for each view to use a different hash than the one provided by the legacy stateOfDownload method, and allows bypassing the DownloadsData indirection entirely.

MozReview-Commit-ID: 2D1ixsZCkCa

--HG--
extra : rebase_source : f429fe475ea1887180e269ee8aa0addcee76704d
extra : source : df5f46c825a10587149a7bbac2e126c3906e0393
2017-07-17 12:07:17 +01:00
Paolo Amadini
180e05ac9f Bug 1381409 - Part 1 - Always add Download objects in their original order. r=mak
When a new front-end view is added to the DownloadsData object, the Download objects it contains are loaded into the view starting with the newest, which is the opposite of the order used by the underlying DownloadList.

This was originally implemented as an optimization for the Downloads Panel, at a time when the full list of completed downloads was persisted in the same SQLite database as session downloads. This difference is now unnecessary given the low number of session downloads, and can be removed in preparation for bypassing the DownloadsData indirection entirely.

MozReview-Commit-ID: 5EBkqvyXFq4

--HG--
extra : rebase_source : 44b8783e5c44460d3aa4fb9bd0834c981110e98e
extra : source : 56b8e456797c56c45ed791c0d40f43031e94dc22
2017-07-16 17:36:00 +01:00
Paolo Amadini
3c1829bf94 Bug 1357915 - Fix download commands operating on multiple items in the Library window. r=Standard8
This was regressed by bug 1264206 while removing legacy array comprehensions, because selectedItems is a NodeList and not an Array.

MozReview-Commit-ID: 61GG3SiiWwS

--HG--
extra : rebase_source : 3b3c1268be944d1942450336d4e9c652b4054b41
2017-07-18 10:19:48 +01:00
Gijs Kruitbosch
dbd7fca428 Bug 1369729 - use descriptionheightworkaround for sync panel, r=mconley,Paolo
MozReview-Commit-ID: LQg6NEgCqz2

--HG--
extra : rebase_source : a039936a4c8e416c16171cacf73dab781d77ab50
2017-06-28 17:50:43 +01:00
Sam Foster
9afb8e9798 Bug 1375309 - Implement Photon download progressbar r=Paolo
* Split out the arrow and progressbar in the indicatorOverlay for individual animation.
* Group icon and progressbar parts into addressable elements in a single download-icons.svg

MozReview-Commit-ID: KAn0gFqjKjc

--HG--
extra : rebase_source : 4df5377be7d6d0b42eaebd1e28286b81fd555ec2
2017-06-28 15:03:52 -07:00
Blake Kaplan
a922e0a67a Bug 1375710 - Remove CPOWs from browser_iframe_gone_mid_download.js. r=Gijs
MozReview-Commit-ID: JUF8Vdx0vsy

--HG--
extra : rebase_source : 5be556124776c4dacce7cbabf1df70662c36f433
2017-05-16 18:58:28 -07:00
Florian Quèze
2924991bf6 Bug 1368456 - remove Promise.jsm imports in tests, r=mconley. 2017-06-23 11:25:52 +02:00
Florian Quèze
721c3ada5e Bug 1368456 - Remove imports of Promise.jsm from Firefox, r=mconley. 2017-06-23 11:25:18 +02:00
Paolo Amadini
10ee6a5c4e Bug 1362970 - Part 2 - Script-generated patch to convert .then(null, ...) to .catch(...). r=florian
Changes to Promise tests designed to test .then(null) have been reverted, and the browser/extensions directory was excluded because the projects it contains have a separate process for accepting changes.

MozReview-Commit-ID: 1buqgX1EP4P

--HG--
extra : rebase_source : 3a9ea310d3e4a8642aabbc10636c04bfe2e77070
2017-06-19 11:32:37 +01:00
Mark Striemer
f69d99cef4 Bug 1369771 - Confirm launch of executables other than .exe on Windows r=Paolo
MozReview-Commit-ID: 2TbLbdMc3d3

--HG--
extra : rebase_source : 9380ca04af2d9a9dbf1bedba558231897ed9ff4f
2017-05-29 16:38:54 -05:00
Edouard Oger
adde19d4f4 Bug 1369855 - Update sinon.js to version 2.3.2. r=markh
MozReview-Commit-ID: FPB4HebP3g7

--HG--
extra : rebase_source : 1e55c1dbc8bff59e1a7a097e4a6a58a19bc95688
2017-06-02 15:50:30 -04:00
Sebastian Hengst
d1ec3e6aa9 merge mozilla-central to mozilla-inbound. r=merge a=merge 2017-05-24 11:27:29 +02:00
Paolo Amadini
33ebc4466d Bug 1009116 - Redo resizing architecture of panelmultiview. r=Gijs
The height of the "panelmultiview" binding is now determined by the stack layout code, and doesn't have to be calculated manually via JavaScript anymore. This allows the removal of mutation and overflow observers, and reduces the number of synchronous layouts being made.

There is still a workaround included for wrapping blocks not being taken into account in height calculations.

MozReview-Commit-ID: 9rrPU5O5hUx

--HG--
extra : rebase_source : b872c14a553c4293ac476d5d22c634a5a0f6cb24
extra : intermediate-source : bf96469b6ea7daee29eb75a60d11f017a1c86a64
extra : source : 719bb4e7286fbd3baf32061929e4b7d9f953c671
2017-05-23 17:08:01 +01:00
Doug Thayer
f1396f3334 Bug 1359733 - (pt. 5) Pull out indicator.js badges r=Gijs
See also pt. 4. We are moving app menu notification state
into a jsm since it is not specific to one window and this
simplifies work for the new app update UI.

MozReview-Commit-ID: InEp5b0y2n0

--HG--
extra : rebase_source : afe4870fe01d64c7b870ddf568c525e6b12f27b2
2017-05-15 11:57:58 -07:00