After PFetch is enabled, fetch() call in workers will not create a channel in the content process anymore.
Although netmonitor also watches the channels in the parent process, the created channel still loses the BrowsingContext information for netmonitor to connect the network event and the channel.
Depends on D174441
Differential Revision: https://phabricator.services.mozilla.com/D174442
Tabs for original sources weren't correctly restored. We were still have tabs registered in the reducer,
but we were never trying to re-link them to the next page load's source objects.
Also, resetTabsForThread was removing tabs entirely instead of only nullifying source/sourceActor attributes.
So that on reload you may easily loose tabs of any additional target and possibly also the top target.
Differential Revision: https://phabricator.services.mozilla.com/D177164
After PFetch is enabled, fetch() call in workers will not create a channel in the content process anymore.
Although netmonitor also watches the channels in the parent process, the created channel still loses the BrowsingContext information for netmonitor to connect the network event and the channel.
Depends on D174441
Differential Revision: https://phabricator.services.mozilla.com/D174442
1) This patch cleanups the styling for blackboxing
- Ignored sources in the source tree are colored out and the icoon colors are consistent.
- Source content for ignored sources are also colored out.
- Ignored lines are colored out.
- The tab content for ignored sources are also abit lighter.
2) Also added tests to assert the lines in the sources are styled correcty
Thanks
Differential Revision: https://phabricator.services.mozilla.com/D173688
Support view() notation for animation-timeline:
`<view()> = view( [ <axis> || <'view-timeline-inset'> ]? )`
We move AnimationTimeline and its related types into the generics folder,
and define two new structs for scroll() and view().
Note:
1. The syntax of scroll() doesn't match the current version of the spec.
I will update it in Bug 1814444.
2. We will handle the creation/usage of the Anonymous View Progress Timelines
in the next patch.
Differential Revision: https://phabricator.services.mozilla.com/D173904
1) This patch cleanups the styling for blackboxing
- Ignored sources in the source tree are colored out and the icoon colors are consistent.
- Source content for ignored sources are also colored out.
- Ignored lines are colored out.
- The tab content for ignored sources are also abit lighter.
2) Also added tests to assert the lines in the sources are styled correcty
Thanks
Differential Revision: https://phabricator.services.mozilla.com/D173688
The project root UI is now handled in SourcesTree.
We simplify the markup so we keep the number of element to the minimum,
which helps managing the styles.
The CSS is refactored to remove/merge now unused properties, and we use
a CSS grid for the layout.
PrimaryPanes.spec.js is removed as we already have a mochitest asserting
the project root feature (browser_dbg-project-root.js)
Depends on D176666
Differential Revision: https://phabricator.services.mozilla.com/D176683
Most of the work needed for this was done in the previous patch of the stack,
but there were a few things we needed to do:
- actually have styling for the expand arrow in reps.css (in the console we're
(getting the "global" rule for styling arrows)
- not display the expand arrow _before_ the expression label for custom formatter
with body. The custom formatter handles fetching and displaying body by itself,
and we shouldn't leak that to the parent ObjectInspector
A test is added to ensure that this works as expected.
We might need a follow up for updating the expression panel style as "wide"
custom formatter might get hidden at certain sizes which isn't great
Differential Revision: https://phabricator.services.mozilla.com/D175847
With the current implementation, we were always passing a null `front` property
for the ObjectInspector root for a given expression.
The front is needed in CustomFormatter so the the body can be retrieved.
Doing this revealed an issue in ObjectInspector `rootsChanged` action, where we
were releasing actors while they might still be needed.
We now only release actors that are not in the new roots.
This was not visible before because we were only dealing with a grip before,
and we'd create a new ObjectActor whenever we needed to fetch the properties
from it.
Differential Revision: https://phabricator.services.mozilla.com/D175846
Instead, if we were selecting a generated source, we would keep selecting generated source.
If there is no selected source, we would still try to select the original source.
Many tests were relying on this behavior.
WASM test was failing because of errors with the parser worker.
I added early bailout in order to prevent trying to use the parser worker for WASM.
shared-head test helper were also tweaked to better support select WASM binary sources.
Differential Revision: https://phabricator.services.mozilla.com/D176349
The worker itself ignores already the WASM sources,
but we could save some cycle to avoid calling the parserWorker entirely
when we know the source won't be supported by it.
Differential Revision: https://phabricator.services.mozilla.com/D176414
This patch sets `this.compatibilityIssues` earlier so we effectively guard on
multiple "concurrent" calls.
Depends on D176395
Differential Revision: https://phabricator.services.mozilla.com/D176396
In `_getCompatSummary`, we were indirectly calling `getCompatTable` multiple times
with the same parameters. We fix this by calling it once directly in `_getCompatSummary`,
and then looking into the result to extract the data we want.
This patch also removes unecessary spread/rest operators when we didn't get any
values from it.
Differential Revision: https://phabricator.services.mozilla.com/D176395
Dev Tools is primarily targeted at web developers.
Web developers are most comfortable with ARIA roles, rather than Gecko internal role strings.
This is especially true for landmarks, which map to a single landmark role in Gecko, but most Dev Tools users expect separate ARIA roles: main, navigation, etc.
We fall back to a Gecko role string for roles which can't be mapped to ARIA; e.g. iframe.
Differential Revision: https://phabricator.services.mozilla.com/D175585
Dev Tools is primarily targeted at web developers.
Web developers are most comfortable with ARIA roles, rather than Gecko internal role strings.
This is especially true for landmarks, which map to a single landmark role in Gecko, but most Dev Tools users expect separate ARIA roles: main, navigation, etc.
We fall back to a Gecko role string for roles which can't be mapped to ARIA; e.g. iframe.
Differential Revision: https://phabricator.services.mozilla.com/D175585
This adds the file design-tokens.css which hosts our
tier 1 and tier 2 design tokens. Components can use these
to define their own tier 3 tokens.
Differential Revision: https://phabricator.services.mozilla.com/D164507
We were decoding groups and files source items label,
but not folders.
We fix this and take the occasion to use decodeURI instead
of the non-standard unescape.
A test is added to ensure the source tree items are rendered
as expected.
Differential Revision: https://phabricator.services.mozilla.com/D176145
We were not reading highlightedLineRange's sourceId
and so we might have been highlighting the wrong lines.
Move some logic up to Editor/index which knows about the displayed source.
This also help completely disable the HighlightedLines component until
an highlights start.
Differential Revision: https://phabricator.services.mozilla.com/D175878
