Chris Peterson
6a5ea85fa5
Bug 1278468 - Fix -Wshadow warnings in storage/ directory. r=mak
...
storage/TelemetryVFS.cpp:81:44 [-Wshadow] declaration shadows a field of '(anonymous namespace)::IOThreadAutoTimer'
storage/VacuumManager.cpp:192:25 [-Wshadow] declaration shadows a local variable
storage/VacuumManager.cpp:248:13 [-Wshadow] declaration shadows a local variable
storage/VacuumManager.cpp:249:14 [-Wshadow] declaration shadows a local variable
storage/VacuumManager.cpp:251:19 [-Wshadow] declaration shadows a local variable
storage/mozStorageConnection.cpp:971:15 [-Wshadow] declaration shadows a local variable
storage/mozStorageStatement.cpp:449:19 [-Wshadow] declaration shadows a local variable
storage/variantToSQLiteT_impl.h:97:16 [-Wshadow] declaration shadows a local variable
--HG--
extra : rebase_source : 4e966f23ff352b6f8ea8e992278ab8a952c69e01
2016-06-07 22:08:41 -07:00
Chris Peterson
8a9e2d2bd4
Bug 1272513 - Part 2: Remove redundant -Wshadow CXXFLAGS from moz.build files. r=glandium
2016-05-14 00:54:55 -07:00
Chris Peterson
353ee65255
Bug 1272513 - Part 1: Suppress -Wshadow warnings-as-errors in some directories. r=glandium
2016-05-11 00:00:01 -07:00
Randell Jesup
477adfcd7e
Bug 1271514: clean up threads in test_unlock_notify r=froydnj
...
MozReview-Commit-ID: EbCnWFzLMca
2016-05-11 00:09:53 -04:00
Kyle Huey
941ab1f522
Bug 1268313: Part 7 - Move NS_NewRunnableMethod and friends to mozilla::NewRunnableMethod. r=froydnj
2016-05-05 01:45:00 -07:00
Carsten "Tomcat" Book
ba3fe0975c
Backed out changeset 85ce8cb0639a (bug 1268313)
...
--HG--
extra : rebase_source : 56d1cf41a2dc4959b67f834e07192a5c772176a8
2016-04-29 14:21:16 +02:00
Kyle Huey
48a594a09e
Bug 1268313: Part 7 - Move NS_NewRunnableMethod and friends to mozilla::NewRunnableMethod. r=froydnj
2016-04-28 14:08:25 -07:00
Kyle Huey
c73656947b
Bug 1265927: Move nsRunnable to mozilla::Runnable, CancelableRunnable to mozilla::CancelableRunnable. r=froydnj
2016-04-25 17:23:21 -07:00
Kyle Huey
d9265a3eaf
Bug 1259294: Part 2 - Use MOZ_ALWAYS_SUCCEEDS. r=froydnj
2016-03-28 10:28:15 -07:00
Jan Varga
7bb929b877
Bug 1182987 - Part 2: Add getQuotaObjects() to mozIStorageConnection; r=mak
2016-03-15 07:00:28 +01:00
Ted Mielczarek
68bd5e8c4d
bug 1244743 - Replace MOZ_NATIVE_X with MOZ_SYSTEM_X. r=gps
...
MozReview-Commit-ID: 9ip3qeAXFEe
--HG--
extra : commitid : H6aEkHprVyX
extra : rebase_source : e20d5f4b297caf66711c72cd55dd76f7f9ef9d9c
extra : histedit_source : 47545e0ea61eb66f16545f70e6d3792a389bedb1
2016-02-01 10:49:34 -05:00
sajitk
823704b8d6
Bug 1219482: Replace PRLogModuleInfo with LazyLogModule in various files.r=benjamin
2016-01-28 10:35:00 -08:00
Jonathan Watt
ccf5c4c6dc
Bug 1253094, part 7 - Stop using DebugOnly for class/struct members in storage/. r=mak
...
MozReview-Commit-ID: 72nH7FVfUtZ
2016-02-26 15:52:08 +00:00
Xidorn Quan
2ad2ca17e9
Bug 1248757 followup - Release blob after assignment in DoGetBlobAsString on CLOSED TREE.
...
MozReview-Commit-ID: HOsMvsjBJKF
--HG--
extra : source : cac755e67ad9739d72f78a184f20bafd845e514f
2016-02-17 11:57:59 +08:00
Ben Kelly
124248a8ad
Bug 1248757 Use string ::Assign() instead of Adopt() when reading blobs as strings. r=asuth
2016-02-16 14:32:00 -08:00
Carsten "Tomcat" Book
b1eedbe899
Merge mozilla-central to mozilla-inbound
2016-02-11 11:56:20 +01:00
Jeffrey Tran
f139fb05d8
Bug 1230685 - Replace function declarations with add_task statements in test_storage_value_array.js and test_unicode.js. r=mak
...
--HG--
extra : commitid : GaYkxxYU4Yj
2016-02-10 15:30:34 +01:00
Jeffrey Tran
1a2bff1271
Bug 1230683 - Replace try/catch with Assert.throws in test_storage_connection.js. r=mak
...
--HG--
extra : commitid : CevJdrYql4m
2016-02-10 15:30:28 +01:00
Dave Townsend
0a6414b898
Bug 1245649: Turn on no-trailing-spaces. r=Gijs
...
--HG--
extra : commitid : F2OWKTvXUO4
extra : rebase_source : ec68631342e0edc59d77b6bab1cdc975ad175327
2016-02-03 14:22:33 -08:00
Birunthan Mohanathas
d7371d07d0
Bug 1235261 - Part 1: Rename nsAutoTArray to AutoTArray. r=froydnj
2016-02-02 17:36:30 +02:00
Aidin Gharibnavaz
686438c658
Bug 1164581 - Adding an overload for NS_ProxyRelease that accepts already_AddRefed, and removing all the others. r=bobbyholley
2016-02-10 08:23:00 +01:00
Carsten "Tomcat" Book
5b358688b7
Backed out changeset c18e29c1b369 (bug 1164581) for cpp unit tests test failures
...
--HG--
extra : rebase_source : fb6fd434c8e3f4b5fa53ea645a54c07cab207894
2016-02-08 11:17:38 +01:00
Aidin Gharibnavaz
69cf7e035f
Bug 1164581 - Adding an overload for NS_ProxyRelease that accepts already_AddRefed, and removing all the others. r=bobbyholley
...
--HG--
extra : rebase_source : 3c6bba6613a14e48239d302bdd0f7fe2e322265d
2016-02-07 10:56:00 +01:00
Phil Ringnalda
d381b4bca6
Back out 7 changesets (bug 1235261) for cpptest failures in TestTArray
...
CLOSED TREE
Backed out changeset d66c3f19a210 (bug 1235261)
Backed out changeset 467d945426bb (bug 1235261)
Backed out changeset 32b61df13142 (bug 1235261)
Backed out changeset c50bb8ed4196 (bug 1235261)
Backed out changeset 0ff0fa6fe81f (bug 1235261)
Backed out changeset df70e89669da (bug 1235261)
Backed out changeset 064969357fc9 (bug 1235261)
2016-01-31 10:10:57 -08:00
Birunthan Mohanathas
373593275e
Bug 1235261 - Part 1: Rename nsAutoTArray to AutoTArray. r=froydnj
2016-01-31 17:12:12 +02:00
Wes Kocher
b9d77f5943
Backed out changeset 2c56aed63687 (bug 1219482) to hopefully fix the intermittent hazard failures CLOSED TREE
...
--HG--
extra : commitid : 7egFNnxx2ut
2016-01-29 10:15:38 -08:00
sajitk
6fdb9b782e
Bug 1219482 - Replace PRLogModuleInfo with LazyLogModule in various files. r=bsmedberg
...
--HG--
extra : rebase_source : 37e8f53a8aa5242058ab8fc867804cbc8940653e
2016-01-28 10:35:00 -05:00
Carsten "Tomcat" Book
323b54c218
merge mozilla-inbound to mozilla-central a=merge
2016-01-28 12:13:37 +01:00
Nicholas Nethercote
d8dd426798
Bug 1187141
- Replace nsBaseHashtable::Enumerate() calls in storage/ with iterators. r=mak.
2016-01-24 18:09:12 -08:00
Jeffrey Tran
c601fe0a05
Bug 555087 - Add check for exception when passing undefined parameter. r=adw
2016-01-20 16:37:00 +01:00
Dave Townsend
9b1de02e15
Bug 1239354: Replace old-style generator function with star functions. r=asuth
...
--HG--
extra : rebase_source : e932378aaf2d08a1ff3b096cdb5770c139c93979
2016-01-13 08:58:15 -08:00
Andrew Sutherland
debfaf45f7
Bug 1237601 - Perform storage close synchronously if async thread cannot be started. r=bkelly
...
Also factors asyncClose tests out into their own file.
2016-01-07 11:18:00 -05:00
Andrew Sutherland
896d9d7315
Bug 1237601 - Centralize storage xpcshell promise helpers (support patch). r=bkelly
2016-01-12 17:27:33 -05:00
Andrea Marchesini
caa2f9b456
Bug 1231378 - part 4 - Fix uninitialized members of classes in netwerk/widget/storage/uriloader/memory/tools, r=smaug
2016-01-12 18:16:59 +00:00
Carsten "Tomcat" Book
3589aeeb8a
Backed out changeset d6b0ffe1a7b3 (bug 1231378)
2016-01-12 15:48:54 +01:00
Andrea Marchesini
2609a149da
Bug 1231378 - part 4 - Fix uninitialized members of classes in netwerk/widget/storage/uriloader/memory/tools, r=smaug
2016-01-12 13:57:37 +00:00
Chris Peterson
c0fb08917c
Bug 1235237 - Annotate intentional switch fallthrough to suppress -Wimplicit-fallthrough warning in storage/. r=mak
...
storage/mozStoragePrivateHelpers.cpp:234:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
2015-11-22 22:09:23 -08:00
Nicholas Nethercote
ec89bbf7f2
Bug 1237151 (part 3) - Remove ignored qualifiers in all remaining code. r=froydnj.
2016-01-05 17:08:45 -08:00
Marco Bonardo
1006b4755f
Bug 1230549 - Storage should pass more eslint rules. r=yoric
...
--HG--
extra : commitid : 9FE8bR3AhsJ
extra : rebase_source : 1d65cc419e9375facb1dc7265e05ee84195153e7
2015-12-04 17:00:03 +01:00
Marco Bonardo
4190a83115
Bug 1230549 - Make Storage pass basic eslint. r=yoric
...
--HG--
rename : browser/.eslintrc => storage/.eslintrc
extra : commitid : 5RiWGmPFkg2
extra : rebase_source : 54b8a2e9680c37d88c0a501d85422163f4e04fea
2015-12-04 15:52:43 +01:00
Nathan Froyd
8a2948e596
Bug 1225923 - part 1 - convert all needs-to-copy instances of AppendElement(nsDependentString(...)); r=erahm
...
When people write:
array.AppendElement(nsDependentString(...));
(resp. nsDependentCString), it's not clear whether they expect the newly
constructed dependent string to live in the array, or whether they're
just making a nsString-like holder whose contents can be freely copied
into the array's newly-created nsString. Sometimes the latter is what
you prefer, and sometimes the former. In all cases, however, the latter
behavior is what you get.
Let's try to make that behavior more explicit by pre-constructing
nsString elements and then using Assign to show that copying is taking
place. This patch involves no functional change in behavior (it ought
to be epsilon faster due to using AppendElements, rather than repeatedly
calling AppendElement).
2015-11-18 10:25:19 -05:00
Nicholas Nethercote
8eb10da71a
Bug 1186791 (part 3) - Replace nsBaseHashtable::EnumerateRead() calls in storage/ with iterators. r=mak.
...
--HG--
extra : rebase_source : 8fc71420355baa87b63f6c9c817a27395272cb33
2015-10-29 16:43:34 -07:00
Nicholas Nethercote
acb6e8f1f1
Bug 1186791 (part 2) - Replace nsBaseHashtable::EnumerateRead() calls in storage/ with iterators. r=mak.
...
--HG--
extra : rebase_source : defddc0f2e490b5b1b41fd71bebedfc8b31a35bb
2015-10-29 16:04:42 -07:00
Nicholas Nethercote
23e7f15036
Bug 1186791 (part 1) - Replace nsBaseHashtable::EnumerateRead() calls in storage/ with iterators. r=mak.
...
--HG--
extra : rebase_source : 5781d353bec6bef4b96a6f4f6c734e10594b5643
2015-10-29 16:04:41 -07:00
Nathan Froyd
4bc7fd6e21
Bug 1219238 - remove AutoArray from mozStorageSQLFunctions.cpp; r=mak
...
nsAutoTArray is practically the same thing; we should just use that and
avoid code duplications.
2015-10-27 21:22:52 -04:00
Tooru Fujisawa
6fc0b6a576
Bug 1217982 - Remove for-each from storage/. r=mak
...
--HG--
extra : commitid : JkK4BJvCHax
extra : rebase_source : add04bcdd5f6400e8d20f9fdcd3ce57f48fabae1
2015-10-19 03:53:14 +09:00
Nathan Froyd
01583602a9
Bug 1207245 - part 6 - rename nsRefPtr<T> to RefPtr<T>; r=ehsan; a=Tomcat
...
The bulk of this commit was generated with a script, executed at the top
level of a typical source code checkout. The only non-machine-generated
part was modifying MFBT's moz.build to reflect the new naming.
CLOSED TREE makes big refactorings like this a piece of cake.
# The main substitution.
find . -name '*.cpp' -o -name '*.cc' -o -name '*.h' -o -name '*.mm' -o -name '*.idl'| \
xargs perl -p -i -e '
s/nsRefPtr\.h/RefPtr\.h/g; # handle includes
s/nsRefPtr ?</RefPtr</g; # handle declarations and variables
'
# Handle a special friend declaration in gfx/layers/AtomicRefCountedWithFinalize.h.
perl -p -i -e 's/::nsRefPtr;/::RefPtr;/' gfx/layers/AtomicRefCountedWithFinalize.h
# Handle nsRefPtr.h itself, a couple places that define constructors
# from nsRefPtr, and code generators specially. We do this here, rather
# than indiscriminantly s/nsRefPtr/RefPtr/, because that would rename
# things like nsRefPtrHashtable.
perl -p -i -e 's/nsRefPtr/RefPtr/g' \
mfbt/nsRefPtr.h \
xpcom/glue/nsCOMPtr.h \
xpcom/base/OwningNonNull.h \
ipc/ipdl/ipdl/lower.py \
ipc/ipdl/ipdl/builtin.py \
dom/bindings/Codegen.py \
python/lldbutils/lldbutils/utils.py
# In our indiscriminate substitution above, we renamed
# nsRefPtrGetterAddRefs, the class behind getter_AddRefs. Fix that up.
find . -name '*.cpp' -o -name '*.h' -o -name '*.idl' | \
xargs perl -p -i -e 's/nsRefPtrGetterAddRefs/RefPtrGetterAddRefs/g'
if [ -d .git ]; then
git mv mfbt/nsRefPtr.h mfbt/RefPtr.h
else
hg mv mfbt/nsRefPtr.h mfbt/RefPtr.h
fi
--HG--
rename : mfbt/nsRefPtr.h => mfbt/RefPtr.h
2015-10-18 01:24:48 -04:00
Eric Rahm
1874580339
Bug 1194023 - Part 2: Only check for sort operations if mozStorage logging is enabled. r=mak
2015-09-25 16:33:22 -07:00
Eric Rahm
af00644989
Bug 1194023 - Part 1: Filter out warnings about sort operations on CREATE INDEX statements. r=mak
2015-09-25 15:27:48 -07:00
Tooru Fujisawa
ee9f17192c
Bug 1207499 - Part 9: Remove use of expression closure from storage/. r=mak
...
--HG--
extra : commitid : CuirUjswj0A
extra : rebase_source : 4368bcee9edccffb48a99a154b13e4625c20d263
2015-09-23 18:42:19 +09:00