Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-05 00:25:27 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
499,028 Commits 615 Branches 98 Tags 6 GiB
71456ae11e
Commit Graph

51 Commits

Author SHA1 Message Date
Nicholas Nethercote
34dcc7b852 Bug 1299384 - Use MOZ_MUST_USE with NS_warn_if_impl(). r=erahm. 
This change avoids lots of false positives for Coverity's CHECKED_RETURN
warning, caused by NS_WARN_IF's current use in both statement-style and
expression-style.

In the case where the code within the NS_WARN_IF has side-effects, I made the
following change.

> NS_WARN_IF(NS_FAILED(FunctionWithSideEffects()));
> -->
> Unused << NS_WARN_IF(NS_FAILED(FunctionWithSideEffects()));

In the case where the code within the NS_WARN_IF lacks side-effects, I made the
following change.

> NS_WARN_IF(!condWithoutSideEffects);
> -->
> NS_WARNING_ASSERTION(condWithoutSideEffects, "msg");

This has two improvements.
- The condition is not evaluated in non-debug builds.
- The sense of the condition is inverted to the familiar "this condition should
  be true" sense used in assertions.

A common variation on the side-effect-free case is the following.

> nsresult rv = Fn();
> NS_WARN_IF_(NS_FAILED(rv));
> -->
> DebugOnly<nsresult rv> = Fn();
> NS_WARNING_ASSERTION(NS_SUCCEEDED(rv), "Fn failed");

--HG--
extra : rebase_source : 58788245021096efa8372a9dc1d597a611d45611
 2016-09-02 17:12:24 +10:00
Kan-Ru Chen
b6d880aca1 Bug 1297276 - Rename mfbt/unused.h to mfbt/Unused.h for consistency. r=froydnj 
The patch is generated from following command:

  rgrep -l unused.h|xargs sed -i -e s,mozilla/unused.h,mozilla/Unused.h,

MozReview-Commit-ID: AtLcWApZfES


--HG--
rename : mfbt/unused.h => mfbt/Unused.h
 2016-08-24 14:47:04 +08:00
Andrea Marchesini
60ab8339e0 Bug 1288736 - Add some missing rv.SuppressException(), r=smaug 2016-07-22 16:50:10 +02:00
Kyle Huey
2709afd167 Bug 1263311: Part 3 - s/nsCancelableRunnable/CancelableRunnable/g. r=froydnj 2016-04-11 11:40:06 -07:00
Andrea Marchesini
eb9a84d8f8 Bug 1257180 - patch 1 - Directory clonable to workers, r=smaug 2016-04-12 08:50:38 -04:00
Sebastian Hengst
f25d35d7af Backed out changeset b416fc68c0a2 (bug 1257180) for crash in test_performance_user_timing.html on Android debug. r=backout on a CLOSED TREE 2016-04-12 17:56:15 +02:00
Andrea Marchesini
846b1de4c5 Bug 1257180 - patch 1 - Directory clonable to workers, r=smaug 2016-04-12 08:50:38 -04:00
Andrea Marchesini
b0d38d029e Bug 1258221 - patch 3 - Rename FileSystemTaskBase to FileSystemTaskChildBase, r=smaug 2016-04-09 19:17:28 +01:00
Andrea Marchesini
9345155089 Bug 1258221 - patch 2 - Port FileSystem API and DeviceStorage API to PBackground, r=smaug 2016-04-09 19:17:02 +01:00
Andrea Marchesini
c6067c0a80 Bug 1258221 - patch 1 - File::CreateFromFile only for main-thread, r=smaug 2016-04-09 19:15:50 +01:00
Andrea Marchesini
69278a33e5 Bug 1173320 - patch 5/8 - Cleanup manual string path management, r=smaug 2016-03-20 11:56:10 +01:00
Andrea Marchesini
4c6e588645 Bug 1173320 - patch 2/8 - Proper naming for the FileSystem path serialization, r=smaug 2016-03-20 11:56:10 +01:00
Andrea Marchesini
18858bf144 Bug 1173320 - patch 1/8 - Implement Directory object as string and not as BlobImpl, r=smaug 2016-03-20 11:56:10 +01:00
Phil Ringnalda
b47ec4d2bd Backed out 8 changesets (bug 1173320) for adding dom/filesystem/tests/test_basic.html without making it work on Android 
Backed out changeset 7e3a105b9160 (bug 1173320)
Backed out changeset 094819fbb07f (bug 1173320)
Backed out changeset 23b0e55ff1db (bug 1173320)
Backed out changeset 8bf8e2fcedad (bug 1173320)
Backed out changeset 3de390c6f47f (bug 1173320)
Backed out changeset fb298010e12e (bug 1173320)
Backed out changeset f1a965c2f796 (bug 1173320)
Backed out changeset 176128ba757f (bug 1173320)
 2016-03-19 19:44:22 -07:00
Andrea Marchesini
f9925e6480 Bug 1173320 - patch 5/8 - Cleanup manual string path management, r=smaug 2016-03-19 22:29:47 +01:00
Andrea Marchesini
f43b2ad7ea Bug 1173320 - patch 2/8 - Proper naming for the FileSystem path serialization, r=smaug 2016-03-19 22:29:46 +01:00
Andrea Marchesini
232e5767b0 Bug 1173320 - patch 1/8 - Implement Directory object as string and not as BlobImpl, r=smaug 2016-03-19 22:29:46 +01:00
Andrea Marchesini
e234f69eff Bug 1234192 - part 1 - FileSystemBase should not be thread-safe, r=smaug 2015-12-30 08:53:20 +00:00
Phil Ringnalda
3196bbcb53 Back out 2 changesets (bug 1234192) for "Assertion failure: !mFileSystem" in test_fs_createFile.html 
Backed out changeset 3f37b08ceb85 (bug 1234192)
Backed out changeset bab507aa7874 (bug 1234192)
 2015-12-29 19:16:40 -08:00
Andrea Marchesini
2a897eff4e Bug 1234192 - part 1 - FileSystemBase should not be thread-safe, r=smaug 2015-12-29 20:41:37 +00:00
Birunthan Mohanathas
9985829ecc Bug 1219392 - Capitalize mozilla::unused to avoid conflicts. r=froydnj 2015-11-02 07:53:26 +02:00
Dragana Damjanovic
7987d2203e Bug 905127 - Part 2 - remove unnecessary nsNetUtil.h includes r=jduell 2015-07-06 07:55:00 +02:00
Emanuel Hoogeveen
7d1e52f2ff Bug 905127 - Part 1 - Make some functions from nsNetUtil not inline. r=jduell 2015-07-07 04:17:00 +02:00
Juan Gomez
258ad59e3f Bug 1171931 - Refactor duplicated code using XRE_IsParent/ContentProcess. r=froydnj 2015-07-03 18:29:00 -07:00
Ryan VanderMeulen
5f5c327690 Backed out changeset 8b4e4083639e (bug 1171931) for B2G debug emulator bustage. 2015-06-25 19:48:42 -04:00
Juan Gomez
702a59d135 Bug 1171931 - Refactor duplicated code using XRE_IsParent/ContentProcess. r=froydnj 
--HG--
extra : rebase_source : 2ecbe6c1dd8a7ad8dc529b53349ad431cf1116c9
 2015-06-24 14:11:00 -04:00
Andrea Marchesini
f4538bb921 Bug 1163387 - Rename FileImpl to BlobImpl, r=ehsan 
--HG--
rename : dom/base/MultipartFileImpl.cpp => dom/base/MultipartBlobImpl.cpp
rename : dom/base/MultipartFileImpl.h => dom/base/MultipartBlobImpl.h
 2015-05-12 13:11:03 +01:00
Andrea Marchesini
368a198972 Bug 1159401 - Split Blob and File classes, r=bz 2015-05-12 13:09:51 +01:00
Wes Kocher
983fcabeef Backed out 2 changesets (bug 1159401) for b2g build bustage 
Backed out changeset adfee1efb1e1 (bug 1159401)
Backed out changeset 70c63c8546e3 (bug 1159401)
 2015-05-11 14:54:02 -07:00
Wes Kocher
6b003ab737 Backed out changeset 56e4c68dc3da (bug 1163387) for build bustage CLOSED TREE 
--HG--
rename : dom/base/MultipartBlobImpl.cpp => dom/base/MultipartFileImpl.cpp
rename : dom/base/MultipartBlobImpl.h => dom/base/MultipartFileImpl.h
 2015-05-11 13:17:58 -07:00
Andrea Marchesini
49a0ee6938 Bug 1163387 - Rename FileImpl to BlobImpl, r=ehsan 
--HG--
rename : dom/base/MultipartFileImpl.cpp => dom/base/MultipartBlobImpl.cpp
rename : dom/base/MultipartFileImpl.h => dom/base/MultipartBlobImpl.h
 2015-05-11 18:50:54 +01:00
Andrea Marchesini
91a8a35606 Bug 1159401 - patch 1 - Split Blob and File in 2 classes, r=bz 2015-05-11 18:50:50 +01:00
Ryan VanderMeulen
2390c704f8 Backout revisions 4287533203fb and 96a3ebfe09d8 (bug 1159401) for bustage. 
CLOSED TREE

--HG--
extra : histedit_source : a6c24f88b9c5a0cbcf2d44189fd359ddb20757b4%2C46613cfc309a9f0531e8c2475ac17877f606f231
 2015-05-11 11:43:59 -04:00
Andrea Marchesini
48ecacaa74 Bug 1159401 - patch 1 - Split Blob and File in 2 classes, r=bz 2015-05-11 15:20:06 +01:00
Andrew McCreight
9e8f4b219e Bug 1152551, part 2 - Fix mode lines in dom/. r=jst 2015-05-03 15:32:37 -04:00
Andrea Marchesini
3c8ee378d5 Bug 1158437 - dom::File should accept negative date values, r=smaug 2015-04-27 12:17:19 +01:00
Andrea Marchesini
8f8ec51372 Bug 1047483 - patch 3 - Renaming DOMFile to File, r=ehsan 
--HG--
rename : content/base/public/nsDOMFile.h => content/base/public/File.h
rename : content/base/src/nsDOMFile.cpp => content/base/src/File.cpp
 2014-10-08 17:15:23 +01:00
Andrea Marchesini
7491bee8c3 Bug 1047483 - patch 1 - Porting DOMFile/DOMBlob to WebIDL, r=bz, r=bkelly, r=bholley 2014-10-08 17:15:22 +01:00
Ryan VanderMeulen
cd3e8a6f73 Backed out 7 changesets (bug 1047483, bug 1079301, bug 1079335) for webplatform test failures. 
Backed out changeset 7d06b68c44d0 (bug 1079335)
Backed out changeset 92030169528e (bug 1079301)
Backed out changeset c09d7f95554a (bug 1047483)
Backed out changeset c199f1057d7e (bug 1047483)
Backed out changeset 18830d07884c (bug 1047483)
Backed out changeset e087289ccfbb (bug 1047483)
Backed out changeset 6238ff5d3ed0 (bug 1047483)

CLOSED TREE

--HG--
rename : content/base/public/File.h => content/base/public/nsDOMFile.h
rename : content/base/src/MultipartFileImpl.cpp => content/base/src/nsDOMBlobBuilder.cpp
rename : content/base/src/MultipartFileImpl.h => content/base/src/nsDOMBlobBuilder.h
rename : content/base/src/File.cpp => content/base/src/nsDOMFile.cpp
 2014-10-07 13:16:11 -04:00
Andrea Marchesini
c8190ba625 Bug 1047483 - patch 3 - Renaming DOMFile to File, r=ehsan 
--HG--
rename : content/base/public/nsDOMFile.h => content/base/public/File.h
rename : content/base/src/nsDOMFile.cpp => content/base/src/File.cpp
 2014-10-07 15:20:55 +01:00
Andrea Marchesini
d272279126 Bug 1047483 - patch 1 - Porting DOMFile/DOMBlob to WebIDL, r=bz, r=bkelly, r=bholley 2014-10-07 15:20:52 +01:00
Ben Turner
d081140cb0 Bug 994190 - 'Modify main-thread IndexedDB to use PBackground', r=khuey. 2014-09-26 16:21:57 -07:00
Ben Turner
46d101f40c Backout bug 994190 and merge over some stuff that landed afterwards on a CLOSED TREE. 2014-09-17 19:36:01 -04:00
Ben Turner
1a91d40956 Bug 994190 - 'Modify main-thread IndexedDB to use PBackground', r=khuey. 
--HG--
rename : dom/indexedDB/ipc/SerializationHelpers.h => dom/indexedDB/SerializationHelpers.h
rename : dom/indexedDB/ipc/unit/head.js => dom/indexedDB/test/unit/xpcshell-head-child-process.js
rename : dom/indexedDB/test/unit/head.js => dom/indexedDB/test/unit/xpcshell-head-parent-process.js
rename : dom/ipc/Blob.h => dom/ipc/BlobParent.h
rename : dom/ipc/FileDescriptorSetChild.cpp => ipc/glue/FileDescriptorSetChild.cpp
rename : dom/ipc/FileDescriptorSetChild.h => ipc/glue/FileDescriptorSetChild.h
rename : dom/ipc/FileDescriptorSetParent.cpp => ipc/glue/FileDescriptorSetParent.cpp
rename : dom/ipc/FileDescriptorSetParent.h => ipc/glue/FileDescriptorSetParent.h
rename : dom/ipc/PFileDescriptorSet.ipdl => ipc/glue/PFileDescriptorSet.ipdl
 2014-09-13 12:12:19 -04:00
Yuan Xulei
488fa35aeb Bug 910412 - Filesystem API permission request and checks. r=dhylands 2014-03-05 11:24:19 +08:00
Yuan Xulei
9d543fd864 Bug 910412 - Implement |getRoot|, |createDirectory| and |get| for Directory. r=dhylands, r=smaug 2014-03-05 11:25:40 +08:00
Ryan VanderMeulen
a154cec3e0 Backed out 5 changesets (bug 910412) for intermittent crash whack-a-mole. 
Backed out changeset e3eb9463b3e1 (bug 910412)
Backed out changeset d5863d302bde (bug 910412)
Backed out changeset 422b66d4b1ca (bug 910412)
Backed out changeset 3431d59d752e (bug 910412)
Backed out changeset b1c0310cdac1 (bug 910412)
 2014-03-11 12:17:03 -04:00
Ryan VanderMeulen
9e12356217 Backed out changeset 3c126eebea64 (bug 981145) 2014-03-11 12:17:01 -04:00
Yuan Xulei
55e3be12a2 Bug 981145 - Remove main thread assertion from FileSystemTaskBase dtor. r=dhylands 2014-03-11 08:10:57 -04:00
Yuan Xulei
4b1c019b74 Bug 910412 - Filesystem API permission request and checks. r=dhylands 2014-03-05 11:24:19 +08:00