Commit Graph

1212 Commits

Author SHA1 Message Date
Dorel Luca
7320ae982a Backed out changeset f3aaf04fce3b (bug 1679758) for Devtool failures in browser_styleeditor_syncAddProperty.js. CLOSED TREE 2020-12-13 16:38:21 +02:00
Kartik Gautam
caf549c200 Bug 1679758 - Remove trailing empty lines r=sylvestre
Differential Revision: https://phabricator.services.mozilla.com/D99595
2020-12-13 13:28:30 +00:00
Simon Giesecke
1c53236b70 Bug 1679272 - Include ScopeExit.h exactly where used. r=andi
Differential Revision: https://phabricator.services.mozilla.com/D98888
2020-12-07 14:25:59 +00:00
Simon Giesecke
971b645fe3 Bug 1660470 - Add missing include directives/forward declarations. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D87865
2020-11-23 16:21:38 +00:00
Tim Huang
fd15d2199a Bug 1641270 - Part 3: Make nsICookieJarSetting serializable. r=dimi
In order to send the cookieJarSetting across processes in JS. We need to
make it serializable.

Differential Revision: https://phabricator.services.mozilla.com/D95613
2020-11-11 11:13:55 +00:00
Tim Huang
f0c895fc31 Bug 1641270 - Part 1: Expose cookieJarSettings to UI code through Document. r=smaug,dimi
Differential Revision: https://phabricator.services.mozilla.com/D95611
2020-11-11 11:13:57 +00:00
Mihai Alexandru Michis
4038013e6f Backed out 9 changesets (bug 1641270) for causing dt failures in browser_jsonview_save_json.js
CLOSED TREE

Backed out changeset 89a6dab92f1a (bug 1641270)
Backed out changeset 5f9c5af66b77 (bug 1641270)
Backed out changeset dfeb879f4131 (bug 1641270)
Backed out changeset 143728b1b1ab (bug 1641270)
Backed out changeset 265ae2953416 (bug 1641270)
Backed out changeset 55ea7810c160 (bug 1641270)
Backed out changeset 7bef9112f296 (bug 1641270)
Backed out changeset 2663dc1e9a3e (bug 1641270)
Backed out changeset fcba6dba3649 (bug 1641270)
2020-11-11 13:10:11 +02:00
Tim Huang
13ec804734 Bug 1641270 - Part 3: Make nsICookieJarSetting serializable. r=dimi
In order to send the cookieJarSetting across processes in JS. We need to
make it serializable.

Differential Revision: https://phabricator.services.mozilla.com/D95613
2020-11-10 11:47:32 +00:00
Tim Huang
5a9cd22328 Bug 1641270 - Part 1: Expose cookieJarSettings to UI code through Document. r=smaug,dimi
Differential Revision: https://phabricator.services.mozilla.com/D95611
2020-11-10 11:47:11 +00:00
Valentin Gosu
ad416f2616 Bug 1666678 - [cookie] rejected cookie when domain have ipv6 address r=baku
Differential Revision: https://phabricator.services.mozilla.com/D91246
2020-11-04 09:44:23 +00:00
Ricky Stewart
02a7b4ebdf Bug 1654103: Standardize on Black for Python code in mozilla-central.
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.

To produce this patch I did all of the following:

1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.

2. Run ./mach lint --linter black --fix

3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.

4. Make some ad-hoc manual updates to `testing/marionette/client/setup.py`, `testing/marionette/harness/setup.py`, and `testing/firefox-ui/harness/setup.py`, which have hard-coded regexes that break after the reformat.

5. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D94045
2020-10-26 18:34:53 +00:00
Bogdan Tara
da1098d4aa Backed out 10 changesets (bug 1654103, bug 1672023, bug 1518999) for PanZoomControllerTest.touchEventForResult gv-junit failures CLOSED TREE
Backed out changeset ff3fb0b4a512 (bug 1672023)
Backed out changeset e7834b600201 (bug 1654103)
Backed out changeset 807893ca8069 (bug 1518999)
Backed out changeset 13e6b92440e9 (bug 1518999)
Backed out changeset 8b2ac5a6c98a (bug 1518999)
Backed out changeset 575748295752 (bug 1518999)
Backed out changeset 65f07ce7b39b (bug 1518999)
Backed out changeset 4bb80556158d (bug 1518999)
Backed out changeset 8ac8461d7bd7 (bug 1518999)
Backed out changeset e8ba13ee17f5 (bug 1518999)
2020-10-24 03:36:18 +03:00
Ricky Stewart
c0cea3b0fa Bug 1654103: Standardize on Black for Python code in mozilla-central. r=remote-protocol-reviewers,marionette-reviewers,webdriver-reviewers,perftest-reviewers,devtools-backward-compat-reviewers,jgilbert,preferences-reviewers,sylvestre,maja_zf,webcompat-reviewers,denschub,ntim,whimboo,sparky
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.

To produce this patch I did all of the following:

1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.

2. Run ./mach lint --linter black --fix

3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.

4. Make some ad-hoc manual updates to `testing/marionette/client/setup.py`, `testing/marionette/harness/setup.py`, and `testing/firefox-ui/harness/setup.py`, which have hard-coded regexes that break after the reformat.

5. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D94045
2020-10-23 20:40:42 +00:00
Dorel Luca
1ff59cb7a3 Backed out changeset 7558c8821a07 (bug 1654103) for multiple failures. CLOSED TREE 2020-10-22 03:51:06 +03:00
Ricky Stewart
50762dacab Bug 1654103: Standardize on Black for Python code in mozilla-central. r=remote-protocol-reviewers,marionette-reviewers,webdriver-reviewers,perftest-reviewers,devtools-backward-compat-reviewers,jgilbert,preferences-reviewers,sylvestre,maja_zf,webcompat-reviewers,denschub,ntim,whimboo,sparky
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.

To produce this patch I did all of the following:

1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.

2. Run ./mach lint --linter black --fix

3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.

4. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D94045
2020-10-21 21:27:27 +00:00
Narcis Beleuzu
025ef5008e Backed out changeset 71aa02ea22b6 (bug 1666678) for GTest failures on TestCookieMain 2020-10-05 21:32:24 +03:00
Valentin Gosu
1d498c5bad Bug 1666678 - [cookie] rejected cookie when domain have ipv6 address r=baku
Differential Revision: https://phabricator.services.mozilla.com/D91246
2020-09-24 13:17:42 +00:00
Simon Giesecke
de7bab0f06 Bug 1650145 - Replace all value uses of Empty[C]String by 0-length _ns literals. r=froydnj,geckoview-reviewers,agi
Differential Revision: https://phabricator.services.mozilla.com/D82325
2020-09-23 15:17:15 +00:00
Simon Giesecke
96f3e7e019 Bug 1654992 - Use std::move instead of SwapElements where possible. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D84807
2020-08-04 11:27:07 +00:00
Andrea Marchesini
8afe3a9501 Bug 1656980 - CookieService::GetCookiesSince needs to check the CookieService initialization state, r=mayhemer
Differential Revision: https://phabricator.services.mozilla.com/D85824
2020-08-04 10:01:09 +00:00
Noemi Erli
381fca9783 Backed out 4 changesets (bug 1654992, bug 1654991) for causing timeous in mask-opacity-1e.html
Backed out changeset 11f0f54c6e0a (bug 1654992)
Backed out changeset a353dd5b3f08 (bug 1654991)
Backed out changeset 6a7964ba549f (bug 1654991)
Backed out changeset cf3bfb91d98c (bug 1654991)
2020-08-03 22:09:36 +03:00
Simon Giesecke
032d2ac9d3 Bug 1654992 - Use std::move instead of SwapElements where possible. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D84807
2020-08-03 14:54:18 +00:00
Honza Bambas
b984b89632 Bug 1654556 - Log also "failed the samesite tests" cookie rejection reason, r=baku
Differential Revision: https://phabricator.services.mozilla.com/D84555
2020-07-23 14:48:12 +00:00
Bogdan Tara
24dcc81896 Backed out changeset 29ae67e7f8d5 (bug 1654556) for browser_webconsole_warning_group_storage_isolation.js failures CLOSED TREE 2020-07-23 15:20:30 +03:00
Honza Bambas
71af5acb52 Bug 1654556 - Log also "failed the samesite tests" cookie rejection reason, r=baku
Differential Revision: https://phabricator.services.mozilla.com/D84555
2020-07-23 09:45:28 +00:00
Honza Bambas
1dd3107c82 Bug 1596741 - Emit warning to console when rejecting to set cookie, r=baku,flod
Differential Revision: https://phabricator.services.mozilla.com/D83649
2020-07-20 10:32:06 +00:00
Bogdan Tara
6b8e469ce3 Backed out changeset 0cc074b94631 (bug 1596741) for assertion failure on CookieLogging.cpp CLOSED TREE 2020-07-18 10:02:39 +03:00
Honza Bambas
d4dd583612 Bug 1596741 - Emit warning to console when rejecting to set cookie, r=baku,flod
Differential Revision: https://phabricator.services.mozilla.com/D83649
2020-07-18 05:23:54 +00:00
Csoregi Natalia
b70d90ce05 Backed out changeset 72e7c3e8393e (bug 1596741) as by request. CLOSED TREE 2020-07-17 19:00:15 +03:00
Honza Bambas
a1c623c01c Bug 1596741 - Emit warning to console when rejecting to set cookie, r=baku
Differential Revision: https://phabricator.services.mozilla.com/D83649
2020-07-17 14:26:02 +00:00
Simon Giesecke
202c188ca0 Bug 1652960 - Remove unnecessary includes from Document.h. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D83634
2020-07-15 15:48:53 +00:00
Simon Giesecke
fea9dab7f2 Bug 1651714 - Reduce expensive includes for TabMessageUtils.h. r=smaug
With these changes, on my Linux analysis with ClangBuildAnalyzer, the
top two expensive headers, DOMTypes.h and TabMessageUtils.h are no longer
among the 30 most expensive headers.

Differential Revision: https://phabricator.services.mozilla.com/D82935
2020-07-15 13:24:20 +00:00
Frederik Braun
a7153982e8 Bug 1366973: Rename security flags to not contain DATA anymore r=geckoview-reviewers,ckerschb,snorp
Differential Revision: https://phabricator.services.mozilla.com/D83490
2020-07-15 11:20:45 +00:00
Andrea Marchesini
3c1b71a6e4 Bug 1651618 - Use cookie 'SameSite' attribute with capital 'S' everywhere, r=flod,fluent-reviewers,remote-protocol-reviewers,marionette-reviewers,perftest-reviewers,whimboo,sparky
Differential Revision: https://phabricator.services.mozilla.com/D82872
2020-07-09 20:40:15 +00:00
Andrea Marchesini
9d5e2e6db9 Bug 1650211 - Ignore cookie settings during the shutdown, r=mayhemer
Differential Revision: https://phabricator.services.mozilla.com/D82498
2020-07-09 14:14:41 +00:00
Andrea Marchesini
c69f56d7dd Bug 1650656 - Call CookieCommons::SchemeToSchemeType only when the scheme is supported, r=mayhemer
Differential Revision: https://phabricator.services.mozilla.com/D82491
2020-07-09 11:05:58 +00:00
Simon Giesecke
9364b353d4 Bug 1648010 - Remove NS_NAMED_LITERAL_CSTRING and NS_NAMED_LITERAL_STRING macros. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D80631
2020-07-01 08:42:31 +00:00
Simon Giesecke
cd8b8939b9 Bug 1648010 - Replace uses of NS_LITERAL_STRING/NS_LITERAL_CSTRING macros by _ns literals. r=geckoview-reviewers,jgilbert,agi,hsivonen,froydnj
Differential Revision: https://phabricator.services.mozilla.com/D80860
2020-07-01 08:29:29 +00:00
Tim Huang
986aadbbd4 Bug 1644738 - Propagate the IsOnContentBlockingAllowList in CookieJarSettings to the script generated document. r=baku
We also need to propagate the IsOnContentBlockingAllowList to the script
generated document. For this kind of document, it won't have the
CookieJarSettings at the first place. It will generate its
CookieJarSettings when someone requests it. And we need to propagate the
flag when generating the CookieJarSettings in this case. Or the script
generated document will have a wrong IsOnContentBlockingAllowList flag.

Differential Revision: https://phabricator.services.mozilla.com/D81727
2020-07-01 05:57:16 +00:00
Andrea Marchesini
a9d21d61f2 Bug 1642971 - Do not allow cookies for FTP channels, r=mayhemer
Differential Revision: https://phabricator.services.mozilla.com/D79663
2020-06-16 12:26:34 +00:00
Andrea Marchesini
68f456af30 Bug 1642971 - Support FTP scheme for cookies, r=mayhemer
Differential Revision: https://phabricator.services.mozilla.com/D78042
2020-06-10 12:28:54 +00:00
Liang-Heng Chen
01f8cce7e1 Bug 1640135 - P4: update usage of PartitionKey; r=timhuang
Differential Revision: https://phabricator.services.mozilla.com/D77917
2020-06-04 10:51:21 +00:00
Andrea Marchesini
69818a4d17 Bug 1639833 - IntrisincStoragePrincipal should always be partitioned - part 4 - Renaming storage access permission methods, r=dimi
Differential Revision: https://phabricator.services.mozilla.com/D76917
2020-06-03 06:12:06 +00:00
Andrea Marchesini
2a98a3d66d Bug 1640405 - SameSite=lax/strict cookies should be sent to TYPE_SAVEAS_DOWNLOAD content-type, r=mayhemer
Differential Revision: https://phabricator.services.mozilla.com/D77298
2020-06-02 12:23:00 +00:00
Andrea Marchesini
6254482164 Bug 1638358 - Cookie Schemeful Same-Site - part 6 - console messages, r=mayhemer
Differential Revision: https://phabricator.services.mozilla.com/D75800
2020-06-02 13:50:32 +00:00
Andrea Marchesini
7ff3759ac3 Bug 1638358 - Cookie Schemeful Same-Site - part 5 - schemeful comparison, r=mayhemer
Differential Revision: https://phabricator.services.mozilla.com/D75629
2020-06-02 13:50:12 +00:00
Andrea Marchesini
4c5f4e6c30 Bug 1638358 - Cookie Schemeful Same-Site - part 4 - tests for cookie scheme merging, r=mayhemer
Differential Revision: https://phabricator.services.mozilla.com/D75628
2020-06-02 13:49:45 +00:00
Andrea Marchesini
5ccae203ff Bug 1638358 - Cookie Schemeful Same-Site - part 3 - update add/addNative methods, r=mayhemer,remote-protocol-reviewers,marionette-reviewers,maja_zf,MattN,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D75627
2020-06-02 13:49:27 +00:00
Andrea Marchesini
fdba4c920d Bug 1638358 - Cookie Schemeful Same-Site - part 2 - schemeMap in the cookie DB, r=mayhemer
Differential Revision: https://phabricator.services.mozilla.com/D75626
2020-06-02 13:48:54 +00:00
Andrea Marchesini
01cf5e2ca5 Bug 1638358 - Cookie Schemeful Same-Site - part 1 - scheme map in nsICookie, r=mayhemer
Differential Revision: https://phabricator.services.mozilla.com/D75624
2020-06-02 13:48:28 +00:00